[lxc-devel] [lxc/lxc] a72c68: conf: remove faulty flags

St├ęphane Graber noreply at github.com
Thu Jun 11 17:54:22 UTC 2020


  Branch: refs/heads/master
  Home:   https://github.com/lxc/lxc
  Commit: a72c68f789165c7cc01681f8a3f76334b9704790
      https://github.com/lxc/lxc/commit/a72c68f789165c7cc01681f8a3f76334b9704790
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2020-06-11 (Thu, 11 Jun 2020)

  Changed paths:
    M src/lxc/conf.c

  Log Message:
  -----------
  conf: remove faulty flags

If we set O_RDWR we won't be able to open directories and if we set O_PATH we
won't be able to chown.

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: 8053a085e0bac04df8301da30d6396c4e079c472
      https://github.com/lxc/lxc/commit/8053a085e0bac04df8301da30d6396c4e079c472
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2020-06-11 (Thu, 11 Jun 2020)

  Changed paths:
    M src/lxc/conf.c

  Log Message:
  -----------
  conf: always use target_fd in userns_exec_mapped_root()

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: 2e8013f9f15441231a7d654641c7c74aefd65b65
      https://github.com/lxc/lxc/commit/2e8013f9f15441231a7d654641c7c74aefd65b65
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2020-06-11 (Thu, 11 Jun 2020)

  Changed paths:
    M src/lxc/conf.c

  Log Message:
  -----------
  conf: add some more logging to userns_exec_mapped_root()

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: 6e1a327abaa91d6d0219cedfb0d7fd053ececdb2
      https://github.com/lxc/lxc/commit/6e1a327abaa91d6d0219cedfb0d7fd053ececdb2
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2020-06-11 (Thu, 11 Jun 2020)

  Changed paths:
    M src/lxc/conf.c
    M src/lxc/conf.h

  Log Message:
  -----------
  conf: kill old chown_mapped_root()

It's now a wrapper around userns_exec_mapped_root() which allows us to avoid
fork() + exec() lxc-usernsexec makes things way nicer to test with ASAN etc.

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: 472a2ff9539bbf26d59016e6375347a4e40310f7
      https://github.com/lxc/lxc/commit/472a2ff9539bbf26d59016e6375347a4e40310f7
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2020-06-11 (Thu, 11 Jun 2020)

  Changed paths:
    M src/lxc/lxccontainer.c

  Log Message:
  -----------
  lxccontainer: remove pointless string duplication

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: ebe4f04eb6065a61fc34220ffe8db8d56e01c45a
      https://github.com/lxc/lxc/commit/ebe4f04eb6065a61fc34220ffe8db8d56e01c45a
  Author: St├ęphane Graber <stgraber at ubuntu.com>
  Date:   2020-06-11 (Thu, 11 Jun 2020)

  Changed paths:
    M src/lxc/conf.c
    M src/lxc/conf.h
    M src/lxc/lxccontainer.c

  Log Message:
  -----------
  Merge pull request #3446 from brauner/2020-06-10/fixes_2

conf: kill old chown_mapped_root()


Compare: https://github.com/lxc/lxc/compare/c2fe5ecb2858...ebe4f04eb606


More information about the lxc-devel mailing list