[lxc-devel] [lxc/lxc] 542563: network: improve veth device creation

Stéphane Graber noreply at github.com
Fri Jan 10 13:38:31 UTC 2020


  Branch: refs/heads/master
  Home:   https://github.com/lxc/lxc
  Commit: 542563017dce6e915f5e2541f3a68b15e940b8fd
      https://github.com/lxc/lxc/commit/542563017dce6e915f5e2541f3a68b15e940b8fd
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2020-01-09 (Thu, 09 Jan 2020)

  Changed paths:
    M src/lxc/cmd/lxc_user_nic.c
    M src/lxc/network.c
    M src/lxc/network.h

  Log Message:
  -----------
  network: improve veth device creation

This allows us to avoid having to move the network device. It also allows us to
work around a kernel bug that in combination with a recent change in systemd
244 causes uses of systemd-networkd to not get an ip address.

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: 0858c829b4b9fcff8492c87317a5b27f414ee876
      https://github.com/lxc/lxc/commit/0858c829b4b9fcff8492c87317a5b27f414ee876
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2020-01-09 (Thu, 09 Jan 2020)

  Changed paths:
    M src/lxc/network.c

  Log Message:
  -----------
  network: fix typ and formatting in comment

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: 3919322d524dcf249baf9cc5fcf8718b3dbb1017
      https://github.com/lxc/lxc/commit/3919322d524dcf249baf9cc5fcf8718b3dbb1017
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2020-01-09 (Thu, 09 Jan 2020)

  Changed paths:
    M src/tests/api_reboot.c

  Log Message:
  -----------
  tests: log api reboot test failures

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: 0104c121a734f63d3304ee0210f7a7dc943ac173
      https://github.com/lxc/lxc/commit/0104c121a734f63d3304ee0210f7a7dc943ac173
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2020-01-09 (Thu, 09 Jan 2020)

  Changed paths:
    M src/lxc/network.c

  Log Message:
  -----------
  network: fix network device removal

We can't delete by netdev->ifindex since that's the ifindex of the device in
the container, not on the host. The correct thing is done below.

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: 8bf64b77ac8a6f7d447709cdb6c6ad768f2302c1
      https://github.com/lxc/lxc/commit/8bf64b77ac8a6f7d447709cdb6c6ad768f2302c1
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2020-01-10 (Fri, 10 Jan 2020)

  Changed paths:
    M src/lxc/network.c

  Log Message:
  -----------
  network: rework network device creation

This makes all the codepaths easier to follow and also moves and renames
devices in one single step.

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: 6f6bd4128e97defbe583df0059c10e6a47559b07
      https://github.com/lxc/lxc/commit/6f6bd4128e97defbe583df0059c10e6a47559b07
  Author: Stéphane Graber <stgraber at ubuntu.com>
  Date:   2020-01-10 (Fri, 10 Jan 2020)

  Changed paths:
    M src/lxc/cmd/lxc_user_nic.c
    M src/lxc/network.c
    M src/lxc/network.h
    M src/tests/api_reboot.c

  Log Message:
  -----------
  Merge pull request #3248 from brauner/2020-01-05/veth_devices

network: improve veth device creation


Compare: https://github.com/lxc/lxc/compare/90ddf3c0d7ac...6f6bd4128e97


More information about the lxc-devel mailing list