[lxc-devel] [lxd/master] VM: Fix race in onStop getting operation

tomponline on Github lxc-bot at linuxcontainers.org
Mon Aug 10 08:29:51 UTC 2020


A non-text attachment was scrubbed...
Name: not available
Type: text/x-mailbox
Size: 361 bytes
Desc: not available
URL: <http://lists.linuxcontainers.org/pipermail/lxc-devel/attachments/20200810/9a6af539/attachment.bin>
-------------- next part --------------
From 4dc02e4a02ba8311a49a97d67bff17a957879a39 Mon Sep 17 00:00:00 2001
From: Thomas Parrott <thomas.parrott at canonical.com>
Date: Fri, 7 Aug 2020 18:02:39 +0100
Subject: [PATCH] lxd/instance/drivers/driver/qemu: Fix race in onStop getting
 operation

Signed-off-by: Thomas Parrott <thomas.parrott at canonical.com>
---
 lxd/instance/drivers/driver_qemu.go | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/lxd/instance/drivers/driver_qemu.go b/lxd/instance/drivers/driver_qemu.go
index 5e671ceb52..cc12ed6d14 100644
--- a/lxd/instance/drivers/driver_qemu.go
+++ b/lxd/instance/drivers/driver_qemu.go
@@ -503,7 +503,9 @@ func (vm *qemu) onStop(target string) error {
 	// Record power state.
 	err := vm.state.Cluster.UpdateInstancePowerState(vm.id, "STOPPED")
 	if err != nil {
-		op.Done(err)
+		if op != nil {
+			op.Done(err)
+		}
 		return err
 	}
 


More information about the lxc-devel mailing list