[lxc-devel] [lxc/lxc] 3769a8: travis: add back coverity

Wed Apr 15 21:39:59 UTC 2020

  Branch: refs/heads/stable-4.0
  Home:   https://github.com/lxc/lxc
  Commit: 3769a87ba2dccea477401d4e83472cd29fbde49f
      https://github.com/lxc/lxc/commit/3769a87ba2dccea477401d4e83472cd29fbde49f
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2020-04-15 (Wed, 15 Apr 2020)

  Changed paths:
    M .travis.yml

  Log Message:
  -----------
  travis: add back coverity

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: c7c55c1a21b9e1b189a72dee6b70c785ea21a94d
      https://github.com/lxc/lxc/commit/c7c55c1a21b9e1b189a72dee6b70c785ea21a94d
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2020-04-15 (Wed, 15 Apr 2020)

  Changed paths:
    M src/lxc/memory_utils.h

  Log Message:
  -----------
  memory_utils: directly NULL ptr in free_disarm()

This should keep coverity happy.

Fixes: Coverity 1461757.
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 6810da44843cb3e92117c49bce0c2fb8b6f6cc2e
      https://github.com/lxc/lxc/commit/6810da44843cb3e92117c49bce0c2fb8b6f6cc2e
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2020-04-15 (Wed, 15 Apr 2020)

  Changed paths:
    M src/lxc/conf.c

  Log Message:
  -----------
  conf: fix tty cleanup

Fixes: Coverity 1461755.
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 86652cfb15effefd809b03782f3e547e78870cf1
      https://github.com/lxc/lxc/commit/86652cfb15effefd809b03782f3e547e78870cf1
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2020-04-15 (Wed, 15 Apr 2020)

  Changed paths:
    M src/lxc/cgroups/cgfsng.c

  Log Message:
  -----------
  cgroups: do not pass NULL pointer

Fixes: Coverity 1461752.
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: a4ccd3a7524e62adc25793d2e2b0277b9de2abeb
      https://github.com/lxc/lxc/commit/a4ccd3a7524e62adc25793d2e2b0277b9de2abeb
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2020-04-15 (Wed, 15 Apr 2020)

  Changed paths:
    M src/lxc/uuid.c

  Log Message:
  -----------
  uuid: close fd

Fixes: Coverity 1461751.
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: bc15baacf5f52b788ec0b398b860824310c30e7f
      https://github.com/lxc/lxc/commit/bc15baacf5f52b788ec0b398b860824310c30e7f
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2020-04-15 (Wed, 15 Apr 2020)

  Changed paths:
    M src/lxc/cgroups/cgroup2_devices.c

  Log Message:
  -----------
  cgroups: fix cgroup2 devices

Fixes: Coverity 1461748.
Fixes: Coverity 1461746.
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 9c0e2551770143a4ff8863e647cec995d6ccb682
      https://github.com/lxc/lxc/commit/9c0e2551770143a4ff8863e647cec995d6ccb682
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2020-04-15 (Wed, 15 Apr 2020)

  Changed paths:
    M src/lxc/rexec.c

  Log Message:
  -----------
  rexec: avoid double-close

Fixes: Coverity 1461721.
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 6a40ccf59100f3ed29c6132cdc67c3eba06e5915
      https://github.com/lxc/lxc/commit/6a40ccf59100f3ed29c6132cdc67c3eba06e5915
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2020-04-15 (Wed, 15 Apr 2020)

  Changed paths:
    M src/lxc/cgroups/cgroup2_devices.c

  Log Message:
  -----------
  cgroups: use correct NULL pointer check

Fixes: Coverity 1461722.
Fixes: Coverity 1461737.
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: e052e6d006c43ceea51d014398b2f61b5b178a05
      https://github.com/lxc/lxc/commit/e052e6d006c43ceea51d014398b2f61b5b178a05
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2020-04-15 (Wed, 15 Apr 2020)

  Changed paths:
    M src/lxc/conf.c

  Log Message:
  -----------
  conf: don't double free in get_minimal_idmap()

Fixes: Coverity 1461725.
Fixes: Coverity 1461727.
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: c89533f402c21dd62d2bb584571a2c73f4e60425
      https://github.com/lxc/lxc/commit/c89533f402c21dd62d2bb584571a2c73f4e60425
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2020-04-15 (Wed, 15 Apr 2020)

  Changed paths:
    M src/lxc/criu.c

  Log Message:
  -----------
  criu: make explicit that we're ignoring rmdir() return value

Fixes: Coverity 1461726.
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: a1232a5727e9e0c7b16e4beb4033182150cc2682
      https://github.com/lxc/lxc/commit/a1232a5727e9e0c7b16e4beb4033182150cc2682
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2020-04-15 (Wed, 15 Apr 2020)

  Changed paths:
    M src/lxc/storage/zfs.c

  Log Message:
  -----------
  zfs: fix resource leak

Fixes: Coverity 1461730.
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 00d87eb12f759e120af00ce394282845393d41d9
      https://github.com/lxc/lxc/commit/00d87eb12f759e120af00ce394282845393d41d9
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2020-04-15 (Wed, 15 Apr 2020)

  Changed paths:
    M src/lxc/commands_utils.c

  Log Message:
  -----------
  commands: add additional check to lxc_cmd_sock_get_state()

to please Coverity.

Fixes: Coverity 1461732.
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: dfa49f0d04effe25bd245a47f4ec4a3c40b3ac63
      https://github.com/lxc/lxc/commit/dfa49f0d04effe25bd245a47f4ec4a3c40b3ac63
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2020-04-15 (Wed, 15 Apr 2020)

  Changed paths:
    M src/lxc/network.c

  Log Message:
  -----------
  network: log warning on network deconfiguration failures

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 10b15ed006d1e69fb424aadb5e28402d162b4852
      https://github.com/lxc/lxc/commit/10b15ed006d1e69fb424aadb5e28402d162b4852
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2020-04-15 (Wed, 15 Apr 2020)

  Changed paths:
    M src/lxc/log.c

  Log Message:
  -----------
  log: restore non-local value

Fixes: Coverity 1461734.
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 264d40e507cf4fc94afad4363f56ac28850d26db
      https://github.com/lxc/lxc/commit/264d40e507cf4fc94afad4363f56ac28850d26db
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2020-04-15 (Wed, 15 Apr 2020)

  Changed paths:
    M src/lxc/attach.c

  Log Message:
  -----------
  attach: move check for valid config earlier

Fixes: Coverity 1461735.
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 82057b132cfb9982fabd90a496426adaf07d7e04
      https://github.com/lxc/lxc/commit/82057b132cfb9982fabd90a496426adaf07d7e04
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2020-04-15 (Wed, 15 Apr 2020)

  Changed paths:
    M src/lxc/rexec.c

  Log Message:
  -----------
  rexec: free argv array on failure

Fixes: Coverity 1461736.
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: f576850defad8dab9ef4c46ba323c74a54dfbf0d
      https://github.com/lxc/lxc/commit/f576850defad8dab9ef4c46ba323c74a54dfbf0d
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2020-04-15 (Wed, 15 Apr 2020)

  Changed paths:
    M src/lxc/conf.c

  Log Message:
  -----------
  conf: correctly cleanup memory in get_minimal_idmap()

Fixes: Coverity 1461760.
Fixes: Coverity 1461762.
Fixes: Coverity 1461763.
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: da23a3c5eb4f74684b6ff5e9862c7e774916b1f0
      https://github.com/lxc/lxc/commit/da23a3c5eb4f74684b6ff5e9862c7e774916b1f0
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2020-04-15 (Wed, 15 Apr 2020)

  Changed paths:
    M src/lxc/log.h

  Log Message:
  -----------
  log: set GNU_SOURCE as it might help coverity along

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 04a7c46e1fff45dd5f4d9040742c67523cade491
      https://github.com/lxc/lxc/commit/04a7c46e1fff45dd5f4d9040742c67523cade491
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2020-04-15 (Wed, 15 Apr 2020)

  Changed paths:
    M .travis.yml
    M configure.ac
    M src/lxc/log.h

  Log Message:
  -----------
  travis: coverity gets confused about the %m printf extension in glibc

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: f2f25719b74a409f85ae787111c864ef7c0a4bca
      https://github.com/lxc/lxc/commit/f2f25719b74a409f85ae787111c864ef7c0a4bca
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2020-04-15 (Wed, 15 Apr 2020)

  Changed paths:
    M src/lxc/cgroups/cgfsng.c

  Log Message:
  -----------
  cgroups: fix cgroup limit braino

Fixes: https://discuss.linuxcontainers.org/t/memory-limits-no-longer-being-applied/7429/7
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

Compare: https://github.com/lxc/lxc/compare/4a2484801de9...f2f25719b74a