[lxc-devel] [lxc/lxc] 83b25c: cgroups: do not pass NULL pointer

Wed Apr 15 12:38:27 UTC 2020

  Branch: refs/heads/master
  Home:   https://github.com/lxc/lxc
  Commit: 83b25c4d371676bbdf164f14227ab9260a8ad530
      https://github.com/lxc/lxc/commit/83b25c4d371676bbdf164f14227ab9260a8ad530
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2020-04-15 (Wed, 15 Apr 2020)

  Changed paths:
    M src/lxc/cgroups/cgfsng.c

  Log Message:
  -----------
  cgroups: do not pass NULL pointer

Fixes: Coverity 1461752.
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: e84e4a989dba41383e4cf3921da6b2439add0363
      https://github.com/lxc/lxc/commit/e84e4a989dba41383e4cf3921da6b2439add0363
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2020-04-15 (Wed, 15 Apr 2020)

  Changed paths:
    M src/lxc/uuid.c

  Log Message:
  -----------
  uuid: close fd

Fixes: Coverity 1461751.
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: cd86470685809deda9e9721412fe63b6557856cd
      https://github.com/lxc/lxc/commit/cd86470685809deda9e9721412fe63b6557856cd
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2020-04-15 (Wed, 15 Apr 2020)

  Changed paths:
    M src/lxc/cgroups/cgroup2_devices.c

  Log Message:
  -----------
  cgroups: fix cgroup2 devices

Fixes: Coverity 1461748.
Fixes: Coverity 1461746.
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 67e724615c8228d7f0398bce707bc25e30696b72
      https://github.com/lxc/lxc/commit/67e724615c8228d7f0398bce707bc25e30696b72
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2020-04-15 (Wed, 15 Apr 2020)

  Changed paths:
    M src/lxc/rexec.c

  Log Message:
  -----------
  rexec: avoid double-close

Fixes: Coverity 1461721.
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 7484656d639a76f0ec94db0c9dca414310de0e26
      https://github.com/lxc/lxc/commit/7484656d639a76f0ec94db0c9dca414310de0e26
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2020-04-15 (Wed, 15 Apr 2020)

  Changed paths:
    M src/lxc/cgroups/cgroup2_devices.c

  Log Message:
  -----------
  cgroups: use correct NULL pointer check

Fixes: Coverity 1461722.
Fixes: Coverity 1461737.
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 2c99621932e0a8822ae6ba1e6404ba92f43fc57e
      https://github.com/lxc/lxc/commit/2c99621932e0a8822ae6ba1e6404ba92f43fc57e
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2020-04-15 (Wed, 15 Apr 2020)

  Changed paths:
    M src/lxc/conf.c

  Log Message:
  -----------
  conf: don't double free in get_minimal_idmap()

Fixes: Coverity 1461725.
Fixes: Coverity 1461727.
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: f075e955d126d73054477f474a7aaf4209749e16
      https://github.com/lxc/lxc/commit/f075e955d126d73054477f474a7aaf4209749e16
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2020-04-15 (Wed, 15 Apr 2020)

  Changed paths:
    M src/lxc/criu.c

  Log Message:
  -----------
  criu: make explicit that we're ignoring rmdir() return value

Fixes: Coverity 1461726.
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: c148bb7d9ff5983a4286a9804affca855aa7defc
      https://github.com/lxc/lxc/commit/c148bb7d9ff5983a4286a9804affca855aa7defc
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2020-04-15 (Wed, 15 Apr 2020)

  Changed paths:
    M src/lxc/storage/zfs.c

  Log Message:
  -----------
  zfs: fix resource leak

Fixes: Coverity 1461730.
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 7792a5b60f7949d1a41db95f1ea2a7a6b89d9a3f
      https://github.com/lxc/lxc/commit/7792a5b60f7949d1a41db95f1ea2a7a6b89d9a3f
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2020-04-15 (Wed, 15 Apr 2020)

  Changed paths:
    M src/lxc/commands_utils.c

  Log Message:
  -----------
  commands: add additional check to lxc_cmd_sock_get_state()

to please Coverity.

Fixes: Coverity 1461732.
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 40a220433fc7dbd7a5b4c9845dd12bebf4d99a17
      https://github.com/lxc/lxc/commit/40a220433fc7dbd7a5b4c9845dd12bebf4d99a17
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2020-04-15 (Wed, 15 Apr 2020)

  Changed paths:
    M src/lxc/network.c

  Log Message:
  -----------
  network: log warning on network deconfiguration failures

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: ad9ea93929ca5a9e99ff44d8da1de602356fa67d
      https://github.com/lxc/lxc/commit/ad9ea93929ca5a9e99ff44d8da1de602356fa67d
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2020-04-15 (Wed, 15 Apr 2020)

  Changed paths:
    M src/lxc/log.c

  Log Message:
  -----------
  log: restore non-local value

Fixes: Coverity 1461734.
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: a9909116bc2088fd52c55725df861ceb6e73f061
      https://github.com/lxc/lxc/commit/a9909116bc2088fd52c55725df861ceb6e73f061
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2020-04-15 (Wed, 15 Apr 2020)

  Changed paths:
    M src/lxc/attach.c

  Log Message:
  -----------
  attach: move check for valid config earlier

Fixes: Coverity 1461735.
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 0212dc6f33159d55a41ab6ed20c0b37ebb14c66e
      https://github.com/lxc/lxc/commit/0212dc6f33159d55a41ab6ed20c0b37ebb14c66e
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2020-04-15 (Wed, 15 Apr 2020)

  Changed paths:
    M src/lxc/rexec.c

  Log Message:
  -----------
  rexec: free argv array on failure

Fixes: Coverity 1461736.
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 55785a2cf205492efc4a41e804c7d343de0ca3fb
      https://github.com/lxc/lxc/commit/55785a2cf205492efc4a41e804c7d343de0ca3fb
  Author: Stéphane Graber <stgraber at stgraber.org>
  Date:   2020-04-15 (Wed, 15 Apr 2020)

  Changed paths:
    M src/lxc/attach.c
    M src/lxc/cgroups/cgfsng.c
    M src/lxc/cgroups/cgroup2_devices.c
    M src/lxc/commands_utils.c
    M src/lxc/conf.c
    M src/lxc/criu.c
    M src/lxc/log.c
    M src/lxc/network.c
    M src/lxc/rexec.c
    M src/lxc/storage/zfs.c
    M src/lxc/uuid.c

  Log Message:
  -----------
  Merge pull request #3381 from brauner/2020-04-15/fixes

fixes

Compare: https://github.com/lxc/lxc/compare/e0624f70fcef...55785a2cf205