[lxc-devel] [lxc/lxc] 346830: cgroups: fix "uninitialized transient_len" warning

[Christian Brauner]

  Branch: refs/heads/master
  Home:   https://github.com/lxc/lxc
  Commit: 346830421a968c41e3198ca64ab3f7217075e491
      https://github.com/lxc/lxc/commit/346830421a968c41e3198ca64ab3f7217075e491
  Author: Aleksa Sarai <cyphar at cyphar.com>
  Date:   2020-04-02 (Thu, 02 Apr 2020)

  Changed paths:
    M src/lxc/cgroups/cgfsng.c

  Log Message:
  -----------
  cgroups: fix "uninitialized transient_len" warning

Without this change, a build error is triggered if you compile with
-Werror=maybe-uninitialized.

 cgroups/cgfsng.c: In function 'cgfsng_monitor_enter':
 groups/cgfsng.c:1387:9: error: 'transient_len' may be used uninitialized in this function
    ret = lxc_writeat(h->cgfd_mon, "cgroup.procs", transient, transient_len);
          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

The issue is that if handler->transient_pid is 0, then transient_len is
uninitialised but lxc_writeat(..., transient_len) still gets called.

Signed-off-by: Aleksa Sarai <cyphar at cyphar.com>


  Commit: 370a2284be2ea2ab1b80bd90026f0fbdb5baa1a8
      https://github.com/lxc/lxc/commit/370a2284be2ea2ab1b80bd90026f0fbdb5baa1a8
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2020-04-02 (Thu, 02 Apr 2020)

  Changed paths:
    M src/lxc/cgroups/cgfsng.c

  Log Message:
  -----------
  Merge pull request #3347 from cyphar/cgfsng-uninitialised

cgroups: fix "uninitialized transient_len" warning


Compare: https://github.com/lxc/lxc/compare/5f2ed0c09f99...370a2284be2e