[lxc-devel] [lxd/master] forksyscall: remove left-over advance_arg() call

brauner on Github lxc-bot at linuxcontainers.org
Thu Oct 31 10:28:42 UTC 2019


A non-text attachment was scrubbed...
Name: not available
Type: text/x-mailbox
Size: 364 bytes
Desc: not available
URL: <http://lists.linuxcontainers.org/pipermail/lxc-devel/attachments/20191031/4614ff22/attachment.bin>
-------------- next part --------------
From fbb66fae35df1dd3cfa6fd2df8e293aaa2517900 Mon Sep 17 00:00:00 2001
From: Christian Brauner <christian.brauner at ubuntu.com>
Date: Thu, 31 Oct 2019 11:27:49 +0100
Subject: [PATCH] forksyscall: remove left-over advance_arg() call

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
---
 lxd/main_forksyscall.go | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/lxd/main_forksyscall.go b/lxd/main_forksyscall.go
index ccb7da6e00..04738aa6d9 100644
--- a/lxd/main_forksyscall.go
+++ b/lxd/main_forksyscall.go
@@ -153,7 +153,6 @@ static void mknod_emulate(void)
 	target = advance_arg(true);
 	mode = atoi(advance_arg(true));
 	dev = atoi(advance_arg(true));
-	advance_arg(true);
 	uid = atoi(advance_arg(true));
 	gid = atoi(advance_arg(true));
 	fsuid = atoi(advance_arg(true));
@@ -172,8 +171,10 @@ static void mknod_emulate(void)
 		_exit(EXIT_FAILURE);
 	}
 
-	if (!acquire_final_creds(pid, uid, gid, fsuid, fsgid))
+	if (!acquire_final_creds(pid, uid, gid, fsuid, fsgid)) {
+		fprintf(stderr, "%d", ENOANO);
 		_exit(EXIT_FAILURE);
+	}
 
 	ret = fstatfs(target_dir_fd, &sfs);
 	if (ret) {


More information about the lxc-devel mailing list