[lxc-devel] [lxc/lxc] 912c4b: conf: Fixes unitialised variable.

Christian Brauner noreply at github.com
Tue Mar 5 18:27:34 UTC 2019


  Branch: refs/heads/master
  Home:   https://github.com/lxc/lxc
  Commit: 912c4bb474b52284cf82c336b0af161be6c25ac1
      https://github.com/lxc/lxc/commit/912c4bb474b52284cf82c336b0af161be6c25ac1
  Author: tomponline <tomp at tomp.uk>
  Date:   2019-03-05 (Tue, 05 Mar 2019)

  Changed paths:
    M src/lxc/conf.c

  Log Message:
  -----------
  conf: Fixes unitialised variable.

Signed-off-by: tomponline <tomp at tomp.uk>


  Commit: b5bd9e1172f77d1bfb679b34d4f889de224148f0
      https://github.com/lxc/lxc/commit/b5bd9e1172f77d1bfb679b34d4f889de224148f0
  Author: Christian Brauner <christian at brauner.io>
  Date:   2019-03-05 (Tue, 05 Mar 2019)

  Changed paths:
    M src/lxc/conf.c

  Log Message:
  -----------
  Merge pull request #2895 from tomponline/tp-2019-03-05/minor-fix

conf: Fixes uninitialised variable.

> @brauner clang is failing but gcc passes, would it be OK to initialise this to 0?

He, unfortunately not. :)
What would happen now is that you'd close `stdin` on a standard system. What you'd want is `= -EBADF`. :)


Compare: https://github.com/lxc/lxc/compare/859ce0118270...b5bd9e1172f7


More information about the lxc-devel mailing list