[lxc-devel] [lxc/master] Makefile: Adds compile flags -Wall -Werror -Wno-portability

[tomponline on Github]

A non-text attachment was scrubbed...
Name: not available
Type: text/x-mailbox
Size: 446 bytes
Desc: not available
URL: <http://lists.linuxcontainers.org/pipermail/lxc-devel/attachments/20190305/d21d85b3/attachment.bin>
-------------- next part --------------
From 17c3a69d5f8a75f38ae7d968d617bcf6d08d153b Mon Sep 17 00:00:00 2001
From: tomponline <tomp at tomp.uk>
Date: Tue, 5 Mar 2019 16:10:43 +0000
Subject: [PATCH] Makefile: Adds compile flags -Wall -Werror -Wno-portability
 which were not applying.

Closes #2885.

Signed-off-by: tomponline <tomp at tomp.uk>
---
 src/lxc/Makefile.am   | 6 +++++-
 src/tests/Makefile.am | 5 ++++-
 2 files changed, 9 insertions(+), 2 deletions(-)

diff --git a/src/lxc/Makefile.am b/src/lxc/Makefile.am
index 538201b517..1eb868a2e7 100644
--- a/src/lxc/Makefile.am
+++ b/src/lxc/Makefile.am
@@ -202,7 +202,11 @@ AM_CFLAGS = -DLXCROOTFSMOUNT=\"$(LXCROOTFSMOUNT)\" \
 	    -I $(top_srcdir)/src \
 	    -I $(top_srcdir)/src/lxc \
 	    -I $(top_srcdir)/src/lxc/storage \
-	    -I $(top_srcdir)/src/lxc/cgroups
+	    -I $(top_srcdir)/src/lxc/cgroups \
+	    -Wall \
+	    -Werror \
+	    -Wno-portability
+
 
 if ENABLE_APPARMOR
 AM_CFLAGS += -DHAVE_APPARMOR
diff --git a/src/tests/Makefile.am b/src/tests/Makefile.am
index f7e9dc8294..ca48fd8892 100644
--- a/src/tests/Makefile.am
+++ b/src/tests/Makefile.am
@@ -51,7 +51,10 @@ AM_CFLAGS=-DLXCROOTFSMOUNT=\"$(LXCROOTFSMOUNT)\" \
 	  -I $(top_srcdir)/src/lxc \
 	  -I $(top_srcdir)/src/lxc/cgroups \
 	  -I $(top_srcdir)/src/lxc/tools \
-	  -pthread
+	  -pthread \
+	  -Wall \
+	  -Werror \
+	  -Wno-portability
 
 if ENABLE_APPARMOR
 AM_CFLAGS += -DHAVE_APPARMOR