[lxc-devel] [lxc/master] fix memory leak in do_storage_create

lifeng68 on Github lxc-bot at linuxcontainers.org
Fri Jun 28 02:29:19 UTC 2019


A non-text attachment was scrubbed...
Name: not available
Type: text/x-mailbox
Size: 344 bytes
Desc: not available
URL: <http://lists.linuxcontainers.org/pipermail/lxc-devel/attachments/20190627/aa4c019f/attachment.bin>
-------------- next part --------------
From 8ea91347b83efd22e1ea9e3b388182753815f88f Mon Sep 17 00:00:00 2001
From: LiFeng <lifeng68 at huawei.com>
Date: Thu, 27 Jun 2019 23:49:08 -0400
Subject: [PATCH] fix memory leak in do_storage_create

Signed-off-by: LiFeng <lifeng68 at huawei.com>
---
 src/lxc/lxccontainer.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/src/lxc/lxccontainer.c b/src/lxc/lxccontainer.c
index a618645f81..98ea9798d8 100644
--- a/src/lxc/lxccontainer.c
+++ b/src/lxc/lxccontainer.c
@@ -1304,6 +1304,7 @@ static struct lxc_storage *do_storage_create(struct lxc_container *c,
 
 	if (!c->set_config_item(c, "lxc.rootfs.path", bdev->src)) {
 		ERROR("Failed to set \"lxc.rootfs.path = %s\"", bdev->src);
+		storage_put(bdev);
 		return NULL;
 	}
 


More information about the lxc-devel mailing list