[lxc-devel] [lxc/master] network: remove faulty restriction

[brauner on Github]

A non-text attachment was scrubbed...
Name: not available
Type: text/x-mailbox
Size: 424 bytes
Desc: not available
URL: <http://lists.linuxcontainers.org/pipermail/lxc-devel/attachments/20190703/3aa36ec9/attachment.bin>
-------------- next part --------------
From ab9cf3a441e184c4d1387206d81ce81e8009f026 Mon Sep 17 00:00:00 2001
From: Christian Brauner <christian.brauner at ubuntu.com>
Date: Wed, 3 Jul 2019 15:13:46 +0200
Subject: [PATCH] network: remove faulty restriction

Reported-by: Thomas Parrott <thomas.parrott at canonical.com>
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
---
 src/lxc/network.c | 7 -------
 1 file changed, 7 deletions(-)

diff --git a/src/lxc/network.c b/src/lxc/network.c
index 69638bfa90..2df4be3c01 100644
--- a/src/lxc/network.c
+++ b/src/lxc/network.c
@@ -3508,13 +3508,6 @@ static int lxc_setup_netdev_in_child_namespaces(struct lxc_netdev *netdev)
 		if (netdev->type == LXC_NET_NONE)
 			return 0;
 
-		if (netdev->type != LXC_NET_VETH) {
-			net_type_name = lxc_net_type_to_str(netdev->type);
-			ERROR("%s networks are not supported for containers "
-			      "not setup up by privileged users", net_type_name);
-			return -1;
-		}
-
 		netdev->ifindex = if_nametoindex(netdev->created_name);
 		if (!netdev->ifindex)
 			SYSERROR("Failed to retrieve ifindex for network device with name %s",