[lxc-devel] [lxc/lxc] 5f9fac: attach: use move_fd in lxc_proc_close_ns_fd

Christian Brauner noreply at github.com
Mon Feb 25 16:19:17 UTC 2019


  Branch: refs/heads/master
  Home:   https://github.com/lxc/lxc
  Commit: 5f9facdac9fed59f5e4b52a35bf550a417ae7e7e
      https://github.com/lxc/lxc/commit/5f9facdac9fed59f5e4b52a35bf550a417ae7e7e
  Author: Wolfgang Bumiller <w.bumiller at proxmox.com>
  Date:   2019-02-25 (Mon, 25 Feb 2019)

  Changed paths:
    M src/lxc/attach.c

  Log Message:
  -----------
  attach: use move_fd in lxc_proc_close_ns_fd

Previously this set `ctx->ns_fd[*]` to `-EBADF` until commit
fd2a88b190eb ("attach: cleanup macros lxc_proc_close_ns_fd",
but there are some code paths where we call this before
later calling `lxc_proc_put_context_info` which would call
this function again with the file descriptors still
unchanged.

Signed-off-by: Wolfgang Bumiller <w.bumiller at proxmox.com>


  Commit: 1fe8dffad6eb010679fdf9d258d2ceab32c334c5
      https://github.com/lxc/lxc/commit/1fe8dffad6eb010679fdf9d258d2ceab32c334c5
  Author: Christian Brauner <christian at brauner.io>
  Date:   2019-02-25 (Mon, 25 Feb 2019)

  Changed paths:
    M src/lxc/attach.c

  Log Message:
  -----------
  Merge pull request #2881 from Blub/2019-02-25/lxc-attach-move_fd

attach: use move_fd in lxc_proc_close_ns_fd


Compare: https://github.com/lxc/lxc/compare/de24eb5ba6b6...1fe8dffad6eb


More information about the lxc-devel mailing list