[lxc-devel] [lxc/lxc] 29a7b4: conf: do not log devpts umount2() failure

Stéphane Graber noreply at github.com
Fri Feb 15 23:21:34 UTC 2019


  Branch: refs/heads/master
  Home:   https://github.com/lxc/lxc
  Commit: 29a7b484ffa86e8b552bd90dc26d9ea5f577eed2
      https://github.com/lxc/lxc/commit/29a7b484ffa86e8b552bd90dc26d9ea5f577eed2
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2019-02-15 (Fri, 15 Feb 2019)

  Changed paths:
    M src/lxc/conf.c

  Log Message:
  -----------
  conf: do not log devpts umount2() failure

We're not acting based on the return value so don't log anything.

Fixes: https://discuss.linuxcontainers.org/t/warning-in-the-container-log/4072/2
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: 24548539af7fa95cd9ca7b971eb9f301065492e0
      https://github.com/lxc/lxc/commit/24548539af7fa95cd9ca7b971eb9f301065492e0
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2019-02-15 (Fri, 15 Feb 2019)

  Changed paths:
    M src/lxc/network.c

  Log Message:
  -----------
  network: do not log false friends

The netlink functions just return -1 and not specific negative errno values so
logging them doesn't make any sense.

Fixes: https://discuss.linuxcontainers.org/t/warning-in-the-container-log/4072/2
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: 4d3d037a98cf5e4c5038ad7cecf3b20028963e8a
      https://github.com/lxc/lxc/commit/4d3d037a98cf5e4c5038ad7cecf3b20028963e8a
  Author: Stéphane Graber <stgraber at stgraber.org>
  Date:   2019-02-15 (Fri, 15 Feb 2019)

  Changed paths:
    M src/lxc/conf.c
    M src/lxc/network.c

  Log Message:
  -----------
  Merge pull request #2857 from brauner/2019-02-15/tweak_log

log: fixes


Compare: https://github.com/lxc/lxc/compare/2cd64122513b...4d3d037a98cf


More information about the lxc-devel mailing list