[lxc-devel] [lxc/lxc] f2668e: cgfsng: coding style for cgfsng_monitor_create()

Wolfgang Bumiller noreply at github.com
Sun Feb 10 10:34:43 UTC 2019


  Branch: refs/heads/master
  Home:   https://github.com/lxc/lxc
  Commit: f2668eea509deccb77a90dac8a12f43bfcb6178f
      https://github.com/lxc/lxc/commit/f2668eea509deccb77a90dac8a12f43bfcb6178f
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2019-02-10 (Sun, 10 Feb 2019)

  Changed paths:
    M src/lxc/cgroups/cgfsng.c

  Log Message:
  -----------
  cgfsng: coding style for cgfsng_monitor_create()

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: d99d5c935a9ee2eb66ba9e55e85bd707d4c1647b
      https://github.com/lxc/lxc/commit/d99d5c935a9ee2eb66ba9e55e85bd707d4c1647b
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2019-02-10 (Sun, 10 Feb 2019)

  Changed paths:
    M src/lxc/cgroups/cgfsng.c

  Log Message:
  -----------
  cgfsng: coding style for cgfsng_payload_create()

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: c74da4abd20ede6a30c358dc275ba43b1d12e8d5
      https://github.com/lxc/lxc/commit/c74da4abd20ede6a30c358dc275ba43b1d12e8d5
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2019-02-10 (Sun, 10 Feb 2019)

  Changed paths:
    M src/lxc/cgroups/cgfsng.c
    M src/lxc/macro.h

  Log Message:
  -----------
  cgfsng: fix cgroup creation

When cgroup creation failed we reset container_cgroup to NULL to avoid
issues with __cleanup__. Fix that logic:
- add steal_ptr() based on take_ptr()
- move stealing the pointer out of the loop

lxc ctImport 20190210050705.858 DEBUG    network - network.c:instantiate_veth:202 - Instantiated veth "vethGQMH7I/vethSPXNL3", index is "272"
lxc ctImport 20190210050705.858 ERROR    cgfsng - cgroups/cgfsng.c:mkdir_eexist_on_last:1262 - File exists - Failed to create directory "/sys/fs/cgroup/unified//lxc.payload/ctImport-0"
lxc ctImport 20190210050705.858 ERROR    cgfsng - cgroups/cgfsng.c:container_create_path_for_hierarchy:1302 - Failed to create cgroup "/sys/fs/cgroup/unified//lxc.payload/ctImport-0"
lxc ctImport 20190210050705.858 ERROR    cgfsng - cgroups/cgfsng.c:cgfsng_payload_create:1431 - Failed to create cgroup "/sys/fs/cgroup/unified//lxc.payload/ctImport-0"
lxc ctImport 20190210050705.858 INFO     cgfsng - cgroups/cgfsng.c:cgfsng_payload_create:1441 - The container uses "lxc.payload/ctImport-0" as cgroup
lxc ctImport 20190210050705.858 ERROR    cgfsng - cgroups/cgfsng.c:mkdir_eexist_on_last:1262 - File exists - Failed to create directory "/sys/fs/cgroup/unified/"
lxc ctImport 20190210050705.858 ERROR    cgfsng - cgroups/cgfsng.c:container_create_path_for_hierarchy:1302 - Failed to create cgroup "/sys/fs/cgroup/unified/"
lxc ctImport 20190210050705.858 ERROR    cgfsng - cgroups/cgfsng.c:cgfsng_payload_create:1431 - Failed to create cgroup "/sys/fs/cgroup/unified/"
lxc ctImport 20190210050705.858 INFO     cgfsng - cgroups/cgfsng.c:cgfsng_payload_create:1441 - The container uses "(null)" as cgroup

Fixes: d97919abf22 ("cgroups: partially switch to cleanup macros")
Reported-by: Stéphane Graber <stgraber at ubuntu.com>
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: b49c4e2de47e1c9dd7526427e809cb750c4edada
      https://github.com/lxc/lxc/commit/b49c4e2de47e1c9dd7526427e809cb750c4edada
  Author: Wolfgang Bumiller <w.bumiller at proxmox.com>
  Date:   2019-02-10 (Sun, 10 Feb 2019)

  Changed paths:
    M src/lxc/cgroups/cgfsng.c
    M src/lxc/macro.h

  Log Message:
  -----------
  Merge pull request #2836 from brauner/2019-02-10/fix_cgfsng_driver

cgroup: bugfixes


Compare: https://github.com/lxc/lxc/compare/41f808b29a58...b49c4e2de47e


More information about the lxc-devel mailing list