[lxc-devel] [lxc/lxc] 7cac34: log: rearrange

[Christian Brauner]

  Branch: refs/heads/stable-3.0
  Home:   https://github.com/lxc/lxc
  Commit: 7cac3403a885bcccebc50f9bad895d1b028110c7
      https://github.com/lxc/lxc/commit/7cac3403a885bcccebc50f9bad895d1b028110c7
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2019-12-08 (Sun, 08 Dec 2019)

  Changed paths:
    M src/lxc/log.h

  Log Message:
  -----------
  log: rearrange

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: 3ed47250b322182cce212c191a069b131aa11e27
      https://github.com/lxc/lxc/commit/3ed47250b322182cce212c191a069b131aa11e27
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2019-12-08 (Sun, 08 Dec 2019)

  Changed paths:
    M src/lxc/macro.h

  Log Message:
  -----------
  macro: add ret_errno()

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: fa85bdaa23990bac7d69b7599f2e336578703522
      https://github.com/lxc/lxc/commit/fa85bdaa23990bac7d69b7599f2e336578703522
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2019-12-08 (Sun, 08 Dec 2019)

  Changed paths:
    M src/lxc/af_unix.c

  Log Message:
  -----------
  af_unix: s/minus_one_set_errno(/ret_set_errno(-1, /g

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: ad9fbcc46e8e8878786bad65102d5d7fcdb51549
      https://github.com/lxc/lxc/commit/ad9fbcc46e8e8878786bad65102d5d7fcdb51549
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2019-12-08 (Sun, 08 Dec 2019)

  Changed paths:
    M src/lxc/attach.c

  Log Message:
  -----------
  attach: s/minus_one_set_errno(/ret_set_errno(-1, /g

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: 17809bcf82af9bf1672159e7d914d1b3431a308c
      https://github.com/lxc/lxc/commit/17809bcf82af9bf1672159e7d914d1b3431a308c
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2019-12-08 (Sun, 08 Dec 2019)

  Changed paths:
    M src/lxc/commands.c

  Log Message:
  -----------
  commands: replace logging helpers

s/error_log_errno(/log_error_errno(-1, /g
s/minus_one_set_errno(/ret_set_errno(-1, /g

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: 71fac4fb5427817fe8020655b361c7ec680de76c
      https://github.com/lxc/lxc/commit/71fac4fb5427817fe8020655b361c7ec680de76c
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2019-12-08 (Sun, 08 Dec 2019)

  Changed paths:
    M src/lxc/network.c

  Log Message:
  -----------
  network: replace logging helpers

s/error_log_errno(/log_error_errno(-1, /g
s/minus_one_set_errno(/ret_set_errno(-1, /g

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: 6d9a9f085c4f2acd8bd787396f5295a8b2d6b7e3
      https://github.com/lxc/lxc/commit/6d9a9f085c4f2acd8bd787396f5295a8b2d6b7e3
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2019-12-08 (Sun, 08 Dec 2019)

  Changed paths:
    M src/lxc/confile.c

  Log Message:
  -----------
  confile: replace logging helpers

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: c00683a49d00ae3131fa34682415dd0c0c0c9929
      https://github.com/lxc/lxc/commit/c00683a49d00ae3131fa34682415dd0c0c0c9929
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2019-12-08 (Sun, 08 Dec 2019)

  Changed paths:
    M src/lxc/cgroups/cgfsng.c

  Log Message:
  -----------
  cgroups/cgfsng: replace logging functions

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: 56e96489da2f0557911aae833b935e2594d9e713
      https://github.com/lxc/lxc/commit/56e96489da2f0557911aae833b935e2594d9e713
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2019-12-08 (Sun, 08 Dec 2019)

  Changed paths:
    M src/lxc/cgroups/cgroup.c

  Log Message:
  -----------
  cgroups/cgroup: replace logging functions

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: 093469d725a4522e2150551a492522913f4e9dbb
      https://github.com/lxc/lxc/commit/093469d725a4522e2150551a492522913f4e9dbb
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2019-12-08 (Sun, 08 Dec 2019)

  Changed paths:
    M src/lxc/cgroups/cgroup2_devices.c

  Log Message:
  -----------
  cgroups/cgroup2_devices: replace logging functions

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: b53314a68a91a8ed5e2fdbc263ecbafbfe76b7ed
      https://github.com/lxc/lxc/commit/b53314a68a91a8ed5e2fdbc263ecbafbfe76b7ed
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2019-12-08 (Sun, 08 Dec 2019)

  Changed paths:
    M src/lxc/cgroups/cgfsng.c
    M src/lxc/cgroups/cgroup.h

  Log Message:
  -----------
  cgroups: rework return values of some functions

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: e35dec01637f957e9cfaa7fac940804926a41ee4
      https://github.com/lxc/lxc/commit/e35dec01637f957e9cfaa7fac940804926a41ee4
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2019-12-08 (Sun, 08 Dec 2019)

  Changed paths:
    M src/lxc/log.h
    M src/lxc/macro.h

  Log Message:
  -----------
  {log, macro}: remove unused logging functions

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: b7e685d6d806a741db5b0a64f34f3d0a077f3908
      https://github.com/lxc/lxc/commit/b7e685d6d806a741db5b0a64f34f3d0a077f3908
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2019-12-08 (Sun, 08 Dec 2019)

  Changed paths:
    M src/lxc/compiler.h

  Log Message:
  -----------
  compiler: add __unused attribute

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: 40354e5a8e317ebc8c2270dc7de074dde40f55ea
      https://github.com/lxc/lxc/commit/40354e5a8e317ebc8c2270dc7de074dde40f55ea
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2019-12-08 (Sun, 08 Dec 2019)

  Changed paths:
    M src/lxc/attach.c

  Log Message:
  -----------
  attach: replace closing helpers

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: 5429155b4a11590745edf2605cc13679683958f5
      https://github.com/lxc/lxc/commit/5429155b4a11590745edf2605cc13679683958f5
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2019-12-08 (Sun, 08 Dec 2019)

  Changed paths:
    M src/lxc/log.h

  Log Message:
  -----------
  log: replace compiler attributes

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: 97c09b99979a9eebc1fae0cec357a9646966be99
      https://github.com/lxc/lxc/commit/97c09b99979a9eebc1fae0cec357a9646966be99
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2019-12-08 (Sun, 08 Dec 2019)

  Changed paths:
    M src/lxc/start.c

  Log Message:
  -----------
  start: replace compiler attributes

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: 5fd45ff53d5c65b7d15978c24320e3780ceabc45
      https://github.com/lxc/lxc/commit/5fd45ff53d5c65b7d15978c24320e3780ceabc45
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2019-12-08 (Sun, 08 Dec 2019)

  Changed paths:
    M src/lxc/log.h

  Log Message:
  -----------
  log: remove unused compiler attribute

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: 1359d2238b89945bdeb208e59fcad4a67be1ab26
      https://github.com/lxc/lxc/commit/1359d2238b89945bdeb208e59fcad4a67be1ab26
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2019-12-08 (Sun, 08 Dec 2019)

  Changed paths:
    M src/lxc/cgroups/cgfsng.c

  Log Message:
  -----------
  cgroups/cgfsng: rework cgfsng_payload_destroy()

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: e0c8dc5edd6c70929281cbe84c799e2ff55fe35b
      https://github.com/lxc/lxc/commit/e0c8dc5edd6c70929281cbe84c799e2ff55fe35b
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2019-12-08 (Sun, 08 Dec 2019)

  Changed paths:
    M src/lxc/cgroups/cgfsng.c

  Log Message:
  -----------
  cgroups/cgfsng: rework cgfsng_monitor_destroy()

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: 9322b1a3d472b26c30ac2c4ba37d9cd617e19174
      https://github.com/lxc/lxc/commit/9322b1a3d472b26c30ac2c4ba37d9cd617e19174
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2019-12-08 (Sun, 08 Dec 2019)

  Changed paths:
    M src/lxc/cgroups/cgfsng.c
    M src/lxc/log.h

  Log Message:
  -----------
  cgroups/cgfsng: rework cgfsng_monitor_create()

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: 50a48614b2674fa6a648278aeac3ded4649c860d
      https://github.com/lxc/lxc/commit/50a48614b2674fa6a648278aeac3ded4649c860d
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2019-12-08 (Sun, 08 Dec 2019)

  Changed paths:
    M src/lxc/cgroups/cgfsng.c

  Log Message:
  -----------
  cgroups/cgfsng: rework cgfsng_monitor_enter()

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: 43a42cc11331b438c496bd6ef4ff171c8aed585f
      https://github.com/lxc/lxc/commit/43a42cc11331b438c496bd6ef4ff171c8aed585f
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2019-12-08 (Sun, 08 Dec 2019)

  Changed paths:
    M src/lxc/cgroups/cgfsng.c

  Log Message:
  -----------
  cgroups/cgfsng: rework cgfsng_{monitor,payload}_delegate_controllers()

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: 584d340bd785ec7c9f6559a5fd39d4a4ed3d8a13
      https://github.com/lxc/lxc/commit/584d340bd785ec7c9f6559a5fd39d4a4ed3d8a13
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2019-12-08 (Sun, 08 Dec 2019)

  Changed paths:
    M src/lxc/cgroups/cgfsng.c

  Log Message:
  -----------
  cgroups/cgfsng: rework cgroup2 unprivileged delegation

We accidently checked files to delegate for privileged container and not for
unprivileged containers in the pure unified case. Fix that and clean up the
delegation file parsing.

Closes #3206.
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: b64652d4c31ac0640db54f20c0e520c8b0dcb5ea
      https://github.com/lxc/lxc/commit/b64652d4c31ac0640db54f20c0e520c8b0dcb5ea
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2019-12-08 (Sun, 08 Dec 2019)

  Changed paths:
    M src/lxc/cgroups/cgfsng.c
    M src/lxc/log.h

  Log Message:
  -----------
  cgroups/cgfsng: log chown_cgroup_wrapper()

It's becoming more important on cgroup2 to properly delegate cgroups.

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: 75bb976e8f71cd67b9c8e6abd20bdf10c578ce3e
      https://github.com/lxc/lxc/commit/75bb976e8f71cd67b9c8e6abd20bdf10c578ce3e
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2019-12-08 (Sun, 08 Dec 2019)

  Changed paths:
    M src/lxc/cgroups/cgfsng.c

  Log Message:
  -----------
  cgroups/cgfsng: don't dereference NULL-pointer

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: 1a4b9d449bada4625687420e2efd2c9e312bc8ae
      https://github.com/lxc/lxc/commit/1a4b9d449bada4625687420e2efd2c9e312bc8ae
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2019-12-08 (Sun, 08 Dec 2019)

  Changed paths:
    M src/lxc/cgroups/cgfsng.c

  Log Message:
  -----------
  cgroups/cgfsng: rework cgroup attach

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: f29b71cee225f29d2ffa71eb400b83f42465290f
      https://github.com/lxc/lxc/commit/f29b71cee225f29d2ffa71eb400b83f42465290f
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2019-12-08 (Sun, 08 Dec 2019)

  Changed paths:
    M src/lxc/compiler.h
    M src/lxc/log.h
    M src/lxc/start.c

  Log Message:
  -----------
  tree-wide: s/__unused/__lxc_unused/g

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: 58222337d59215567e5793b9f0e217823c12f47a
      https://github.com/lxc/lxc/commit/58222337d59215567e5793b9f0e217823c12f47a
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2019-12-08 (Sun, 08 Dec 2019)

  Changed paths:
    M src/lxc/cgroups/cgfsng.c

  Log Message:
  -----------
  cgroups/cgfsng: rework cgfsng_payload_create()

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: 68990f1ebff95cda1abbf0fc4b77cd53ef4fce19
      https://github.com/lxc/lxc/commit/68990f1ebff95cda1abbf0fc4b77cd53ef4fce19
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2019-12-08 (Sun, 08 Dec 2019)

  Changed paths:
    M src/lxc/cgroups/cgfsng.c

  Log Message:
  -----------
  cgroups/cgfsng: rework cgfsng_payload_enter()

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: f7cdc98a88fd9223590c07a84867eccbdb724495
      https://github.com/lxc/lxc/commit/f7cdc98a88fd9223590c07a84867eccbdb724495
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2019-12-08 (Sun, 08 Dec 2019)

  Changed paths:
    M src/lxc/cgroups/cgfsng.c

  Log Message:
  -----------
  cgroups/cgfsng: rework cgfsng_escape()

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: 9a8bead27cc250ff7f823ab75a1fd3cd45886186
      https://github.com/lxc/lxc/commit/9a8bead27cc250ff7f823ab75a1fd3cd45886186
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2019-12-08 (Sun, 08 Dec 2019)

  Changed paths:
    M src/lxc/cgroups/cgfsng.c

  Log Message:
  -----------
  cgroups/cgfsng: rework cgfsng_num_hierarchies()

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: 1d0ef8513698697e3c8dfbf5ed5e6563cdbd2921
      https://github.com/lxc/lxc/commit/1d0ef8513698697e3c8dfbf5ed5e6563cdbd2921
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2019-12-08 (Sun, 08 Dec 2019)

  Changed paths:
    M src/lxc/cgroups/cgfsng.c

  Log Message:
  -----------
  cgroups/cgfsng: rework cgfsng_get_hierarchies()

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: e650b99a88ba5fef357a89bfdeba5c07bac80f18
      https://github.com/lxc/lxc/commit/e650b99a88ba5fef357a89bfdeba5c07bac80f18
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2019-12-08 (Sun, 08 Dec 2019)

  Changed paths:
    M src/lxc/cgroups/cgfsng.c

  Log Message:
  -----------
  cgroups/cgfsng: rework cgfsng_unfreeze()

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: b411338805072c6c696566584907d693132edc90
      https://github.com/lxc/lxc/commit/b411338805072c6c696566584907d693132edc90
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2019-12-08 (Sun, 08 Dec 2019)

  Changed paths:
    M src/lxc/cgroups/cgfsng.c

  Log Message:
  -----------
  cgroups/cgfsng: rework cgfsng_{get,set}()

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: 6782b4b23fd6e8ce3b7ef577ffefbeda288da94b
      https://github.com/lxc/lxc/commit/6782b4b23fd6e8ce3b7ef577ffefbeda288da94b
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2019-12-08 (Sun, 08 Dec 2019)

  Changed paths:
    M src/lxc/cgroups/cgfsng.c

  Log Message:
  -----------
  cgroups/cgfsng: rework cgfsng_setup_limits_legacy()

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: ae072728bf502214455c40f8ae40712da2904db8
      https://github.com/lxc/lxc/commit/ae072728bf502214455c40f8ae40712da2904db8
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2019-12-08 (Sun, 08 Dec 2019)

  Changed paths:
    M src/lxc/cgroups/cgfsng.c

  Log Message:
  -----------
  cgroups/cgfsng: rework cgfsng_setup_limits()

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: 78bda28d1af94de37ebdeef15a89329f00f8c51b
      https://github.com/lxc/lxc/commit/78bda28d1af94de37ebdeef15a89329f00f8c51b
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2019-12-08 (Sun, 08 Dec 2019)

  Changed paths:
    M src/lxc/cgroups/cgfsng.c

  Log Message:
  -----------
  cgroups/cgfsng: rework cgfsng_attach()

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: 48ee0f070a33b3ba93b09cc7a4353ff35b3828a5
      https://github.com/lxc/lxc/commit/48ee0f070a33b3ba93b09cc7a4353ff35b3828a5
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2019-12-08 (Sun, 08 Dec 2019)

  Changed paths:
    M src/lxc/cgroups/cgfsng.c

  Log Message:
  -----------
  cgroups/cgfsng: rework cgfsng_chown()

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: 362bcc432683f5029193e0f7412d72c9cf68dafe
      https://github.com/lxc/lxc/commit/362bcc432683f5029193e0f7412d72c9cf68dafe
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2019-12-08 (Sun, 08 Dec 2019)

  Changed paths:
    M src/lxc/cgroups/cgfsng.c

  Log Message:
  -----------
  cgroups/cgfsng: rework cgfsng_mount()

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: b46a3ae82b2a8768b272d41ad2ce91da9d8dae14
      https://github.com/lxc/lxc/commit/b46a3ae82b2a8768b272d41ad2ce91da9d8dae14
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2019-12-08 (Sun, 08 Dec 2019)

  Changed paths:
    M src/lxc/cgroups/cgfsng.c

  Log Message:
  -----------
  cgroups/cgfsng: rework cgfsng_nrtasks()

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: b805280efeaf93693533e7d07173c9e77b63974b
      https://github.com/lxc/lxc/commit/b805280efeaf93693533e7d07173c9e77b63974b
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2019-12-08 (Sun, 08 Dec 2019)

  Changed paths:
    M src/lxc/cgroups/cgfsng.c

  Log Message:
  -----------
  cgroups/cgfsng: cgfsng_devices_activate()

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: 1b7b7923eec917156d00eb05c90f06721f5ff7e9
      https://github.com/lxc/lxc/commit/1b7b7923eec917156d00eb05c90f06721f5ff7e9
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2019-12-08 (Sun, 08 Dec 2019)

  Changed paths:
    M src/lxc/cgroups/cgfsng.c
    M src/lxc/file_utils.c
    M src/lxc/file_utils.h

  Log Message:
  -----------
  cgroups/cgfsng: replace lxc_write_file()

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


Compare: https://github.com/lxc/lxc/compare/4c3a47db9eb4...1b7b7923eec9