[lxc-devel] [lxc/lxc] 3910f8: commands: use logging return helpers

Christian Brauner noreply at github.com
Thu Dec 5 10:00:46 UTC 2019


  Branch: refs/heads/stable-3.0
  Home:   https://github.com/lxc/lxc
  Commit: 3910f81ff670a022dccc4f95c6298180249d7db7
      https://github.com/lxc/lxc/commit/3910f81ff670a022dccc4f95c6298180249d7db7
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2019-12-05 (Thu, 05 Dec 2019)

  Changed paths:
    M src/lxc/commands.c
    M src/lxc/log.h

  Log Message:
  -----------
  commands: use logging return helpers

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: 1e8adfa12f774243c5a58c7d74d2948125859491
      https://github.com/lxc/lxc/commit/1e8adfa12f774243c5a58c7d74d2948125859491
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2019-12-05 (Thu, 05 Dec 2019)

  Changed paths:
    R COPYING
    A LICENSE.GPL2
    A LICENSE.LGPL2.1
    M src/lxc/Makefile.am
    M src/lxc/af_unix.c
    M src/lxc/af_unix.h
    M src/lxc/attach.c
    M src/lxc/attach.h
    M src/lxc/attach_options.h
    M src/lxc/caps.c
    M src/lxc/caps.h
    M src/lxc/cgroups/cgfsng.c
    M src/lxc/cgroups/cgroup.c
    M src/lxc/cgroups/cgroup.h
    M src/lxc/cgroups/cgroup_utils.c
    M src/lxc/cgroups/cgroup_utils.h
    M src/lxc/cmd/lxc-checkconfig.in
    M src/lxc/cmd/lxc-update-config.in
    M src/lxc/cmd/lxc_init.c
    M src/lxc/cmd/lxc_monitord.c
    M src/lxc/cmd/lxc_user_nic.c
    M src/lxc/cmd/lxc_usernsexec.c
    M src/lxc/commands.c
    M src/lxc/commands.h
    M src/lxc/commands_utils.c
    M src/lxc/commands_utils.h
    M src/lxc/compiler.h
    M src/lxc/conf.c
    M src/lxc/conf.h
    M src/lxc/confile.c
    M src/lxc/confile.h
    M src/lxc/confile_utils.c
    M src/lxc/confile_utils.h
    M src/lxc/criu.c
    M src/lxc/criu.h
    M src/lxc/error.c
    M src/lxc/error.h
    M src/lxc/execute.c
    M src/lxc/file_utils.c
    M src/lxc/file_utils.h
    M src/lxc/freezer.c
    M src/lxc/initutils.c
    M src/lxc/initutils.h
    M src/lxc/list.h
    M src/lxc/log.c
    M src/lxc/log.h
    M src/lxc/lsm/apparmor.c
    M src/lxc/lsm/lsm.c
    M src/lxc/lsm/lsm.h
    M src/lxc/lsm/nop.c
    M src/lxc/lsm/selinux.c
    M src/lxc/lxc.functions.in
    M src/lxc/lxc.h
    M src/lxc/lxccontainer.c
    M src/lxc/lxccontainer.h
    M src/lxc/lxclock.c
    M src/lxc/lxclock.h
    M src/lxc/lxcseccomp.h
    M src/lxc/macro.h
    M src/lxc/mainloop.c
    M src/lxc/mainloop.h
    M src/lxc/memory_utils.h
    M src/lxc/monitor.c
    M src/lxc/monitor.h
    M src/lxc/namespace.c
    M src/lxc/namespace.h
    M src/lxc/network.c
    M src/lxc/network.h
    M src/lxc/nl.c
    M src/lxc/nl.h
    M src/lxc/pam/pam_cgfs.c
    M src/lxc/parse.c
    M src/lxc/parse.h
    M src/lxc/raw_syscalls.c
    M src/lxc/raw_syscalls.h
    M src/lxc/rexec.c
    M src/lxc/rexec.h
    M src/lxc/ringbuf.c
    M src/lxc/ringbuf.h
    M src/lxc/rtnl.c
    M src/lxc/rtnl.h
    M src/lxc/seccomp.c
    M src/lxc/start.c
    M src/lxc/start.h
    M src/lxc/state.c
    M src/lxc/state.h
    M src/lxc/storage/btrfs.c
    M src/lxc/storage/btrfs.h
    M src/lxc/storage/dir.c
    M src/lxc/storage/dir.h
    M src/lxc/storage/loop.c
    M src/lxc/storage/loop.h
    M src/lxc/storage/lvm.c
    M src/lxc/storage/lvm.h
    M src/lxc/storage/nbd.c
    M src/lxc/storage/nbd.h
    M src/lxc/storage/overlay.c
    M src/lxc/storage/overlay.h
    M src/lxc/storage/rbd.c
    M src/lxc/storage/rbd.h
    M src/lxc/storage/rsync.c
    M src/lxc/storage/rsync.h
    M src/lxc/storage/storage.c
    M src/lxc/storage/storage.h
    M src/lxc/storage/storage_utils.c
    M src/lxc/storage/storage_utils.h
    M src/lxc/storage/zfs.c
    M src/lxc/storage/zfs.h
    M src/lxc/string_utils.c
    M src/lxc/string_utils.h
    M src/lxc/sync.c
    M src/lxc/sync.h
    M src/lxc/syscall_wrappers.h
    M src/lxc/terminal.c
    M src/lxc/terminal.h
    M src/lxc/tools/arguments.c
    M src/lxc/tools/arguments.h
    M src/lxc/tools/include/getsubopt.c
    M src/lxc/tools/include/getsubopt.h
    M src/lxc/tools/lxc_attach.c
    M src/lxc/tools/lxc_autostart.c
    M src/lxc/tools/lxc_cgroup.c
    M src/lxc/tools/lxc_checkpoint.c
    M src/lxc/tools/lxc_config.c
    M src/lxc/tools/lxc_console.c
    M src/lxc/tools/lxc_copy.c
    M src/lxc/tools/lxc_create.c
    M src/lxc/tools/lxc_destroy.c
    M src/lxc/tools/lxc_device.c
    M src/lxc/tools/lxc_execute.c
    M src/lxc/tools/lxc_freeze.c
    M src/lxc/tools/lxc_info.c
    M src/lxc/tools/lxc_ls.c
    M src/lxc/tools/lxc_monitor.c
    M src/lxc/tools/lxc_snapshot.c
    M src/lxc/tools/lxc_start.c
    M src/lxc/tools/lxc_stop.c
    M src/lxc/tools/lxc_top.c
    M src/lxc/tools/lxc_unfreeze.c
    M src/lxc/tools/lxc_unshare.c
    M src/lxc/tools/lxc_wait.c
    M src/lxc/utils.c
    M src/lxc/utils.h
    M src/lxc/uuid.c
    M src/lxc/uuid.h
    M src/lxc/version.h.in

  Log Message:
  -----------
  lxc: switch to SPDX

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: ec26ee91c3ba0e234bed64a543b84366a4471b8a
      https://github.com/lxc/lxc/commit/ec26ee91c3ba0e234bed64a543b84366a4471b8a
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2019-12-05 (Thu, 05 Dec 2019)

  Changed paths:
    M src/lxc/attach.c
    M src/lxc/cgroups/cgfsng.c
    M src/lxc/cgroups/cgroup.h
    M src/lxc/commands.c
    M src/lxc/log.h
    M src/lxc/macro.h

  Log Message:
  -----------
  cgroups: improve container cgroup attaching

The current attach.c codepath which handles moving the attaching process into
the container's cgroups allocates a whole new struct cgroup_ops and goes
through the trouble of reparsing the whole cgroup layout.
That's costly and wasteful. My plan has always been to move this into the
command api by getting fds for attaching back but but it's not worth going
through that hazzle for non-unified hosts. On pure unified hosts however -
being the future - we can just attach through a single fd so there's no need to
allocate and setup struct cgroup_ops.

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: df5f3618851bc46fafcbf20ccfa3c540180a1cd0
      https://github.com/lxc/lxc/commit/df5f3618851bc46fafcbf20ccfa3c540180a1cd0
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2019-12-05 (Thu, 05 Dec 2019)

  Changed paths:
    M src/lxc/cgroups/cgfsng.c

  Log Message:
  -----------
  cgroups/devices: correctly verify bpf device useability in cgfsng_devices_activate()

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


Compare: https://github.com/lxc/lxc/compare/663287e92bee...df5f3618851b


More information about the lxc-devel mailing list