[lxc-devel] [lxc/lxc] 23a917: commands: use logging return helpers

Stéphane Graber noreply at github.com
Wed Dec 4 14:58:00 UTC 2019


  Branch: refs/heads/master
  Home:   https://github.com/lxc/lxc
  Commit: 23a917e5d242698607edc4cf5dd270bb744e843d
      https://github.com/lxc/lxc/commit/23a917e5d242698607edc4cf5dd270bb744e843d
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2019-12-04 (Wed, 04 Dec 2019)

  Changed paths:
    M src/lxc/commands.c
    M src/lxc/log.h

  Log Message:
  -----------
  commands: use logging return helpers

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: 900b6606584e484b7528043b851320f9b110706b
      https://github.com/lxc/lxc/commit/900b6606584e484b7528043b851320f9b110706b
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2019-12-04 (Wed, 04 Dec 2019)

  Changed paths:
    M src/lxc/attach.c
    M src/lxc/cgroups/cgfsng.c
    M src/lxc/cgroups/cgroup.h
    M src/lxc/commands.c
    M src/lxc/log.h
    M src/lxc/macro.h

  Log Message:
  -----------
  cgroups: improve container cgroup attaching

The current attach.c codepath which handles moving the attaching process into
the container's cgroups allocates a whole new struct cgroup_ops and goes
through the trouble of reparsing the whole cgroup layout.
That's costly and wasteful. My plan has always been to move this into the
command api by getting fds for attaching back but but it's not worth going
through that hazzle for non-unified hosts. On pure unified hosts however -
being the future - we can just attach through a single fd so there's no need to
allocate and setup struct cgroup_ops.

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: 9994db5125538bcabca9239f132280b46fa266c7
      https://github.com/lxc/lxc/commit/9994db5125538bcabca9239f132280b46fa266c7
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2019-12-04 (Wed, 04 Dec 2019)

  Changed paths:
    M src/lxc/cgroups/cgfsng.c

  Log Message:
  -----------
  cgroups/devices: correctly verify bpf device useability in cgfsng_devices_activate()

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: 8a7d02b7120f43a013a8a6bb595af11e678e5de4
      https://github.com/lxc/lxc/commit/8a7d02b7120f43a013a8a6bb595af11e678e5de4
  Author: Stéphane Graber <stgraber at ubuntu.com>
  Date:   2019-12-04 (Wed, 04 Dec 2019)

  Changed paths:
    M src/lxc/attach.c
    M src/lxc/cgroups/cgfsng.c
    M src/lxc/cgroups/cgroup.h
    M src/lxc/commands.c
    M src/lxc/log.h
    M src/lxc/macro.h

  Log Message:
  -----------
  Merge pull request #3207 from brauner/cgroup2_improvements_2

cgroups: improve container cgroup attaching


Compare: https://github.com/lxc/lxc/compare/c10ac1b13b50...8a7d02b7120f


More information about the lxc-devel mailing list