[lxc-devel] [lxc/lxc] 64b11b: cgroups: use __do_free

Julio Faracco noreply at github.com
Sun Aug 11 19:42:58 UTC 2019


  Branch: refs/heads/stable-3.0
  Home:   https://github.com/lxc/lxc
  Commit: 64b11bda8311256cfdee095c2618ec9508c3dc6e
      https://github.com/lxc/lxc/commit/64b11bda8311256cfdee095c2618ec9508c3dc6e
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2019-08-11 (Sun, 11 Aug 2019)

  Changed paths:
    M src/lxc/cgroups/cgfsng.c

  Log Message:
  -----------
  cgroups: use __do_free

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: bba1ede501acd82d0f41d9961ea91f496d4c9e84
      https://github.com/lxc/lxc/commit/bba1ede501acd82d0f41d9961ea91f496d4c9e84
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2019-08-11 (Sun, 11 Aug 2019)

  Changed paths:
    M src/lxc/cgroups/cgfsng.c

  Log Message:
  -----------
  cgroups: move variables into tighter scope

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: 53c4e67dbf35c2f2aee9354e2dd36d2731d95a86
      https://github.com/lxc/lxc/commit/53c4e67dbf35c2f2aee9354e2dd36d2731d95a86
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2019-08-11 (Sun, 11 Aug 2019)

  Changed paths:
    M src/lxc/cgroups/cgfsng.c

  Log Message:
  -----------
  cgroups: simplify cgfsng_setup_limits()

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: aa88fb43dafc149e74bc8fa198275b79315c257b
      https://github.com/lxc/lxc/commit/aa88fb43dafc149e74bc8fa198275b79315c257b
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2019-08-11 (Sun, 11 Aug 2019)

  Changed paths:
    M src/lxc/cgroups/cgfsng.c

  Log Message:
  -----------
  cgroups: use __do_free in cgfsng_attach()

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: b660fd1b4bbc61e18c7e7af755964f3b6e2cb6de
      https://github.com/lxc/lxc/commit/b660fd1b4bbc61e18c7e7af755964f3b6e2cb6de
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2019-08-11 (Sun, 11 Aug 2019)

  Changed paths:
    M src/lxc/cgroups/cgfsng.c

  Log Message:
  -----------
  cgroups: move variable into tighter scope

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: a3d3232e1407e0b59303b995674678d2b4c908a1
      https://github.com/lxc/lxc/commit/a3d3232e1407e0b59303b995674678d2b4c908a1
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2019-08-11 (Sun, 11 Aug 2019)

  Changed paths:
    M src/lxc/cgroups/cgfsng.c

  Log Message:
  -----------
  cgroups: move variable into tighter scope

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: fa6f9d83a8259c5138ce3f99562a9f0dfcbfbc66
      https://github.com/lxc/lxc/commit/fa6f9d83a8259c5138ce3f99562a9f0dfcbfbc66
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2019-08-11 (Sun, 11 Aug 2019)

  Changed paths:
    M src/lxc/cgroups/cgfsng.c

  Log Message:
  -----------
  cgroups: simplify cgfsng_nrtasks()

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: c41884a94c3fd2e56780ae8251f134130af40c8d
      https://github.com/lxc/lxc/commit/c41884a94c3fd2e56780ae8251f134130af40c8d
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2019-08-11 (Sun, 11 Aug 2019)

  Changed paths:
    M src/lxc/cgroups/cgfsng.c

  Log Message:
  -----------
  cgroups: move variable into tighter scope

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: db3d5c1f4bf7eee5ca49fe660c6731442f689e1e
      https://github.com/lxc/lxc/commit/db3d5c1f4bf7eee5ca49fe660c6731442f689e1e
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2019-08-11 (Sun, 11 Aug 2019)

  Changed paths:
    M src/lxc/cgroups/cgfsng.c

  Log Message:
  -----------
  cgroups: correctly order variables

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: 898a01e69f33d33857888ac2811015b83d027295
      https://github.com/lxc/lxc/commit/898a01e69f33d33857888ac2811015b83d027295
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2019-08-11 (Sun, 11 Aug 2019)

  Changed paths:
    M src/lxc/cgroups/cgfsng.c

  Log Message:
  -----------
  cgroups: move variable into tighter scope

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: a67697bfa903300a3988a92238fe1dd2720a35f8
      https://github.com/lxc/lxc/commit/a67697bfa903300a3988a92238fe1dd2720a35f8
  Author: LiFeng <lifeng68 at huawei.com>
  Date:   2019-08-11 (Sun, 11 Aug 2019)

  Changed paths:
    M src/lxc/lxccontainer.c

  Log Message:
  -----------
  fix memory leak in do_storage_create

Signed-off-by: LiFeng <lifeng68 at huawei.com>


  Commit: 362e8b6a8138e2812c7deda41dda32b5375edc5f
      https://github.com/lxc/lxc/commit/362e8b6a8138e2812c7deda41dda32b5375edc5f
  Author: Rachid Koucha <47061324+Rachid-Koucha at users.noreply.github.com>
  Date:   2019-08-11 (Sun, 11 Aug 2019)

  Changed paths:
    M src/lxc/start.c

  Log Message:
  -----------
  Move code/variable in smaller scope

In start.c, do not fill path[] table if not necessary

Signed-off-by: Rachid Koucha <rachid.koucha at gmail.com>


  Commit: b24466050fdc4b6487bb4dfe1f07e6bc1650378c
      https://github.com/lxc/lxc/commit/b24466050fdc4b6487bb4dfe1f07e6bc1650378c
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2019-08-11 (Sun, 11 Aug 2019)

  Changed paths:
    M src/lxc/start.c

  Log Message:
  -----------
  start: expose LXC_PID to network hooks too

Closes #3066.
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: b9071a6dab43631d65ccf7cbb9c6f39769c86f09
      https://github.com/lxc/lxc/commit/b9071a6dab43631d65ccf7cbb9c6f39769c86f09
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2019-08-11 (Sun, 11 Aug 2019)

  Changed paths:
    M src/lxc/cgroups/cgfsng.c

  Log Message:
  -----------
  cgroups: hande cpuset initialization race

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: 69384628439c298b3e0d60e55bade4c9ddb5c97d
      https://github.com/lxc/lxc/commit/69384628439c298b3e0d60e55bade4c9ddb5c97d
  Author: Wolfgang Bumiller <w.bumiller at proxmox.com>
  Date:   2019-08-11 (Sun, 11 Aug 2019)

  Changed paths:
    M src/lxc/raw_syscalls.c

  Log Message:
  -----------
  pidf_send_signal: fix return value

Signed-off-by: Wolfgang Bumiller <w.bumiller at proxmox.com>


  Commit: 6010712d168a4eec00d5279ab191cd31b63fe745
      https://github.com/lxc/lxc/commit/6010712d168a4eec00d5279ab191cd31b63fe745
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2019-08-11 (Sun, 11 Aug 2019)

  Changed paths:
    M src/lxc/cgroups/cgroup.c

  Log Message:
  -----------
  cgroup: check for non-empty conf

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: f2dc70c18bfd32c553b89cc94729b1d2070a0169
      https://github.com/lxc/lxc/commit/f2dc70c18bfd32c553b89cc94729b1d2070a0169
  Author: Rachid Koucha <47061324+Rachid-Koucha at users.noreply.github.com>
  Date:   2019-08-11 (Sun, 11 Aug 2019)

  Changed paths:
    M src/lxc/terminal.c

  Log Message:
  -----------
  Typo fix

Fixed a typo in error message

Signed-off-by: Rachid Koucha <rachid.koucha at gmail.com>


  Commit: 025472f9c78ee670f5a57b444b790f1e221bf776
      https://github.com/lxc/lxc/commit/025472f9c78ee670f5a57b444b790f1e221bf776
  Author: Rachid Koucha <47061324+Rachid-Koucha at users.noreply.github.com>
  Date:   2019-08-11 (Sun, 11 Aug 2019)

  Changed paths:
    M src/lxc/utils.c

  Log Message:
  -----------
  Suppress hardcoded table sizes

. Use sizeof() instead of hardcoded values
. snprintf(..., size, ""...) is in error if the return code is >= size (not sufficient to set only ">")

Signed-off-by: Rachid Koucha <rachid.koucha at gmail.com>


  Commit: d15d0bd19634fa03a4c0ce632d06ae5374c15e3e
      https://github.com/lxc/lxc/commit/d15d0bd19634fa03a4c0ce632d06ae5374c15e3e
  Author: Thomas Parrott <thomas.parrott at canonical.com>
  Date:   2019-08-11 (Sun, 11 Aug 2019)

  Changed paths:
    M src/lxc/log.h

  Log Message:
  -----------
  lxc/log: Adds error_log_errno macro

Suggested usage:

	return error_log_errno(err, "Failed: %s", "some error");

It sets errno to the value of err, then calls SYSERROR with the format and remaining args.

It always returns -1.

Suggested-by: Christian Brauner <christian.brauner at ubuntu.com>
Signed-off-by: Thomas Parrott <thomas.parrott at canonical.com>


  Commit: cf61d25eb94d5168cf7e76d9acf4e89599bfd176
      https://github.com/lxc/lxc/commit/cf61d25eb94d5168cf7e76d9acf4e89599bfd176
  Author: St├ęphane Graber <stgraber at ubuntu.com>
  Date:   2019-08-11 (Sun, 11 Aug 2019)

  Changed paths:
    M templates/lxc-download.in

  Log Message:
  -----------
  lxc-download: Pre-release bump of compat

Signed-off-by: St├ęphane Graber <stgraber at ubuntu.com>


  Commit: f452e523d91c7ceca29b7760cfa9d7030bb7ddae
      https://github.com/lxc/lxc/commit/f452e523d91c7ceca29b7760cfa9d7030bb7ddae
  Author: Tycho Andersen <tycho at tycho.ws>
  Date:   2019-08-11 (Sun, 11 Aug 2019)

  Changed paths:
    M src/lxc/start.c

  Log Message:
  -----------
  pidfds: don't print a scary warning on ENOSYS

Most kernels don't have this functionality yet, and so the warning is
printed a lot. Our people are scared of warnings, so let's make it INFO
instead in this case.

Signed-off-by: Tycho Andersen <tycho at tycho.ws>


  Commit: a29e5dc592481e7fc76a6c97ee62b4f9ef6f8b0e
      https://github.com/lxc/lxc/commit/a29e5dc592481e7fc76a6c97ee62b4f9ef6f8b0e
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2019-08-11 (Sun, 11 Aug 2019)

  Changed paths:
    M src/lxc/cgroups/cgfsng.c

  Log Message:
  -----------
  cgroups: initialize cpuset properly

Closes #3108.
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: c5abc9de6f88febbf055433acf4156780bfca647
      https://github.com/lxc/lxc/commit/c5abc9de6f88febbf055433acf4156780bfca647
  Author: Thomas Parrott <thomas.parrott at canonical.com>
  Date:   2019-08-11 (Sun, 11 Aug 2019)

  Changed paths:
    M src/lxc/attach.c
    M src/lxc/attach.h
    M src/lxc/lxccontainer.c
    M src/lxc/network.c
    M src/lxc/network.h

  Log Message:
  -----------
  lxccontainer: do_lxcapi_detach_interface to support detaching wlan devices

Signed-off-by: Thomas Parrott <thomas.parrott at canonical.com>


  Commit: 0bea6d539cd9d6099ec4a94e728bc3328ad2235d
      https://github.com/lxc/lxc/commit/0bea6d539cd9d6099ec4a94e728bc3328ad2235d
  Author: Julio Faracco <jcfaracco at gmail.com>
  Date:   2019-08-11 (Sun, 11 Aug 2019)

  Changed paths:
    M src/lxc/lxccontainer.c
    M src/lxc/utils.c
    M src/lxc/utils.h

  Log Message:
  -----------
  utils: Fix wrong integer of a function parameter.

If SSL is enabled, utils will include function `do_sha1_hash()` to
generate a sha1 encrypted buffer. Last function argument of
`EVP_DigestFinal_ex()` requires a `unsigned int` but the current
parameter is an `integer` type.

See error:
utils.c:350:38: error: passing 'int *' to parameter of type 'unsigned int *' converts between pointers to integer types with different sign
      [-Werror,-Wpointer-sign]
        EVP_DigestFinal_ex(mdctx, md_value, md_len);
                                            ^~~~~~
/usr/include/openssl/evp.h:549:49: note: passing argument to parameter 's' here
                                  unsigned int *s);

Signed-off-by: Julio Faracco <jcfaracco at gmail.com>


Compare: https://github.com/lxc/lxc/compare/4da32f95de15...0bea6d539cd9


More information about the lxc-devel mailing list