[lxc-devel] [lxc/lxc] b53a08: cgroups: fix potential nullderef

Stéphane Graber noreply at github.com
Sun Apr 14 18:04:02 UTC 2019


  Branch: refs/heads/master
  Home:   https://github.com/lxc/lxc
  Commit: b53a08535a8a7f1c8745466ae572886b3b4f5477
      https://github.com/lxc/lxc/commit/b53a08535a8a7f1c8745466ae572886b3b4f5477
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2019-04-14 (Sun, 14 Apr 2019)

  Changed paths:
    M src/lxc/cgroups/cgfsng.c

  Log Message:
  -----------
  cgroups: fix potential nullderef

The child_path variable is initialized very late in the function so jumping to
the on_error label would cause a nullderef. With the cleanup macros we can
simplify this function to simply do direct returns and avoid that whole issue.

Closes #2935.

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: 49ce8186e6b8cb955792cbc794b261424a5f0f41
      https://github.com/lxc/lxc/commit/49ce8186e6b8cb955792cbc794b261424a5f0f41
  Author: Stéphane Graber <stgraber at ubuntu.com>
  Date:   2019-04-14 (Sun, 14 Apr 2019)

  Changed paths:
    M src/lxc/cgroups/cgfsng.c

  Log Message:
  -----------
  Merge pull request #2936 from brauner/2019-04-14/issue_2935

cgroups: fix potential nullderef


Compare: https://github.com/lxc/lxc/compare/30a9d1371a2f...49ce8186e6b8


More information about the lxc-devel mailing list