[lxc-devel] [lxc/lxc] a42d8c: lxc-usernsexec: fix default map functionality

Wed Apr 10 21:16:45 UTC 2019

  Branch: refs/heads/stable-3.0
  Home:   https://github.com/lxc/lxc
  Commit: a42d8c762e521520f2747b8ed2af89fcd38179e6
      https://github.com/lxc/lxc/commit/a42d8c762e521520f2747b8ed2af89fcd38179e6
  Author: Cameron Nemo <camerontnorman at gmail.com>
  Date:   2019-04-10 (Wed, 10 Apr 2019)

  Changed paths:
    M src/lxc/cmd/lxc_usernsexec.c

  Log Message:
  -----------
  lxc-usernsexec: fix default map functionality

* Place NULL bytes at the end of strings so that
  lxc_safe_ulong() can parse them correctly

* Only free the newly created id_map on error,
  to avoid passing garbage to lxc_map_ids()

Signed-off-by: Cameron Nemo <camerontnorman at gmail.com>

  Commit: 07c046cda3b2df9abe149741b7f86c16c84ec9bc
      https://github.com/lxc/lxc/commit/07c046cda3b2df9abe149741b7f86c16c84ec9bc
  Author: 2xsec <dh48.jeong at samsung.com>
  Date:   2019-04-10 (Wed, 10 Apr 2019)

  Changed paths:
    M src/lxc/Makefile.am

  Log Message:
  -----------
  fix install error when using --disable-commands option

Signed-off-by: 2xsec <dh48.jeong at samsung.com>

  Commit: 0fed92a0e112e18b8f5acfeab9f7f5d21383da10
      https://github.com/lxc/lxc/commit/0fed92a0e112e18b8f5acfeab9f7f5d21383da10
  Author: Adam Kasztenny <adamkasztenny at gmail.com>
  Date:   2019-04-10 (Wed, 10 Apr 2019)

  Changed paths:
    M src/lxc/tools/lxc_create.c

  Log Message:
  -----------
  Add template-options to help output

Copied from the [manpage](https://github.com/lxc/lxc/blob/9e42c1e3f102be48be9014e1ecbacc2a57446e20/doc/lxc-create.sgml.in#L175).

Signed-off-by: Adam Kasztenny <adamkasztenny at gmail.com>

  Commit: be257f9495ca84307475d796947d7882444617ba
      https://github.com/lxc/lxc/commit/be257f9495ca84307475d796947d7882444617ba
  Author: Fabrice Fontaine <fontaine.fabrice at gmail.com>
  Date:   2019-04-10 (Wed, 10 Apr 2019)

  Changed paths:
    M src/lxc/string_utils.h

  Log Message:
  -----------
  stringutils: include stdarg for va_list

Fixes:
 - http://autobuild.buildroot.org/results/0b90e7dca2984652842832a41abad93ac49a9b86

Signed-off-by: Fabrice Fontaine <fontaine.fabrice at gmail.com>

  Commit: ef562ba58f0ffa275df89462e4f9666223e97b0f
      https://github.com/lxc/lxc/commit/ef562ba58f0ffa275df89462e4f9666223e97b0f
  Author: Fabrice Fontaine <fontaine.fabrice at gmail.com>
  Date:   2019-04-10 (Wed, 10 Apr 2019)

  Changed paths:
    M configure.ac

  Log Message:
  -----------
  configure.ac: fix build without stack-protector

Compiler based hardening (including -fstack-protector-strong) are
enabled since version 3.0.3 and
https://github.com/lxc/lxc/commit/2268c27754152aa538db2c9e3753d72d19bcd17a

However, some compilers could missed the needed library (-lssp or
-lssp_nonshared) at linking step so use ax_check_link_flag instead of
ax_check_compile_flag

Fixes:
 - http://autobuild.buildroot.org/results/0b90e7dca2984652842832a41abad93ac49a9b86

Signed-off-by: Fabrice Fontaine <fontaine.fabrice at gmail.com>

  Commit: 032b2138e4169bf93abce9e45cfd0b35ddedcb79
      https://github.com/lxc/lxc/commit/032b2138e4169bf93abce9e45cfd0b35ddedcb79
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2019-04-10 (Wed, 10 Apr 2019)

  Changed paths:
    M src/lxc/storage/storage_utils.c
    M src/lxc/storage/storage_utils.h

  Log Message:
  -----------
  storage: remove unused function

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: f98f39dbe4781af7b7a2a9c1f3a3ea48c3bc139a
      https://github.com/lxc/lxc/commit/f98f39dbe4781af7b7a2a9c1f3a3ea48c3bc139a
  Author: Oguz Bektas <o.bektas at proxmox.com>
  Date:   2019-04-10 (Wed, 10 Apr 2019)

  Changed paths:
    M src/lxc/tools/lxc_cgroup.c

  Log Message:
  -----------
  fix lxc-cgroup not giving output

lxc-cgroup fails to provide any output since the latest version, this
should fix it

Signed-off-by: Oguz Bektas <o.bektas at proxmox.com>

  Commit: ee542ce95a7cd4611ac610cec3cc6301748300d8
      https://github.com/lxc/lxc/commit/ee542ce95a7cd4611ac610cec3cc6301748300d8
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2019-04-10 (Wed, 10 Apr 2019)

  Changed paths:
    M src/lxc/tools/lxc_cgroup.c

  Log Message:
  -----------
  tools: add newline to lxc-cgroup output

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: c7a010f1971c87c84af25ca124f887ad422ab8ad
      https://github.com/lxc/lxc/commit/c7a010f1971c87c84af25ca124f887ad422ab8ad
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2019-04-10 (Wed, 10 Apr 2019)

  Changed paths:
    M src/lxc/commands.c
    M src/lxc/terminal.c
    M src/lxc/terminal.h

  Log Message:
  -----------
  terminal: remove sigwinch command

SIGWINCH is handled in lxc_terminal_signalfd_cb().

I cannot for the life of me figure out what this is supposed to do.
Afaict, it scans a global list that is totally unnecessary and also
let's say you have 100 ttys and for a single one SIGWINCH is sent. In
that case the whole list is walked and two ioctl()s are performed: one
to get window size one to set window size. For 99 of them the window
size hasn't changed.
If we see issues we can revert!

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 327653bec7f74a6bfc27b66b547d7844ffbee1a5
      https://github.com/lxc/lxc/commit/327653bec7f74a6bfc27b66b547d7844ffbee1a5
  Author: S.Çağlar Onur <caglar at 10ur.org>
  Date:   2019-04-10 (Wed, 10 Apr 2019)

  Changed paths:
    M src/lxc/lxccontainer.c

  Log Message:
  -----------
  Set c to NULL after freeing it

Signed-off-by: S.Çağlar Onur <caglar at 10ur.org>

  Commit: ed07f7bc02af01b933085ab42daae09374f31258
      https://github.com/lxc/lxc/commit/ed07f7bc02af01b933085ab42daae09374f31258
  Author: Wolfgang Bumiller <w.bumiller at proxmox.com>
  Date:   2019-04-10 (Wed, 10 Apr 2019)

  Changed paths:
    M src/lxc/conf.c

  Log Message:
  -----------
  conf: use SYSERROR on lxc_write_to_file errors

Signed-off-by: Wolfgang Bumiller <w.bumiller at proxmox.com>

  Commit: 9b10954e536ae71ffbf384dda2cc17f9ab783c04
      https://github.com/lxc/lxc/commit/9b10954e536ae71ffbf384dda2cc17f9ab783c04
  Author: S.Çağlar Onur <caglar at 10ur.org>
  Date:   2019-04-10 (Wed, 10 Apr 2019)

  Changed paths:
    M src/lxc/lxccontainer.c

  Log Message:
  -----------
  Revert "Set c to NULL after freeing it"

Signed-off-by: S.Çağlar Onur <caglar at 10ur.org>

  Commit: 0630112e914ab391eef2951b8a0e482e4da17b61
      https://github.com/lxc/lxc/commit/0630112e914ab391eef2951b8a0e482e4da17b61
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2019-04-10 (Wed, 10 Apr 2019)

  Changed paths:
    M src/lxc/lxccontainer.c

  Log Message:
  -----------
  lxccontainer: fix container copy

We need to strip the prefix from the container's source path before
trying to update the file.

Closes #2380.

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 13da0d41ffeec0cd5008871e3336778aa38e3eac
      https://github.com/lxc/lxc/commit/13da0d41ffeec0cd5008871e3336778aa38e3eac
  Author: hn <hn at users.noreply.github.com>
  Date:   2019-04-10 (Wed, 10 Apr 2019)

  Changed paths:
    M src/lxc/network.c

  Log Message:
  -----------
  fix: unprivileged veth devices (e.g. vethFWABHX) never contain 'Z' character in the randomly generated device name part because for modulo one does not need to substract 1 from strlen().

Signed-off-by: Hajo Noerenberg <hajo-github at noerenberg.de>

  Commit: fdce1d4315a1a2186f3b57f9b92d24a4c57ad9d5
      https://github.com/lxc/lxc/commit/fdce1d4315a1a2186f3b57f9b92d24a4c57ad9d5
  Author: Ondrej Kubik <ondrej.kubik at canonical.com>
  Date:   2019-04-10 (Wed, 10 Apr 2019)

  Changed paths:
    M src/include/lxcmntent.c

  Log Message:
  -----------
  Fixing compile error when compiling for android

Signed-off-by: Ondrej Kubik <ondrej.kubik at canonical.com>

  Commit: 0612e42f77d3fe1ab5446c5250095695b2f4d32b
      https://github.com/lxc/lxc/commit/0612e42f77d3fe1ab5446c5250095695b2f4d32b
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2019-04-10 (Wed, 10 Apr 2019)

  Changed paths:
    M src/lxc/start.c

  Log Message:
  -----------
  start: handle missing CLONE_NEWCGROUP

If cgroup namespaces are not supported we should just record it in the
log and move on.

Cc: Ondrej Kubik <ondrej.kubik at canonical.com>
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: a6f250f1a5d660173e6075cb76c02b9d520681ed
      https://github.com/lxc/lxc/commit/a6f250f1a5d660173e6075cb76c02b9d520681ed
  Author: hn <hn at users.noreply.github.com>
  Date:   2019-04-10 (Wed, 10 Apr 2019)

  Changed paths:
    M src/lxc/cmd/lxc_user_nic.c

  Log Message:
  -----------
  network: prefix veth interface name with uid info

Signed-off-by: Hajo Noerenberg <hajo-github at noerenberg.de>
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 69be5eab962ad0910c2287a5e66fc95cc01d1f21
      https://github.com/lxc/lxc/commit/69be5eab962ad0910c2287a5e66fc95cc01d1f21
  Author: Wolfgang Bumiller <w.bumiller at proxmox.com>
  Date:   2019-04-10 (Wed, 10 Apr 2019)

  Changed paths:
    M src/lxc/conf.c

  Log Message:
  -----------
  Revert "conf: remove extra MS_BIND with sysfs:mixed"

This reverts commit 51a922baf724689ff3a0df938ca8975601c9c815.

The above commit confuses the mountall unit of privileged
Ubuntu 14.04 containers at startup so that they cannot
finish booting.

Signed-off-by: Wolfgang Bumiller <w.bumiller at proxmox.com>

  Commit: 266892a9450725635fb28f420bfa11eb2eab745d
      https://github.com/lxc/lxc/commit/266892a9450725635fb28f420bfa11eb2eab745d
  Author: t00416110 <tanyifeng1 at huawei.com>
  Date:   2019-04-10 (Wed, 10 Apr 2019)

  Changed paths:
    M src/lxc/conf.c

  Log Message:
  -----------
  conf.c: fix memory leak and mount error

1. cleanup namespace memory
2. fix bug when ro mount not setted, mount propagation will be skipped.

Signed-off-by: t00416110 <tanyifeng1 at huawei.com>

  Commit: 8dec2437c3251acd6d1cac830df18aa33922fe54
      https://github.com/lxc/lxc/commit/8dec2437c3251acd6d1cac830df18aa33922fe54
  Author: LiFeng <lifeng68 at huawei.com>
  Date:   2019-04-10 (Wed, 10 Apr 2019)

  Changed paths:
    M src/lxc/cgroups/cgroup.c

  Log Message:
  -----------
  Fix memory leak in cgroup_exit

Add free memory pointed by struct cgroup_ops *ops

Signed-off-by: LiFeng <lifeng68 at huawei.com>

  Commit: 14609f10d8a39eac016f39c062155afdbbf25f2f
      https://github.com/lxc/lxc/commit/14609f10d8a39eac016f39c062155afdbbf25f2f
  Author: ondra <ondrak at localhost.localdomain>
  Date:   2019-04-10 (Wed, 10 Apr 2019)

  Changed paths:
    M src/lxc/utils.c

  Log Message:
  -----------
  Fixing hooks functionality Android where 'sh' is placed under /system/bin

Signed-off-by: ondra <ondrak at localhost.localdomain>

  Commit: 60a074ed43db521e70d5dadc044e6f29f60e5517
      https://github.com/lxc/lxc/commit/60a074ed43db521e70d5dadc044e6f29f60e5517
  Author: ondra <ondrak at localhost.localdomain>
  Date:   2019-04-10 (Wed, 10 Apr 2019)

  Changed paths:
    M src/lxc/utils.c

  Log Message:
  -----------
  Handle alternative loop device location on Android

Signed-off-by: ondra <ondrak at localhost.localdomain>

  Commit: 37368137a88491a02fb076cc4280af3de24024dc
      https://github.com/lxc/lxc/commit/37368137a88491a02fb076cc4280af3de24024dc
  Author: Rachid Koucha <47061324+Rachid-Koucha at users.noreply.github.com>
  Date:   2019-04-10 (Wed, 10 Apr 2019)

  Changed paths:
    M src/lxc/commands.c

  Log Message:
  -----------
  Avoid risk of "too far memory read"

As we call "lxc_add_state_client(fd, handler, (lxc_state_t *)req->data)"
which supposes that the last parameter is a table of MAX_STATE
entries when calling memcpy():
memcpy(newclient->states, states, sizeof(newclient->states))

Signed-off-by: Rachid Koucha <rachid.koucha at gmail.com>

  Commit: 31c5fa86eea37048802d27505c707f3c9a7f5277
      https://github.com/lxc/lxc/commit/31c5fa86eea37048802d27505c707f3c9a7f5277
  Author: Rachid Koucha <47061324+Rachid-Koucha at users.noreply.github.com>
  Date:   2019-04-10 (Wed, 10 Apr 2019)

  Changed paths:
    M templates/lxc-busybox.in

  Log Message:
  -----------
  Installation of default.script for udhcpc

The busybox template installs default.script in /usr/share/udhcpc/.
But the pathname of "default.script" may vary from one busybox
build to another. As the pathname is displayed in udhcpc's help,
grab it from it.

Signed-off-by: Rachid Koucha <rachid.koucha at gmail.com>

  Commit: e61f21b5d6455d7abdf04452279ee07f4513d6ec
      https://github.com/lxc/lxc/commit/e61f21b5d6455d7abdf04452279ee07f4513d6ec
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2019-04-10 (Wed, 10 Apr 2019)

  Changed paths:
    M src/lxc/conf.c

  Log Message:
  -----------
  conf: check for successful mount entry parse

Since liblxc is completely in control of the mount entry file we should
only consider a parse successful when EOF is reached.

Closes #2798.

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: ad45241cfd4dc62730c8501797d632171ee2c795
      https://github.com/lxc/lxc/commit/ad45241cfd4dc62730c8501797d632171ee2c795
  Author: Rachid Koucha <47061324+Rachid-Koucha at users.noreply.github.com>
  Date:   2019-04-10 (Wed, 10 Apr 2019)

  Changed paths:
    M templates/lxc-busybox.in

  Log Message:
  -----------
  Use BUSYBOX_EXE variable in configure_busybox()

As "which busybox" is stored in BUSYBOX_EXE 
global variable at startup, use it wherever it is
needed.

Signed-off-by: Rachid Koucha <rachid.koucha at gmail.com>

  Commit: 3801fef9c39624720828094c3f14c3bc568ea531
      https://github.com/lxc/lxc/commit/3801fef9c39624720828094c3f14c3bc568ea531
  Author: Rachid Koucha <47061324+Rachid-Koucha at users.noreply.github.com>
  Date:   2019-04-10 (Wed, 10 Apr 2019)

  Changed paths:
    M templates/lxc-busybox.in

  Log Message:
  -----------
  Create /var/run

Some programs like "who" need this directory
to work (this permits the of /var/run/utmp file).

Signed-off-by: Rachid Koucha <rachid.koucha at gmail.com>

  Commit: 6c3948db829c62332dd4d7ea20f196d04641bb10
      https://github.com/lxc/lxc/commit/6c3948db829c62332dd4d7ea20f196d04641bb10
  Author: Rachid Koucha <47061324+Rachid-Koucha at users.noreply.github.com>
  Date:   2019-04-10 (Wed, 10 Apr 2019)

  Changed paths:
    M templates/lxc-busybox.in

  Log Message:
  -----------
  /etc/resolv.conf grows indefinitely

This file grows indefinitely : upon each DHCP lease renew,
the "nameserver ..dns..." line is added at the end of the file.
Make a "grep" in the file to make sure that the same line
does not already exist.

Signed-off-by: Rachid Koucha <rachid.koucha at gmail.com>

  Commit: 80ace6aa2765696dbce4db6e832dda66f6e2ac5f
      https://github.com/lxc/lxc/commit/80ace6aa2765696dbce4db6e832dda66f6e2ac5f
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2019-04-10 (Wed, 10 Apr 2019)

  Changed paths:
    M src/lxc/compiler.h

  Log Message:
  -----------
  compiler: remove deprecated and unneeded header

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: ff5fa8365bb6c28cc5f4f9364f481f5c64299dca
      https://github.com/lxc/lxc/commit/ff5fa8365bb6c28cc5f4f9364f481f5c64299dca
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2019-04-10 (Wed, 10 Apr 2019)

  Changed paths:
    M src/include/prlimit.h

  Log Message:
  -----------
  prlimit: remove deprecated and unneeded header

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 1cd792b10754868d21fe6e223817187e5e7d263e
      https://github.com/lxc/lxc/commit/1cd792b10754868d21fe6e223817187e5e7d263e
  Author: Rachid Koucha <47061324+Rachid-Koucha at users.noreply.github.com>
  Date:   2019-04-10 (Wed, 10 Apr 2019)

  Changed paths:
    M src/lxc/utils.c

  Log Message:
  -----------
  More accurate error msg for template file

When calling lxc-create, if the template exists but is not executable, we end with the following error messages which make believe that the template file does not exist when it is merely a execute access problem:

lxc-create: ctn00: utils.c: get_template_path: 918 No such file or directory - bad template: /.../lxc-busybox
lxc-create: ctn00: lxccontainer.c: do_lxcapi_create: 1786 Unknown template "/.../lxc-busybox"
lxc-create: ctn00: tools/lxc_create.c: main: 327 Failed to create container ctn00

Actually internally the errno is lost as the following code triggers a useless access to (strace output):

access("/.../lxc-busybox", X_OK) = -1 ENOENT (No such file or directory)

With the above fix, we get a more explicit error message when the template file is missing the "execute" bit:

lxc-create: bbc: utils.c: get_template_path: 917 Permission denied - Bad template pathname: /tmp/azerty
lxc-create: bbc: lxccontainer.c: do_lxcapi_create: 1816 Unknown template "/tmp/azerty"
lxc-create: bbc: tools/lxc_create.c: main: 331 Failed to create container bbc

With the above fix, we get a more explicit error message when the pathname of the template file is incorrect:

lxc-create: bbc: utils.c: get_template_path: 917 No such file or directory - Bad template pathname: /tmp/qwerty
lxc-create: bbc: lxccontainer.c: do_lxcapi_create: 1816 Unknown template "/tmp/qwerty"
lxc-create: bbc: tools/lxc_create.c: main: 331 Failed to create container bbc

Signed-off-by: Rachid Koucha <rachid.koucha at gmail.com>

  Commit: 8c0de8132f2692d589af68dc54c8d7d5a9d4bfc4
      https://github.com/lxc/lxc/commit/8c0de8132f2692d589af68dc54c8d7d5a9d4bfc4
  Author: tomponline <tomp at tomp.uk>
  Date:   2019-04-10 (Wed, 10 Apr 2019)

  Changed paths:
    M lxc.spec.in

  Log Message:
  -----------
  fix rpm packaging for bash completion directory.

Closed #1825

Signed-off-by: tomponline <tomp at tomp.uk>

  Commit: 889c437a430f8a29620446052d07760ead2f80f0
      https://github.com/lxc/lxc/commit/889c437a430f8a29620446052d07760ead2f80f0
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2019-04-10 (Wed, 10 Apr 2019)

  Changed paths:
    M configure.ac

  Log Message:
  -----------
  compiler: -Wlogical-op hardening

Warn about suspicious uses of logical operators in expressions.

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 0b625d1b2e811880c511e6a9528b77a16c124aca
      https://github.com/lxc/lxc/commit/0b625d1b2e811880c511e6a9528b77a16c124aca
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2019-04-10 (Wed, 10 Apr 2019)

  Changed paths:
    M configure.ac
    M src/tests/Makefile.am

  Log Message:
  -----------
  compiler: -Wmissing-include-dirs hardening

Warn if a user-supplied include directory does not exist.

This already surfaced a bug that is fixed by this commit.

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 6a939892adcd4e4df9320fef879f75c5d56da66f
      https://github.com/lxc/lxc/commit/6a939892adcd4e4df9320fef879f75c5d56da66f
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2019-04-10 (Wed, 10 Apr 2019)

  Changed paths:
    M configure.ac

  Log Message:
  -----------
  compiler: -Wold-style-definition hardening

Warn if an old-style function definition is used. A warning is given
even if there is a previous prototype.

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: e41c504a84d9d5214b094139be55865baa7fc5b4
      https://github.com/lxc/lxc/commit/e41c504a84d9d5214b094139be55865baa7fc5b4
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2019-04-10 (Wed, 10 Apr 2019)

  Changed paths:
    M configure.ac

  Log Message:
  -----------
  compiler: -Winit-self hardening

Warn about uninitialized variables that are initialized with themselves.
Note this option can only be used with the -Wuninitialized option.

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 61f2b9becf53e775896926d7743140885dcacdd8
      https://github.com/lxc/lxc/commit/61f2b9becf53e775896926d7743140885dcacdd8
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2019-04-10 (Wed, 10 Apr 2019)

  Changed paths:
    M configure.ac

  Log Message:
  -----------
  compiler: -Wfloat-equal hardening

Warn if floating-point values are used in equality comparisons.

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 4ad0b8e88f1afc63001b521bf636f0b03c51607b
      https://github.com/lxc/lxc/commit/4ad0b8e88f1afc63001b521bf636f0b03c51607b
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2019-04-10 (Wed, 10 Apr 2019)

  Changed paths:
    M configure.ac
    M src/tests/state_server.c

  Log Message:
  -----------
  compiler: -Wsuggest-attribute=noreturn hardening

Warn about functions that might be candidates for attributes pure, const
or noreturn or malloc.

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: f987808ea0e9c39fe78ef16f30292a604e0ad594
      https://github.com/lxc/lxc/commit/f987808ea0e9c39fe78ef16f30292a604e0ad594
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2019-04-10 (Wed, 10 Apr 2019)

  Changed paths:
    M configure.ac

  Log Message:
  -----------
  compiler: -Werror=return-type hardening

Warn whenever a function is defined with a return type that defaults to
int. Also warn about any return statement with no return value in a
function whose return type is not void (falling off the end of the
function body is considered returning without a value).

For C only, warn about a return statement with an expression in a
function whose return type is void, unless the expression type is also
void. As a GNU extension, the latter case is accepted without a warning
unless -Wpedantic is used.

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: b51be7bcf8c31ccfca778f5ae0fd83f507424039
      https://github.com/lxc/lxc/commit/b51be7bcf8c31ccfca778f5ae0fd83f507424039
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2019-04-10 (Wed, 10 Apr 2019)

  Changed paths:
    M configure.ac

  Log Message:
  -----------
  compiler: -Werror=incompatible-pointer-types

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 4180936e321ae33f05f8c823cc35bffcf2d2ab4c
      https://github.com/lxc/lxc/commit/4180936e321ae33f05f8c823cc35bffcf2d2ab4c
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2019-04-10 (Wed, 10 Apr 2019)

  Changed paths:
    M configure.ac
    M src/lxc/criu.c
    M src/lxc/log.c
    M src/lxc/pam/pam_cgfs.c
    M src/lxc/storage/lvm.c
    M src/lxc/string_utils.c

  Log Message:
  -----------
  compiler: -Wformat=2 hardening

Enable -Wformat plus additional format checks. Currently equivalent to
-Wformat -Wformat-nonliteral -Wformat-security -Wformat-y2k.

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 0dbcb8fa6b229e4976650a1093a598938122c644
      https://github.com/lxc/lxc/commit/0dbcb8fa6b229e4976650a1093a598938122c644
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2019-04-10 (Wed, 10 Apr 2019)

  Changed paths:
    M configure.ac

  Log Message:
  -----------
  compiler: set -Wimplicit-fallthrough to 5

-Wimplicit-fallthrough=5 doesn’t recognize any comments as fallthrough
comments, only attributes disable the warning.

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 83a9b543065abb2f1d9e8007cc4ef74324772e27
      https://github.com/lxc/lxc/commit/83a9b543065abb2f1d9e8007cc4ef74324772e27
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2019-04-10 (Wed, 10 Apr 2019)

  Changed paths:
    M src/lxc/attach.c
    M src/lxc/cmd/lxc_user_nic.c
    M src/lxc/conf.c
    M src/lxc/criu.c
    M src/lxc/log.h
    M src/lxc/lxccontainer.c
    M src/lxc/network.c
    M src/lxc/storage/overlay.c
    M src/lxc/storage/storage.c
    M src/lxc/storage/zfs.c
    M src/lxc/tools/lxc_info.c
    M src/lxc/tools/lxc_ls.c
    M src/lxc/tools/lxc_unshare.c
    M src/tests/share_ns.c
    M src/tests/state_server.c

  Log Message:
  -----------
  compiler: -Wshadow hardening

Warn whenever a local variable or type declaration shadows another
variable, parameter, type, class member (in C++), or instance variable
(in Objective-C) or whenever a built-in function is shadowed.

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: d56bef60755d4617fd357cd06d7c98b5500edc65
      https://github.com/lxc/lxc/commit/d56bef60755d4617fd357cd06d7c98b5500edc65
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2019-04-10 (Wed, 10 Apr 2019)

  Changed paths:
    M configure.ac

  Log Message:
  -----------
  compiler: -Wendif-labels hardening

Do not warn whenever an #else or an #endif are followed by text.

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 61f7d591bfcf4004e9316549337a702c545f0e2a
      https://github.com/lxc/lxc/commit/61f7d591bfcf4004e9316549337a702c545f0e2a
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2019-04-10 (Wed, 10 Apr 2019)

  Changed paths:
    M configure.ac

  Log Message:
  -----------
  compiler: -Werror=overflow hardening

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 69eac658ac89ea17effa35134039afb694b89faa
      https://github.com/lxc/lxc/commit/69eac658ac89ea17effa35134039afb694b89faa
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2019-04-10 (Wed, 10 Apr 2019)

  Changed paths:
    M configure.ac

  Log Message:
  -----------
  compiler: -fdiagnostics-show-option

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: c0eaaed5c233b958502efef32daf4286f7bcee06
      https://github.com/lxc/lxc/commit/c0eaaed5c233b958502efef32daf4286f7bcee06
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2019-04-10 (Wed, 10 Apr 2019)

  Changed paths:
    M configure.ac

  Log Message:
  -----------
  compiler: fix -fstack-protector-strong

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: e0d0b7907a91d19cb792bf572e5cceff00039613
      https://github.com/lxc/lxc/commit/e0d0b7907a91d19cb792bf572e5cceff00039613
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2019-04-10 (Wed, 10 Apr 2019)

  Changed paths:
    M configure.ac

  Log Message:
  -----------
  compiler: -Werror=shift-count-overflow hardening

Warn if shift count >= width of type.

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: f7f6034aa4d534a8380a73454eb56daaa345dcc0
      https://github.com/lxc/lxc/commit/f7f6034aa4d534a8380a73454eb56daaa345dcc0
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2019-04-10 (Wed, 10 Apr 2019)

  Changed paths:
    M configure.ac

  Log Message:
  -----------
  compiler: -Werror=shift-overflow=2 hardening

Warn about left shift overflows. This warning is enabled by default in
C99 and C++11 modes (and newer).

-Wshift-overflow=2
This warning level also warns about left-shifting 1 into the sign bit,
unless C++14 mode (or newer) is active.

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 2024e50d5b9f2f3e33d16d5346abb060c373b744
      https://github.com/lxc/lxc/commit/2024e50d5b9f2f3e33d16d5346abb060c373b744
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2019-04-10 (Wed, 10 Apr 2019)

  Changed paths:
    M configure.ac

  Log Message:
  -----------
  compiler: -Wdate-time hardening

Warn when macros __TIME__, __DATE__ or __TIMESTAMP__ are encountered as
they might prevent bit-wise-identical reproducible compilations.

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 89876c4f308489af5da79f78455b317ecfa4c877
      https://github.com/lxc/lxc/commit/89876c4f308489af5da79f78455b317ecfa4c877
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2019-04-10 (Wed, 10 Apr 2019)

  Changed paths:
    M configure.ac
    M src/tests/lxc-test-utils.c

  Log Message:
  -----------
  compiler: -Wnested-externs hardening

Warn if an extern declaration is encountered within a function.

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 8f4d34d6c93c63fbd0214eb69a48db7a3efcf6c5
      https://github.com/lxc/lxc/commit/8f4d34d6c93c63fbd0214eb69a48db7a3efcf6c5
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2019-04-10 (Wed, 10 Apr 2019)

  Changed paths:
    M src/include/lxcmntent.c

  Log Message:
  -----------
  lxcmntent: remove stack allocations

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 794afb259ed3d769f3f4a93233695df88859f7f2
      https://github.com/lxc/lxc/commit/794afb259ed3d769f3f4a93233695df88859f7f2
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2019-04-10 (Wed, 10 Apr 2019)

  Changed paths:
    M src/lxc/cgroups/cgfsng.c

  Log Message:
  -----------
  cgroups: remove stack allocations

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 0fac0f222c0d6d27ce27ffc01f82863b80257423
      https://github.com/lxc/lxc/commit/0fac0f222c0d6d27ce27ffc01f82863b80257423
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2019-04-10 (Wed, 10 Apr 2019)

  Changed paths:
    M src/lxc/Makefile.am
    M src/lxc/cmd/lxc_user_nic.c

  Log Message:
  -----------
  lxc_user_nic: remove stack allocations

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 8131f12a0ff104b8f2ba4cccc12c6dd3226b3a62
      https://github.com/lxc/lxc/commit/8131f12a0ff104b8f2ba4cccc12c6dd3226b3a62
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2019-04-10 (Wed, 10 Apr 2019)

  Changed paths:
    M src/lxc/commands.c

  Log Message:
  -----------
  commands: remove stack allocations

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: c8a0e25a5214b7c1a7593abfe89c1e1d5c013d07
      https://github.com/lxc/lxc/commit/c8a0e25a5214b7c1a7593abfe89c1e1d5c013d07
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2019-04-10 (Wed, 10 Apr 2019)

  Changed paths:
    M src/lxc/commands_utils.c

  Log Message:
  -----------
  commands_utils: remove stack allocations

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 76f1bb4f02b2fc07f53776eceefd53d33f36f64a
      https://github.com/lxc/lxc/commit/76f1bb4f02b2fc07f53776eceefd53d33f36f64a
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2019-04-10 (Wed, 10 Apr 2019)

  Changed paths:
    M src/lxc/conf.c

  Log Message:
  -----------
  conf: remove stack allocations

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: fa3b307346eb2cba10297f1ce64758f30308cb27
      https://github.com/lxc/lxc/commit/fa3b307346eb2cba10297f1ce64758f30308cb27
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2019-04-10 (Wed, 10 Apr 2019)

  Changed paths:
    M src/lxc/confile.c

  Log Message:
  -----------
  confile: remove stack allocations

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: a76e6dcd5bed87881c5498fe2d315e74c3f01aff
      https://github.com/lxc/lxc/commit/a76e6dcd5bed87881c5498fe2d315e74c3f01aff
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2019-04-10 (Wed, 10 Apr 2019)

  Changed paths:
    M src/lxc/lxccontainer.c

  Log Message:
  -----------
  lxccontainer: remove stack allocations

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: b81013a576222a152ff42fe2ce396f7391e430c3
      https://github.com/lxc/lxc/commit/b81013a576222a152ff42fe2ce396f7391e430c3
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2019-04-10 (Wed, 10 Apr 2019)

  Changed paths:
    M src/lxc/monitor.c

  Log Message:
  -----------
  monitor: remove stack allocations

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 35099526e059abde1e69e9d1e11901ad84ab3f8a
      https://github.com/lxc/lxc/commit/35099526e059abde1e69e9d1e11901ad84ab3f8a
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2019-04-10 (Wed, 10 Apr 2019)

  Changed paths:
    M src/lxc/namespace.c

  Log Message:
  -----------
  namespace: remove stack allocations

Switch to a static stack instead of allocating a new one. There's really
no point in doing all of the dance to get the current pagesize.

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 3c7859c90d39c10dd625e55b72ef659f2cb06c74
      https://github.com/lxc/lxc/commit/3c7859c90d39c10dd625e55b72ef659f2cb06c74
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2019-04-10 (Wed, 10 Apr 2019)

  Changed paths:
    M src/lxc/network.c

  Log Message:
  -----------
  network: remove stack allocations

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: fbe89316d01269cd09b6f210d6eadc594bacc4a9
      https://github.com/lxc/lxc/commit/fbe89316d01269cd09b6f210d6eadc594bacc4a9
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2019-04-10 (Wed, 10 Apr 2019)

  Changed paths:
    M src/lxc/Makefile.am
    M src/lxc/pam/pam_cgfs.c

  Log Message:
  -----------
  pam_cgfs: remove stack allocations

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 75d4510c2b877f02c10754d894382d9ff1f175b3
      https://github.com/lxc/lxc/commit/75d4510c2b877f02c10754d894382d9ff1f175b3
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2019-04-10 (Wed, 10 Apr 2019)

  Changed paths:
    M src/lxc/start.c

  Log Message:
  -----------
  start: remove stack allocations

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: db1b2ec6a1797f2d2578ccd528446e1f3e2e19fa
      https://github.com/lxc/lxc/commit/db1b2ec6a1797f2d2578ccd528446e1f3e2e19fa
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2019-04-10 (Wed, 10 Apr 2019)

  Changed paths:
    M src/lxc/storage/storage.c

  Log Message:
  -----------
  storage: remove stack allocations

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: d8f9cae8e5054d9c57e00794bf8f20cf4e89d90b
      https://github.com/lxc/lxc/commit/d8f9cae8e5054d9c57e00794bf8f20cf4e89d90b
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2019-04-10 (Wed, 10 Apr 2019)

  Changed paths:
    M src/lxc/string_utils.c

  Log Message:
  -----------
  string_utils: remove stack allocations

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: ae1ed9589b5119f4adabe1eb41131b30bfea661c
      https://github.com/lxc/lxc/commit/ae1ed9589b5119f4adabe1eb41131b30bfea661c
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2019-04-10 (Wed, 10 Apr 2019)

  Changed paths:
    M src/lxc/terminal.c

  Log Message:
  -----------
  terminal: remove stack allocations

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 3027cf9ff1aea15e1e48fc4a20aa2f30a2115204
      https://github.com/lxc/lxc/commit/3027cf9ff1aea15e1e48fc4a20aa2f30a2115204
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2019-04-10 (Wed, 10 Apr 2019)

  Changed paths:
    M src/lxc/storage/loop.c

  Log Message:
  -----------
  loop: remove stack allocations

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 38153969a5a31b751fb23b3b29b82b7e00b7cc16
      https://github.com/lxc/lxc/commit/38153969a5a31b751fb23b3b29b82b7e00b7cc16
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2019-04-10 (Wed, 10 Apr 2019)

  Changed paths:
    M src/lxc/storage/lvm.c

  Log Message:
  -----------
  lvm: remove stack allocations

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 39d12f927481c2661efac87cece3944a28187f21
      https://github.com/lxc/lxc/commit/39d12f927481c2661efac87cece3944a28187f21
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2019-04-10 (Wed, 10 Apr 2019)

  Changed paths:
    M src/lxc/storage/nbd.c

  Log Message:
  -----------
  nbd: remove stack allocations

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 7f6a269ddaa1b749ecd3d6cfb7ef0bdec7917272
      https://github.com/lxc/lxc/commit/7f6a269ddaa1b749ecd3d6cfb7ef0bdec7917272
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2019-04-10 (Wed, 10 Apr 2019)

  Changed paths:
    M src/lxc/storage/rbd.c

  Log Message:
  -----------
  rbd: remove stack allocations

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: b12ba3f0faa5a3942b243f9607c1b12e4cf4ed8c
      https://github.com/lxc/lxc/commit/b12ba3f0faa5a3942b243f9607c1b12e4cf4ed8c
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2019-04-10 (Wed, 10 Apr 2019)

  Changed paths:
    M src/lxc/storage/overlay.c

  Log Message:
  -----------
  overlay: remove stack allocations

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 3f77af2b9a22972202bcfd6e017fc19c25cf20a6
      https://github.com/lxc/lxc/commit/3f77af2b9a22972202bcfd6e017fc19c25cf20a6
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2019-04-10 (Wed, 10 Apr 2019)

  Changed paths:
    M src/lxc/tools/lxc_unshare.c

  Log Message:
  -----------
  lxc-unshare: remove stack allocations

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: d28ea2a1350e223c4175d835651fd0b4ed387c84
      https://github.com/lxc/lxc/commit/d28ea2a1350e223c4175d835651fd0b4ed387c84
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2019-04-10 (Wed, 10 Apr 2019)

  Changed paths:
    M README.md

  Log Message:
  -----------
  README: add LGTM

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 7bb01e97c2b4703391d9eb08846463d28a28a0db
      https://github.com/lxc/lxc/commit/7bb01e97c2b4703391d9eb08846463d28a28a0db
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2019-04-10 (Wed, 10 Apr 2019)

  Changed paths:
    M src/lxc/commands.c

  Log Message:
  -----------
  commands: remove unnecessary check

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 147019662a0f91d96ca294bb6127500b655c2af8
      https://github.com/lxc/lxc/commit/147019662a0f91d96ca294bb6127500b655c2af8
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2019-04-10 (Wed, 10 Apr 2019)

  Changed paths:
    M src/lxc/cgroups/cgfsng.c

  Log Message:
  -----------
  cgfsng: remove unnecessary check

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: a66fcff7b84c2592fb2eee080ea3b220449a1c9c
      https://github.com/lxc/lxc/commit/a66fcff7b84c2592fb2eee080ea3b220449a1c9c
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2019-04-10 (Wed, 10 Apr 2019)

  Changed paths:
    M src/lxc/start.c

  Log Message:
  -----------
  start: prevent signed-issues

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 866c8d669c03e959ad222f1d37ab4da80a13d989
      https://github.com/lxc/lxc/commit/866c8d669c03e959ad222f1d37ab4da80a13d989
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2019-04-10 (Wed, 10 Apr 2019)

  Changed paths:
    M src/lxc/cmd/lxc_init.c

  Log Message:
  -----------
  lxc-init: exit with error on wait failure

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 95ac8e2c34b5b2a2667ed1d9c24efc560e645cb1
      https://github.com/lxc/lxc/commit/95ac8e2c34b5b2a2667ed1d9c24efc560e645cb1
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2019-04-10 (Wed, 10 Apr 2019)

  Changed paths:
    A coccinelle/run-coccinelle.sh

  Log Message:
  -----------
  coccinelle: add coccinelle support

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 50d6d5c384e2ca620070270325910762a6bbcdb7
      https://github.com/lxc/lxc/commit/50d6d5c384e2ca620070270325910762a6bbcdb7
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2019-04-10 (Wed, 10 Apr 2019)

  Changed paths:
    A coccinelle/while-true.cocci
    M src/lxc/cmd/lxc_init.c
    M src/lxc/lxccontainer.c
    M src/lxc/network.c
    M src/lxc/pam/pam_cgfs.c
    M src/lxc/storage/btrfs.c
    M src/lxc/storage/nbd.c
    M src/lxc/string_utils.c
    M src/lxc/tools/arguments.c
    M src/lxc/utils.c

  Log Message:
  -----------
  coccinelle: s/while({1,true})/for(;;)/

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 4d2e88eed96ecf18539c6eef66785465b6d6fc0a
      https://github.com/lxc/lxc/commit/4d2e88eed96ecf18539c6eef66785465b6d6fc0a
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2019-04-10 (Wed, 10 Apr 2019)

  Changed paths:
    A coccinelle/exit.cocci
    M src/lxc/attach.c
    M src/lxc/cmd/lxc_init.c
    M src/lxc/storage/nbd.c
    M src/lxc/tools/arguments.c
    M src/lxc/tools/lxc_autostart.c
    M src/tests/aa.c
    M src/tests/cgpath.c
    M src/tests/list.c
    M src/tests/locktests.c
    M src/tests/may_control.c
    M src/tests/snapshot.c
    M src/tests/startone.c

  Log Message:
  -----------
  coccinelle: use standard exit identifiers

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 7446500ebe11f75421a12723d9dfcf884a79cc02
      https://github.com/lxc/lxc/commit/7446500ebe11f75421a12723d9dfcf884a79cc02
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2019-04-10 (Wed, 10 Apr 2019)

  Changed paths:
    M src/lxc/parse.c

  Log Message:
  -----------
  parse: handle \r

Closes #2838.

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: e7ba79ba3bfb7a92398b273a53519d2c673ce938
      https://github.com/lxc/lxc/commit/e7ba79ba3bfb7a92398b273a53519d2c673ce938
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2019-04-10 (Wed, 10 Apr 2019)

  Changed paths:
    M src/lxc/compiler.h

  Log Message:
  -----------
  compiler: fix wrong licensing

/* Affected People */
Christian Brauner <christian.brauner at ubuntu.com>

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: ec67f43b9f1aca7b1e4a82c27cc4b19c46359b85
      https://github.com/lxc/lxc/commit/ec67f43b9f1aca7b1e4a82c27cc4b19c46359b85
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2019-04-10 (Wed, 10 Apr 2019)

  Changed paths:
    M src/lxc/ringbuf.h

  Log Message:
  -----------
  ringbuf.h: fix wrong licensing

/* Affected People */
Christian Brauner <christian.brauner at ubuntu.com>

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: e6c4af1bbd954f0157a8cef040b03e0334ff9a55
      https://github.com/lxc/lxc/commit/e6c4af1bbd954f0157a8cef040b03e0334ff9a55
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2019-04-10 (Wed, 10 Apr 2019)

  Changed paths:
    M src/lxc/syscall_wrappers.h

  Log Message:
  -----------
  syscall_wrappers: fix wrong licensing

/* Affected People */
Christian Brauner <christian.brauner at ubuntu.com>
Aleksa Sarai <cyphar at cyphar.com>

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: eb6fdb57b396b5a9b39ca83134f2c9795fb4ee19
      https://github.com/lxc/lxc/commit/eb6fdb57b396b5a9b39ca83134f2c9795fb4ee19
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2019-04-10 (Wed, 10 Apr 2019)

  Changed paths:
    M src/lxc/string_utils.h

  Log Message:
  -----------
  string_utils.h: fix wrong licensing

liblxc has always been meant to be LGPLv2.1+ as reflected by the many
downstreams projects and bindings which are themselves under LGPLv2.1+ or other
licenses which would be incompatible with linking against a GPLv2+ library.

It's pretty normal for a library to be LGPL while binaries are GPL as a GPL
library would only ever be usable by other GPL-only projects, which isn't the
case for very many of the liblxc downstreams.

The issue here is really carelessness. None of those GPL headers were put there
intentionally, instead being wrongly copy/pasted from other parts of the
codebase which is indeed intended to be GPLv2+. This is also made clear in our
CONTRIBUTING file in this repository:

Licensing for new files:
------------------------

LXC is made of files shipped under a few different licenses.

Anything that ends up being part of the LXC library needs to be released
under LGPLv2.1+ or a license compatible with it (though the latter will
only be accepted for cases where the code originated elsewhere and was
imported into LXC).

Language bindings for the libraries need to be released under LGPLv2.1+.

Anything else (non-libraries) needs to be Free Software and needs to be
allowed to link with LGPLv2.1+ code (if needed). LXC upstream prefers
LGPLv2.1+ or GPLv2 for those.

When introducing a new file into the project, please make sure it has a
copyright header making clear under which license it's being released
and if it doesn't match the criteria described above, please explain
your decision on the lxc-devel mailing-list when submitting your patch.

This is intended to switch over files to LGPLv2.1+ to which end we have
collected ACKs from relevant people.
/* Affected People */
Christian Brauner <christian.brauner at ubuntu.com>
Fabrice Fontaine <fontaine.fabrice at gmail.com>
Josh Soref <jsoref at gmail.com>

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Acked-by: Fabrice Fontaine <fontaine.fabrice at gmail.com>
Acked-by: Josh Soref <jsoref at gmail.com>

  Commit: a7ba5e4ea20194692b233d496fe7ccdba8d12a91
      https://github.com/lxc/lxc/commit/a7ba5e4ea20194692b233d496fe7ccdba8d12a91
  Author: Hervé Beraud <hberaud at redhat.com>
  Date:   2019-04-10 (Wed, 10 Apr 2019)

  Changed paths:
    M .travis.yml
    M config/apparmor/lxc-generate-aa-rules.py

  Log Message:
  -----------
  apparmor: catch config file opening error

Improve config file error opening management
and improve main code block.

Execute this python script during CI to avoid
regressions

Signed-off-by: Hervé Beraud <hberaud at redhat.com>

  Commit: 65fd947dab2bbe6c1ca4b9004fd251c07a8afc98
      https://github.com/lxc/lxc/commit/65fd947dab2bbe6c1ca4b9004fd251c07a8afc98
  Author: Hervé Beraud <hberaud at redhat.com>
  Date:   2019-04-10 (Wed, 10 Apr 2019)

  Changed paths:
    M .travis.yml

  Log Message:
  -----------
  apparmor: Improve testing on apparmor python script

Compare command output to already existing container-rules file

Signed-off-by: Hervé Beraud <hberaud at redhat.com>

  Commit: 308666f4644cb68d3e71b58fec12a092bd1e60af
      https://github.com/lxc/lxc/commit/308666f4644cb68d3e71b58fec12a092bd1e60af
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2019-04-10 (Wed, 10 Apr 2019)

  Changed paths:
    M src/lxc/conf.c

  Log Message:
  -----------
  conf: do not log devpts umount2() failure

We're not acting based on the return value so don't log anything.

Fixes: https://discuss.linuxcontainers.org/t/warning-in-the-container-log/4072/2
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: b50038237ff9a7cfff146b839de81902d09821a7
      https://github.com/lxc/lxc/commit/b50038237ff9a7cfff146b839de81902d09821a7
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2019-04-10 (Wed, 10 Apr 2019)

  Changed paths:
    M src/lxc/network.c

  Log Message:
  -----------
  network: do not log false friends

The netlink functions just return -1 and not specific negative errno values so
logging them doesn't make any sense.

Fixes: https://discuss.linuxcontainers.org/t/warning-in-the-container-log/4072/2
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 9cacba0b16bdf5e1a2d634e4a8b57ade82996c08
      https://github.com/lxc/lxc/commit/9cacba0b16bdf5e1a2d634e4a8b57ade82996c08
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2019-04-10 (Wed, 10 Apr 2019)

  Changed paths:
    M src/lxc/start.c

  Log Message:
  -----------
  start: move variable into tighter scope

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 998f8423664d5575393644e955e752da6fc3013c
      https://github.com/lxc/lxc/commit/998f8423664d5575393644e955e752da6fc3013c
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2019-04-10 (Wed, 10 Apr 2019)

  Changed paths:
    M src/lxc/af_unix.c

  Log Message:
  -----------
  af_unix: use __do_free

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 49cc76a79b4168cc0ce8ef752ce35da8da5b7d81
      https://github.com/lxc/lxc/commit/49cc76a79b4168cc0ce8ef752ce35da8da5b7d81
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2019-04-10 (Wed, 10 Apr 2019)

  Changed paths:
    M src/lxc/attach.c

  Log Message:
  -----------
  attach: use __do_free

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 5c7dbbbe425b6ef04de701ff98405b5b26b6e6ee
      https://github.com/lxc/lxc/commit/5c7dbbbe425b6ef04de701ff98405b5b26b6e6ee
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2019-04-10 (Wed, 10 Apr 2019)

  Changed paths:
    M src/lxc/cgroups/cgroup_utils.c

  Log Message:
  -----------
  cgroup_utils: use __do_free

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 95150175344dce502046868eee3d6c98f0c81cd4
      https://github.com/lxc/lxc/commit/95150175344dce502046868eee3d6c98f0c81cd4
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2019-04-10 (Wed, 10 Apr 2019)

  Changed paths:
    M src/lxc/Makefile.am
    M src/lxc/cmd/lxc_init.c

  Log Message:
  -----------
  lxc-init: use cleanup macros

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 55236d5dec0003868750cb5f70b7c81f762e0c10
      https://github.com/lxc/lxc/commit/55236d5dec0003868750cb5f70b7c81f762e0c10
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2019-04-10 (Wed, 10 Apr 2019)

  Changed paths:
    M src/lxc/cmd/lxc_user_nic.c

  Log Message:
  -----------
  lxc-user-nic: use cleanup macros

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: e0cb8f4e75aec7d3c07aab956d76a341e892defa
      https://github.com/lxc/lxc/commit/e0cb8f4e75aec7d3c07aab956d76a341e892defa
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2019-04-10 (Wed, 10 Apr 2019)

  Changed paths:
    M src/lxc/Makefile.am
    M src/lxc/cmd/lxc_usernsexec.c

  Log Message:
  -----------
  lxc-usernsexec: use cleanup macros

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 253e0d272848ab34dae3d9d34644f005acb5d8c3
      https://github.com/lxc/lxc/commit/253e0d272848ab34dae3d9d34644f005acb5d8c3
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2019-04-10 (Wed, 10 Apr 2019)

  Changed paths:
    M src/lxc/commands.c

  Log Message:
  -----------
  commands: move declaration into tighter scope

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: d9c4e404114fd7966b42ce120caf5a6f6af8f538
      https://github.com/lxc/lxc/commit/d9c4e404114fd7966b42ce120caf5a6f6af8f538
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2019-04-10 (Wed, 10 Apr 2019)

  Changed paths:
    M src/lxc/commands.c

  Log Message:
  -----------
  commands: cleanup macros in lxc_cmd_console()

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 4c5a103a7bfd36faea55cf3612fb48ec514ebcab
      https://github.com/lxc/lxc/commit/4c5a103a7bfd36faea55cf3612fb48ec514ebcab
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2019-04-10 (Wed, 10 Apr 2019)

  Changed paths:
    M src/lxc/macro.h

  Log Message:
  -----------
  macro: introduce steal_fd()

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 9fb12c13d6fef23b5ac0d1148ee7b0ac12401c8d
      https://github.com/lxc/lxc/commit/9fb12c13d6fef23b5ac0d1148ee7b0ac12401c8d
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2019-04-10 (Wed, 10 Apr 2019)

  Changed paths:
    M src/lxc/commands.c

  Log Message:
  -----------
  commands: use __do_close_prot_errno

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 82bc16c57273de3b61ae9c7b268cf993c1a7311a
      https://github.com/lxc/lxc/commit/82bc16c57273de3b61ae9c7b268cf993c1a7311a
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2019-04-10 (Wed, 10 Apr 2019)

  Changed paths:
    M src/lxc/commands.c

  Log Message:
  -----------
  commands: cleanup macros lxc_cmd()

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: f6f4304b7bac29e17bc83a636b751d8bc963c2be
      https://github.com/lxc/lxc/commit/f6f4304b7bac29e17bc83a636b751d8bc963c2be
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2019-04-10 (Wed, 10 Apr 2019)

  Changed paths:
    M src/lxc/commands.c

  Log Message:
  -----------
  commands: cleanup macros lxc_cmd_add_state_client

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 9179fca11efb886022b7b62a0553029b05058a0b
      https://github.com/lxc/lxc/commit/9179fca11efb886022b7b62a0553029b05058a0b
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2019-04-10 (Wed, 10 Apr 2019)

  Changed paths:
    M src/lxc/commands.c

  Log Message:
  -----------
  commands: cleanup macros lxc_cmd_accept()

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: d5c6c73b05e8d93f44a1986850f8421e9d4b7915
      https://github.com/lxc/lxc/commit/d5c6c73b05e8d93f44a1986850f8421e9d4b7915
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2019-04-10 (Wed, 10 Apr 2019)

  Changed paths:
    M src/lxc/commands.c

  Log Message:
  -----------
  commands: cleanup macros lxc_cmd_init

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 8a102e40e9f51b5f10a52939503338fae8078a58
      https://github.com/lxc/lxc/commit/8a102e40e9f51b5f10a52939503338fae8078a58
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2019-04-10 (Wed, 10 Apr 2019)

  Changed paths:
    M src/lxc/commands.c

  Log Message:
  -----------
  commands: cleanup macros lxc_cmd_init()

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 426b377a1a908592d0c4c6b7e5252e536aedd64c
      https://github.com/lxc/lxc/commit/426b377a1a908592d0c4c6b7e5252e536aedd64c
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2019-04-10 (Wed, 10 Apr 2019)

  Changed paths:
    M src/lxc/commands.c
    M src/lxc/macro.h

  Log Message:
  -----------
  tree-wide: s/steal_fd/move_fd/g

Suggested-by: Wolfgang Bumiller <w.bumiller at proxmox.com>
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 363870dc9e62fa7377c52be62df120d3621b1d56
      https://github.com/lxc/lxc/commit/363870dc9e62fa7377c52be62df120d3621b1d56
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2019-04-10 (Wed, 10 Apr 2019)

  Changed paths:
    M src/tests/Makefile.am
    A src/tests/cve-2019-5736.c

  Log Message:
  -----------
  cve-2019-5736: add test

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 031452be2a06069df35dd9798dfa2679b4262d0a
      https://github.com/lxc/lxc/commit/031452be2a06069df35dd9798dfa2679b4262d0a
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2019-04-10 (Wed, 10 Apr 2019)

  Changed paths:
    M src/lxc/commands_utils.c

  Log Message:
  -----------
  commands_utils: auto close lxc_cmd_sock_get_state

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 0153cd73ea9047825f6724abeb71a80984cfa7e2
      https://github.com/lxc/lxc/commit/0153cd73ea9047825f6724abeb71a80984cfa7e2
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2019-04-10 (Wed, 10 Apr 2019)

  Changed paths:
    M src/lxc/commands_utils.c

  Log Message:
  -----------
  commands_utils: auto free lxc_add_state_client

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 203a87b04e71f68e405507124c99c92ecab20ddc
      https://github.com/lxc/lxc/commit/203a87b04e71f68e405507124c99c92ecab20ddc
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2019-04-10 (Wed, 10 Apr 2019)

  Changed paths:
    M src/lxc/conf.c

  Log Message:
  -----------
  conf: auto free run_buffer

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 22f7e2a8eeffb848bab8e8baf724d35e90ea9be2
      https://github.com/lxc/lxc/commit/22f7e2a8eeffb848bab8e8baf724d35e90ea9be2
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2019-04-10 (Wed, 10 Apr 2019)

  Changed paths:
    M src/lxc/conf.c

  Log Message:
  -----------
  conf: cleanup macros run_script_argv

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 6d78bdddd8f21f59775c7954ac043e3bc9b34c95
      https://github.com/lxc/lxc/commit/6d78bdddd8f21f59775c7954ac043e3bc9b34c95
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2019-04-10 (Wed, 10 Apr 2019)

  Changed paths:
    M src/lxc/conf.c

  Log Message:
  -----------
  conf: cleanup macros pin_rootfs

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 9c5707ccd84dfa765d5fc1e33bb70f0a8caa20e5
      https://github.com/lxc/lxc/commit/9c5707ccd84dfa765d5fc1e33bb70f0a8caa20e5
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2019-04-10 (Wed, 10 Apr 2019)

  Changed paths:
    M src/lxc/conf.c

  Log Message:
  -----------
  conf: cleanup macros lxc_mount_auto_mounts

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 2455904a5e728d9c085e3b0a289dd2c228213187
      https://github.com/lxc/lxc/commit/2455904a5e728d9c085e3b0a289dd2c228213187
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2019-04-10 (Wed, 10 Apr 2019)

  Changed paths:
    M src/lxc/conf.c

  Log Message:
  -----------
  conf: cleanup macros lxc_chroot

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: bda1c3fc5a9f48ed67c5ee54328834732bf87a43
      https://github.com/lxc/lxc/commit/bda1c3fc5a9f48ed67c5ee54328834732bf87a43
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2019-04-10 (Wed, 10 Apr 2019)

  Changed paths:
    M src/lxc/conf.c

  Log Message:
  -----------
  conf: cleanup macros parse_mntopts

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 652342782f5e9ac782a0bad6a395c5d8df99c0bf
      https://github.com/lxc/lxc/commit/652342782f5e9ac782a0bad6a395c5d8df99c0bf
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2019-04-10 (Wed, 10 Apr 2019)

  Changed paths:
    M src/lxc/conf.c

  Log Message:
  -----------
  conf: cleanup macros parse_propagationopts

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 0a03d9e043d153ef52c4d428eef5a54f979c095b
      https://github.com/lxc/lxc/commit/0a03d9e043d153ef52c4d428eef5a54f979c095b
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2019-04-10 (Wed, 10 Apr 2019)

  Changed paths:
    M src/lxc/conf.c

  Log Message:
  -----------
  conf: cleanup macros mount_entry_create_dir_file

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: dc1cc272971f2f873955691f95c52ef2de71fe25
      https://github.com/lxc/lxc/commit/dc1cc272971f2f873955691f95c52ef2de71fe25
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2019-04-10 (Wed, 10 Apr 2019)

  Changed paths:
    M src/lxc/conf.c

  Log Message:
  -----------
  conf: cleanup macros mount_entry_on_generic

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: a441f28bb40c7198fb8e48111379003bf300a6e8
      https://github.com/lxc/lxc/commit/a441f28bb40c7198fb8e48111379003bf300a6e8
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2019-04-10 (Wed, 10 Apr 2019)

  Changed paths:
    M src/lxc/conf.c

  Log Message:
  -----------
  conf: cleanup macros setup_sysctl_parameters

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: f795a92daaa47547582cfff55fbbbb95fd051115
      https://github.com/lxc/lxc/commit/f795a92daaa47547582cfff55fbbbb95fd051115
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2019-04-10 (Wed, 10 Apr 2019)

  Changed paths:
    M src/lxc/conf.c

  Log Message:
  -----------
  conf: cleanup macros setup_proc_filesystem

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 4958760007af4f45a1ff59196af49699349e2569
      https://github.com/lxc/lxc/commit/4958760007af4f45a1ff59196af49699349e2569
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2019-04-10 (Wed, 10 Apr 2019)

  Changed paths:
    M src/lxc/conf.c

  Log Message:
  -----------
  conf: cleanup macros idmaptool_on_path_[...]

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 1d9cba1054ff5f8aa6ba8bb5f24488b260fdc7c1
      https://github.com/lxc/lxc/commit/1d9cba1054ff5f8aa6ba8bb5f24488b260fdc7c1
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2019-04-10 (Wed, 10 Apr 2019)

  Changed paths:
    M src/lxc/conf.c

  Log Message:
  -----------
  conf: cleanup macros remount_all_slave

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 65993096b282f11a46fc7366d2675e6b7c548871
      https://github.com/lxc/lxc/commit/65993096b282f11a46fc7366d2675e6b7c548871
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2019-04-10 (Wed, 10 Apr 2019)

  Changed paths:
    M src/lxc/conf.c

  Log Message:
  -----------
  conf: cleanup macros lxc_execute_bind_init

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 281292149d8874df43f8e6e3bbe33db025da2041
      https://github.com/lxc/lxc/commit/281292149d8874df43f8e6e3bbe33db025da2041
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2019-04-10 (Wed, 10 Apr 2019)

  Changed paths:
    M src/lxc/conf.c

  Log Message:
  -----------
  conf: cleanup macros get_minimal_idmap

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 3402c46346fe629c38afe046ebd3387a36422d49
      https://github.com/lxc/lxc/commit/3402c46346fe629c38afe046ebd3387a36422d49
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2019-04-10 (Wed, 10 Apr 2019)

  Changed paths:
    M src/lxc/conf.c

  Log Message:
  -----------
  conf: cleanup macros get{g,u}name

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: d1115e99646d0f82fdbcf501ada6b50247a76acf
      https://github.com/lxc/lxc/commit/d1115e99646d0f82fdbcf501ada6b50247a76acf
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2019-04-10 (Wed, 10 Apr 2019)

  Changed paths:
    M src/lxc/conf.c

  Log Message:
  -----------
  conf: cleanup macros suggest_default_idmap

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 8f443f75e2e585b3761e7f2b4232965fcb33bb5b
      https://github.com/lxc/lxc/commit/8f443f75e2e585b3761e7f2b4232965fcb33bb5b
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2019-04-10 (Wed, 10 Apr 2019)

  Changed paths:
    M .travis.yml

  Log Message:
  -----------
  travis: run coccinelle

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: bf68bedfb48b7afd888fd666dab2345a87a574ed
      https://github.com/lxc/lxc/commit/bf68bedfb48b7afd888fd666dab2345a87a574ed
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2019-04-10 (Wed, 10 Apr 2019)

  Changed paths:
    M .travis.yml

  Log Message:
  -----------
  travis: run coccinelle

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: be1a8b1e6f9b6c76f4ffcb4638fb1cb076b52834
      https://github.com/lxc/lxc/commit/be1a8b1e6f9b6c76f4ffcb4638fb1cb076b52834
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2019-04-10 (Wed, 10 Apr 2019)

  Changed paths:
    M src/lxc/attach.c

  Log Message:
  -----------
  attach: cleanup macros lxc_proc_close_ns_fd

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: ce61ad7d2bb3020e3157b248f5019b689e672b74
      https://github.com/lxc/lxc/commit/ce61ad7d2bb3020e3157b248f5019b689e672b74
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2019-04-10 (Wed, 10 Apr 2019)

  Changed paths:
    M src/lxc/attach.c

  Log Message:
  -----------
  attach: cleanup macros in_same_namespace

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: d346fa5d1abb2c3350843781ffb6dafef6969ecb
      https://github.com/lxc/lxc/commit/d346fa5d1abb2c3350843781ffb6dafef6969ecb
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2019-04-10 (Wed, 10 Apr 2019)

  Changed paths:
    M src/lxc/attach.c

  Log Message:
  -----------
  attach: cleanup macros lxc_put_attach_clone_[...]

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 58f0ca626eb8c4a2530820fdd0882c41d6664c45
      https://github.com/lxc/lxc/commit/58f0ca626eb8c4a2530820fdd0882c41d6664c45
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2019-04-10 (Wed, 10 Apr 2019)

  Changed paths:
    M src/lxc/attach.c

  Log Message:
  -----------
  attach: cleanup macros lxc_attach_terminal_[...]

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 900bda6ae22e1a79a689bce2333f08fa97a6b42a
      https://github.com/lxc/lxc/commit/900bda6ae22e1a79a689bce2333f08fa97a6b42a
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2019-04-10 (Wed, 10 Apr 2019)

  Changed paths:
    M .travis.yml

  Log Message:
  -----------
  .travis: give coverity one more try

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 999ef15f0808b8ba4064810dc73eecf92deca8d5
      https://github.com/lxc/lxc/commit/999ef15f0808b8ba4064810dc73eecf92deca8d5
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2019-04-10 (Wed, 10 Apr 2019)

  Changed paths:
    M .travis.yml
    M README.md

  Log Message:
  -----------
  .travis: remove coverity

It hasn't worked reliably for us for a long time. Remove it until such time as
someone cares enough to fix it.

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: ae68cad763d5b39a6a9e51de2acd1ad128b720ca
      https://github.com/lxc/lxc/commit/ae68cad763d5b39a6a9e51de2acd1ad128b720ca
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2019-04-10 (Wed, 10 Apr 2019)

  Changed paths:
    M src/lxc/tools/lxc_attach.c

  Log Message:
  -----------
  lxc-attach: switch to attach_run_wait

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 011ddec179986014b8b8bc375befa9fa8f510602
      https://github.com/lxc/lxc/commit/011ddec179986014b8b8bc375befa9fa8f510602
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2019-04-10 (Wed, 10 Apr 2019)

  Changed paths:
    M src/lxc/conf.c

  Log Message:
  -----------
  conf: simplify idmaptool_on_path_and_privileged

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: ecd9800c6e4c8af8513f4f199659d35e2919ac7f
      https://github.com/lxc/lxc/commit/ecd9800c6e4c8af8513f4f199659d35e2919ac7f
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2019-04-10 (Wed, 10 Apr 2019)

  Changed paths:
    M src/lxc/conf.c

  Log Message:
  -----------
  conf: cleanup macros remount_all_slave

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: e17929c4b186b524b683d48dcac41c3c7491089d
      https://github.com/lxc/lxc/commit/e17929c4b186b524b683d48dcac41c3c7491089d
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2019-04-10 (Wed, 10 Apr 2019)

  Changed paths:
    M src/lxc/conf.c

  Log Message:
  -----------
  conf: cleanup macros lxc_chroot

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: e7ea11b8d335f4e7c6d062fa26485cbf5c9811c5
      https://github.com/lxc/lxc/commit/e7ea11b8d335f4e7c6d062fa26485cbf5c9811c5
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2019-04-10 (Wed, 10 Apr 2019)

  Changed paths:
    M src/lxc/conf.c

  Log Message:
  -----------
  conf: cleanup macros lxc_pivot_root

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: b2cb6906b9cf5244755634a233288172c72383ce
      https://github.com/lxc/lxc/commit/b2cb6906b9cf5244755634a233288172c72383ce
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2019-04-10 (Wed, 10 Apr 2019)

  Changed paths:
    M src/lxc/conf.c

  Log Message:
  -----------
  conf: cleanup macros lxc_fill_autodev

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 6847cfea1dafbab65ca704f8b8398f3e95b58c7e
      https://github.com/lxc/lxc/commit/6847cfea1dafbab65ca704f8b8398f3e95b58c7e
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2019-04-10 (Wed, 10 Apr 2019)

  Changed paths:
    M src/lxc/conf.c

  Log Message:
  -----------
  conf: cleanup macros make_anonymous_mount_file

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: d970583815c7fd505d752112af62a59acb693825
      https://github.com/lxc/lxc/commit/d970583815c7fd505d752112af62a59acb693825
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2019-04-10 (Wed, 10 Apr 2019)

  Changed paths:
    M src/lxc/conf.c

  Log Message:
  -----------
  conf: cleanup macros setup_mount_entries

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 640dfcdca472d8476051ee2732a5169008518bdc
      https://github.com/lxc/lxc/commit/640dfcdca472d8476051ee2732a5169008518bdc
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2019-04-10 (Wed, 10 Apr 2019)

  Changed paths:
    M src/lxc/conf.c

  Log Message:
  -----------
  conf: cleanup macros write_id_mapping

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 801e1da46f8e45c6d7f1cc47ee7a900d8724b457
      https://github.com/lxc/lxc/commit/801e1da46f8e45c6d7f1cc47ee7a900d8724b457
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2019-04-10 (Wed, 10 Apr 2019)

  Changed paths:
    M src/lxc/conf.c

  Log Message:
  -----------
  conf: cleanup macros suggest_default_idmap

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 56ad362cde156c6f074bee58c523e5b7b9ea11f9
      https://github.com/lxc/lxc/commit/56ad362cde156c6f074bee58c523e5b7b9ea11f9
  Author: Wolfgang Bumiller <w.bumiller at proxmox.com>
  Date:   2019-04-10 (Wed, 10 Apr 2019)

  Changed paths:
    M src/lxc/attach.c

  Log Message:
  -----------
  attach: use move_fd in lxc_proc_close_ns_fd

Previously this set `ctx->ns_fd[*]` to `-EBADF` until commit
fd2a88b190eb ("attach: cleanup macros lxc_proc_close_ns_fd",
but there are some code paths where we call this before
later calling `lxc_proc_put_context_info` which would call
this function again with the file descriptors still
unchanged.

Signed-off-by: Wolfgang Bumiller <w.bumiller at proxmox.com>

  Commit: f078295329fd4cd66ce6ab99a7acd668d82aab3f
      https://github.com/lxc/lxc/commit/f078295329fd4cd66ce6ab99a7acd668d82aab3f
  Author: Marco Dickert <marco at misterunknown.de>
  Date:   2019-04-10 (Wed, 10 Apr 2019)

  Changed paths:
    M templates/lxc-download.in

  Log Message:
  -----------
  gpg: use proxy, if http_proxy is set

Signed-off-by: Marco Dickert <marco at misterunknown.de>

  Commit: 85345e6cee82dcbb760c4270ba6da011b2a170bd
      https://github.com/lxc/lxc/commit/85345e6cee82dcbb760c4270ba6da011b2a170bd
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2019-04-10 (Wed, 10 Apr 2019)

  Changed paths:
    M src/lxc/conf.c
    M src/lxc/utils.h

  Log Message:
  -----------
  conf: remove fgets() from run_buffer()

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 075f5358381dfc269bd3f56e656192539bd35770
      https://github.com/lxc/lxc/commit/075f5358381dfc269bd3f56e656192539bd35770
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2019-04-10 (Wed, 10 Apr 2019)

  Changed paths:
    M src/lxc/conf.c

  Log Message:
  -----------
  conf: remove fgets() from lxc_chroot()

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 13aa24dd8243a6070fca832e4b384c0c1948897a
      https://github.com/lxc/lxc/commit/13aa24dd8243a6070fca832e4b384c0c1948897a
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2019-04-10 (Wed, 10 Apr 2019)

  Changed paths:
    M src/lxc/initutils.c

  Log Message:
  -----------
  initutils: remove fgets() from lxc_global_con[...]

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 24d573152af229d560d51afdf1d6e41a08049654
      https://github.com/lxc/lxc/commit/24d573152af229d560d51afdf1d6e41a08049654
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2019-04-10 (Wed, 10 Apr 2019)

  Changed paths:
    M src/lxc/initutils.c

  Log Message:
  -----------
  initutils: remove fgets() from setproctitle()

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 5c94c36fde7b2d85d7e85f9fc19d267169e444dc
      https://github.com/lxc/lxc/commit/5c94c36fde7b2d85d7e85f9fc19d267169e444dc
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2019-04-10 (Wed, 10 Apr 2019)

  Changed paths:
    M src/lxc/conf.c

  Log Message:
  -----------
  conf: remove unused variable

Closes #2885.

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 43c4a869054572a9ef01258ceebe470740a08e16
      https://github.com/lxc/lxc/commit/43c4a869054572a9ef01258ceebe470740a08e16
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2019-04-10 (Wed, 10 Apr 2019)

  Changed paths:
    M src/lxc/confile.c

  Log Message:
  -----------
  confile: shut up gcc

Invalid warning but let's please the compiler.

Closes #2885.

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 0fb2209b0697cc3d7adaf94eda81e823030f39a1
      https://github.com/lxc/lxc/commit/0fb2209b0697cc3d7adaf94eda81e823030f39a1
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2019-04-10 (Wed, 10 Apr 2019)

  Changed paths:
    M CODING_STYLE.md

  Log Message:
  -----------
  CODING_STYLE: update

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 66248ae2132462b78efea9e93bc6b6e383c28a7c
      https://github.com/lxc/lxc/commit/66248ae2132462b78efea9e93bc6b6e383c28a7c
  Author: Ondrej Kubik <ondrej.kubik at canonical.com>
  Date:   2019-04-10 (Wed, 10 Apr 2019)

  Changed paths:
    M src/include/fexecve.c

  Log Message:
  -----------
  Fix android compilation

Signed-off-by: Ondrej Kubik <ondrej.kubik at canonical.com>

  Commit: ac5b5822dc8b483f1bd0bd5bf082628920f3f08d
      https://github.com/lxc/lxc/commit/ac5b5822dc8b483f1bd0bd5bf082628920f3f08d
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2019-04-10 (Wed, 10 Apr 2019)

  Changed paths:
    M src/lxc/commands_utils.c

  Log Message:
  -----------
  commands_utils.c: fix wrong licensing

liblxc has always been meant to be LGPLv2.1+ as reflected by the many
downstreams projects and bindings which are themselves under LGPLv2.1+ or other
licenses which would be incompatible with linking against a GPLv2+ library.

It's pretty normal for a library to be LGPL while binaries are GPL as a GPL
library would only ever be usable by other GPL-only projects, which isn't the
case for very many of the liblxc downstreams.

The issue here is really carelessness. None of those GPL headers were put there
intentionally, instead being wrongly copy/pasted from other parts of the
codebase which is indeed intended to be GPLv2+. This is also made clear in our
CONTRIBUTING file in this repository:

Licensing for new files:
------------------------

LXC is made of files shipped under a few different licenses.

Anything that ends up being part of the LXC library needs to be released
under LGPLv2.1+ or a license compatible with it (though the latter will
only be accepted for cases where the code originated elsewhere and was
imported into LXC).

Language bindings for the libraries need to be released under LGPLv2.1+.

Anything else (non-libraries) needs to be Free Software and needs to be
allowed to link with LGPLv2.1+ code (if needed). LXC upstream prefers
LGPLv2.1+ or GPLv2 for those.

When introducing a new file into the project, please make sure it has a
copyright header making clear under which license it's being released
and if it doesn't match the criteria described above, please explain
your decision on the lxc-devel mailing-list when submitting your patch.

This is intended to switch over files to LGPLv2.1+ to which end we have
collected ACKs from relevant people.
/* Affected People */
Christian Brauner <christian.brauner at ubuntu.com>
Donghwa Jeong <dh48.jeong at samsung.com>

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Acked-by: Donghwa Jeong <dh48.jeong at samsung.com>

  Commit: b4c496763955cf3bddf89e35c260cbaf012312e2
      https://github.com/lxc/lxc/commit/b4c496763955cf3bddf89e35c260cbaf012312e2
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2019-04-10 (Wed, 10 Apr 2019)

  Changed paths:
    M src/lxc/commands_utils.h

  Log Message:
  -----------
  commands_utils.h: fix wrong licensing

liblxc has always been meant to be LGPLv2.1+ as reflected by the many
downstreams projects and bindings which are themselves under LGPLv2.1+ or other
licenses which would be incompatible with linking against a GPLv2+ library.

It's pretty normal for a library to be LGPL while binaries are GPL as a GPL
library would only ever be usable by other GPL-only projects, which isn't the
case for very many of the liblxc downstreams.

The issue here is really carelessness. None of those GPL headers were put there
intentionally, instead being wrongly copy/pasted from other parts of the
codebase which is indeed intended to be GPLv2+. This is also made clear in our
CONTRIBUTING file in this repository:

Licensing for new files:
------------------------

LXC is made of files shipped under a few different licenses.

Anything that ends up being part of the LXC library needs to be released
under LGPLv2.1+ or a license compatible with it (though the latter will
only be accepted for cases where the code originated elsewhere and was
imported into LXC).

Language bindings for the libraries need to be released under LGPLv2.1+.

Anything else (non-libraries) needs to be Free Software and needs to be
allowed to link with LGPLv2.1+ code (if needed). LXC upstream prefers
LGPLv2.1+ or GPLv2 for those.

When introducing a new file into the project, please make sure it has a
copyright header making clear under which license it's being released
and if it doesn't match the criteria described above, please explain
your decision on the lxc-devel mailing-list when submitting your patch.

This is intended to switch over files to LGPLv2.1+ to which end we have
collected ACKs from relevant people.
/* Affected People */
Christian Brauner <christian.brauner at ubuntu.com>
Donghwa Jeong <dh48.jeong at samsung.com>

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Acked-by: Donghwa Jeong <dh48.jeong at samsung.com>

  Commit: 942fc4ca47205ceeea4e27be4a1ad470c7dd3b24
      https://github.com/lxc/lxc/commit/942fc4ca47205ceeea4e27be4a1ad470c7dd3b24
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2019-04-10 (Wed, 10 Apr 2019)

  Changed paths:
    M src/lxc/file_utils.c

  Log Message:
  -----------
  file_utils.c: fix wrong licensing

liblxc has always been meant to be LGPLv2.1+ as reflected by the many
downstreams projects and bindings which are themselves under LGPLv2.1+ or other
licenses which would be incompatible with linking against a GPLv2+ library.

It's pretty normal for a library to be LGPL while binaries are GPL as a GPL
library would only ever be usable by other GPL-only projects, which isn't the
case for very many of the liblxc downstreams.

The issue here is really carelessness. None of those GPL headers were put there
intentionally, instead being wrongly copy/pasted from other parts of the
codebase which is indeed intended to be GPLv2+. This is also made clear in our
CONTRIBUTING file in this repository:

Licensing for new files:
------------------------

LXC is made of files shipped under a few different licenses.

Anything that ends up being part of the LXC library needs to be released
under LGPLv2.1+ or a license compatible with it (though the latter will
only be accepted for cases where the code originated elsewhere and was
imported into LXC).

Language bindings for the libraries need to be released under LGPLv2.1+.

Anything else (non-libraries) needs to be Free Software and needs to be
allowed to link with LGPLv2.1+ code (if needed). LXC upstream prefers
LGPLv2.1+ or GPLv2 for those.

When introducing a new file into the project, please make sure it has a
copyright header making clear under which license it's being released
and if it doesn't match the criteria described above, please explain
your decision on the lxc-devel mailing-list when submitting your patch.

This is intended to switch over files to LGPLv2.1+ to which end we have
collected ACKs from relevant people.
/* Affected People */
Christian Brauner <christian.brauner at ubuntu.com>
Donghwa Jeong <dh48.jeong at samsung.com>

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Acked-by: Donghwa Jeong <dh48.jeong at samsung.com>

  Commit: 4e249c2e9efc16dee7048887ad876992602982ae
      https://github.com/lxc/lxc/commit/4e249c2e9efc16dee7048887ad876992602982ae
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2019-04-10 (Wed, 10 Apr 2019)

  Changed paths:
    M src/lxc/string_utils.c

  Log Message:
  -----------
  string_utils.c: fix wrong licensing

liblxc has always been meant to be LGPLv2.1+ as reflected by the many
downstreams projects and bindings which are themselves under LGPLv2.1+ or other
licenses which would be incompatible with linking against a GPLv2+ library.

It's pretty normal for a library to be LGPL while binaries are GPL as a GPL
library would only ever be usable by other GPL-only projects, which isn't the
case for very many of the liblxc downstreams.

The issue here is really carelessness. None of those GPL headers were put there
intentionally, instead being wrongly copy/pasted from other parts of the
codebase which is indeed intended to be GPLv2+. This is also made clear in our
CONTRIBUTING file in this repository:

Licensing for new files:
------------------------

LXC is made of files shipped under a few different licenses.

Anything that ends up being part of the LXC library needs to be released
under LGPLv2.1+ or a license compatible with it (though the latter will
only be accepted for cases where the code originated elsewhere and was
imported into LXC).

Language bindings for the libraries need to be released under LGPLv2.1+.

Anything else (non-libraries) needs to be Free Software and needs to be
allowed to link with LGPLv2.1+ code (if needed). LXC upstream prefers
LGPLv2.1+ or GPLv2 for those.

When introducing a new file into the project, please make sure it has a
copyright header making clear under which license it's being released
and if it doesn't match the criteria described above, please explain
your decision on the lxc-devel mailing-list when submitting your patch.

This is intended to switch over files to LGPLv2.1+ to which end we have
collected ACKs from relevant people.
/* Affected People */
Christian Brauner <christian.brauner at ubuntu.com>
Donghwa Jeong <dh48.jeong at samsung.com>

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Acked-by: Donghwa Jeong <dh48.jeong at samsung.com>

  Commit: 20c6f53a50811d00874e4550e2224ee6e838aa58
      https://github.com/lxc/lxc/commit/20c6f53a50811d00874e4550e2224ee6e838aa58
  Author: tomponline <tomp at tomp.uk>
  Date:   2019-04-10 (Wed, 10 Apr 2019)

  Changed paths:
    M src/lxc/attach.c

  Log Message:
  -----------
  attach: remove unused variable

Closes lxc#2885.

Signed-off-by: tomponline <tomp at tomp.uk>

  Commit: 32dad1cd1128afcc3757b0f4ade7d194f9015442
      https://github.com/lxc/lxc/commit/32dad1cd1128afcc3757b0f4ade7d194f9015442
  Author: tomponline <tomp at tomp.uk>
  Date:   2019-04-10 (Wed, 10 Apr 2019)

  Changed paths:
    M src/lxc/attach.c

  Log Message:
  -----------
  attacg: shut up gcc

Invalid warning but let's please the compiler.

Closes lxc#2885.

Signed-off-by: tomponline <tomp at tomp.uk>

  Commit: aa4376ad327d750289e899900c2ea411031b3175
      https://github.com/lxc/lxc/commit/aa4376ad327d750289e899900c2ea411031b3175
  Author: tomponline <tomp at tomp.uk>
  Date:   2019-04-10 (Wed, 10 Apr 2019)

  Changed paths:
    M src/lxc/lxccontainer.c

  Log Message:
  -----------
  lxccontainer: shut up gcc and remove unused variables.

Closes #2885.

Signed-off-by: tomponline <tomp at tomp.uk>

  Commit: 5bcb2cd773e6b1e0a879fba91c8b6be903a09491
      https://github.com/lxc/lxc/commit/5bcb2cd773e6b1e0a879fba91c8b6be903a09491
  Author: tomponline <tomp at tomp.uk>
  Date:   2019-04-10 (Wed, 10 Apr 2019)

  Changed paths:
    M src/lxc/network.c

  Log Message:
  -----------
  network: shut up gcc.

Closes #2885.

Signed-off-by: tomponline <tomp at tomp.uk>

  Commit: c0469fafa6788a0ec8e2c286cf56c99a69a62113
      https://github.com/lxc/lxc/commit/c0469fafa6788a0ec8e2c286cf56c99a69a62113
  Author: tomponline <tomp at tomp.uk>
  Date:   2019-04-10 (Wed, 10 Apr 2019)

  Changed paths:
    M src/lxc/monitor.c

  Log Message:
  -----------
  monitor: shut up gcc.

Closes #2885.

Signed-off-by: tomponline <tomp at tomp.uk>

  Commit: 5ec0ffa960fb299b0c8938b2293aade1053b202d
      https://github.com/lxc/lxc/commit/5ec0ffa960fb299b0c8938b2293aade1053b202d
  Author: tomponline <tomp at tomp.uk>
  Date:   2019-04-10 (Wed, 10 Apr 2019)

  Changed paths:
    M src/lxc/start.c

  Log Message:
  -----------
  start: shut up gcc.

Closes #2885.

Signed-off-by: tomponline <tomp at tomp.uk>

  Commit: 68f4f387d3e01da5800ace0664974685c3c96d25
      https://github.com/lxc/lxc/commit/68f4f387d3e01da5800ace0664974685c3c96d25
  Author: tomponline <tomp at tomp.uk>
  Date:   2019-04-10 (Wed, 10 Apr 2019)

  Changed paths:
    M src/lxc/storage/loop.c
    M src/lxc/storage/lvm.c
    M src/lxc/storage/nbd.c
    M src/lxc/storage/storage.c

  Log Message:
  -----------
  storage: shut up gcc and remove unused variables.

Closes #2885.

Signed-off-by: tomponline <tomp at tomp.uk>

  Commit: 7e5a72cb296536ff0f856fe0788ab91255d1f743
      https://github.com/lxc/lxc/commit/7e5a72cb296536ff0f856fe0788ab91255d1f743
  Author: tomponline <tomp at tomp.uk>
  Date:   2019-04-10 (Wed, 10 Apr 2019)

  Changed paths:
    M src/lxc/cmd/lxc_user_nic.c

  Log Message:
  -----------
  cmd: shut up gcc.

Closes #2885.

Signed-off-by: tomponline <tomp at tomp.uk>

  Commit: ec78a81ca444b691a4bf47a0e6d91e7ef63f19df
      https://github.com/lxc/lxc/commit/ec78a81ca444b691a4bf47a0e6d91e7ef63f19df
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2019-04-10 (Wed, 10 Apr 2019)

  Changed paths:
    M src/lxc/confile.c
    M src/lxc/confile_utils.c
    M src/lxc/confile_utils.h
    M src/tests/lxc-test-utils.c

  Log Message:
  -----------
  confile_utils: lxc_config_net_is_hwaddr()

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 6fccdc346270d7e70f2fd277a1a708181277cf95
      https://github.com/lxc/lxc/commit/6fccdc346270d7e70f2fd277a1a708181277cf95
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2019-04-10 (Wed, 10 Apr 2019)

  Changed paths:
    M src/lxc/confile.c
    M src/lxc/confile_utils.c
    M src/lxc/confile_utils.h

  Log Message:
  -----------
  confile_utils: make update_hwaddr() static

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: bb112e595fe544589d426558476b244767e80ca1
      https://github.com/lxc/lxc/commit/bb112e595fe544589d426558476b244767e80ca1
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2019-04-10 (Wed, 10 Apr 2019)

  Changed paths:
    M src/lxc/confile.c
    M src/lxc/confile_utils.c
    M src/lxc/confile_utils.h

  Log Message:
  -----------
  confile: make parse_limit_value() static

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: f0cab6a89f5ee5bfe7e466c8a181d435a1f45f6a
      https://github.com/lxc/lxc/commit/f0cab6a89f5ee5bfe7e466c8a181d435a1f45f6a
  Author: tomponline <tomp at tomp.uk>
  Date:   2019-04-10 (Wed, 10 Apr 2019)

  Changed paths:
    M src/lxc/conf.c

  Log Message:
  -----------
  conf: Fixes unitialised variable.

Signed-off-by: tomponline <tomp at tomp.uk>

  Commit: 45b77cc8e88fff4a06b73ecc432f9bfd68868ba7
      https://github.com/lxc/lxc/commit/45b77cc8e88fff4a06b73ecc432f9bfd68868ba7
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2019-04-10 (Wed, 10 Apr 2019)

  Changed paths:
    M src/lxc/conf.c

  Log Message:
  -----------
  Revert "conf: Fixes unitialised variable."

This reverts commit 912c4bb474b52284cf82c336b0af161be6c25ac1.

I accidently merged this commit. The initialization is wrong.

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 6e935c2565e8e8a5f5e8e79878bec6d4df8681fc
      https://github.com/lxc/lxc/commit/6e935c2565e8e8a5f5e8e79878bec6d4df8681fc
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2019-04-10 (Wed, 10 Apr 2019)

  Changed paths:
    M src/lxc/conf.c

  Log Message:
  -----------
  conf: avoid compiler warning

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: a2a5f386c7bf2b35f956aecc5764975b6fac89ab
      https://github.com/lxc/lxc/commit/a2a5f386c7bf2b35f956aecc5764975b6fac89ab
  Author: Michael Sparmann <750643+TheSeven at users.noreply.github.com>
  Date:   2019-04-10 (Wed, 10 Apr 2019)

  Changed paths:
    M src/lxc/cgroups/cgfsng.c

  Log Message:
  -----------
  Fix lxc.cgroup2.<controller> on cgroup2-only systems

Signed-off-by: Michael Sparmann <theseven at gmx.net>

  Commit: c8a92f33d4b0e95f7320702267136fcfc6e88c3a
      https://github.com/lxc/lxc/commit/c8a92f33d4b0e95f7320702267136fcfc6e88c3a
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2019-04-10 (Wed, 10 Apr 2019)

  Changed paths:
    M src/lxc/start.c

  Log Message:
  -----------
  hooks: drop namespace references before post-stop

Callers such as LXD run post-stop hooks to perform cleanup operations on
shutdown. This can involve umount and other things. To avoid surprises with
lingering namespace references we should close all our namespace-preserving
file descriptors. We don't need them at this point anymore anyway.

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: fa10d27ca16929f7b16abd01af1f539644086bdb
      https://github.com/lxc/lxc/commit/fa10d27ca16929f7b16abd01af1f539644086bdb
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2019-04-10 (Wed, 10 Apr 2019)

  Changed paths:
    M src/lxc/storage/btrfs.c

  Log Message:
  -----------
  btrfs: ensure \0 byte at end

Apparently the name received from the tree walk is not guaranteed to have \0
byte at the end. So let's make sure we append one.
Note that this is only an issue if there are any subvolumes in the container's
rootfs.

Closes 2826.

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 21b00b0a07b82cbb3b9dd026dfa71a8a933dd2de
      https://github.com/lxc/lxc/commit/21b00b0a07b82cbb3b9dd026dfa71a8a933dd2de
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2019-04-10 (Wed, 10 Apr 2019)

  Changed paths:
    M configure.ac

  Log Message:
  -----------
  compiler: -fasynchronous-unwind-tables hardening

Increased reliability of backtraces.

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: c6cf5e2a37c1f6f3c7c804d693fe7ca8e78aa6a9
      https://github.com/lxc/lxc/commit/c6cf5e2a37c1f6f3c7c804d693fe7ca8e78aa6a9
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2019-04-10 (Wed, 10 Apr 2019)

  Changed paths:
    M configure.ac

  Log Message:
  -----------
  compiler: -pipe

Avoid temporary files, speeding up builds.

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 821b53b38f392172b6e846a42ce475c21debe5dc
      https://github.com/lxc/lxc/commit/821b53b38f392172b6e846a42ce475c21debe5dc
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2019-04-10 (Wed, 10 Apr 2019)

  Changed paths:
    M configure.ac

  Log Message:
  -----------
  compiler: -fexceptions hardening

This hardens multi-threaded C. Without it, the implementation of thread
cancellation handlers (introduced by pthread_cleanup_push) uses a completely
unprotected function pointer on the stack. This function pointer can simplify
the exploitation of stack-based buffer overflows even if the thread in question
is never canceled.

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: f5ca34dfb445d2af65e90cbe4834a3ef77c28441
      https://github.com/lxc/lxc/commit/f5ca34dfb445d2af65e90cbe4834a3ef77c28441
  Author: Felix Abecassis <fabecassis at nvidia.com>
  Date:   2019-04-10 (Wed, 10 Apr 2019)

  Changed paths:
    M src/lxc/utils.c

  Log Message:
  -----------
  utils: fix handling of PID namespaces in lxc_set_death_signal

Signed-off-by: Felix Abecassis <fabecassis at nvidia.com>

  Commit: 232b8c42b95f98fc5182ed5fc5ea02b1b2ac30c5
      https://github.com/lxc/lxc/commit/232b8c42b95f98fc5182ed5fc5ea02b1b2ac30c5
  Author: Felix Abecassis <fabecassis at nvidia.com>
  Date:   2019-04-10 (Wed, 10 Apr 2019)

  Changed paths:
    M src/lxc/start.c

  Log Message:
  -----------
  start: fix parent PID passed to lxc_set_death_signal

Fixes: #2902

Signed-off-by: Felix Abecassis <fabecassis at nvidia.com>

  Commit: 051ef2732f8038554f8f0c82f01ef743c240b5b3
      https://github.com/lxc/lxc/commit/051ef2732f8038554f8f0c82f01ef743c240b5b3
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2019-04-10 (Wed, 10 Apr 2019)

  Changed paths:
    M configure.ac
    M src/lxc/Makefile.am

  Log Message:
  -----------
  hardening: enable address sanitizer build

This adds --{disable,enable}-asan. It is disabled by default.

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 3fe0b3cd127d8047f86dcfe4ff12b8e735112fb8
      https://github.com/lxc/lxc/commit/3fe0b3cd127d8047f86dcfe4ff12b8e735112fb8
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2019-04-10 (Wed, 10 Apr 2019)

  Changed paths:
    M src/lxc/start.c
    M src/lxc/start.h

  Log Message:
  -----------
  start: backport monitor_pid handling

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: def2d52b74e65a1fe67ee76fa4a91939d5a0359c
      https://github.com/lxc/lxc/commit/def2d52b74e65a1fe67ee76fa4a91939d5a0359c
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2019-04-10 (Wed, 10 Apr 2019)

  Changed paths:
    M src/lxc/cgroups/cgfsng.c

  Log Message:
  -----------
  cgfsng: fix cgroup2 handling

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

Compare: https://github.com/lxc/lxc/compare/9690cdba7201...def2d52b74e6