[lxc-devel] [lxc/lxc] 6b4e3a: tests: cleanup get_item.c
GitHub
noreply at github.com
Sun Sep 30 22:50:10 UTC 2018
Branch: refs/heads/stable-3.0
Home: https://github.com/lxc/lxc
Commit: 6b4e3a5065597179549940868709a4eb2b7dc295
https://github.com/lxc/lxc/commit/6b4e3a5065597179549940868709a4eb2b7dc295
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2018-09-30 (Sun, 30 Sep 2018)
Changed paths:
M src/tests/parse_config_file.c
Log Message:
-----------
tests: cleanup get_item.c
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 8870e1cfa651ab96536766cc08ca35e50f5c68fe
https://github.com/lxc/lxc/commit/8870e1cfa651ab96536766cc08ca35e50f5c68fe
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2018-10-01 (Mon, 01 Oct 2018)
Changed paths:
M src/lxc/macro.h
M src/lxc/parse.c
Log Message:
-----------
build: fix musl
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 97fd1175baad14ab543a260ea4e2541ed46f6492
https://github.com/lxc/lxc/commit/97fd1175baad14ab543a260ea4e2541ed46f6492
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2018-10-01 (Mon, 01 Oct 2018)
Changed paths:
M configure.ac
Log Message:
-----------
configure: reorder header checks
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 8dafe6cece8504311c6686b0402bcdfe1b7ecd56
https://github.com/lxc/lxc/commit/8dafe6cece8504311c6686b0402bcdfe1b7ecd56
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2018-10-01 (Mon, 01 Oct 2018)
Changed paths:
M src/lxc/Makefile.am
A src/lxc/compiler.h
M src/lxc/conf.c
M src/lxc/conf.h
M src/lxc/initutils.c
Log Message:
-----------
compiler: add compiler.h header
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 85ba342413730d0849fda32f74df0f4e2cec8e47
https://github.com/lxc/lxc/commit/85ba342413730d0849fda32f74df0f4e2cec8e47
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2018-10-01 (Mon, 01 Oct 2018)
Changed paths:
M src/lxc/commands.c
Log Message:
-----------
commands: return -1 on lxc_cmd_get_init_pid() err
A while back the whole lxc_cmd() infrastructure was changed to return
meaningful negative error codes. But lxc_cmd_get_init_pid() should always
return -1. Make it so!
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Reported-by: Stéphane Graber <stgraber at ubuntu.com>
Commit: e21477590ab95752244f91092061b50f5ee889bf
https://github.com/lxc/lxc/commit/e21477590ab95752244f91092061b50f5ee889bf
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2018-10-01 (Mon, 01 Oct 2018)
Changed paths:
M src/tests/Makefile.am
A src/tests/basic.c
Log Message:
-----------
tests: add basic.c
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 1cd225b62b62db78f6d488a6038eb88af6dd2500
https://github.com/lxc/lxc/commit/1cd225b62b62db78f6d488a6038eb88af6dd2500
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2018-10-01 (Mon, 01 Oct 2018)
Changed paths:
M src/tests/Makefile.am
Log Message:
-----------
tests: cleanup Makefile
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 253a7210330dc1580225d294ee90658720fa74d2
https://github.com/lxc/lxc/commit/253a7210330dc1580225d294ee90658720fa74d2
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2018-10-01 (Mon, 01 Oct 2018)
Changed paths:
M src/lxc/commands.c
Log Message:
-----------
commands: ensure -1 is sent on EPIPE for init pid
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Reported-by: Stéphane Graber <stgraber at ubuntu.com>
Commit: c05ad00860113512bc2e56eb51697d45a36afb9b
https://github.com/lxc/lxc/commit/c05ad00860113512bc2e56eb51697d45a36afb9b
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2018-10-01 (Mon, 01 Oct 2018)
Changed paths:
M src/lxc/commands.c
M src/lxc/commands_utils.c
M src/lxc/macro.h
Log Message:
-----------
macro: add LXC_AUDS_ADDR_LEN
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: ceecb90e68fbe9d2f950ddd1aec321d3ae7e04c5
https://github.com/lxc/lxc/commit/ceecb90e68fbe9d2f950ddd1aec321d3ae7e04c5
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2018-10-01 (Mon, 01 Oct 2018)
Changed paths:
M src/lxc/commands.h
M src/lxc/macro.h
Log Message:
-----------
macro: move LXC_CMD_DATA_MAX from commands.h
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 80335fa8d2c03e8bb57b48302790f609ecef2d80
https://github.com/lxc/lxc/commit/80335fa8d2c03e8bb57b48302790f609ecef2d80
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2018-10-01 (Mon, 01 Oct 2018)
Changed paths:
M src/lxc/commands.h
M src/lxc/macro.h
Log Message:
-----------
macro: add PTR_TO_INT() and INT_TO_PTR()
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 1e7d9877056d0e9d2fcd255b2b90606bd5e0767a
https://github.com/lxc/lxc/commit/1e7d9877056d0e9d2fcd255b2b90606bd5e0767a
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2018-10-01 (Mon, 01 Oct 2018)
Changed paths:
M src/lxc/macro.h
Log Message:
-----------
macro: add INTTYPE_TO_STRLEN()
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: c90d5e559fa62c8a4e1d41fe2092df0250d0c5f4
https://github.com/lxc/lxc/commit/c90d5e559fa62c8a4e1d41fe2092df0250d0c5f4
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2018-10-01 (Mon, 01 Oct 2018)
Changed paths:
M src/lxc/caps.c
Log Message:
-----------
caps: s/LXC_NUMSTRLEN64/INTTYPE_TO_STRLEN()/
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 660c91914ec36de4fdbfcbe1b7cbd95cded8d849
https://github.com/lxc/lxc/commit/660c91914ec36de4fdbfcbe1b7cbd95cded8d849
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2018-10-01 (Mon, 01 Oct 2018)
Changed paths:
M src/lxc/cgroups/cgfsng.c
Log Message:
-----------
cgfsng: s/LXC_NUMSTRLEN64/INTTYPE_TO_STRLEN()/
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: b1401e3fef9d3b92bca2114fb08fd610b56c740a
https://github.com/lxc/lxc/commit/b1401e3fef9d3b92bca2114fb08fd610b56c740a
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2018-10-01 (Mon, 01 Oct 2018)
Changed paths:
M src/lxc/confile.c
Log Message:
-----------
confile: s/LXC_NUMSTRLEN64/INTTYPE_TO_STRLEN()/
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 85c427f462644cac3cf31b201e7da03dc6551aa0
https://github.com/lxc/lxc/commit/85c427f462644cac3cf31b201e7da03dc6551aa0
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2018-10-01 (Mon, 01 Oct 2018)
Changed paths:
M src/lxc/log.c
Log Message:
-----------
log: s/LXC_NUMSTRLEN64/INTTYPE_TO_STRLEN()/
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: d7451b29e2853a789ba6d2d9cced00da48def209
https://github.com/lxc/lxc/commit/d7451b29e2853a789ba6d2d9cced00da48def209
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2018-10-01 (Mon, 01 Oct 2018)
Changed paths:
M src/lxc/lsm/lsm.h
M src/lxc/macro.h
Log Message:
-----------
lsm: s/LXC_NUMSTRLEN64/INTTYPE_TO_STRLEN()/
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 9570a5a15719a7f8bb95cf061fb929c75a775138
https://github.com/lxc/lxc/commit/9570a5a15719a7f8bb95cf061fb929c75a775138
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2018-10-01 (Mon, 01 Oct 2018)
Changed paths:
M src/lxc/macro.h
Log Message:
-----------
macro: s/LXC_NUMSTRLEN64/INTTYPE_TO_STRLEN()/
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: df0b75de081feac465d885fbe8b4f5ee20ec784e
https://github.com/lxc/lxc/commit/df0b75de081feac465d885fbe8b4f5ee20ec784e
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2018-10-01 (Mon, 01 Oct 2018)
Changed paths:
M src/lxc/lxccontainer.c
Log Message:
-----------
lxccontainer: s/LXC_NUMSTRLEN64/INTTYPE_TO_STRLEN()/
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: b270f2ee8ab882d459f94f8de864158482911967
https://github.com/lxc/lxc/commit/b270f2ee8ab882d459f94f8de864158482911967
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2018-10-01 (Mon, 01 Oct 2018)
Changed paths:
M src/lxc/monitor.c
Log Message:
-----------
monitor: s/LXC_NUMSTRLEN64/INTTYPE_TO_STRLEN()/
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: a16657ffc5e36ea964140dae85f7fddbcf66f728
https://github.com/lxc/lxc/commit/a16657ffc5e36ea964140dae85f7fddbcf66f728
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2018-10-01 (Mon, 01 Oct 2018)
Changed paths:
M src/lxc/network.c
Log Message:
-----------
network: s/LXC_NUMSTRLEN64/INTTYPE_TO_STRLEN()/
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 70025c1710a9037ef019f34b485e669f3f42d3ec
https://github.com/lxc/lxc/commit/70025c1710a9037ef019f34b485e669f3f42d3ec
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2018-10-01 (Mon, 01 Oct 2018)
Changed paths:
M src/lxc/string_utils.c
Log Message:
-----------
string_utils: s/LXC_NUMSTRLEN64/INTTYPE_TO_STRLEN()/
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: d2e61e590442c81e13e3af04939e0cce9ac2aa5b
https://github.com/lxc/lxc/commit/d2e61e590442c81e13e3af04939e0cce9ac2aa5b
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2018-10-01 (Mon, 01 Oct 2018)
Changed paths:
M src/lxc/utils.c
Log Message:
-----------
utils: s/LXC_NUMSTRLEN64/INTTYPE_TO_STRLEN()/
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 39cc7f52047721a329956ee292604d79915133e1
https://github.com/lxc/lxc/commit/39cc7f52047721a329956ee292604d79915133e1
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2018-10-01 (Mon, 01 Oct 2018)
Changed paths:
M src/lxc/Makefile.am
M src/lxc/tools/lxc_monitor.c
Log Message:
-----------
tools: s/LXC_NUMSTRLEN64/INTTYPE_TO_STRLEN()/
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 528ca26a63c658709b091486b3998ef7c9355a22
https://github.com/lxc/lxc/commit/528ca26a63c658709b091486b3998ef7c9355a22
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2018-10-01 (Mon, 01 Oct 2018)
Changed paths:
M src/lxc/conf.c
Log Message:
-----------
conf: s/LXC_NUMSTRLEN64/INTTYPE_TO_STRLEN()/
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 5a6cf5fb3271415706d54b85b42936d99a2db41b
https://github.com/lxc/lxc/commit/5a6cf5fb3271415706d54b85b42936d99a2db41b
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2018-10-01 (Mon, 01 Oct 2018)
Changed paths:
M src/tests/lxc-test-utils.c
Log Message:
-----------
tests: s/LXC_NUMSTRLEN64/INTTYPE_TO_STRLEN()/
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 5c055feec7cc55b8579dc78ba3ac387196cedd51
https://github.com/lxc/lxc/commit/5c055feec7cc55b8579dc78ba3ac387196cedd51
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2018-10-01 (Mon, 01 Oct 2018)
Changed paths:
M src/lxc/macro.h
Log Message:
-----------
macro: final INTTYPE_TO_STRLEN() related cleanups
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 5f93cedd36253158e2fd6fee5956911d2f544207
https://github.com/lxc/lxc/commit/5f93cedd36253158e2fd6fee5956911d2f544207
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2018-10-01 (Mon, 01 Oct 2018)
Changed paths:
M src/lxc/macro.h
Log Message:
-----------
macro: coding style fixes
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: e7c895175f2a77d9cb8a589ebcec8becad4fff64
https://github.com/lxc/lxc/commit/e7c895175f2a77d9cb8a589ebcec8becad4fff64
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2018-10-01 (Mon, 01 Oct 2018)
Changed paths:
M src/lxc/Makefile.am
Log Message:
-----------
Makefile: correctly add ifaddrs to noinst_HEADERS
Before this we only added ifaddrs.h to noinst_HEADERS when we were running on
Android's bionic. That obviously doesn't make sense since it is possible that
ifaddrs.h is not defined and we're also not running on Android's bionic.
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 5d852e714acd962a341d06172f5ce3275d3be958
https://github.com/lxc/lxc/commit/5d852e714acd962a341d06172f5ce3275d3be958
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2018-10-01 (Mon, 01 Oct 2018)
Changed paths:
M src/lxc/start.c
Log Message:
-----------
start: remove duplicate macros
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 1d41f88c0c3e1fab739d45965ebb44602cce2cc7
https://github.com/lxc/lxc/commit/1d41f88c0c3e1fab739d45965ebb44602cce2cc7
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2018-10-01 (Mon, 01 Oct 2018)
Changed paths:
M src/lxc/caps.c
M src/lxc/macro.h
Log Message:
-----------
caps: move macros to macro header
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 6cbcad6032ea66522c208f3bd68ac9545c9bd8f2
https://github.com/lxc/lxc/commit/6cbcad6032ea66522c208f3bd68ac9545c9bd8f2
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2018-10-01 (Mon, 01 Oct 2018)
Changed paths:
M src/lxc/string_utils.c
Log Message:
-----------
string_utils: use UINT64_MAX macro
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 35bd8445ce90bee55f7767aa55f03e99bb31ffc0
https://github.com/lxc/lxc/commit/35bd8445ce90bee55f7767aa55f03e99bb31ffc0
Author: Wolfgang Bumiller <w.bumiller at proxmox.com>
Date: 2018-10-01 (Mon, 01 Oct 2018)
Changed paths:
M src/lxc/caps.c
M src/lxc/cgroups/cgfsng.c
M src/lxc/log.c
M src/lxc/lxccontainer.c
M src/lxc/monitor.c
M src/lxc/tools/lxc_monitor.c
M src/lxc/utils.c
M src/tests/lxc-test-utils.c
Log Message:
-----------
tree-wide: use sizeof on static arrays
Instead of duplicating their lengths in read/snprintf/...
calls.
Signed-off-by: Wolfgang Bumiller <w.bumiller at proxmox.com>
Commit: d3e911923d0a3f0c7add18d2db780edc0322566e
https://github.com/lxc/lxc/commit/d3e911923d0a3f0c7add18d2db780edc0322566e
Author: Stéphane Graber <stgraber at ubuntu.com>
Date: 2018-10-01 (Mon, 01 Oct 2018)
Changed paths:
M src/lxc/caps.c
M src/lxc/cgroups/cgfsng.c
M src/lxc/log.c
M src/lxc/lxccontainer.c
M src/lxc/monitor.c
M src/lxc/tools/lxc_monitor.c
M src/lxc/utils.c
M src/tests/lxc-test-utils.c
Log Message:
-----------
Revert "tree-wide: use sizeof on static arrays"
This reverts commit 81a3bb64b4147ac6da3087cb77ac67828a2f2b76.
This commit broke all builders running with pid_max > 32768.
Reverting for now so we can bring the build farm back online.
Signed-off-by: Stéphane Graber <stgraber at ubuntu.com>
Commit: db1d87ec6a3d927fa012fa3b574db428d1cca053
https://github.com/lxc/lxc/commit/db1d87ec6a3d927fa012fa3b574db428d1cca053
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2018-10-01 (Mon, 01 Oct 2018)
Changed paths:
M src/lxc/commands.c
M src/lxc/macro.h
Log Message:
-----------
commands: pass around intmax_t
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 94c6701bdfff0e89c465eaff03c978d0020f9eb0
https://github.com/lxc/lxc/commit/94c6701bdfff0e89c465eaff03c978d0020f9eb0
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2018-10-01 (Mon, 01 Oct 2018)
Changed paths:
M src/lxc/commands.c
Log Message:
-----------
commands: assign before converting to pointer
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 2cd99fc7887d2977bdac24031ae2c36ad3199db9
https://github.com/lxc/lxc/commit/2cd99fc7887d2977bdac24031ae2c36ad3199db9
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2018-10-01 (Mon, 01 Oct 2018)
Changed paths:
M src/lxc/macro.h
Log Message:
-----------
macro: calculate buffer lengths correctly
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 9dc48709caf319dae4e9b8379c0a887b199daa04
https://github.com/lxc/lxc/commit/9dc48709caf319dae4e9b8379c0a887b199daa04
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2018-10-01 (Mon, 01 Oct 2018)
Changed paths:
M src/lxc/caps.c
M src/lxc/cgroups/cgfsng.c
M src/lxc/log.c
M src/lxc/lxccontainer.c
M src/lxc/monitor.c
M src/lxc/tools/lxc_monitor.c
M src/lxc/utils.c
M src/tests/lxc-test-utils.c
Log Message:
-----------
Revert "Revert "tree-wide: use sizeof on static arrays""
This reverts commit 2fb7cf0b325d2e34cd6faa2758cbaba6b6c3b99f.
The problem wasn't caused by the reverted commit and was fixed in
commit 0c9b1f826d3 ("macro: calculate buffer lengths correctly")
The full explanation can be taken from the following irc excerpt from
the #lxc-dev channel:
│19:54:47 brauner | there was a bug in one of the standard macros we used
│19:55:01 brauner | and the changes by INTTYPE_TO_STRLEN() caused the issue to surface
│19:55:03 brauner | which is good
│19:55:16 brauner | i sent a branch and stgraber merged it that fixes it
│19:57:56 Blub\0 | so...
│19:58:31 Blub\0 | still doesn't explain how it was the sizeof() patch
│20:07:14 brauner | Blub\0: so here's the long explanation
│20:07:35 brauner | Blub\0: stgraber bumped pid_max on our jenkins test builders
│20:07:53 brauner | Blub\0: because we're running *a lot* of containers
│20:07:56 brauner | in any case
│20:08:06 brauner | there was a buffer
│20:08:12 brauner | LXC_LSMATTRLEN
│20:08:59 brauner | it used to be
│20:09:03 brauner | -/* /proc/pid-to-str/attr/current = (5 + INTTYPE_TO_STRLEN(pid_t) + 7 + 1) */
│20:09:03 brauner | -#define LXC_LSMATTRLEN (5 + INTTYPE_TO_STRLEN(pid_t) + 7 + 1)
│20:09:14 brauner | which one can see is wrong
│20:09:21 brauner | before the INTTYPE patchset
│20:09:40 brauner | INTTYPE_TO_STRLEN(pid_t) was LXC_NUMSTRLEN64
│20:09:45 brauner | which gave you 21 chars
│20:09:57 brauner | so it accounted for the missing parts
│20:10:03 brauner | because the correct macro should've been
│20:10:17 brauner | +/* /proc/ = 6
│20:10:17 brauner | + * +
│20:10:17 brauner | + * <pid-as-str> = INTTYPE_TO_STRLEN(pid_t)
│20:10:17 brauner | + * +
│20:10:17 brauner | + * /attr/ = 6
│20:10:17 brauner | + * +
│20:10:17 brauner | + * /current = 8
│20:10:17 brauner | + * +
│20:10:17 brauner | + * \0 = 1
│20:10:17 brauner | + */
│20:10:17 brauner | +#define LXC_LSMATTRLEN (6 + INTTYPE_TO_STRLEN(pid_t) + 6 + 8 + 1)
│20:10:24 Blub\0 | still
│20:10:31 brauner | the issue was only seen
│20:10:39 brauner | when the pid number hit a specific maximum
│20:10:50 Blub\0 | the sizeof patch only changed instances of actual char buf[A_FIXED_NUMBER] + snprintf(buf, A_FIXED_NUMBER, ...)
│20:10:54 brauner | aka exceeded the newly shortened buffer
│20:11:42 brauner | your patch was a red herring
│20:12:03 Blub\0 | I guess
│20:12:06 brauner | it didn't cause it
│20:12:14 brauner | it just surfaced at the same time it was merged
│20:12:25 Blub\0 | so we can revert the revert then? :)
│20:12:35 brauner | yes, that was th eplan all along
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: eec16e863c998357d48055fbee5368f6b630dbc1
https://github.com/lxc/lxc/commit/eec16e863c998357d48055fbee5368f6b630dbc1
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2018-10-01 (Mon, 01 Oct 2018)
Changed paths:
M src/lxc/conf.c
M src/lxc/macro.h
Log Message:
-----------
macro: move MS_* macros
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 0d83e3249b89b318b3e4e45ffda8e47fe3c3861a
https://github.com/lxc/lxc/commit/0d83e3249b89b318b3e4e45ffda8e47fe3c3861a
Author: 2xsec <dh48.jeong at samsung.com>
Date: 2018-10-01 (Mon, 01 Oct 2018)
Changed paths:
M src/lxc/caps.c
Log Message:
-----------
caps: fix illegal access to array bound
Signed-off-by: 2xsec <dh48.jeong at samsung.com>
Commit: 6986ee5e148637c954ac26266697fff303a070f4
https://github.com/lxc/lxc/commit/6986ee5e148637c954ac26266697fff303a070f4
Author: 2xsec <dh48.jeong at samsung.com>
Date: 2018-10-01 (Mon, 01 Oct 2018)
Changed paths:
M src/lxc/utils.c
Log Message:
-----------
utils: defensive programming
If caller passed the size of array not string length, it is possible to be accessed out of bounds.
Reorder conditions can prevent access invalid index of array.
Signed-off-by: 2xsec <dh48.jeong at samsung.com>
Commit: 55a5b989bec1d7db21032c2f5083c365bd612e61
https://github.com/lxc/lxc/commit/55a5b989bec1d7db21032c2f5083c365bd612e61
Author: 2xsec <dh48.jeong at samsung.com>
Date: 2018-10-01 (Mon, 01 Oct 2018)
Changed paths:
M src/lxc/nl.c
Log Message:
-----------
nl: remove duplicated define
Signed-off-by: 2xsec <dh48.jeong at samsung.com>
Commit: d6c83098e64fe18ac7dc5d2b56589c5a66255cb8
https://github.com/lxc/lxc/commit/d6c83098e64fe18ac7dc5d2b56589c5a66255cb8
Author: 2xsec <dh48.jeong at samsung.com>
Date: 2018-10-01 (Mon, 01 Oct 2018)
Changed paths:
M src/lxc/seccomp.c
Log Message:
-----------
syntax error: mismatch brace
Signed-off-by: 2xsec <dh48.jeong at samsung.com>
Commit: 6b19860911b356ad03f6f90ab181d37b45823d6c
https://github.com/lxc/lxc/commit/6b19860911b356ad03f6f90ab181d37b45823d6c
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2018-10-01 (Mon, 01 Oct 2018)
Changed paths:
M src/lxc/commands.c
Log Message:
-----------
commands: better error message
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: c31f08445cade197fa0474a0afde017e67f998e8
https://github.com/lxc/lxc/commit/c31f08445cade197fa0474a0afde017e67f998e8
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2018-10-01 (Mon, 01 Oct 2018)
Changed paths:
M src/lxc/file_utils.c
M src/lxc/file_utils.h
Log Message:
-----------
file_utils: add lxc_recv_nointr()
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: ac59fd12900d64552d25c115901e11a0923505b3
https://github.com/lxc/lxc/commit/ac59fd12900d64552d25c115901e11a0923505b3
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2018-10-01 (Mon, 01 Oct 2018)
Changed paths:
M src/lxc/commands.c
M src/lxc/commands_utils.c
Log Message:
-----------
commands: switch to setting errno and returning -1
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Cc: Wolfgang Bumiller <w.bumiller at proxmox.com>
Commit: cb3cc8cf4521505585bb33543136ead58f4c99aa
https://github.com/lxc/lxc/commit/cb3cc8cf4521505585bb33543136ead58f4c99aa
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2018-10-01 (Mon, 01 Oct 2018)
Changed paths:
M src/lxc/log.h
Log Message:
-----------
log: do not clobber errno
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 8ab04f002470979c6c961dac1497b74a564db967
https://github.com/lxc/lxc/commit/8ab04f002470979c6c961dac1497b74a564db967
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2018-10-01 (Mon, 01 Oct 2018)
Changed paths:
M src/lxc/log.h
Log Message:
-----------
log: save errno on strerror_r()
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: d07aa0ecccb87467744516d21a91ae7dadbba263
https://github.com/lxc/lxc/commit/d07aa0ecccb87467744516d21a91ae7dadbba263
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2018-10-01 (Mon, 01 Oct 2018)
Changed paths:
M src/lxc/commands.c
M src/lxc/commands_utils.c
M src/lxc/network.c
Log Message:
-----------
tree-wide: s/recv()/lxc_recv_nointr()/g
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 712eb8033eb2bc18261d6613cf0488485e8247b1
https://github.com/lxc/lxc/commit/712eb8033eb2bc18261d6613cf0488485e8247b1
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2018-10-01 (Mon, 01 Oct 2018)
Changed paths:
M src/lxc/file_utils.c
M src/lxc/file_utils.h
Log Message:
-----------
file_utils: add lxc_send_nointr()
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: cc3c6011ba78a4e22c12d50444fb6b8e729d1d15
https://github.com/lxc/lxc/commit/cc3c6011ba78a4e22c12d50444fb6b8e729d1d15
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2018-10-01 (Mon, 01 Oct 2018)
Changed paths:
M src/lxc/commands.c
M src/lxc/network.c
M src/lxc/start.c
Log Message:
-----------
tree-wide: s/send()/lxc_send_nointr()/g
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: eed8c0ad133119972e5eda2aea132480faa7f51a
https://github.com/lxc/lxc/commit/eed8c0ad133119972e5eda2aea132480faa7f51a
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2018-10-01 (Mon, 01 Oct 2018)
Changed paths:
M src/lxc/network.c
M src/lxc/nl.c
M src/lxc/start.c
Log Message:
-----------
nl: save errno on lxc_netns_set_nsid()
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 17dd7e6e0c840cd4cc433f8b08326de0816fb7b7
https://github.com/lxc/lxc/commit/17dd7e6e0c840cd4cc433f8b08326de0816fb7b7
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2018-10-01 (Mon, 01 Oct 2018)
Changed paths:
M src/lxc/log.c
Log Message:
-----------
log: log_append_logfile() add new error path
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 7a6e1ccecb6492ec5369f3ac660f1ee8e0903737
https://github.com/lxc/lxc/commit/7a6e1ccecb6492ec5369f3ac660f1ee8e0903737
Author: 2xsec <dh48.jeong at samsung.com>
Date: 2018-10-01 (Mon, 01 Oct 2018)
Changed paths:
M src/lxc/lxccontainer.c
Log Message:
-----------
lxccontainer: fix dereferenced pointer
Signed-off-by: 2xsec <dh48.jeong at samsung.com>
Commit: 8f5dbd1492238537c63241437f792b6b9805ca97
https://github.com/lxc/lxc/commit/8f5dbd1492238537c63241437f792b6b9805ca97
Author: Fabrice Fontaine <fontaine.fabrice at gmail.com>
Date: 2018-10-01 (Mon, 01 Oct 2018)
Changed paths:
M configure.ac
Log Message:
-----------
lxc: fix build with --disable-werror
Fix #2592 by defining -Wvla -std=gnu11 even if --disable-werror is set
As -std=gnu11 is always set, bump requirement on gcc from 4.6 to 4.7
(see https://gcc.gnu.org/projects/cxx-status.html#cxx11)
Signed-off-by: Fabrice Fontaine <fontaine.fabrice at gmail.com>
Commit: 2b3062a0e68306b5e0958f03829d5f88700fe512
https://github.com/lxc/lxc/commit/2b3062a0e68306b5e0958f03829d5f88700fe512
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2018-10-01 (Mon, 01 Oct 2018)
Changed paths:
M src/lxc/cgroups/cgfsng.c
M src/lxc/macro.h
M src/lxc/utils.c
M src/lxc/utils.h
Log Message:
-----------
utils: improve get_ns_uid() and add get_ns_gid()
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: d4f21b92f60bf756aaabf4dc9294c2892875808e
https://github.com/lxc/lxc/commit/d4f21b92f60bf756aaabf4dc9294c2892875808e
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2018-10-01 (Mon, 01 Oct 2018)
Changed paths:
M src/lxc/utils.c
M src/lxc/utils.h
Log Message:
-----------
utils: improve lxc_switch_uid_gid()
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 068720a93d34fafeb481d01c394bc1aead675f2f
https://github.com/lxc/lxc/commit/068720a93d34fafeb481d01c394bc1aead675f2f
Author: 2xsec <dh48.jeong at samsung.com>
Date: 2018-10-01 (Mon, 01 Oct 2018)
Changed paths:
M configure.ac
M src/lxc/Makefile.am
M src/lxc/log.c
Log Message:
-----------
log: support dlog
Signed-off-by: 2xsec <dh48.jeong at samsung.com>
Commit: 9991e6df7605dd74fa73f5cf458ed2b7f06031e6
https://github.com/lxc/lxc/commit/9991e6df7605dd74fa73f5cf458ed2b7f06031e6
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2018-10-01 (Mon, 01 Oct 2018)
Changed paths:
M src/lxc/attach.c
Log Message:
-----------
attach: handle id switching smarter
For setup, switch to the most privileged ids we can find. That is either
nsuid 0 if a mapping has been established if not switch to the ids the
init running in the container was started with.
After setup, switch to the actual requested ids.
Closes #2591.
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 40dcd166b3a9d93130349a7ceb2dd16400899753
https://github.com/lxc/lxc/commit/40dcd166b3a9d93130349a7ceb2dd16400899753
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2018-10-01 (Mon, 01 Oct 2018)
Changed paths:
M src/lxc/start.c
Log Message:
-----------
start: avoid unnecessary syscalls
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 004637bb50ecbe4e667449dcf7a745f499558557
https://github.com/lxc/lxc/commit/004637bb50ecbe4e667449dcf7a745f499558557
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2018-10-01 (Mon, 01 Oct 2018)
Changed paths:
M src/lxc/attach.c
M src/lxc/cmd/lxc_usernsexec.c
M src/lxc/start.c
M src/lxc/storage/rsync.c
M src/lxc/utils.c
M src/lxc/utils.h
Log Message:
-----------
utils: make lxc_setgroups() return bool
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: b8287fca2283d2787a36889637082406dd177c1e
https://github.com/lxc/lxc/commit/b8287fca2283d2787a36889637082406dd177c1e
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2018-10-01 (Mon, 01 Oct 2018)
Changed paths:
M src/lxc/attach.c
M src/lxc/cmd/lxc_usernsexec.c
M src/lxc/start.c
M src/lxc/storage/rsync.c
M src/lxc/utils.c
M src/lxc/utils.h
Log Message:
-----------
utils: make lxc_switch_uid_gid() return bool
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 6bd905a862baaa78eab3f013232e7d7a39ce8f1f
https://github.com/lxc/lxc/commit/6bd905a862baaa78eab3f013232e7d7a39ce8f1f
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2018-10-01 (Mon, 01 Oct 2018)
Changed paths:
M src/lxc/lxccontainer.c
Log Message:
-----------
lxccontainer: use correct pid_t type
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 27095c2a0d3ca66b78725166ccc9c6d1cd5c6592
https://github.com/lxc/lxc/commit/27095c2a0d3ca66b78725166ccc9c6d1cd5c6592
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2018-10-01 (Mon, 01 Oct 2018)
Changed paths:
M src/lxc/conf.c
Log Message:
-----------
conf: remove extra MS_BIND with sysfs:mixed
The extra bind-mount is not required. To succesfully remount read-only
we just need MS_REMOUNT|MS_RDONLY.
Closes #2602.
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Cc: Serge Hallyn <serge at hallyn.com>
Commit: b4c5f409155d3dad4e96d3e83e7e78939de292b3
https://github.com/lxc/lxc/commit/b4c5f409155d3dad4e96d3e83e7e78939de292b3
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2018-10-01 (Mon, 01 Oct 2018)
Changed paths:
M src/lxc/network.c
Log Message:
-----------
network: use correct type in lxc_netns_set_nsid()
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: c4d30a9740a86be68dbafef086cbf5818f6645f9
https://github.com/lxc/lxc/commit/c4d30a9740a86be68dbafef086cbf5818f6645f9
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2018-10-01 (Mon, 01 Oct 2018)
Changed paths:
M src/lxc/macro.h
M src/lxc/network.c
M src/lxc/network.h
Log Message:
-----------
network: add lxc_netns_get_nsid()
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 490f169639068b2c6b59c86d5292869dd853fdd6
https://github.com/lxc/lxc/commit/490f169639068b2c6b59c86d5292869dd853fdd6
Author: 2xsec <dh48.jeong at samsung.com>
Date: 2018-10-01 (Mon, 01 Oct 2018)
Changed paths:
M src/lxc/file_utils.c
M src/lxc/storage/rsync.c
Log Message:
-----------
remove unused variables
Signed-off-by: 2xsec <dh48.jeong at samsung.com>
Commit: 3b462454f1429edee97d29efdb6e23f13753759c
https://github.com/lxc/lxc/commit/3b462454f1429edee97d29efdb6e23f13753759c
Author: 2xsec <dh48.jeong at samsung.com>
Date: 2018-10-01 (Mon, 01 Oct 2018)
Changed paths:
M src/lxc/file_utils.c
Log Message:
-----------
file_utils: remove unused function
Signed-off-by: 2xsec <dh48.jeong at samsung.com>
Commit: 7ac00919f9c4ac46f357723f4a232da5ee691455
https://github.com/lxc/lxc/commit/7ac00919f9c4ac46f357723f4a232da5ee691455
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2018-10-01 (Mon, 01 Oct 2018)
Changed paths:
M src/lxc/network.c
Log Message:
-----------
network: minor tweaks
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: aa074e3ba228a08b49749e5e2d43a881148e29c6
https://github.com/lxc/lxc/commit/aa074e3ba228a08b49749e5e2d43a881148e29c6
Author: 2xsec <dh48.jeong at samsung.com>
Date: 2018-10-01 (Mon, 01 Oct 2018)
Changed paths:
M lxc.spec.in
M src/lxc/Makefile.am
Log Message:
-----------
add compile flags for dlog
Signed-off-by: 2xsec <dh48.jeong at samsung.com>
Commit: 93bf710853e586aa49eb124ae7ba9d1ae8616de4
https://github.com/lxc/lxc/commit/93bf710853e586aa49eb124ae7ba9d1ae8616de4
Author: 2xsec <dh48.jeong at samsung.com>
Date: 2018-10-01 (Mon, 01 Oct 2018)
Changed paths:
M src/lxc/log.c
Log Message:
-----------
log: add common functions
Signed-off-by: 2xsec <dh48.jeong at samsung.com>
Commit: 97dd9582f92729fd7d1227934afb74955d4c7be6
https://github.com/lxc/lxc/commit/97dd9582f92729fd7d1227934afb74955d4c7be6
Author: 2xsec <dh48.jeong at samsung.com>
Date: 2018-10-01 (Mon, 01 Oct 2018)
Changed paths:
M src/lxc/log.c
Log Message:
-----------
log: add additional info of dlog
Signed-off-by: 2xsec <dh48.jeong at samsung.com>
Commit: 8cf8e2e32a7b92e5d730d3aeaa934352496a00f9
https://github.com/lxc/lxc/commit/8cf8e2e32a7b92e5d730d3aeaa934352496a00f9
Author: Stephen Barber <smbarber at chromium.org>
Date: 2018-10-01 (Mon, 01 Oct 2018)
Changed paths:
M src/lxc/attach.c
Log Message:
-----------
attach: don't shutdown ipc socket in child
shutdown() affects sockets even across forked processes. The
attached child process doesn't have any interest in using the
IPC socket, so just close it in the child process and let the
intermediate process handle shutting it down.
This fixes a bug seen with lxc exec in crbug.com/884244
Signed-off-by: Stephen Barber <smbarber at chromium.org>
Commit: 06ff7fffb0f77b20216cb040bda1d665a57b60e7
https://github.com/lxc/lxc/commit/06ff7fffb0f77b20216cb040bda1d665a57b60e7
Author: 2xsec <dh48.jeong at samsung.com>
Date: 2018-10-01 (Mon, 01 Oct 2018)
Changed paths:
M src/lxc/conf.c
M src/lxc/lxccontainer.c
M src/lxc/tools/lxc_unshare.c
Log Message:
-----------
security: fix too wide or inconsistent non-owner permissions
Signed-off-by: 2xsec <dh48.jeong at samsung.com>
Commit: 8397a1e643f5f7d9d657d2d1c943ba984b35b2a1
https://github.com/lxc/lxc/commit/8397a1e643f5f7d9d657d2d1c943ba984b35b2a1
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2018-10-01 (Mon, 01 Oct 2018)
Changed paths:
M src/lxc/attach.c
Log Message:
-----------
attach: report standard shell exit codes
POSIX mandates that on ENOEXEC 126 and on ENOENT 127 is supposed to be
reported.
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: db894c062a6cbc8a0ebbfbc97923c3fde952c0af
https://github.com/lxc/lxc/commit/db894c062a6cbc8a0ebbfbc97923c3fde952c0af
Author: 2xsec <dh48.jeong at samsung.com>
Date: 2018-10-01 (Mon, 01 Oct 2018)
Changed paths:
M src/lxc/af_unix.c
Log Message:
-----------
af_unix: add function to remove duplicated codes for set sockaddr
Signed-off-by: 2xsec <dh48.jeong at samsung.com>
Commit: 2cac430487814a233e2e15cfe4344fabdf747835
https://github.com/lxc/lxc/commit/2cac430487814a233e2e15cfe4344fabdf747835
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2018-10-01 (Mon, 01 Oct 2018)
Changed paths:
M src/lxc/lxccontainer.c
Log Message:
-----------
lxccontainer: remove locks from set_cgroup_item()
The on-disk config file is not altered and the in-memory config isn't
altered so no need for locking.
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: c55c6a16213b694e98e39af650f75a48553fe634
https://github.com/lxc/lxc/commit/c55c6a16213b694e98e39af650f75a48553fe634
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2018-10-01 (Mon, 01 Oct 2018)
Changed paths:
M src/lxc/lxccontainer.c
Log Message:
-----------
lxccontainer: remove locks from get_cgroup_item()
The on-disk config file is not altered and the in-memory config isn't
altered so no need for locking.
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 7d9fe250298cae5405a9b13b8d8fa6e9bf2962a2
https://github.com/lxc/lxc/commit/7d9fe250298cae5405a9b13b8d8fa6e9bf2962a2
Author: Cameron Nemo <camerontnorman at gmail.com>
Date: 2018-10-01 (Mon, 01 Oct 2018)
Changed paths:
M .gitignore
M config/apparmor/Makefile.am
R config/apparmor/abstractions/start-container
A config/apparmor/abstractions/start-container.in
M configure.ac
Log Message:
-----------
apparmor: account for specified rootfs path (closes #2617)
Signed-off-by: Cameron Nemo <camerontnorman at gmail.com>
Commit: f3774012bc793c18430115e7a6bc767222f79093
https://github.com/lxc/lxc/commit/f3774012bc793c18430115e7a6bc767222f79093
Author: 2xsec <dh48.jeong at samsung.com>
Date: 2018-10-01 (Mon, 01 Oct 2018)
Changed paths:
M src/lxc/conf.c
Log Message:
-----------
conf: realpath() uses null as second parameter to prevent buffer overflow
Signed-off-by: 2xsec <dh48.jeong at samsung.com>
Commit: 4bb538ce4071b80f44574029dbaeaafca490440c
https://github.com/lxc/lxc/commit/4bb538ce4071b80f44574029dbaeaafca490440c
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2018-10-01 (Mon, 01 Oct 2018)
Changed paths:
M src/lxc/execute.c
M src/lxc/lxc.h
M src/lxc/start.c
M src/lxc/start.h
Log Message:
-----------
start: s/backgrounded/daemonize/g
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: d0308f0c3bd9f02546de7ac5d3b43580989338b3
https://github.com/lxc/lxc/commit/d0308f0c3bd9f02546de7ac5d3b43580989338b3
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2018-10-01 (Mon, 01 Oct 2018)
Changed paths:
M src/lxc/cgroups/cgfsng.c
Log Message:
-----------
cgfsng: mark ops with __cgfsng_ops__ attribute
Helps to easily tell the cgfsng ops functions from helpers.
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: a5a0ca05b69880c53ffa2cec9f8b674c6b080f47
https://github.com/lxc/lxc/commit/a5a0ca05b69880c53ffa2cec9f8b674c6b080f47
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2018-10-01 (Mon, 01 Oct 2018)
Changed paths:
M CODING_STYLE.md
A config/ax_check_compile_flag.m4
M configure.ac
M src/lxc/attach.c
M src/lxc/cmd/lxc_init.c
M src/lxc/compiler.h
M src/lxc/tools/arguments.c
Log Message:
-----------
autotools: add -Wimplicit-fallthrough
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 3ec9a308df2face30bd03b733718119733e6a38d
https://github.com/lxc/lxc/commit/3ec9a308df2face30bd03b733718119733e6a38d
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2018-10-01 (Mon, 01 Oct 2018)
Changed paths:
M src/lxc/cgroups/cgfsng.c
M src/lxc/cgroups/cgroup.h
M src/lxc/criu.c
M src/lxc/start.c
Log Message:
-----------
cgroup: rename container specific cgroup functions
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 9f238864dba2a04b47c62958c96f423fd1dc40ad
https://github.com/lxc/lxc/commit/9f238864dba2a04b47c62958c96f423fd1dc40ad
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2018-10-01 (Mon, 01 Oct 2018)
Changed paths:
M src/lxc/cgroups/cgfsng.c
M src/lxc/cgroups/cgroup.c
M src/lxc/cgroups/cgroup.h
Log Message:
-----------
cgroups: s/fullcgpath/container_full_path/g
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 984dec41bf8e42f4c88bca795e946ea85e187d01
https://github.com/lxc/lxc/commit/984dec41bf8e42f4c88bca795e946ea85e187d01
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2018-10-01 (Mon, 01 Oct 2018)
Changed paths:
M src/lxc/cgroups/cgroup.c
Log Message:
-----------
cgroups: add missing string.h include
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 1537e2c38718a7570c3764fb7a059178ddfef5da
https://github.com/lxc/lxc/commit/1537e2c38718a7570c3764fb7a059178ddfef5da
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2018-10-01 (Mon, 01 Oct 2018)
Changed paths:
M src/lxc/cgroups/cgfsng.c
M src/lxc/cgroups/cgroup.c
M src/lxc/cgroups/cgroup.h
Log Message:
-----------
cgroups: s/base_cgroup/container_base_path/g
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: a3f3659b4e1551bf1e2bf61acfdf7bd902cec0ae
https://github.com/lxc/lxc/commit/a3f3659b4e1551bf1e2bf61acfdf7bd902cec0ae
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2018-10-01 (Mon, 01 Oct 2018)
Changed paths:
M configure.ac
Log Message:
-----------
autotools: fix wrong AX_CHECK_COMPILE_FLAG test
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: bc1462e2a00c959b6c69658bc8a9176c71ea83b9
https://github.com/lxc/lxc/commit/bc1462e2a00c959b6c69658bc8a9176c71ea83b9
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2018-10-01 (Mon, 01 Oct 2018)
Changed paths:
M src/lxc/compiler.h
Log Message:
-----------
compiler: s/__fallthrough__/__fallthrough/g
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 78fdc1cff1ed845c2b35cb43811a0d9f66b00078
https://github.com/lxc/lxc/commit/78fdc1cff1ed845c2b35cb43811a0d9f66b00078
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2018-10-01 (Mon, 01 Oct 2018)
Changed paths:
M src/lxc/cmd/lxc_init.c
M src/lxc/compiler.h
M src/lxc/tools/arguments.c
Log Message:
-----------
compiler: s/__noreturn__/__noreturn/g
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 4cbbb1357ec15c8979ab9131eea2316a8786c4ee
https://github.com/lxc/lxc/commit/4cbbb1357ec15c8979ab9131eea2316a8786c4ee
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2018-10-01 (Mon, 01 Oct 2018)
Changed paths:
M src/lxc/cgroups/cgfsng.c
M src/lxc/compiler.h
Log Message:
-----------
cgfsng: s/__cgfsng_ops__/__cgfsng_ops/g
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: b4616616ebced1accb141640bfab56570f165e5c
https://github.com/lxc/lxc/commit/b4616616ebced1accb141640bfab56570f165e5c
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2018-10-01 (Mon, 01 Oct 2018)
Changed paths:
M src/lxc/macro.h
Log Message:
-----------
macro: add STRLITERALLEN() and STRARRAYLEN()
sizeof() implementation for string literals and string arrays that makes
it behave like strlen() for strings.
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: a111dc9fa97ce4e32f43c118407dba79859cf2de
https://github.com/lxc/lxc/commit/a111dc9fa97ce4e32f43c118407dba79859cf2de
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2018-10-01 (Mon, 01 Oct 2018)
Changed paths:
M src/lxc/caps.c
M src/lxc/cgroups/cgfsng.c
M src/lxc/conf.c
M src/lxc/confile.c
M src/lxc/confile_utils.c
M src/lxc/log.c
M src/lxc/lxclock.c
M src/lxc/storage/overlay.c
Log Message:
-----------
tree-wide: replace sizeof() with SIZEOF2STRLEN()
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 1fafbd94cba51c79d5f4d2fe6a0073dbbb71f566
https://github.com/lxc/lxc/commit/1fafbd94cba51c79d5f4d2fe6a0073dbbb71f566
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2018-10-01 (Mon, 01 Oct 2018)
Changed paths:
M src/lxc/compiler.h
Log Message:
-----------
compiler: __attribute__((noreturn)) on bionic
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 047cf9b8634b8d582023d16d18aa9db9e05f2a66
https://github.com/lxc/lxc/commit/047cf9b8634b8d582023d16d18aa9db9e05f2a66
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2018-10-01 (Mon, 01 Oct 2018)
Changed paths:
M configure.ac
M src/include/ifaddrs.c
M src/lxc/lxccontainer.c
M src/lxc/network.c
M src/lxc/rtnl.c
Log Message:
-----------
autotools: support -Wcast-align
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 9b3475ac61750e19e5bef9779b48efdad1b44844
https://github.com/lxc/lxc/commit/9b3475ac61750e19e5bef9779b48efdad1b44844
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2018-10-01 (Mon, 01 Oct 2018)
Changed paths:
M configure.ac
M src/lxc/log.h
Log Message:
-----------
autotools: support -Wstrict-prototypes
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: c504d32f4697281e8413a22b14cc24f032e33578
https://github.com/lxc/lxc/commit/c504d32f4697281e8413a22b14cc24f032e33578
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2018-10-01 (Mon, 01 Oct 2018)
Changed paths:
R src/include/ifaddrs.c
R src/include/ifaddrs.h
A src/include/netns_ifaddrs.c
A src/include/netns_ifaddrs.h
M src/lxc/Makefile.am
M src/lxc/macro.h
M src/lxc/network.c
M src/lxc/nl.c
M src/lxc/nl.h
Log Message:
-----------
network: add netns_getifaddrs() implementation
This commit introduces my concept of a network namespace aware
getifaddrs(), i.e. netns_getifaddrs(). This presupposes a kernel that
carries my IF{L}A_TARGET_NETNSID patches:
struct netns_ifaddrs {
struct netns_ifaddrs *ifa_next;
/* Can - but shouldn't be - NULL. */
char *ifa_name;
/* This field is not present struct ifaddrs. */
int ifa_ifindex;
unsigned ifa_flags;
/* This field is not present struct ifaddrs. */
int ifa_mtu;
/* This field is not present struct ifaddrs. */
int ifa_prefixlen;
struct sockaddr *ifa_addr;
struct sockaddr *ifa_netmask;
union {
struct sockaddr *ifu_broadaddr;
struct sockaddr *ifu_dstaddr;
} ifa_ifu;
/* If you don't know what this is for don't touch it. */
void *ifa_data;
};
which is a superset of struct ifaddrs. It contains additional
information such as the mtu, ifindex of the interface and the prefix
length of the address.
Note that the field ordering is different. So don't get any ideas of
using memcpy() to copy from an old struct ifaddrs into a struct
netns_ifaddrs.
int netns_getifaddrs(struct netns_ifaddrs **ifap, __s32 netns_id, bool *netnsid_aware)
takes a network namespace identifier as argument which identifies the
target network namespace.
If successfull, i.e. netns_getifaddrs() returns 0, callers should check
the bool *netnsid_aware return argument. If it is true then
RTM_GET{ADDR,LINK} requests are fully netnsid aware. If it is false then
they are not and the information returned in struct netns_ifaddrs does
*not* contain correct information about the target network namespace
identified by netnsid.
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 7cd53b4c82ca4873166391824dd3ceabf5e27ab6
https://github.com/lxc/lxc/commit/7cd53b4c82ca4873166391824dd3ceabf5e27ab6
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2018-10-01 (Mon, 01 Oct 2018)
Changed paths:
M src/lxc/confile.c
M src/lxc/lxccontainer.c
M src/lxc/network.c
M src/lxc/tools/lxc_device.c
Log Message:
-----------
tree_wide: switch to netns_getifaddrs()
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 21fb5be3df219a62692ee08b4bb895b15ade6760
https://github.com/lxc/lxc/commit/21fb5be3df219a62692ee08b4bb895b15ade6760
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2018-10-01 (Mon, 01 Oct 2018)
Changed paths:
M src/include/netns_ifaddrs.c
Log Message:
-----------
netns_ifaddrs: mark casts as safe
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 563f484ac6ae476cad0ecf1aa52d67eb28a24307
https://github.com/lxc/lxc/commit/563f484ac6ae476cad0ecf1aa52d67eb28a24307
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2018-10-01 (Mon, 01 Oct 2018)
Changed paths:
M src/lxc/Makefile.am
Log Message:
-----------
autotools: fix lxc_user_nic build
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 4adc0d84ae58de6330eaeb74d94c67b2a172be76
https://github.com/lxc/lxc/commit/4adc0d84ae58de6330eaeb74d94c67b2a172be76
Author: Stéphane Graber <stgraber at ubuntu.com>
Date: 2018-10-01 (Mon, 01 Oct 2018)
Changed paths:
M src/lxc/commands.c
Log Message:
-----------
stop: Only freeze if freezer is available
Closes #2644
Signed-off-by: Stéphane Graber <stgraber at ubuntu.com>
Commit: d80ec04e8f9530fca2dc8b5e5287ef2193a3c1ca
https://github.com/lxc/lxc/commit/d80ec04e8f9530fca2dc8b5e5287ef2193a3c1ca
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2018-10-01 (Mon, 01 Oct 2018)
Changed paths:
M doc/ja/lxc-attach.sgml.in
M doc/ja/lxc-unshare.sgml.in
M doc/ko/lxc-attach.sgml.in
M doc/ko/lxc-unshare.sgml.in
M doc/lxc-attach.sgml.in
M doc/lxc-unshare.sgml.in
Log Message:
-----------
doc: tweak documentation a little
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 5576e5fa5b815141c85395cfebbed4fc140ef249
https://github.com/lxc/lxc/commit/5576e5fa5b815141c85395cfebbed4fc140ef249
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2018-10-01 (Mon, 01 Oct 2018)
Changed paths:
M src/lxc/cgroups/cgfsng.c
M src/lxc/cgroups/cgroup.h
M src/lxc/commands.c
Log Message:
-----------
cgfsng: set errno to ENOENT on get_hierarchy()
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: f194a4bfe1b5316f47147d2233de538db2eec580
https://github.com/lxc/lxc/commit/f194a4bfe1b5316f47147d2233de538db2eec580
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2018-10-01 (Mon, 01 Oct 2018)
Changed paths:
M src/lxc/cgroups/cgfsng.c
Log Message:
-----------
cgfsng: s/cgfsng_destroy/cgfsng_payload_destroy/g
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 52a11c3c961b03d51002318f86cb46e6c7235a54
https://github.com/lxc/lxc/commit/52a11c3c961b03d51002318f86cb46e6c7235a54
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2018-10-01 (Mon, 01 Oct 2018)
Changed paths:
M src/lxc/cgroups/cgfsng.c
Log Message:
-----------
cgfsng: s/25/INTTYPE_TO_STRLEN(pid_t)/g
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 0b35ed87a768ba6b13aead891de9a4b6926d5bc5
https://github.com/lxc/lxc/commit/0b35ed87a768ba6b13aead891de9a4b6926d5bc5
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2018-10-01 (Mon, 01 Oct 2018)
Changed paths:
M src/lxc/compiler.h
Log Message:
-----------
compiler: fix __noreturn on bionic
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: fd63cb7c5a5b510ada1c9c8fcbb6d133670e397b
https://github.com/lxc/lxc/commit/fd63cb7c5a5b510ada1c9c8fcbb6d133670e397b
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2018-10-01 (Mon, 01 Oct 2018)
Changed paths:
M src/lxc/compiler.h
M src/lxc/confile.c
M src/lxc/parse.h
Log Message:
-----------
compiler: add __hot attribute
This instructs the compiler to better optimize the config parsing code.
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: a7d0477c8a993bdc244aecc41da5e2885eb2472b
https://github.com/lxc/lxc/commit/a7d0477c8a993bdc244aecc41da5e2885eb2472b
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2018-10-01 (Mon, 01 Oct 2018)
Changed paths:
M src/include/netns_ifaddrs.c
M src/include/netns_ifaddrs.h
Log Message:
-----------
netns_ifaddrs: fix missing include
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 894556faee97934c09445f92697f224521587767
https://github.com/lxc/lxc/commit/894556faee97934c09445f92697f224521587767
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2018-10-01 (Mon, 01 Oct 2018)
Changed paths:
M configure.ac
M src/lxc/Makefile.am
Log Message:
-----------
autools: prevent dlog build on stable branch
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Compare: https://github.com/lxc/lxc/compare/1d2bdf44e433...894556faee97
**NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/
Functionality will be removed from GitHub.com on January 31st, 2019.
More information about the lxc-devel
mailing list