[lxc-devel] [lxc/lxc] 3999f5: cgfsng: s/cgfsng_destroy/cgfsng_payload_destroy/g

GitHub noreply at github.com
Thu Sep 27 11:12:58 UTC 2018


  Branch: refs/heads/master
  Home:   https://github.com/lxc/lxc
  Commit: 3999f50bd2a86ad897fe267b99a676cc7a4a7fe8
      https://github.com/lxc/lxc/commit/3999f50bd2a86ad897fe267b99a676cc7a4a7fe8
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-09-26 (Wed, 26 Sep 2018)

  Changed paths:
    M src/lxc/cgroups/cgfsng.c

  Log Message:
  -----------
  cgfsng: s/cgfsng_destroy/cgfsng_payload_destroy/g

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: 434c8e15c9821bce65d3bc1eefae0ecfa843ef1e
      https://github.com/lxc/lxc/commit/434c8e15c9821bce65d3bc1eefae0ecfa843ef1e
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-09-26 (Wed, 26 Sep 2018)

  Changed paths:
    M src/lxc/cgroups/cgfsng.c
    M src/lxc/cgroups/cgroup.h
    M src/lxc/start.c
    M src/lxc/start.h

  Log Message:
  -----------
  cgfsng: add cgfsng_monitor_destroy()

Since we switched to the new cgroup scoping scheme that places the
container payload into lxc.payload/<container-name> and
lxc.monitor/<container-name> deletion becomes slightly more complicated.
The monitor will be able to rm_rf(lxc.payload/<container-name>) but will
not be able to rm_rf(lxc.monitor/<container-name>) since it will be
located in that cgroup and it will thus be populated.
My current solution to this is to create a lxc.pivot cgroup that only
exists so that the monitor process on container stop can pivot into it,
call rm_rf(lxc.monitor/<container-name>) and can then exit. This group
has not function whatsoever apart from this and can thus be shared by
all monitor processes.

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: 625ad37b595868abb9c82fcf8665f2b4af522b5c
      https://github.com/lxc/lxc/commit/625ad37b595868abb9c82fcf8665f2b4af522b5c
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-09-26 (Wed, 26 Sep 2018)

  Changed paths:
    M src/lxc/cgroups/cgfsng.c
    M src/lxc/cgroups/cgroup.c
    M src/lxc/cgroups/cgroup.h

  Log Message:
  -----------
  cgroups: introduce helper macros

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: 5ce03bc048212feae5de5a3f41fe189bb7f9ee58
      https://github.com/lxc/lxc/commit/5ce03bc048212feae5de5a3f41fe189bb7f9ee58
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-09-26 (Wed, 26 Sep 2018)

  Changed paths:
    M src/lxc/cgroups/cgfsng.c

  Log Message:
  -----------
  cgfsng: ensure no-reuse in cgfsng_monitor_create()

The same way we need to ensure that no existing cgroups are reused for
the payload in cgfsng_payload_create() we need to ensure that no
existing cgroups are reused for the monitor. Technially this is less of
an issue since there currently is no logic for the monitor to apply
limits to its cgroup but it is still the proper way to do it.

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: a3650c0c4d54aa09ac8a18a768dbae37d4733801
      https://github.com/lxc/lxc/commit/a3650c0c4d54aa09ac8a18a768dbae37d4733801
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-09-26 (Wed, 26 Sep 2018)

  Changed paths:
    M src/lxc/cgroups/cgfsng.c

  Log Message:
  -----------
  cgfsng: s/25/INTTYPE_TO_STRLEN(pid_t)/g

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: ebc10afe213872d92c3d4641e34e6bd3c6d826be
      https://github.com/lxc/lxc/commit/ebc10afe213872d92c3d4641e34e6bd3c6d826be
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-09-26 (Wed, 26 Sep 2018)

  Changed paths:
    M src/lxc/cgroups/cgfsng.c

  Log Message:
  -----------
  cgfsng: do not go into infinite loop

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: adaeef1fcc8678ee9870459c5d6136f3519ef4bb
      https://github.com/lxc/lxc/commit/adaeef1fcc8678ee9870459c5d6136f3519ef4bb
  Author: Wolfgang Bumiller <w.bumiller at proxmox.com>
  Date:   2018-09-27 (Thu, 27 Sep 2018)

  Changed paths:
    M src/lxc/cgroups/cgfsng.c
    M src/lxc/cgroups/cgroup.c
    M src/lxc/cgroups/cgroup.h
    M src/lxc/start.c
    M src/lxc/start.h

  Log Message:
  -----------
  Merge pull request #2643 from brauner/2018-09-23/cgroup_scoping_fixes

cgroups: implement monitor cgroup deletion


Compare: https://github.com/lxc/lxc/compare/537eba4c30be...adaeef1fcc86
      **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.


More information about the lxc-devel mailing list