[lxc-devel] [lxc/lxc] 5dc59a: attach: don't shutdown ipc socket in child

GitHub noreply at github.com
Tue Sep 18 15:24:48 UTC 2018


  Branch: refs/heads/master
  Home:   https://github.com/lxc/lxc
  Commit: 5dc59a075516ccbcdd6333d6630d6fee578f5fe0
      https://github.com/lxc/lxc/commit/5dc59a075516ccbcdd6333d6630d6fee578f5fe0
  Author: Stephen Barber <smbarber at chromium.org>
  Date:   2018-09-17 (Mon, 17 Sep 2018)

  Changed paths:
    M src/lxc/attach.c

  Log Message:
  -----------
  attach: don't shutdown ipc socket in child

shutdown() affects sockets even across forked processes. The
attached child process doesn't have any interest in using the
IPC socket, so just close it in the child process and let the
intermediate process handle shutting it down.

This fixes a bug seen with lxc exec in crbug.com/884244

Signed-off-by: Stephen Barber <smbarber at chromium.org>


  Commit: ee3d71040d54df6f9d1fdabdd60c4fdbb96eb9b0
      https://github.com/lxc/lxc/commit/ee3d71040d54df6f9d1fdabdd60c4fdbb96eb9b0
  Author: Christian Brauner <christian at brauner.io>
  Date:   2018-09-18 (Tue, 18 Sep 2018)

  Changed paths:
    M src/lxc/attach.c

  Log Message:
  -----------
  Merge pull request #2619 from smibarber/attach-shutdown

attach: don't shutdown ipc socket in child


Compare: https://github.com/lxc/lxc/compare/de6af06271e1...ee3d71040d54
      **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.


More information about the lxc-devel mailing list