[lxc-devel] [lxc/lxc] 33eb2e: confile: do not overwrite global variable

Mon Oct 22 19:31:02 UTC 2018

  Branch: refs/heads/master
  Home:   https://github.com/lxc/lxc
  Commit: 33eb2ec1862579b535cbc99db08c09f835bdba6d
      https://github.com/lxc/lxc/commit/33eb2ec1862579b535cbc99db08c09f835bdba6d
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-10-22 (Mon, 22 Oct 2018)

  Changed paths:
    M src/lxc/confile.c

  Log Message:
  -----------
  confile: do not overwrite global variable

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: 00e5ca13848704f936bf822003f5976fe1cf4f63
      https://github.com/lxc/lxc/commit/00e5ca13848704f936bf822003f5976fe1cf4f63
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-10-22 (Mon, 22 Oct 2018)

  Changed paths:
    M src/lxc/commands.c

  Log Message:
  -----------
  commands: simplify

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: edae86e922420b11a55932eb446b4cbeed48c9f1
      https://github.com/lxc/lxc/commit/edae86e922420b11a55932eb446b4cbeed48c9f1
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-10-22 (Mon, 22 Oct 2018)

  Changed paths:
    M src/lxc/cgroups/cgfsng.c

  Log Message:
  -----------
  cgfsng: move increment out of branch

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: 632ac690a9fc20c24c4b28d335a17750a22c5661
      https://github.com/lxc/lxc/commit/632ac690a9fc20c24c4b28d335a17750a22c5661
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-10-22 (Mon, 22 Oct 2018)

  Changed paths:
    M src/lxc/cmd/lxc_monitord.c

  Log Message:
  -----------
  monitord: do not hide global variable

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: f3c348587d068dcad30dffcc01f1bab291ce3570
      https://github.com/lxc/lxc/commit/f3c348587d068dcad30dffcc01f1bab291ce3570
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-10-22 (Mon, 22 Oct 2018)

  Changed paths:
    M src/lxc/tools/lxc_copy.c

  Log Message:
  -----------
  tools/lxc_copy: do not hide global variable

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: 551105ff4639d1f64c97d6dd50dc30534e575c4a
      https://github.com/lxc/lxc/commit/551105ff4639d1f64c97d6dd50dc30534e575c4a
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-10-22 (Mon, 22 Oct 2018)

  Changed paths:
    M src/lxc/tools/lxc_top.c

  Log Message:
  -----------
  tools/lxc_top: do not hide global variable

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: e69abbb1fa8a3e3806da913291121783c103adfd
      https://github.com/lxc/lxc/commit/e69abbb1fa8a3e3806da913291121783c103adfd
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-10-22 (Mon, 22 Oct 2018)

  Changed paths:
    M src/lxc/tools/lxc_info.c

  Log Message:
  -----------
  tools/lxc_info: do not hide global variable

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: 961b6f44314f320cbb96579869166cc21b73c995
      https://github.com/lxc/lxc/commit/961b6f44314f320cbb96579869166cc21b73c995
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-10-22 (Mon, 22 Oct 2018)

  Changed paths:
    M src/lxc/state.c

  Log Message:
  -----------
  state: remove tautological check

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: e2d0c21b9a4d3cd0c114145c3ed18743abf440cd
      https://github.com/lxc/lxc/commit/e2d0c21b9a4d3cd0c114145c3ed18743abf440cd
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-10-22 (Mon, 22 Oct 2018)

  Changed paths:
    M src/lxc/conf.c

  Log Message:
  -----------
  conf: remove tautological check

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: 7806ebd74f88426ac88838224db74d157bad0f7c
      https://github.com/lxc/lxc/commit/7806ebd74f88426ac88838224db74d157bad0f7c
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-10-22 (Mon, 22 Oct 2018)

  Changed paths:
    M src/lxc/conf.c

  Log Message:
  -----------
  conf: use O_CLOEXEC in lxc_pivot_root()

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: 3695b24384b71662a1225f6cc25f702667fbbe38
      https://github.com/lxc/lxc/commit/3695b24384b71662a1225f6cc25f702667fbbe38
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-10-22 (Mon, 22 Oct 2018)

  Changed paths:
    M src/lxc/conf.c

  Log Message:
  -----------
  conf: remove tautological check

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: b20e0599c64d64d877460f759b33ad526f82d3ee
      https://github.com/lxc/lxc/commit/b20e0599c64d64d877460f759b33ad526f82d3ee
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-10-22 (Mon, 22 Oct 2018)

  Changed paths:
    M src/lxc/lxccontainer.c

  Log Message:
  -----------
  lxccontainer: remove check from goto target

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: 8157e43740317612207e7bf0304c272638658d53
      https://github.com/lxc/lxc/commit/8157e43740317612207e7bf0304c272638658d53
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-10-22 (Mon, 22 Oct 2018)

  Changed paths:
    M src/lxc/start.c

  Log Message:
  -----------
  start: prevent values smaller 0

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: 489b0b2913ae464ca9f4bd50956910d316d20daf
      https://github.com/lxc/lxc/commit/489b0b2913ae464ca9f4bd50956910d316d20daf
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-10-22 (Mon, 22 Oct 2018)

  Changed paths:
    M src/lxc/tools/lxc_stop.c

  Log Message:
  -----------
  tools/lxc_stop: use correct check

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: c837120231c1c9fa4b54ea0d72e6c00dfbf97f0d
      https://github.com/lxc/lxc/commit/c837120231c1c9fa4b54ea0d72e6c00dfbf97f0d
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-10-22 (Mon, 22 Oct 2018)

  Changed paths:
    M src/lxc/cmd/lxc_init.c

  Log Message:
  -----------
  cmd/lxc_init: do not hide global variable

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: 637d38f2465eda9bfb0f56e43c99ba39bbe09e70
      https://github.com/lxc/lxc/commit/637d38f2465eda9bfb0f56e43c99ba39bbe09e70
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-10-22 (Mon, 22 Oct 2018)

  Changed paths:
    M src/lxc/confile.c

  Log Message:
  -----------
  coverity: #1440391

Dereference null return value

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: 7d60776a32900598c75e7dace6787e70ab0593af
      https://github.com/lxc/lxc/commit/7d60776a32900598c75e7dace6787e70ab0593af
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-10-22 (Mon, 22 Oct 2018)

  Changed paths:
    M src/include/netns_ifaddrs.c

  Log Message:
  -----------
  coverity: #1440389

Logically dead code

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: 6d61f17dd64de9b030adf0e0ab0ed1b56b999603
      https://github.com/lxc/lxc/commit/6d61f17dd64de9b030adf0e0ab0ed1b56b999603
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-10-22 (Mon, 22 Oct 2018)

  Changed paths:
    M src/lxc/criu.c

  Log Message:
  -----------
  coverity: #1426130

Bad bit shift operation

Fixes: commit b5b12b9e759 ("criu: add feature check capability")
Cc: Adrian Reber <areber at redhat.com>
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: f8f1069a8d7e4a4d3d507a07df591ee9ebeb4737
      https://github.com/lxc/lxc/commit/f8f1069a8d7e4a4d3d507a07df591ee9ebeb4737
  Author: Serge Hallyn <serge at hallyn.com>
  Date:   2018-10-22 (Mon, 22 Oct 2018)

  Changed paths:
    M src/include/netns_ifaddrs.c
    M src/lxc/cgroups/cgfsng.c
    M src/lxc/cmd/lxc_init.c
    M src/lxc/cmd/lxc_monitord.c
    M src/lxc/commands.c
    M src/lxc/conf.c
    M src/lxc/confile.c
    M src/lxc/criu.c
    M src/lxc/lxccontainer.c
    M src/lxc/start.c
    M src/lxc/state.c
    M src/lxc/tools/lxc_copy.c
    M src/lxc/tools/lxc_info.c
    M src/lxc/tools/lxc_stop.c
    M src/lxc/tools/lxc_top.c

  Log Message:
  -----------
  Merge pull request #2707 from brauner/2018-10-20/code_quality

tree-wide: bugfixes


Compare: https://github.com/lxc/lxc/compare/2a08398569f0...f8f1069a8d7e
      **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.