[lxc-devel] [lxc/lxc] d2af43: confile: remove unused variable

GitHub noreply at github.com
Fri Oct 12 19:42:53 UTC 2018


  Branch: refs/heads/stable-3.0
  Home:   https://github.com/lxc/lxc
  Commit: d2af43e59dde097699ca0fdfc4dcb5ba5ab3a0fe
      https://github.com/lxc/lxc/commit/d2af43e59dde097699ca0fdfc4dcb5ba5ab3a0fe
  Author: 2xsec <dh48.jeong at samsung.com>
  Date:   2018-10-12 (Fri, 12 Oct 2018)

  Changed paths:
    M src/lxc/confile.c

  Log Message:
  -----------
  confile: remove unused variable

Signed-off-by: 2xsec <dh48.jeong at samsung.com>


  Commit: 8edd79b1b50251ffddff23f581abc7c67453cfe3
      https://github.com/lxc/lxc/commit/8edd79b1b50251ffddff23f581abc7c67453cfe3
  Author: 2xsec <dh48.jeong at samsung.com>
  Date:   2018-10-12 (Fri, 12 Oct 2018)

  Changed paths:
    M src/lxc/parse.c

  Log Message:
  -----------
  parse: fix uninitialized pointer access

Signed-off-by: 2xsec <dh48.jeong at samsung.com>


  Commit: 6fc19f8ab20d9a7e97c50cc63b7b1011ddb7f188
      https://github.com/lxc/lxc/commit/6fc19f8ab20d9a7e97c50cc63b7b1011ddb7f188
  Author: 2xsec <dh48.jeong at samsung.com>
  Date:   2018-10-12 (Fri, 12 Oct 2018)

  Changed paths:
    M lxc.spec.in

  Log Message:
  -----------
  fix rpm packaging error for static library

Signed-off-by: 2xsec <dh48.jeong at samsung.com>


  Commit: ff69eaad7a4d5368cf33068f5b0e0eda610a8763
      https://github.com/lxc/lxc/commit/ff69eaad7a4d5368cf33068f5b0e0eda610a8763
  Author: 2xsec <dh48.jeong at samsung.com>
  Date:   2018-10-12 (Fri, 12 Oct 2018)

  Changed paths:
    M lxc.spec.in

  Log Message:
  -----------
  fix post section script error for rpm install

Signed-off-by: 2xsec <dh48.jeong at samsung.com>


  Commit: e0af2046ade042195d515b0155cac66ffa3e25e6
      https://github.com/lxc/lxc/commit/e0af2046ade042195d515b0155cac66ffa3e25e6
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-10-12 (Fri, 12 Oct 2018)

  Changed paths:
    M src/lxc/conf.c

  Log Message:
  -----------
  conf: log prlimit setup

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: 427fe98acf21cc868777eef31318355dc8da950b
      https://github.com/lxc/lxc/commit/427fe98acf21cc868777eef31318355dc8da950b
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-10-12 (Fri, 12 Oct 2018)

  Changed paths:
    M src/lxc/conf.c

  Log Message:
  -----------
  conf: verify_start_hooks() after lxc.mount.entry

Fixes: https://discuss.linuxcontainers.org/t/are-lxc-mount-entry-available-when-lxc-hook-start-is-validated/2906/3
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: e2965240906c776e0b71b90a11247b900a88b5d8
      https://github.com/lxc/lxc/commit/e2965240906c776e0b71b90a11247b900a88b5d8
  Author: Adrian Reber <areber at redhat.com>
  Date:   2018-10-12 (Fri, 12 Oct 2018)

  Changed paths:
    M src/lxc/criu.c

  Log Message:
  -----------
  checkpoint: fix running do_dump()

Testing 'lxc <container> stop --stateful' crashed LXD:

fatal error: unexpected signal during runtime execution
[signal SIGSEGV: segmentation violation code=0x1 addr=0xe8 pc=0x7f3198ff0592]

runtime stack:
runtime.throw(0x117fe4a, 0x2a)
	/opt/rh/go-toolset-1.10/root/usr/lib/go-toolset-1.10-golang/src/runtime/panic.go:616 +0x81
runtime.sigpanic()
	/opt/rh/go-toolset-1.10/root/usr/lib/go-toolset-1.10-golang/src/runtime/signal_unix.go:372 +0x28e

goroutine 375 [syscall]:
runtime.cgocall(0xef38e3, 0xc420731630, 0x29)
	/opt/rh/go-toolset-1.10/root/usr/lib/go-toolset-1.10-golang/src/runtime/cgocall.go:128 +0x64 fp=0xc4207315f0 sp=0xc4207315b8 pc=0x410fc4
gopkg.in/lxc/go-lxc%2ev2._Cfunc_go_lxc_migrate(0x7f316c001220, 0xc400000001, 0xc420302460, 0xc4205d6080, 0x0)
	_cgo_gotypes.go:752 +0x4d fp=0xc420731630 sp=0xc4207315f0 pc=0x909d7d
gopkg.in/lxc/go-lxc%2ev2.(*Container).Migrate.func4(0x7f316c001220, 0xc400000001, 0xc420302460, 0xc4205d6080, 0x0)
	/share/go/src/gopkg.in/lxc/go-lxc.v2/container.go:1798 +0x160 fp=0xc420731668 sp=0xc420731630 pc=0x91b970
gopkg.in/lxc/go-lxc%2ev2.(*Container).Migrate(0xc4207a52f0, 0x1, 0xc42051ec00, 0x20, 0x0, 0x0, 0x0, 0x0, 0x101, 0x10000000, ...)
	/share/go/src/gopkg.in/lxc/go-lxc.v2/container.go:1798 +0x29f fp=0xc420731760 sp=0xc420731668 pc=0x9160ef

The commit 5a087e056f94 introduced a second parameter (conf) to the
cgroup escape() function which was never set in do_dump(). Instead of
taking it from opts->handler->conf it is now used from c->lxc_conf.

Fixes: 5a087e056f94 ("cgroups: don't escape if lxc.cgroup.keep is true")
Suggested-by: Christian Brauner <christian.brauner at ubuntu.com>
Signed-off-by: Adrian Reber <areber at redhat.com>


  Commit: 05ba40f03dbf6817d1fecd20b1845e23facf14c9
      https://github.com/lxc/lxc/commit/05ba40f03dbf6817d1fecd20b1845e23facf14c9
  Author: 2xsec <dh48.jeong at samsung.com>
  Date:   2018-10-12 (Fri, 12 Oct 2018)

  Changed paths:
    M src/lxc/monitor.c

  Log Message:
  -----------
  monitor: log cleanups

Signed-off-by: 2xsec <dh48.jeong at samsung.com>


  Commit: 4409a533bfb8da5141ecfea5074b6b723f788c37
      https://github.com/lxc/lxc/commit/4409a533bfb8da5141ecfea5074b6b723f788c37
  Author: 2xsec <dh48.jeong at samsung.com>
  Date:   2018-10-12 (Fri, 12 Oct 2018)

  Changed paths:
    M src/lxc/monitor.c

  Log Message:
  -----------
  monitor: checking name too long to make monitor sock name

Signed-off-by: 2xsec <dh48.jeong at samsung.com>


  Commit: c8b502f08b5be22bb848187d4d0638981550bd00
      https://github.com/lxc/lxc/commit/c8b502f08b5be22bb848187d4d0638981550bd00
  Author: 2xsec <dh48.jeong at samsung.com>
  Date:   2018-10-12 (Fri, 12 Oct 2018)

  Changed paths:
    M src/lxc/commands.c
    M src/lxc/commands_utils.c
    M src/lxc/commands_utils.h

  Log Message:
  -----------
  commands_utils: improve code redundancy to make abstract unix socket name

Signed-off-by: 2xsec <dh48.jeong at samsung.com>


  Commit: 97e7f5754fe794aef7e27ec0088980c0a0a31706
      https://github.com/lxc/lxc/commit/97e7f5754fe794aef7e27ec0088980c0a0a31706
  Author: 2xsec <dh48.jeong at samsung.com>
  Date:   2018-10-12 (Fri, 12 Oct 2018)

  Changed paths:
    M src/lxc/monitor.c

  Log Message:
  -----------
  monitor: fix coding standard

Signed-off-by: 2xsec <dh48.jeong at samsung.com>


Compare: https://github.com/lxc/lxc/compare/491b23041b7f...97e7f5754fe7
      **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.


More information about the lxc-devel mailing list