[lxc-devel] [lxc/lxc] 6099dd: Revert "Revert "cgfsng: avoid tiny race window""

GitHub noreply at github.com
Wed Oct 3 12:11:58 UTC 2018


  Branch: refs/heads/master
  Home:   https://github.com/lxc/lxc
  Commit: 6099dd5a1384d821e8d5b3467f0f1acab9bfb190
      https://github.com/lxc/lxc/commit/6099dd5a1384d821e8d5b3467f0f1acab9bfb190
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-10-03 (Wed, 03 Oct 2018)

  Changed paths:
    M src/lxc/cgroups/cgfsng.c
    M src/lxc/utils.c

  Log Message:
  -----------
  Revert "Revert "cgfsng: avoid tiny race window""

This reverts commit c5e7a7acbf23f0c267179b3318af41423b39493a.

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: ef1853605066aa15630424340f2d7777964ed5d9
      https://github.com/lxc/lxc/commit/ef1853605066aa15630424340f2d7777964ed5d9
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-10-03 (Wed, 03 Oct 2018)

  Changed paths:
    M src/lxc/cgroups/cgfsng.c

  Log Message:
  -----------
  cgfsng: handle v1 cpuset hierarchy first

If the value of cgroup.clone_children in our immediate ancestor cgroup
is 0 then the cpuset of any cgroups we create in subtrees will be empty
and hence we'll copy an empty cpuset at which point we cannot enter the
cpuset cgroup.
Avoid this problem by initializing cgroup.clone_children to 1 an copying
the initialized cpuset of our immediate ancestor. Note, that the cpuset
of our immediate ancestor must be initialized and ours as well otherwise
we couldn't be located in this cgroup.

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: 15418afe93e4b1cc196b56f99b58086efba2bdd7
      https://github.com/lxc/lxc/commit/15418afe93e4b1cc196b56f99b58086efba2bdd7
  Author: Wolfgang Bumiller <w.bumiller at proxmox.com>
  Date:   2018-10-03 (Wed, 03 Oct 2018)

  Changed paths:
    M src/lxc/cgroups/cgfsng.c
    M src/lxc/utils.c

  Log Message:
  -----------
  Merge pull request #2670 from brauner/2018-10-03/cgfsng_fix_race

cgfsng: close tiny race window


Compare: https://github.com/lxc/lxc/compare/c5e7a7acbf23...15418afe93e4
      **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.


More information about the lxc-devel mailing list