[lxc-devel] [lxc/lxc] 6e6221: templates: actually create DOWNLOAD_TEMP directory

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/lxc/lxc
  Commit: 6e62213e029497fad264ba0d48549ee5e6f5e92d
      https://github.com/lxc/lxc/commit/6e62213e029497fad264ba0d48549ee5e6f5e92d
  Author: Mark Asselstine <mark.asselstine at windriver.com>
  Date:   2018-05-31 (Thu, 31 May 2018)

  Changed paths:
    M templates/lxc-download.in

  Log Message:
  -----------
  templates: actually create DOWNLOAD_TEMP directory

The way 'mktemp' is currently used you will get a temp directory in
$TMPDIR or '/tmp' and DOWNLOAD_TEMP will not be pointing to an actual
directory. This will result in the wget operations failing and the
container will fail to create:

    ERROR: Failed to download http://....

Instead we want to use the '-p' option for mktemp to set the base path
and this will ensure that the temp directory is created in the correct
location and DOWNLOAD_TEMP will be consistent with this location.

Signed-off-by: Mark Asselstine <mark.asselstine at windriver.com>


  Commit: 4d6301a04a6014e6668addc4381118e1941875c2
      https://github.com/lxc/lxc/commit/4d6301a04a6014e6668addc4381118e1941875c2
  Author: Christian Brauner <christian at brauner.io>
  Date:   2018-05-31 (Thu, 31 May 2018)

  Changed paths:
    M templates/lxc-download.in

  Log Message:
  -----------
  Merge pull request #2369 from masselstine/master

templates: actually create DOWNLOAD_TEMP directory


Compare: https://github.com/lxc/lxc/compare/ae8d875f89ac...4d6301a04a60
      **NOTE:** This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.