[lxc-devel] [lxc/lxc] 1b4872: lxccontainer: fix fd leaks when sending signals

GitHub noreply at github.com
Fri May 25 10:47:06 UTC 2018


  Branch: refs/heads/stable-3.0
  Home:   https://github.com/lxc/lxc
  Commit: 1b4872c760468a889563904020081c30982b69ce
      https://github.com/lxc/lxc/commit/1b4872c760468a889563904020081c30982b69ce
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-05-25 (Fri, 25 May 2018)

  Changed paths:
    M src/lxc/lxccontainer.c

  Log Message:
  -----------
  lxccontainer: fix fd leaks when sending signals

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: 2c16d4e59d7fe29b4d1aae802811f2dc83cce35b
      https://github.com/lxc/lxc/commit/2c16d4e59d7fe29b4d1aae802811f2dc83cce35b
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-05-25 (Fri, 25 May 2018)

  Changed paths:
    M src/lxc/confile.c

  Log Message:
  -----------
  confile: order architectures

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: 6e816a91b998b1cea436c08f7605fc4de192501b
      https://github.com/lxc/lxc/commit/6e816a91b998b1cea436c08f7605fc4de192501b
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-05-25 (Fri, 25 May 2018)

  Changed paths:
    M src/lxc/start.c

  Log Message:
  -----------
  start: log setns() failure

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: 0d83285d46ac00673cd94c90c470ecbc60b183cd
      https://github.com/lxc/lxc/commit/0d83285d46ac00673cd94c90c470ecbc60b183cd
  Author: Wolfgang Bumiller <w.bumiller at proxmox.com>
  Date:   2018-05-25 (Fri, 25 May 2018)

  Changed paths:
    M src/lxc/seccomp.c

  Log Message:
  -----------
  seccomp: leak fixup

Fix an error case not free()ing the line forgotten during
the move from fgets() on a static buffer to using getline.

Signed-off-by: Wolfgang Bumiller <w.bumiller at proxmox.com>
Fixes: ccf8d128e430 ("seccomp: parse_config_v1()")


  Commit: c88d84cbf5ec11ac2b2075c910d575471edc2916
      https://github.com/lxc/lxc/commit/c88d84cbf5ec11ac2b2075c910d575471edc2916
  Author: Wolfgang Bumiller <w.bumiller at proxmox.com>
  Date:   2018-05-25 (Fri, 25 May 2018)

  Changed paths:
    M src/lxc/seccomp.c

  Log Message:
  -----------
  seccomp: re-add action parse error handling

This can happen when the 'errno' action can't parse its
supplied number.

Signed-off-by: Wolfgang Bumiller <w.bumiller at proxmox.com>
Fixes: f67c94d00a0d ("seccomp: parse_v2_rules()")


  Commit: 3ce8c639a3bbf4422dbeb4e2d9abd3f932d81055
      https://github.com/lxc/lxc/commit/3ce8c639a3bbf4422dbeb4e2d9abd3f932d81055
  Author: Wolfgang Bumiller <w.bumiller at proxmox.com>
  Date:   2018-05-25 (Fri, 25 May 2018)

  Changed paths:
    M src/lxc/seccomp.c

  Log Message:
  -----------
  seccomp: refactor line handling of parse_config

Moving parse_config_v2 to use getline accidentally parsed
the wrong buffer. Since both _v1 and _v2 now use getline it
seems to be simpler to also use getline() for the first line
before entering the version specific parsers and pass along
the pointer and size so they can reuse them.

Signed-off-by: Wolfgang Bumiller <w.bumiller at proxmox.com>
Fixes: 9c3798eba41c ("seccomp: parse_config_v2()")


  Commit: 3b09ea5a716c4ae5c8e696c6020daf5aa8ed2ce4
      https://github.com/lxc/lxc/commit/3b09ea5a716c4ae5c8e696c6020daf5aa8ed2ce4
  Author: Wolfgang Bumiller <w.bumiller at proxmox.com>
  Date:   2018-05-25 (Fri, 25 May 2018)

  Changed paths:
    M src/lxc/seccomp.c

  Log Message:
  -----------
  seccomp: error on unrecognized actions

Be more strict about unrecognized actions. Previously the
parser would happily accept lines with typos like:

  kexec_load errrno 1

(note the extra 'r')

Signed-off-by: Wolfgang Bumiller <w.bumiller at proxmox.com>


Compare: https://github.com/lxc/lxc/compare/42a0468fa647...3b09ea5a716c
      **NOTE:** This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.


More information about the lxc-devel mailing list