[lxc-devel] [lxc/lxc] f6d79e: tools: only create log file when requested

GitHub noreply at github.com
Wed May 23 15:28:04 UTC 2018


  Branch: refs/heads/master
  Home:   https://github.com/lxc/lxc
  Commit: f6d79ec119739addc2a43109f7dd08b09f5bafa9
      https://github.com/lxc/lxc/commit/f6d79ec119739addc2a43109f7dd08b09f5bafa9
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-05-23 (Wed, 23 May 2018)

  Changed paths:
    M src/lxc/tools/lxc_attach.c
    M src/lxc/tools/lxc_autostart.c
    M src/lxc/tools/lxc_cgroup.c
    M src/lxc/tools/lxc_checkpoint.c
    M src/lxc/tools/lxc_console.c
    M src/lxc/tools/lxc_copy.c
    M src/lxc/tools/lxc_create.c
    M src/lxc/tools/lxc_destroy.c
    M src/lxc/tools/lxc_device.c
    M src/lxc/tools/lxc_execute.c
    M src/lxc/tools/lxc_freeze.c
    M src/lxc/tools/lxc_info.c
    M src/lxc/tools/lxc_ls.c
    M src/lxc/tools/lxc_monitor.c
    M src/lxc/tools/lxc_snapshot.c
    M src/lxc/tools/lxc_start.c
    M src/lxc/tools/lxc_stop.c
    M src/lxc/tools/lxc_unfreeze.c
    M src/lxc/tools/lxc_wait.c

  Log Message:
  -----------
  tools: only create log file when requested

We used to initialize a log unconditionally before. This has led to scenarios
where users where left with container directories and an empty log file even
though they didn't request a log be created at all.
Switch all tools to only create a log file when the user explicitly requests
this.

Closes #1779.
Closes #2032.

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: f217dcd039bc54a19ac0ea57a80b5acf8686bc5e
      https://github.com/lxc/lxc/commit/f217dcd039bc54a19ac0ea57a80b5acf8686bc5e
  Author: Stéphane Graber <stgraber at stgraber.org>
  Date:   2018-05-23 (Wed, 23 May 2018)

  Changed paths:
    M src/lxc/tools/lxc_attach.c
    M src/lxc/tools/lxc_autostart.c
    M src/lxc/tools/lxc_cgroup.c
    M src/lxc/tools/lxc_checkpoint.c
    M src/lxc/tools/lxc_console.c
    M src/lxc/tools/lxc_copy.c
    M src/lxc/tools/lxc_create.c
    M src/lxc/tools/lxc_destroy.c
    M src/lxc/tools/lxc_device.c
    M src/lxc/tools/lxc_execute.c
    M src/lxc/tools/lxc_freeze.c
    M src/lxc/tools/lxc_info.c
    M src/lxc/tools/lxc_ls.c
    M src/lxc/tools/lxc_monitor.c
    M src/lxc/tools/lxc_snapshot.c
    M src/lxc/tools/lxc_start.c
    M src/lxc/tools/lxc_stop.c
    M src/lxc/tools/lxc_unfreeze.c
    M src/lxc/tools/lxc_wait.c

  Log Message:
  -----------
  Merge pull request #2344 from brauner/2018-05-23/on_demand_log_file

tools: only create log file when requested


Compare: https://github.com/lxc/lxc/compare/f6c94d9a4c64...f217dcd039bc
      **NOTE:** This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.


More information about the lxc-devel mailing list