[lxc-devel] [lxc/lxc] a6ce7f: coverity: #1435210

Sat May 12 14:54:49 UTC 2018

  Branch: refs/heads/stabl-3.0
  Home:   https://github.com/lxc/lxc
  Commit: a6ce7f3ad08f42833f581e58674ddd386724fe59
      https://github.com/lxc/lxc/commit/a6ce7f3ad08f42833f581e58674ddd386724fe59
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-05-12 (Sat, 12 May 2018)

  Changed paths:
    M src/lxc/tools/tool_utils.c

  Log Message:
  -----------
  coverity: #1435210

Logically dead code

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 7d02c618b974bfa18f5987e6b1bed7d4f90028f8
      https://github.com/lxc/lxc/commit/7d02c618b974bfa18f5987e6b1bed7d4f90028f8
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-05-12 (Sat, 12 May 2018)

  Changed paths:
    M src/lxc/cgroups/cgfsng.c

  Log Message:
  -----------
  coverity: #1435208

Unused value

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: a6a2b30af86a2ce0ccf3aa2517b30d3053cd0206
      https://github.com/lxc/lxc/commit/a6a2b30af86a2ce0ccf3aa2517b30d3053cd0206
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-05-12 (Sat, 12 May 2018)

  Changed paths:
    M src/tests/aa.c

  Log Message:
  -----------
  coverity: #1435207

Unchecked return value

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 9cd2a7e4b49826a34a5650bd30a160b18a20cbbc
      https://github.com/lxc/lxc/commit/9cd2a7e4b49826a34a5650bd30a160b18a20cbbc
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-05-12 (Sat, 12 May 2018)

  Changed paths:
    M src/lxc/terminal.c

  Log Message:
  -----------
  coverity: #1435206

Time of check time of use

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 85d07fc3bc0d15ceaaefbdfcf7b24639d0d01daa
      https://github.com/lxc/lxc/commit/85d07fc3bc0d15ceaaefbdfcf7b24639d0d01daa
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-05-12 (Sat, 12 May 2018)

  Changed paths:
    M src/tests/attach.c

  Log Message:
  -----------
  coverity: #1435205

Unchecked return value

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: ce1743b424423d9a7aa322443a89c4922db8f070
      https://github.com/lxc/lxc/commit/ce1743b424423d9a7aa322443a89c4922db8f070
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-05-12 (Sat, 12 May 2018)

  Changed paths:
    M src/lxc/parse.c

  Log Message:
  -----------
  coverity: #1435203

Resource leak

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: c7da16f5059056bf80ea5f875f0195659114f590
      https://github.com/lxc/lxc/commit/c7da16f5059056bf80ea5f875f0195659114f590
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-05-12 (Sat, 12 May 2018)

  Changed paths:
    M src/lxc/conf.c

  Log Message:
  -----------
  coverity: #1435200

Resource leak

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: e843c7a9598ea7974478e282f557e531acd5feb6
      https://github.com/lxc/lxc/commit/e843c7a9598ea7974478e282f557e531acd5feb6
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-05-12 (Sat, 12 May 2018)

  Changed paths:
    M src/lxc/tools/lxc_create.c

  Log Message:
  -----------
  coverity: #1435198

Unchecked return value

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: a647e969b75af5fda915c200f238919a6e38d9d7
      https://github.com/lxc/lxc/commit/a647e969b75af5fda915c200f238919a6e38d9d7
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-05-12 (Sat, 12 May 2018)

  Changed paths:
    M src/lxc/tools/lxc_monitor.c

  Log Message:
  -----------
  coverity: #1426734

Argument cannot be negative

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 44d4ebc8ab2bd6196028b706782348782a1edbf6
      https://github.com/lxc/lxc/commit/44d4ebc8ab2bd6196028b706782348782a1edbf6
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-05-12 (Sat, 12 May 2018)

  Changed paths:
    M src/lxc/lxccontainer.c

  Log Message:
  -----------
  lxccontainer: non-functional changes

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 804f0eaac0ae5d61bcb67a7d98b670416ff93b8f
      https://github.com/lxc/lxc/commit/804f0eaac0ae5d61bcb67a7d98b670416ff93b8f
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-05-12 (Sat, 12 May 2018)

  Changed paths:
    M src/lxc/lxccontainer.c
    M src/lxc/lxclock.c

  Log Message:
  -----------
  lxccontainer: use thread-safe *_OFD_* locks

If they aren't available fallback to BSD flock()s.

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: d0cd46a88b024c55cca6d07c70a8b6dedf8dbcef
      https://github.com/lxc/lxc/commit/d0cd46a88b024c55cca6d07c70a8b6dedf8dbcef
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-05-12 (Sat, 12 May 2018)

  Changed paths:
    M src/lxc/lxccontainer.c

  Log Message:
  -----------
  lxccontainer: non-functional changes

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 78a2e53071e74de8d9f308a4b631f405794c644c
      https://github.com/lxc/lxc/commit/78a2e53071e74de8d9f308a4b631f405794c644c
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-05-12 (Sat, 12 May 2018)

  Changed paths:
    M src/lxc/lxccontainer.c

  Log Message:
  -----------
  lxccontainer: do_lxcapi_is_running()

There's no need to do string comparisons.

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: be38ca23b2726233bf936d107807060cf42b0f35
      https://github.com/lxc/lxc/commit/be38ca23b2726233bf936d107807060cf42b0f35
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-05-12 (Sat, 12 May 2018)

  Changed paths:
    M src/lxc/lxccontainer.c

  Log Message:
  -----------
  lxccontainer: do_lxcapi_freeze()

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 849f9891f96b652b17e5ae3e91c94b8af0342628
      https://github.com/lxc/lxc/commit/849f9891f96b652b17e5ae3e91c94b8af0342628
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-05-12 (Sat, 12 May 2018)

  Changed paths:
    M src/lxc/lxccontainer.c

  Log Message:
  -----------
  lxccontainer: do_lxcapi_unfreeze()

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 2c61b3cc01f71debf406e6f17557acd53e97e2c2
      https://github.com/lxc/lxc/commit/2c61b3cc01f71debf406e6f17557acd53e97e2c2
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-05-12 (Sat, 12 May 2018)

  Changed paths:
    M src/lxc/lxccontainer.c

  Log Message:
  -----------
  lxccontainer: non-functional changes

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: d4095065aa8d2ff3b2bdbc64be4fd2d7dfe6357b
      https://github.com/lxc/lxc/commit/d4095065aa8d2ff3b2bdbc64be4fd2d7dfe6357b
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-05-12 (Sat, 12 May 2018)

  Changed paths:
    M src/lxc/cgroups/cgfsng.c
    M src/lxc/conf.c
    M src/lxc/lxccontainer.c
    M src/lxc/utils.c
    M src/lxc/utils.h

  Log Message:
  -----------
  lxccontainer: use thread-safe open() + write()

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: e5b96ec1c7227ae7cada780c571ca491301f96c7
      https://github.com/lxc/lxc/commit/e5b96ec1c7227ae7cada780c571ca491301f96c7
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-05-12 (Sat, 12 May 2018)

  Changed paths:
    M src/lxc/lxccontainer.c

  Log Message:
  -----------
  lxccontainer: non-functional changes

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: b1773d8e4a7c13e45f91264b71819b2085dd08d0
      https://github.com/lxc/lxc/commit/b1773d8e4a7c13e45f91264b71819b2085dd08d0
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-05-12 (Sat, 12 May 2018)

  Changed paths:
    M src/lxc/lxccontainer.c

  Log Message:
  -----------
  lxccontainer: non-functional changes

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 92fff0e9f74c8a0a02be9bec8db8bdb0810be211
      https://github.com/lxc/lxc/commit/92fff0e9f74c8a0a02be9bec8db8bdb0810be211
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-05-12 (Sat, 12 May 2018)

  Changed paths:
    M src/lxc/lxccontainer.c

  Log Message:
  -----------
  lxccontainer: non-functional changes

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: f530c8ccf35054aeb7f04d1482922b44ac393a83
      https://github.com/lxc/lxc/commit/f530c8ccf35054aeb7f04d1482922b44ac393a83
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-05-12 (Sat, 12 May 2018)

  Changed paths:
    M src/lxc/lxccontainer.c

  Log Message:
  -----------
  coverity: #1435263

Use after free

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 45d5f19ba5eb394d9ee3346cd53b8080b112a60e
      https://github.com/lxc/lxc/commit/45d5f19ba5eb394d9ee3346cd53b8080b112a60e
  Author: Tycho Andersen <tycho at tycho.ws>
  Date:   2018-05-12 (Sat, 12 May 2018)

  Changed paths:
    M src/lxc/execute.c

  Log Message:
  -----------
  fix logic for execute log file

The problem here is that lxc-init runs *inside* the container. So if a
person has the log file set to /home/$USER/foo, lxc-init ends up making a
directory /home/$USER/foo inside the container to put the log file in. What
we really want are the logs to be propagated from inside the container to
the outside. We accomplish this by passing an fd without O_CLOEXEC, and
telling lxc-init to log to that file.

Signed-off-by: Tycho Andersen <tycho at tycho.ws>

  Commit: 91a491e4b773f410d2fcb990e4cdd3a8567c51b2
      https://github.com/lxc/lxc/commit/91a491e4b773f410d2fcb990e4cdd3a8567c51b2
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-05-12 (Sat, 12 May 2018)

  Changed paths:
    M src/lxc/utils.h

  Log Message:
  -----------
  utils: add LXC_PROC_PID_FD_LEN

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: e623ce4e4b1ff485b0112b942e94e010c7812d53
      https://github.com/lxc/lxc/commit/e623ce4e4b1ff485b0112b942e94e010c7812d53
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-05-12 (Sat, 12 May 2018)

  Changed paths:
    M src/lxc/execute.c

  Log Message:
  -----------
  execute: use static buffer

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 042dbb7d3c2c50c2f5c303da71efc2ec2fc6829f
      https://github.com/lxc/lxc/commit/042dbb7d3c2c50c2f5c303da71efc2ec2fc6829f
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-05-12 (Sat, 12 May 2018)

  Changed paths:
    M src/lxc/execute.c

  Log Message:
  -----------
  execute: do not check inherited fds again

This is already done in do_lxcapi_start{l}() so a) no need to do it again here
and b) this would close the state socket pair sockets, corrup the fd, and lead
to EBADF.

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 7977dda595964c1f04926e986d95d38114da61a1
      https://github.com/lxc/lxc/commit/7977dda595964c1f04926e986d95d38114da61a1
  Author: Tycho Andersen <tycho at tycho.ws>
  Date:   2018-05-12 (Sat, 12 May 2018)

  Changed paths:
    M src/lxc/execute.c
    M src/lxc/start.c

  Log Message:
  -----------
  add some TRACE/ERROR reporting

The errors in execute_start are important because nothing actually prints
out what error if any there was in these cases, so you're left with an
empty log.

The TRACE logs are simply to tell you which version of start lxc chose to
invoke: exec or start.

Signed-off-by: Tycho Andersen <tycho at tycho.ws>

  Commit: 7ccdf146bdd1d14d89c7abd2d7c91561a2afcfbe
      https://github.com/lxc/lxc/commit/7ccdf146bdd1d14d89c7abd2d7c91561a2afcfbe
  Author: Tycho Andersen <tycho at tycho.ws>
  Date:   2018-05-12 (Sat, 12 May 2018)

  Changed paths:
    M src/lxc/execute.c

  Log Message:
  -----------
  execute: account for -o path option count

This always works fine... until your exec() fails and you try to go and
free it, you've overwritten the allocator's metadata (and potentially other
stuff) and it fails.

Signed-off-by: Tycho Andersen <tycho at tycho.ws>

  Commit: 2f6c8368626b634e674e685bfa3f9d7de348c465
      https://github.com/lxc/lxc/commit/2f6c8368626b634e674e685bfa3f9d7de348c465
  Author: Tycho Andersen <tycho at tycho.ws>
  Date:   2018-05-12 (Sat, 12 May 2018)

  Changed paths:
    M src/lxc/conf.c

  Log Message:
  -----------
  execute: set init_path when existing init is found

I'm not really sure we should be looking in the rootfs for an existing
init, but I'll send a much more invasive patch to correct that. For now,
let's just make sure we set init_path when we find one, so that later in
execute_start() we don't bail.

Signed-off-by: Tycho Andersen <tycho at tycho.ws>

  Commit: 6aea671c057e61cce526ce945212e79eca83825e
      https://github.com/lxc/lxc/commit/6aea671c057e61cce526ce945212e79eca83825e
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-05-12 (Sat, 12 May 2018)

  Changed paths:
    M src/lxc/Makefile.am
    R src/lxc/genl.c
    R src/lxc/genl.h

  Log Message:
  -----------
  genl: remove

These files have never been used and as such have no dependencies in the
codebase whatsoever. So remove them. If we need them we can simply pull them
out of the git history.

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: e958e72762bb9bbef1f5c2240a6656354caa991a
      https://github.com/lxc/lxc/commit/e958e72762bb9bbef1f5c2240a6656354caa991a
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-05-12 (Sat, 12 May 2018)

  Changed paths:
    M src/lxc/network.c

  Log Message:
  -----------
  coverity: #1248104

Argument cannot be negative

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: e9d2f371eedbfbb8c0b137bf36622634da7c728d
      https://github.com/lxc/lxc/commit/e9d2f371eedbfbb8c0b137bf36622634da7c728d
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-05-12 (Sat, 12 May 2018)

  Changed paths:
    M src/lxc/network.c

  Log Message:
  -----------
  coverity: #1248105

Time of check time of use

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 3af748205abdef0c329b7ce637f0e621010e6ea3
      https://github.com/lxc/lxc/commit/3af748205abdef0c329b7ce637f0e621010e6ea3
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-05-12 (Sat, 12 May 2018)

  Changed paths:
    M src/lxc/conf.c
    M src/lxc/lxccontainer.c

  Log Message:
  -----------
  coverity: #1425744

Dereference after null check

userns_exec_{1,full} are called from functions that might not have a conf.

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: f439a9c013d9aa5e1531493b3b59c7ef6fab8ea7
      https://github.com/lxc/lxc/commit/f439a9c013d9aa5e1531493b3b59c7ef6fab8ea7
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-05-12 (Sat, 12 May 2018)

  Changed paths:
    M src/lxc/utils.c

  Log Message:
  -----------
  utils: account for terminating \0 byte

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: f9551693a2270678d535f8bc9bc6c6d5cf668617
      https://github.com/lxc/lxc/commit/f9551693a2270678d535f8bc9bc6c6d5cf668617
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-05-12 (Sat, 12 May 2018)

  Changed paths:
    M src/lxc/confile_utils.c

  Log Message:
  -----------
  confile: satisfy gcc-8

Apparently -Werror=stringop-overflow will trigger an error here even though
this is completely valid since we now that we're definitely copying a \0-byte.
Work around this gcc-8 quirk by using memcpy(). This shouldn't trigger the
warning.

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 2f14a51fd13921cdbd48ce83c155f5dd14579fe4
      https://github.com/lxc/lxc/commit/2f14a51fd13921cdbd48ce83c155f5dd14579fe4
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-05-12 (Sat, 12 May 2018)

  Changed paths:
    M src/lxc/network.c

  Log Message:
  -----------
  network: silence gcc-8

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: ea47aec0b2f40510752cfc39e1c4f4c1da646b39
      https://github.com/lxc/lxc/commit/ea47aec0b2f40510752cfc39e1c4f4c1da646b39
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-05-12 (Sat, 12 May 2018)

  Changed paths:
    M src/lxc/network.c

  Log Message:
  -----------
  network: adhere to IFNAMSIZ limit

The additional \0-byte space added is not needed since IFNAMSIZ needs to
include the \0-byte.

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: e32fd783af4be5822d8d4e7997503c0bc9707027
      https://github.com/lxc/lxc/commit/e32fd783af4be5822d8d4e7997503c0bc9707027
  Author: l00355512 <liuhao27 at huawei.com>
  Date:   2018-05-12 (Sat, 12 May 2018)

  Changed paths:
    M doc/lxc.container.conf.sgml.in
    M src/lxc/utils.c

  Log Message:
  -----------
  support case ignored suffix for sizes

suffix of console max size and console buffer max size

Signed-off-by: l00355512 <liuhao27 at huawei.com>

  Commit: 0556976018a6a2ddfda384537e712b54b86251c7
      https://github.com/lxc/lxc/commit/0556976018a6a2ddfda384537e712b54b86251c7
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-05-12 (Sat, 12 May 2018)

  Changed paths:
    M doc/lxc.container.conf.sgml.in
    M src/lxc/utils.c

  Log Message:
  -----------
  utils: fix parse_byte_size_string() coding style

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: dc2c890d1fa0e8bfb9f2bb8c2b42f105f8622ffe
      https://github.com/lxc/lxc/commit/dc2c890d1fa0e8bfb9f2bb8c2b42f105f8622ffe
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-05-12 (Sat, 12 May 2018)

  Changed paths:
    M configure.ac
    A src/include/strlcpy.c
    A src/include/strlcpy.h
    M src/lxc/Makefile.am

  Log Message:
  -----------
  strlcpy: add strlcpy() implementation

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 79eebb7e835393f19da7d40aa53a03ed26d0ef26
      https://github.com/lxc/lxc/commit/79eebb7e835393f19da7d40aa53a03ed26d0ef26
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-05-12 (Sat, 12 May 2018)

  Changed paths:
    M src/lxc/af_unix.c
    M src/lxc/criu.c
    M src/lxc/log.c
    M src/lxc/lxccontainer.c
    M src/lxc/monitor.c
    M src/lxc/network.c
    M src/lxc/start.c
    M src/lxc/storage/btrfs.c
    M src/lxc/storage/storage_utils.c

  Log Message:
  -----------
  tree-wide: s/strncpy()/strlcpy()/g

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 80aa6de0a23a771166f961b3d037485f3f59d097
      https://github.com/lxc/lxc/commit/80aa6de0a23a771166f961b3d037485f3f59d097
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-05-12 (Sat, 12 May 2018)

  Changed paths:
    M CODING_STYLE.md

  Log Message:
  -----------
  CODING_STYLE: add section about using strlcpy()

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 7b9346a79737f65e7faa7c2cd82bd6a39ce37d68
      https://github.com/lxc/lxc/commit/7b9346a79737f65e7faa7c2cd82bd6a39ce37d68
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-05-12 (Sat, 12 May 2018)

  Changed paths:
    M src/lxc/Makefile.am
    M src/lxc/tools/lxc_monitor.c

  Log Message:
  -----------
  tools: s/strncpy()/strlcpy()/g

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 3c57c959dce9070a3db4c7ee30a2cbda61fd80a6
      https://github.com/lxc/lxc/commit/3c57c959dce9070a3db4c7ee30a2cbda61fd80a6
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-05-12 (Sat, 12 May 2018)

  Changed paths:
    M src/lxc/Makefile.am
    M src/lxc/tools/lxc_monitor.c

  Log Message:
  -----------
  Revert "tools: s/strncpy()/strlcpy()/g"

This reverts commit 2ec47d5149e73db97f7877d06d67cb11421097bb.

First, I forgot to actually replace strncpy() with strlcpy(). Second, we don't
want to \0-terminate since this is an abstract unix socket and this is not
required. Instead, let's simply use memcpy() which is more correct and also
silences gcc-8.

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: e44c49715826503e065bc78bd335d02725eff9dc
      https://github.com/lxc/lxc/commit/e44c49715826503e065bc78bd335d02725eff9dc
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-05-12 (Sat, 12 May 2018)

  Changed paths:
    M src/lxc/tools/lxc_monitor.c

  Log Message:
  -----------
  tools: s/strncpy()/memcpy()/

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

Compare: https://github.com/lxc/lxc/compare/a6ce7f3ad08f^...e44c49715826
      **NOTE:** This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.