[lxc-devel] [lxc/lxc] 50c6bb: Revert "tools: s/strncpy()/strlcpy()/g"

GitHub noreply at github.com
Fri May 11 14:12:33 UTC 2018


  Branch: refs/heads/master
  Home:   https://github.com/lxc/lxc
  Commit: 50c6bb6b74d0414bc1b3bd5395b2bad6009a017d
      https://github.com/lxc/lxc/commit/50c6bb6b74d0414bc1b3bd5395b2bad6009a017d
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-05-11 (Fri, 11 May 2018)

  Changed paths:
    M src/lxc/Makefile.am
    M src/lxc/tools/lxc_monitor.c

  Log Message:
  -----------
  Revert "tools: s/strncpy()/strlcpy()/g"

This reverts commit 2ec47d5149e73db97f7877d06d67cb11421097bb.

First, I forgot to actually replace strncpy() with strlcpy(). Second, we don't
want to \0-terminate since this is an abstract unix socket and this is not
required. Instead, let's simply use memcpy() which is more correct and also
silences gcc-8.

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: d96a98469176ab6064583331cab9f002632a4586
      https://github.com/lxc/lxc/commit/d96a98469176ab6064583331cab9f002632a4586
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-05-11 (Fri, 11 May 2018)

  Changed paths:
    M src/lxc/tools/lxc_monitor.c

  Log Message:
  -----------
  tools: s/strncpy()/memcpy()/

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: 9ab207cad74f77ce643d98334107949ade97463b
      https://github.com/lxc/lxc/commit/9ab207cad74f77ce643d98334107949ade97463b
  Author: Stéphane Graber <stgraber at stgraber.org>
  Date:   2018-05-11 (Fri, 11 May 2018)

  Changed paths:
    M src/lxc/Makefile.am
    M src/lxc/tools/lxc_monitor.c

  Log Message:
  -----------
  Merge pull request #2318 from brauner/2018-05-11/compiler_fixes

tools: s/strncpy()/memcpy()/g


Compare: https://github.com/lxc/lxc/compare/b717d3fab12d...9ab207cad74f
      **NOTE:** This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.


More information about the lxc-devel mailing list