[lxc-devel] [lxc/lxc] b2efeb: add some TRACE/ERROR reporting

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/lxc/lxc
  Commit: b2efeb0bb95e35e5b597b91224d07e6496d0161e
      https://github.com/lxc/lxc/commit/b2efeb0bb95e35e5b597b91224d07e6496d0161e
  Author: Tycho Andersen <tycho at tycho.ws>
  Date:   2018-05-09 (Wed, 09 May 2018)

  Changed paths:
    M src/lxc/execute.c
    M src/lxc/start.c

  Log Message:
  -----------
  add some TRACE/ERROR reporting

The errors in execute_start are important because nothing actually prints
out what error if any there was in these cases, so you're left with an
empty log.

The TRACE logs are simply to tell you which version of start lxc chose to
invoke: exec or start.

Signed-off-by: Tycho Andersen <tycho at tycho.ws>


  Commit: 9c40b2d97829ce2afea4eed9cb4eac40ccec82e5
      https://github.com/lxc/lxc/commit/9c40b2d97829ce2afea4eed9cb4eac40ccec82e5
  Author: Tycho Andersen <tycho at tycho.ws>
  Date:   2018-05-09 (Wed, 09 May 2018)

  Changed paths:
    M src/lxc/execute.c

  Log Message:
  -----------
  execute: account for -o path option count

This always works fine... until your exec() fails and you try to go and
free it, you've overwritten the allocator's metadata (and potentially other
stuff) and it fails.

Signed-off-by: Tycho Andersen <tycho at tycho.ws>


  Commit: 410898489fb1ca8ed774ffc9ff030c64662f51a6
      https://github.com/lxc/lxc/commit/410898489fb1ca8ed774ffc9ff030c64662f51a6
  Author: Tycho Andersen <tycho at tycho.ws>
  Date:   2018-05-09 (Wed, 09 May 2018)

  Changed paths:
    M src/lxc/conf.c

  Log Message:
  -----------
  execute: set init_path when existing init is found

I'm not really sure we should be looking in the rootfs for an existing
init, but I'll send a much more invasive patch to correct that. For now,
let's just make sure we set init_path when we find one, so that later in
execute_start() we don't bail.

Signed-off-by: Tycho Andersen <tycho at tycho.ws>


  Commit: 0f1b40e259a308fa664e6275484c95b15360b1ff
      https://github.com/lxc/lxc/commit/0f1b40e259a308fa664e6275484c95b15360b1ff
  Author: Serge Hallyn <serge at hallyn.com>
  Date:   2018-05-09 (Wed, 09 May 2018)

  Changed paths:
    M src/lxc/conf.c
    M src/lxc/execute.c
    M src/lxc/start.c

  Log Message:
  -----------
  Merge pull request #2308 from tych0/add-logging

fix execute when init in the container already exists


Compare: https://github.com/lxc/lxc/compare/f52624fa563d...0f1b40e259a3
      **NOTE:** This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.