[lxc-devel] [lxc/lxc] 512845: remove leading whitespace from log files

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/lxc/lxc
  Commit: 512845bc109bb11009f4b7c1dd5705e2e4675b80
      https://github.com/lxc/lxc/commit/512845bc109bb11009f4b7c1dd5705e2e4675b80
  Author: Tycho Andersen <tycho at tycho.ws>
  Date:   2018-03-22 (Thu, 22 Mar 2018)

  Changed paths:
    M src/lxc/log.c

  Log Message:
  -----------
  remove leading whitespace from log files

This has annoyed me for a long time, 3.0 seems like the time to fix it :).

I think the way that the log prefix was intended to be used was perhaps a
dynamic prefix per file, but we don't do that today; we include the
filename later in the log message. Instead, we use it as the tool name,
which for liblxc is always "lxc", but could also be things like
"lxc-cgroup" or whatever. There is absolutely no reason to pad this, since
it is always the same for every log file (in fact, we could probably get
rid of the prefix all together, but that seems slightly more drastic).

Instead, let's just drop this padding. Hopefully this will save thousands
of hours of slight annoyance and right scrolling in various pastebins.

Signed-off-by: Tycho Andersen <tycho at tycho.ws>


  Commit: dad96df80b85e55f13931c142bdfe6572ee41617
      https://github.com/lxc/lxc/commit/dad96df80b85e55f13931c142bdfe6572ee41617
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-03-22 (Thu, 22 Mar 2018)

  Changed paths:
    M src/lxc/log.c

  Log Message:
  -----------
  Merge pull request #2230 from tych0/drop-log-whitespace

remove leading whitespace from log files


Compare: https://github.com/lxc/lxc/compare/4c6fb19b30e5...dad96df80b85