[lxc-devel] [lxc/lxc] 604f37: secure coding: strcpy => strlcpy

Fri Jun 22 11:23:42 UTC 2018

  Branch: refs/heads/stable-3.0
  Home:   https://github.com/lxc/lxc
  Commit: 604f37646471ef8f4d284f20f30dac058c506a5c
      https://github.com/lxc/lxc/commit/604f37646471ef8f4d284f20f30dac058c506a5c
  Author: Donghwa Jeong <dh48.jeong at samsung.com>
  Date:   2018-06-22 (Fri, 22 Jun 2018)

  Changed paths:
    M src/lxc/criu.c
    M src/lxc/lxccontainer.c
    M src/lxc/start.c
    M src/lxc/storage/btrfs.c

  Log Message:
  -----------
  secure coding: strcpy => strlcpy

Signed-off-by: Donghwa Jeong <dh48.jeong at samsung.com>

  Commit: c9651be4471b37ca35f01288054597ced6ca79aa
      https://github.com/lxc/lxc/commit/c9651be4471b37ca35f01288054597ced6ca79aa
  Author: Donghwa Jeong <dh48.jeong at samsung.com>
  Date:   2018-06-22 (Fri, 22 Jun 2018)

  Changed paths:
    M src/lxc/network.c

  Log Message:
  -----------
  secure coding: network: strcpy => strlcpy

Signed-off-by: Donghwa Jeong <dh48.jeong at samsung.com>

  Commit: 29babe5e7a0c6ca328be6c787e7f14354677022c
      https://github.com/lxc/lxc/commit/29babe5e7a0c6ca328be6c787e7f14354677022c
  Author: Donghwa Jeong <dh48.jeong at samsung.com>
  Date:   2018-06-22 (Fri, 22 Jun 2018)

  Changed paths:
    M src/lxc/cmd/lxc_user_nic.c
    M src/lxc/confile.c
    M src/lxc/initutils.c
    M src/lxc/pam/pam_cgfs.c
    M src/lxc/storage/nbd.c
    M src/lxc/storage/rbd.c
    M src/lxc/storage/storage.c
    M src/lxc/tools/tool_utils.c
    M src/lxc/utils.c

  Log Message:
  -----------
  secure coding: #2 strcpy => strlcpy

Signed-off-by: Donghwa Jeong <dh48.jeong at samsung.com>

  Commit: 0cd262d1dab32d0f5d9970a8ff371d9ecc8be7dc
      https://github.com/lxc/lxc/commit/0cd262d1dab32d0f5d9970a8ff371d9ecc8be7dc
  Author: Donghwa Jeong <dh48.jeong at samsung.com>
  Date:   2018-06-22 (Fri, 22 Jun 2018)

  Changed paths:
    M src/lxc/conf.c

  Log Message:
  -----------
  conf: remove unused argument

Signed-off-by: Donghwa Jeong <dh48.jeong at samsung.com>

  Commit: 358bad406022e3947e2eec9b7187f072ed84f45c
      https://github.com/lxc/lxc/commit/358bad406022e3947e2eec9b7187f072ed84f45c
  Author: Donghwa Jeong <dh48.jeong at samsung.com>
  Date:   2018-06-22 (Fri, 22 Jun 2018)

  Changed paths:
    M src/lxc/confile.c
    M src/lxc/confile_utils.c
    M src/lxc/confile_utils.h
    M src/tests/attach.c
    M src/tests/cgpath.c
    M src/tests/shortlived.c

  Log Message:
  -----------
  secure coding: #3 strcpy => strlcpy

Signed-off-by: Donghwa Jeong <dh48.jeong at samsung.com>

  Commit: 0314007a9ae415548fe6b19ad3e3be9b479975a6
      https://github.com/lxc/lxc/commit/0314007a9ae415548fe6b19ad3e3be9b479975a6
  Author: Donghwa Jeong <dh48.jeong at samsung.com>
  Date:   2018-06-22 (Fri, 22 Jun 2018)

  Changed paths:
    M src/lxc/cmd/lxc_usernsexec.c

  Log Message:
  -----------
  fix fd handle leak

Signed-off-by: Donghwa Jeong <dh48.jeong at samsung.com>

  Commit: f6b5182f2e8f7005cf1c9cda30dde1f0b8a00d99
      https://github.com/lxc/lxc/commit/f6b5182f2e8f7005cf1c9cda30dde1f0b8a00d99
  Author: Donghwa Jeong <dh48.jeong at samsung.com>
  Date:   2018-06-22 (Fri, 22 Jun 2018)

  Changed paths:
    M src/tests/get_item.c

  Log Message:
  -----------
  fix pointer c is dereferenced after checking null

Signed-off-by: Donghwa Jeong <dh48.jeong at samsung.com>

  Commit: 3eab4446c1a1a8e244f36e25d0323af6503ee96b
      https://github.com/lxc/lxc/commit/3eab4446c1a1a8e244f36e25d0323af6503ee96b
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-06-22 (Fri, 22 Jun 2018)

  Changed paths:
    M configure.ac
    A src/include/strlcat.c
    A src/include/strlcat.h

  Log Message:
  -----------
  include: add strlcat() implementation

CC: Donghwa Jeong <dh48.jeong at samsung.com>
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 1963c60d9a953e14096e7a6241d6b25a145b3be5
      https://github.com/lxc/lxc/commit/1963c60d9a953e14096e7a6241d6b25a145b3be5
  Author: Thomas Hipp <thomas.hipp at canonical.com>
  Date:   2018-06-22 (Fri, 22 Jun 2018)

  Changed paths:
    M templates/lxc-busybox.in

  Log Message:
  -----------
  templates: Fix busybox template

Use `busybox --list`, and exclude the `busybox` applet if necessary.

Signed-off-by: Thomas Hipp <thomas.hipp at canonical.com>

  Commit: 9bb379ba15f1fe3420277645b8b81f79d4eb460d
      https://github.com/lxc/lxc/commit/9bb379ba15f1fe3420277645b8b81f79d4eb460d
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-06-22 (Fri, 22 Jun 2018)

  Changed paths:
    M src/lxc/Makefile.am
    M src/lxc/storage/btrfs.c

  Log Message:
  -----------
  btrfs: s/strncat()/strlcat()/g

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 1076f93813dea5400fc2a261663f53ece2ccef99
      https://github.com/lxc/lxc/commit/1076f93813dea5400fc2a261663f53ece2ccef99
  Author: Donghwa Jeong <dh48.jeong at samsung.com>
  Date:   2018-06-22 (Fri, 22 Jun 2018)

  Changed paths:
    M src/lxc/conf.c
    M src/lxc/confile.c
    M src/lxc/pam/pam_cgfs.c
    M src/lxc/pam/utils.c
    M src/lxc/tools/tool_utils.c
    M src/lxc/utils.c

  Log Message:
  -----------
  secure coding: strcat => strncat

Signed-off-by: Donghwa Jeong <dh48.jeong at samsung.com>

  Commit: 7ff9fe63e57bde80962d96cc497e65831261e8e8
      https://github.com/lxc/lxc/commit/7ff9fe63e57bde80962d96cc497e65831261e8e8
  Author: Donghwa Jeong <dh48.jeong at samsung.com>
  Date:   2018-06-22 (Fri, 22 Jun 2018)

  Changed paths:
    M src/lxc/cgroups/cgfsng.c

  Log Message:
  -----------
  secure coding: cgfsng: strncat, strlcpy

Signed-off-by: Donghwa Jeong <dh48.jeong at samsung.com>

  Commit: 9c39c3b58be3fcf9fe390612c38f38c1b9124abd
      https://github.com/lxc/lxc/commit/9c39c3b58be3fcf9fe390612c38f38c1b9124abd
  Author: Donghwa Jeong <dh48.jeong at samsung.com>
  Date:   2018-06-22 (Fri, 22 Jun 2018)

  Changed paths:
    M src/lxc/storage/btrfs.c

  Log Message:
  -----------
  btrfs: fix wrong buffer size to append string

Signed-off-by: Donghwa Jeong <dh48.jeong at samsung.com>

  Commit: 8a9de93be7c6c3741b9143126276c20b15538714
      https://github.com/lxc/lxc/commit/8a9de93be7c6c3741b9143126276c20b15538714
  Author: Donghwa Jeong <dh48.jeong at samsung.com>
  Date:   2018-06-22 (Fri, 22 Jun 2018)

  Changed paths:
    M src/lxc/cgroups/cgfsng.c

  Log Message:
  -----------
  cgfsng: strncat => strlcat

Signed-off-by: Donghwa Jeong <dh48.jeong at samsung.com>

  Commit: 10b17d914cf46e3ac785c7a6693878633ec85dea
      https://github.com/lxc/lxc/commit/10b17d914cf46e3ac785c7a6693878633ec85dea
  Author: Donghwa Jeong <dh48.jeong at samsung.com>
  Date:   2018-06-22 (Fri, 22 Jun 2018)

  Changed paths:
    M src/lxc/conf.c

  Log Message:
  -----------
  conf: strncat => strlcat

Signed-off-by: Donghwa Jeong <dh48.jeong at samsung.com>

  Commit: 61bcfcb0e483ceaedcbda6c13e2454fc1994a023
      https://github.com/lxc/lxc/commit/61bcfcb0e483ceaedcbda6c13e2454fc1994a023
  Author: Donghwa Jeong <dh48.jeong at samsung.com>
  Date:   2018-06-22 (Fri, 22 Jun 2018)

  Changed paths:
    M src/lxc/pam/pam_cgfs.c

  Log Message:
  -----------
  pam_cgfs: strncat => strlcat

Signed-off-by: Donghwa Jeong <dh48.jeong at samsung.com>

  Commit: 95c654efe2abb7249eb34ba2c312e632728e8eb2
      https://github.com/lxc/lxc/commit/95c654efe2abb7249eb34ba2c312e632728e8eb2
  Author: Donghwa Jeong <dh48.jeong at samsung.com>
  Date:   2018-06-22 (Fri, 22 Jun 2018)

  Changed paths:
    M src/lxc/tools/tool_utils.c

  Log Message:
  -----------
  tool_utils: strncat => strlcat

Signed-off-by: Donghwa Jeong <dh48.jeong at samsung.com>

  Commit: 8ad6f8aec9de45edcef8423c303a4a533afc6600
      https://github.com/lxc/lxc/commit/8ad6f8aec9de45edcef8423c303a4a533afc6600
  Author: Donghwa Jeong <dh48.jeong at samsung.com>
  Date:   2018-06-22 (Fri, 22 Jun 2018)

  Changed paths:
    M src/lxc/pam/utils.c
    M src/lxc/utils.c

  Log Message:
  -----------
  utils: strncat => strlcat

Signed-off-by: Donghwa Jeong <dh48.jeong at samsung.com>

  Commit: e8e3ac45de81c1f252e59b5b09bee3610926385b
      https://github.com/lxc/lxc/commit/e8e3ac45de81c1f252e59b5b09bee3610926385b
  Author: Donghwa Jeong <dh48.jeong at samsung.com>
  Date:   2018-06-22 (Fri, 22 Jun 2018)

  Changed paths:
    M src/lxc/confile.c

  Log Message:
  -----------
  confile: strncat => strlcat

Signed-off-by: Donghwa Jeong <dh48.jeong at samsung.com>

  Commit: 6f94c2d2b1212756f6449c32928d485d1869d05d
      https://github.com/lxc/lxc/commit/6f94c2d2b1212756f6449c32928d485d1869d05d
  Author: Donghwa Jeong <dh48.jeong at samsung.com>
  Date:   2018-06-22 (Fri, 22 Jun 2018)

  Changed paths:
    M src/lxc/storage/btrfs.c

  Log Message:
  -----------
  btrfs: add to check return size of strlcat

Signed-off-by: Donghwa Jeong <dh48.jeong at samsung.com>

Compare: https://github.com/lxc/lxc/compare/e9674af42e7c...6f94c2d2b121
      **NOTE:** This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.