[lxc-devel] [lxc/lxc] 73e3cb: seccomp: drop misleading argument name inherited f...

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/lxc/lxc
  Commit: 73e3cb9a16e8a53e0e52b4682bdb3923cbc9f6f6
      https://github.com/lxc/lxc/commit/73e3cb9a16e8a53e0e52b4682bdb3923cbc9f6f6
  Author: Felix Abecassis <fabecassis at nvidia.com>
  Date:   2018-06-01 (Fri, 01 Jun 2018)

  Changed paths:
    M src/lxc/seccomp.c

  Log Message:
  -----------
  seccomp: drop misleading argument name inherited from the OCI spec

The last (optional) argument was named "valueTwo", which seems to
originate from the OCI runtime spec:
https://github.com/opencontainers/runtime-spec/blob/master/config-linux.md#seccomp

In proper seccomp terminology, "value" is "datum_a" and "valueTwo" is "datum_b".

However, LXC's "valueTwo" was used as the mask for SCMP_CMP_MASKED_EQ,
while the mask is supposed to be "datum_a".

Signed-off-by: Felix Abecassis <fabecassis at nvidia.com>


  Commit: f42183e68cfe5ee185e4ccc0330a22c02fc24597
      https://github.com/lxc/lxc/commit/f42183e68cfe5ee185e4ccc0330a22c02fc24597
  Author: Felix Abecassis <fabecassis at nvidia.com>
  Date:   2018-06-01 (Fri, 01 Jun 2018)

  Changed paths:
    M src/lxc/seccomp.c

  Log Message:
  -----------
  seccomp: use a default value of 0 for the mask

The mask was unconditionally parsed, it failed if no mask was
provided.

Signed-off-by: Felix Abecassis <fabecassis at nvidia.com>


  Commit: 224d1fd25fafc1d1aba10d7767b778ce9fbeb6ee
      https://github.com/lxc/lxc/commit/224d1fd25fafc1d1aba10d7767b778ce9fbeb6ee
  Author: Christian Brauner <christian at brauner.io>
  Date:   2018-06-02 (Sat, 02 Jun 2018)

  Changed paths:
    M src/lxc/seccomp.c

  Log Message:
  -----------
  Merge pull request #2372 from flx42/more-seccomp-fixes

More seccomp fixes


Compare: https://github.com/lxc/lxc/compare/ef52e679dc3b...224d1fd25faf
      **NOTE:** This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.