[lxc-devel] [lxc/lxc] 1aeaca: templates: actually create DOWNLOAD_TEMP directory

[GitHub]

  Branch: refs/heads/stable-3.0
  Home:   https://github.com/lxc/lxc
  Commit: 1aeaca8932048720e1e1d273be78d92d905f22b4
      https://github.com/lxc/lxc/commit/1aeaca8932048720e1e1d273be78d92d905f22b4
  Author: Mark Asselstine <mark.asselstine at windriver.com>
  Date:   2018-06-01 (Fri, 01 Jun 2018)

  Changed paths:
    M templates/lxc-download.in

  Log Message:
  -----------
  templates: actually create DOWNLOAD_TEMP directory

The way 'mktemp' is currently used you will get a temp directory in
$TMPDIR or '/tmp' and DOWNLOAD_TEMP will not be pointing to an actual
directory. This will result in the wget operations failing and the
container will fail to create:

    ERROR: Failed to download http://....

Instead we want to use the '-p' option for mktemp to set the base path
and this will ensure that the temp directory is created in the correct
location and DOWNLOAD_TEMP will be consistent with this location.

Signed-off-by: Mark Asselstine <mark.asselstine at windriver.com>


  Commit: 32b747ad7ab7b0f0f2d9affc85364b61218eb8e8
      https://github.com/lxc/lxc/commit/32b747ad7ab7b0f0f2d9affc85364b61218eb8e8
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-06-01 (Fri, 01 Jun 2018)

  Changed paths:
    M templates/lxc-download.in

  Log Message:
  -----------
  templates: fix download template

This patch fixes
commit 6e62213e0294 ("templates: actually create DOWNLOAD_TEMP directory".
To use mktemp -p correctly the directories need to exist. So call mkdir -p.

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: bfce0f6ee08ad48e1e2e47a369e866d7791c3f4b
      https://github.com/lxc/lxc/commit/bfce0f6ee08ad48e1e2e47a369e866d7791c3f4b
  Author: Julien Surloppe <julien at surloppe.fr>
  Date:   2018-06-01 (Fri, 01 Jun 2018)

  Changed paths:
    M src/lxc/cmd/lxc-update-config.in

  Log Message:
  -----------
  Patch lxc-update-config

The current script doesn't generate a valid configuration for
lxc.network.ipv4 key, it lacking an .address part which lead to:

parse.c: lxc_file_for_each_line: 58 Failed to parse config: lxc.net.0.ipv4 = 192.168.10.101/24

Signed-off-by: Julien Surloppe <julien at surloppe.fr>


Compare: https://github.com/lxc/lxc/compare/2d7c63459212...bfce0f6ee08a
      **NOTE:** This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.