[lxc-devel] [lxc/lxc] b4e5d1: coverity: #1437936

GitHub noreply at github.com
Tue Jul 24 13:03:55 UTC 2018


  Branch: refs/heads/stable-3.0
  Home:   https://github.com/lxc/lxc
  Commit: b4e5d17e3e61b1a86c3030bb3ec60f931ca69869
      https://github.com/lxc/lxc/commit/b4e5d17e3e61b1a86c3030bb3ec60f931ca69869
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-07-24 (Tue, 24 Jul 2018)

  Changed paths:
    M src/lxc/attach.c

  Log Message:
  -----------
  coverity: #1437936

Unchecked return value

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: 52c727bb4f5ef69760eaedc39f278341cf6ddf04
      https://github.com/lxc/lxc/commit/52c727bb4f5ef69760eaedc39f278341cf6ddf04
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-07-24 (Tue, 24 Jul 2018)

  Changed paths:
    M src/lxc/cmd/lxc_usernsexec.c

  Log Message:
  -----------
  coverity: #1437935

Unchecked return value

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: 34e443452f60e8c0dc0d645a7f3d9d834505cad8
      https://github.com/lxc/lxc/commit/34e443452f60e8c0dc0d645a7f3d9d834505cad8
  Author: 2xsec <dh48.jeong at samsung.com>
  Date:   2018-07-24 (Tue, 24 Jul 2018)

  Changed paths:
    M src/lxc/lxclock.c

  Log Message:
  -----------
  lxclock: change error log using strerror to SYSERROR

Signed-off-by: 2xsec <dh48.jeong at samsung.com>


  Commit: c6c38b301a99ed40c4f75b3b2b4e6bd59bc11d8c
      https://github.com/lxc/lxc/commit/c6c38b301a99ed40c4f75b3b2b4e6bd59bc11d8c
  Author: Felix Abecassis <fabecassis at nvidia.com>
  Date:   2018-07-24 (Tue, 24 Jul 2018)

  Changed paths:
    M src/lxc/confile.c

  Log Message:
  -----------
  confile: fix incorrect strncmp

Passing additional configuration options with "--define" was broken.

Result of git bisect:
d899f11b7bfb14c4b532bc801de89c8fb46307d4 is the first bad commit

Signed-off-by: Felix Abecassis <fabecassis at nvidia.com>


  Commit: 0afaa1317e85bbcd9e15e97fbf457cfe5f364492
      https://github.com/lxc/lxc/commit/0afaa1317e85bbcd9e15e97fbf457cfe5f364492
  Author: 2xsec <dh48.jeong at samsung.com>
  Date:   2018-07-24 (Tue, 24 Jul 2018)

  Changed paths:
    M src/lxc/namespace.c
    M src/lxc/tools/arguments.c
    M src/lxc/tools/arguments.h
    M src/lxc/tools/lxc_unshare.c

  Log Message:
  -----------
  tools: lxc-unshare: apply argument parser of lxc and log system of lxc

Signed-off-by: 2xsec <dh48.jeong at samsung.com>


  Commit: 4dcb39cc35abbdbaafb774518973278a65d27039
      https://github.com/lxc/lxc/commit/4dcb39cc35abbdbaafb774518973278a65d27039
  Author: 2xsec <dh48.jeong at samsung.com>
  Date:   2018-07-24 (Tue, 24 Jul 2018)

  Changed paths:
    M src/lxc/tools/arguments.c
    M src/lxc/tools/lxc_unshare.c

  Log Message:
  -----------
  tools: lxc-unshare: fix wrong coding rules

Signed-off-by: 2xsec <dh48.jeong at samsung.com>


  Commit: 671df9f10ce89e5eee607e123a76917782011cd8
      https://github.com/lxc/lxc/commit/671df9f10ce89e5eee607e123a76917782011cd8
  Author: 2xsec <dh48.jeong at samsung.com>
  Date:   2018-07-24 (Tue, 24 Jul 2018)

  Changed paths:
    M src/lxc/tools/lxc_unshare.c

  Log Message:
  -----------
  tools: lxc-unshare: use lxc list for interface names

Signed-off-by: 2xsec <dh48.jeong at samsung.com>


  Commit: 200c29b146e3ea344d69c8201bfbb3e3131d681a
      https://github.com/lxc/lxc/commit/200c29b146e3ea344d69c8201bfbb3e3131d681a
  Author: 2xsec <dh48.jeong at samsung.com>
  Date:   2018-07-24 (Tue, 24 Jul 2018)

  Changed paths:
    M src/lxc/tools/lxc_unshare.c

  Log Message:
  -----------
  coverity: #1437949

Argument cannot be negative

Signed-off-by: 2xsec <dh48.jeong at samsung.com>


  Commit: 370caa511371065b3fea86580757a7809d9054ac
      https://github.com/lxc/lxc/commit/370caa511371065b3fea86580757a7809d9054ac
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-07-24 (Tue, 24 Jul 2018)

  Changed paths:
    M src/lxc/confile.c
    M src/lxc/confile_utils.c
    M src/lxc/confile_utils.h

  Log Message:
  -----------
  confile: move signal helpers to confile utils

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: 53c1c865790ccac6831ea4dee8e8963464369705
      https://github.com/lxc/lxc/commit/53c1c865790ccac6831ea4dee8e8963464369705
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-07-24 (Tue, 24 Jul 2018)

  Changed paths:
    M src/lxc/conf.c

  Log Message:
  -----------
  conf: the atime flags are locked in userns

This means they need to be added for remount and for fresh mounts.

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: 9748d3f1dea809b42dcecae499d3564acaa1d3c1
      https://github.com/lxc/lxc/commit/9748d3f1dea809b42dcecae499d3564acaa1d3c1
  Author: Markos Chandras <mchandras at suse.de>
  Date:   2018-07-24 (Tue, 24 Jul 2018)

  Changed paths:
    M config/apparmor/abstractions/start-container

  Log Message:
  -----------
  apparmor: Allow /usr/lib* paths for mount and pivot_root

openSUSE Leap 15 is using --libdir=/usr/lib64 when building for
x86_64 so we need to allow this path in the apparmor profiles.

Link: https://bugzilla.opensuse.org/show_bug.cgi?id=1099239
Signed-off-by: Markos Chandras <mchandras at suse.de>


  Commit: 94d4ec349c7c249871833b7c4dbb2d4cd9c09e1f
      https://github.com/lxc/lxc/commit/94d4ec349c7c249871833b7c4dbb2d4cd9c09e1f
  Author: 2xsec <dh48.jeong at samsung.com>
  Date:   2018-07-24 (Tue, 24 Jul 2018)

  Changed paths:
    M src/lxc/confile_utils.c
    M src/lxc/confile_utils.h

  Log Message:
  -----------
  confile_utils: fix return value & cleanups

Signed-off-by: 2xsec <dh48.jeong at samsung.com>


  Commit: cbeda58276710051c94682dcbb06c94693f3c639
      https://github.com/lxc/lxc/commit/cbeda58276710051c94682dcbb06c94693f3c639
  Author: 2xsec <dh48.jeong at samsung.com>
  Date:   2018-07-24 (Tue, 24 Jul 2018)

  Changed paths:
    M src/lxc/lxccontainer.c

  Log Message:
  -----------
  lxccontainer: coding rules

Signed-off-by: 2xsec <dh48.jeong at samsung.com>


  Commit: 96d48ff33bae06a2f6873ad8a4dd687322ac7d0b
      https://github.com/lxc/lxc/commit/96d48ff33bae06a2f6873ad8a4dd687322ac7d0b
  Author: 2xsec <dh48.jeong at samsung.com>
  Date:   2018-07-24 (Tue, 24 Jul 2018)

  Changed paths:
    M src/lxc/af_unix.c
    M src/lxc/af_unix.h
    M src/lxc/attach.c
    M src/lxc/cmd/lxc_monitord.c
    M src/lxc/commands.c
    M src/lxc/start.c

  Log Message:
  -----------
  af_unix: fix return value & cleanups

Signed-off-by: 2xsec <dh48.jeong at samsung.com>


  Commit: a01dec487b3738f55c3bc5cd0e2e3ee819de145b
      https://github.com/lxc/lxc/commit/a01dec487b3738f55c3bc5cd0e2e3ee819de145b
  Author: 2xsec <dh48.jeong at samsung.com>
  Date:   2018-07-24 (Tue, 24 Jul 2018)

  Changed paths:
    M src/lxc/attach.c
    M src/lxc/start.c
    M src/lxc/utils.c

  Log Message:
  -----------
  attach: fix return value & cleanups

Signed-off-by: 2xsec <dh48.jeong at samsung.com>


  Commit: a71e32ca2fb62edbbb691e76ea5cac8e56e11096
      https://github.com/lxc/lxc/commit/a71e32ca2fb62edbbb691e76ea5cac8e56e11096
  Author: 2xsec <dh48.jeong at samsung.com>
  Date:   2018-07-24 (Tue, 24 Jul 2018)

  Changed paths:
    M doc/ja/lxc-unshare.sgml.in
    M doc/ko/lxc-unshare.sgml.in
    M doc/lxc-unshare.sgml.in

  Log Message:
  -----------
  docs: add long options of lxc-unshare

Signed-off-by: 2xsec <dh48.jeong at samsung.com>


  Commit: 431b95c4a4338e035171bf9608a58598558d82e4
      https://github.com/lxc/lxc/commit/431b95c4a4338e035171bf9608a58598558d82e4
  Author: 2xsec <dh48.jeong at samsung.com>
  Date:   2018-07-24 (Tue, 24 Jul 2018)

  Changed paths:
    M src/lxc/attach.c

  Log Message:
  -----------
  attach: move errno handling

Signed-off-by: 2xsec <dh48.jeong at samsung.com>


  Commit: 03df81a490ff7f03681ad1c71eae41a3aaf8cb6b
      https://github.com/lxc/lxc/commit/03df81a490ff7f03681ad1c71eae41a3aaf8cb6b
  Author: 2xsec <dh48.jeong at samsung.com>
  Date:   2018-07-24 (Tue, 24 Jul 2018)

  Changed paths:
    M src/lxc/confile_utils.c
    M src/lxc/network.c

  Log Message:
  -----------
  thread safe: rand() => rand_r()

Signed-off-by: 2xsec <dh48.jeong at samsung.com>


  Commit: 4819db24a1f715c87d96895a125d3e97bd08eef8
      https://github.com/lxc/lxc/commit/4819db24a1f715c87d96895a125d3e97bd08eef8
  Author: 2xsec <dh48.jeong at samsung.com>
  Date:   2018-07-24 (Tue, 24 Jul 2018)

  Changed paths:
    M src/lxc/attach.c

  Log Message:
  -----------
  coverity: #1438067

Explicit null dereferenced

Signed-off-by: 2xsec <dh48.jeong at samsung.com>


  Commit: 8713009ec5c41a8649fef44d9ef0777c7a6ae466
      https://github.com/lxc/lxc/commit/8713009ec5c41a8649fef44d9ef0777c7a6ae466
  Author: 2xsec <dh48.jeong at samsung.com>
  Date:   2018-07-24 (Tue, 24 Jul 2018)

  Changed paths:
    M doc/ko/lxc-execute.sgml.in

  Log Message:
  -----------
  docs: tools: -d/--daemonize for lxc-execute

Signed-off-by: 2xsec <dh48.jeong at samsung.com>


  Commit: 46b217d75a691d64e37319b1df9c7380399d05b6
      https://github.com/lxc/lxc/commit/46b217d75a691d64e37319b1df9c7380399d05b6
  Author: 2xsec <dh48.jeong at samsung.com>
  Date:   2018-07-24 (Tue, 24 Jul 2018)

  Changed paths:
    M src/lxc/caps.c
    M src/lxc/start.c

  Log Message:
  -----------
  change log macro of error case from lxc_ambient_caps_up/down

Signed-off-by: 2xsec <dh48.jeong at samsung.com>


  Commit: 4d879838422a8a4bf79ff540fa0dbcce4a82d872
      https://github.com/lxc/lxc/commit/4d879838422a8a4bf79ff540fa0dbcce4a82d872
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-07-24 (Tue, 24 Jul 2018)

  Changed paths:
    M src/lxc/confile.h

  Log Message:
  -----------
  confile: add missing header

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


Compare: https://github.com/lxc/lxc/compare/d81111a658da...4d879838422a
      **NOTE:** This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.


More information about the lxc-devel mailing list