[lxc-devel] [lxc/lxc] 882671: conf: simplify lxc_setup_dev_console()

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/lxc/lxc
  Commit: 882671aa99ffcc4ad29cede85d93701f2b94080d
      https://github.com/lxc/lxc/commit/882671aa99ffcc4ad29cede85d93701f2b94080d
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-07-01 (Sun, 01 Jul 2018)

  Changed paths:
    M src/lxc/conf.c

  Log Message:
  -----------
  conf: simplify lxc_setup_dev_console()

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: 3f15bdd9ca7bc2b163c272728f9cc3871800584b
      https://github.com/lxc/lxc/commit/3f15bdd9ca7bc2b163c272728f9cc3871800584b
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-07-01 (Sun, 01 Jul 2018)

  Changed paths:
    M src/lxc/terminal.c

  Log Message:
  -----------
  terminal: safely retrieve path of slave device

openpty() is a horrible function that uses strcpy() into the char *name
argument if name != NULL. We can't rely on the path being sane in all cases so
let's split out the name retrieval to ttyname_r().

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: a9d4ebc1684044eccd7f9f50ad66cacd46e459b1
      https://github.com/lxc/lxc/commit/a9d4ebc1684044eccd7f9f50ad66cacd46e459b1
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-07-01 (Sun, 01 Jul 2018)

  Changed paths:
    M src/lxc/utils.c
    M src/lxc/utils.h

  Log Message:
  -----------
  utils: add fd_cloexec()

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Cc: Wolfgang Bumiller <w.bumiller at proxmox.com>


  Commit: 408c18a185b17e9a3099e20a2d1d74742df03811
      https://github.com/lxc/lxc/commit/408c18a185b17e9a3099e20a2d1d74742df03811
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-07-01 (Sun, 01 Jul 2018)

  Changed paths:
    M src/lxc/terminal.c

  Log Message:
  -----------
  terminal: set FD_CLOEXEC on pty file descriptors

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Cc: Wolfgang Bumiller <w.bumiller at proxmox.com>


  Commit: 5b74eb3cd760f283659fa589de5a910f64a9aa90
      https://github.com/lxc/lxc/commit/5b74eb3cd760f283659fa589de5a910f64a9aa90
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-07-01 (Sun, 01 Jul 2018)

  Changed paths:
    M src/lxc/start.c

  Log Message:
  -----------
  start: delete terminal on error

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: 77f6262f6142eada91c8d3c3aa58faadc94c1994
      https://github.com/lxc/lxc/commit/77f6262f6142eada91c8d3c3aa58faadc94c1994
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-07-01 (Sun, 01 Jul 2018)

  Changed paths:
    M CODING_STYLE.md

  Log Message:
  -----------
  CODING_STYLE: add section about using strlcat()

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: 23c8a516764e15e9c4a1341654314754e1714742
      https://github.com/lxc/lxc/commit/23c8a516764e15e9c4a1341654314754e1714742
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-07-01 (Sun, 01 Jul 2018)

  Changed paths:
    M src/lxc/attach.c

  Log Message:
  -----------
  attach: do not make terminal raw

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: 3d47b3b24d391df4fbaf314f8459169a4464d35d
      https://github.com/lxc/lxc/commit/3d47b3b24d391df4fbaf314f8459169a4464d35d
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-07-01 (Sun, 01 Jul 2018)

  Changed paths:
    M src/tests/attach.c

  Log Message:
  -----------
  tests: remove duplicate file_exists() definition

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: 7e52f25209789c12dd678a0643384e80a71f00bb
      https://github.com/lxc/lxc/commit/7e52f25209789c12dd678a0643384e80a71f00bb
  Author: Stéphane Graber <stgraber at stgraber.org>
  Date:   2018-07-01 (Sun, 01 Jul 2018)

  Changed paths:
    M CODING_STYLE.md
    M src/lxc/attach.c
    M src/lxc/conf.c
    M src/lxc/start.c
    M src/lxc/terminal.c
    M src/lxc/utils.c
    M src/lxc/utils.h
    M src/tests/attach.c

  Log Message:
  -----------
  Merge pull request #2440 from brauner/2018-06-30/console_fixes

terminal: security fixes


Compare: https://github.com/lxc/lxc/compare/2d876a974d20...7e52f2520978
      **NOTE:** This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.