[lxc-devel] [lxc/lxc] d1953b: [cgfsng] show wrong errno

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/lxc/lxc
  Commit: d1953b26c87864808ce77958cccaeac69440fd17
      https://github.com/lxc/lxc/commit/d1953b26c87864808ce77958cccaeac69440fd17
  Author: duguhaotian <duguhaotian at gmail.com>
  Date:   2018-01-26 (Fri, 26 Jan 2018)

  Changed paths:
    M src/lxc/cgroups/cgfsng.c

  Log Message:
  -----------
  [cgfsng] show wrong errno

lxc_cgroup_set_data: h = get_hierarchy(controller);
if h is NULL, now errno is old, it donot set new one.
And then,
cgfsng_setup_limits:

    if (lxc_cgroup_set_data(cg->subsystem, cg->value, d)) {
		if (do_devices && (errno == EACCES ||
			errno == EPERM)) {
			WARN("Error setting %s to %s for %s",
				cg->subsystem, cg->value,
				d->name);
			continue;
		}
		SYSERROR("Error setting %s to %s for
			 %s",
			 cg->subsystem, cg->value,
			 d->name);
		goto out;
	}

SYSERROR will show old errno, make me confused.

Signed-off-by: duguhaotian <duguhaotian at gmail.com>


  Commit: 3fdb1cf431081689f7d3e166d187541a2e0685a1
      https://github.com/lxc/lxc/commit/3fdb1cf431081689f7d3e166d187541a2e0685a1
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-01-26 (Fri, 26 Jan 2018)

  Changed paths:
    M src/lxc/cgroups/cgfsng.c

  Log Message:
  -----------
  Merge pull request #2109 from duguhaotian/new

[cgfsng] show wrong errno


Compare: https://github.com/lxc/lxc/compare/f1289f48d661...3fdb1cf43108