[lxc-devel] [lxc/lxc] 645980: confile: add "force" to cgroup:{mixed, ro, rw}

Wed Feb 21 17:10:53 UTC 2018

  Branch: refs/heads/stable-2.0
  Home:   https://github.com/lxc/lxc
  Commit: 6459800536333dd46e9d69e161393d9efbce151c
      https://github.com/lxc/lxc/commit/6459800536333dd46e9d69e161393d9efbce151c
  Author: Shukui Yang <yangshukui at huawei.com>
  Date:   2018-02-21 (Wed, 21 Feb 2018)

  Changed paths:
    M doc/lxc.container.conf.sgml.in
    M src/lxc/cgroups/cgfsng.c
    M src/lxc/conf.c
    M src/lxc/conf.h
    M src/lxc/confile.c

  Log Message:
  -----------
  confile: add "force" to cgroup:{mixed,ro,rw}

This lets users specify
   lxc.mount.auto = cgroup:mixed:force
or
  lxc.mount.auto = cgroup:ro:force
or
  lxc.mount.auto = cgroup:rw:force

When cgroup namespaces are supported LXC will not mount cgroups for the
container since it assumes that the init system will mount cgroups itself if it
wants to. This assumption already broke when users wanted to run containers
without CAP_SYS_ADMIN. For example, systemd based containers wouldn't start
since systemd needs to mount cgroups (named systemd hierarchy for legacy
cgroups and the unified hierarchy for unified cgroups) to track processes. This
problem was solved by detecting whether the container had CAP_SYS_ADMIN. If it
didn't we performed the cgroup mounts for it.
However, there are more cases when we should be able to mount cgroups for the
container when cgroup namespaces are supported:
- init systems not mounting cgroups themselves:
  A init system that doesn't mount cgroups would not have cgroups available
  especially when combined with custom LSM profiles to prevent cgroup
  {u}mount()ing inside containers.
- application containers:
  Application containers will usually not mount by cgroups themselves.
- read-only cgroups:
  It is useful to be able to mount cgroups read-only to e.g. prevent
  changing cgroup limits from inside the container while at the same time
  allowing the applications to perform introspection on their own cgroups. This
  again is mostly useful for application containers. System containers running
  systemd will usually not work correctly when cgroups are mounted read-only.
To be fair, all of those use-cases could be covered by custom hooks or
lxc.mount.entry entries but exposing it through lxc.mount.auto takes care of
setting correct mount options and adding the necessary logic to e.g. mount
filesystem read-only correctly.

Currently we only extend this to cgroup:{mixed,ro,rw} but technically there's
no reason not to enable the same behavior for cgroup-full:{mixed,ro,rw} as
well. If someone requests this we can simply treat it as a bug and add "force"
for cgroup-full.

Replaces #2136.

Signed-off-by: Shukui Yang <yangshukui at huawei.com>
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 7a825fd0293ffcd429d0ea130c9e393e17488925
      https://github.com/lxc/lxc/commit/7a825fd0293ffcd429d0ea130c9e393e17488925
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-02-21 (Wed, 21 Feb 2018)

  Changed paths:
    M src/lxc/cgroups/cgfsng.c

  Log Message:
  -----------
  cgfsng: order includes

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 1eeda2cbe24ef22de816d631bf6586c67262a8f2
      https://github.com/lxc/lxc/commit/1eeda2cbe24ef22de816d631bf6586c67262a8f2
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-02-21 (Wed, 21 Feb 2018)

  Changed paths:
    M src/lxc/cgroups/cgfsng.c

  Log Message:
  -----------
  cgfsng: fully document struct hierarchy

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 476619a8319fd2d5ee01146094d55888847b34dc
      https://github.com/lxc/lxc/commit/476619a8319fd2d5ee01146094d55888847b34dc
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-02-21 (Wed, 21 Feb 2018)

  Changed paths:
    M src/lxc/cgroups/cgfsng.c

  Log Message:
  -----------
  cgfsng: fully document struct cgfsng_handler_data

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 758cf80e87faed9d0aa4b05621a18e5cee7b52e5
      https://github.com/lxc/lxc/commit/758cf80e87faed9d0aa4b05621a18e5cee7b52e5
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-02-21 (Wed, 21 Feb 2018)

  Changed paths:
    M src/lxc/cgroups/cgfsng.c

  Log Message:
  -----------
  cgfsng: fully document remaining variables

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 692739628062c5d8d204e168be75b18fb7e2d5b7
      https://github.com/lxc/lxc/commit/692739628062c5d8d204e168be75b18fb7e2d5b7
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-02-21 (Wed, 21 Feb 2018)

  Changed paths:
    M src/lxc/cgroups/cgfsng.c

  Log Message:
  -----------
  cgfsng: free_string_list()

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 1856cc07a61e06bff2c1424bd1e6a18d51e04b52
      https://github.com/lxc/lxc/commit/1856cc07a61e06bff2c1424bd1e6a18d51e04b52
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-02-21 (Wed, 21 Feb 2018)

  Changed paths:
    M src/lxc/cgroups/cgfsng.c

  Log Message:
  -----------
  cgfsng: cg_legacy_must_prefix_named()

s/must_prefix_named/cg_legacy_must_prefix_named/

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 19e3ba64f08cf73040b2a685cd271fdac4b60606
      https://github.com/lxc/lxc/commit/19e3ba64f08cf73040b2a685cd271fdac4b60606
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-02-21 (Wed, 21 Feb 2018)

  Changed paths:
    M src/lxc/cgroups/cgfsng.c

  Log Message:
  -----------
  cgfsng: move cg_legacy_must_prefix_named()

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 2c48d4ad9642e2960ce1f9f10e47ac3ed364126b
      https://github.com/lxc/lxc/commit/2c48d4ad9642e2960ce1f9f10e47ac3ed364126b
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-02-21 (Wed, 21 Feb 2018)

  Changed paths:
    M src/lxc/cgroups/cgfsng.c

  Log Message:
  -----------
  cgfsng: add me to authors

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: dd48aa265faa6de7e42f2cf66d7022c6817dedb4
      https://github.com/lxc/lxc/commit/dd48aa265faa6de7e42f2cf66d7022c6817dedb4
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-02-21 (Wed, 21 Feb 2018)

  Changed paths:
    M src/lxc/cgroups/cgfsng.c

  Log Message:
  -----------
  cgfsng: append_null_to_list()

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 7bbf242f993bed7f72e362b9b36fb93c83978bff
      https://github.com/lxc/lxc/commit/7bbf242f993bed7f72e362b9b36fb93c83978bff
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-02-21 (Wed, 21 Feb 2018)

  Changed paths:
    M src/lxc/cgroups/cgfsng.c

  Log Message:
  -----------
  cgfsng: string_in_list()

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: fa9b5420370dfc9ba34d65000678d3c2b8550cdf
      https://github.com/lxc/lxc/commit/fa9b5420370dfc9ba34d65000678d3c2b8550cdf
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-02-21 (Wed, 21 Feb 2018)

  Changed paths:
    M src/lxc/cgroups/cgfsng.c

  Log Message:
  -----------
  cgfsng: must_append_controller()

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 9bc23170b9e18b6c53b9f180d78a2ad8901b85e7
      https://github.com/lxc/lxc/commit/9bc23170b9e18b6c53b9f180d78a2ad8901b85e7
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-02-21 (Wed, 21 Feb 2018)

  Changed paths:
    M src/lxc/cgroups/cgfsng.c

  Log Message:
  -----------
  cgfsng: get_hierarchy()

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 3dfb52bafef30182a8cde68addaa56c3dc9d76f4
      https://github.com/lxc/lxc/commit/3dfb52bafef30182a8cde68addaa56c3dc9d76f4
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-02-21 (Wed, 21 Feb 2018)

  Changed paths:
    M src/lxc/cgroups/cgfsng.c

  Log Message:
  -----------
  cgfsng: lxc_cpumask()

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 6afe522b95debdbf550ad8c4827699e8cce5c55b
      https://github.com/lxc/lxc/commit/6afe522b95debdbf550ad8c4827699e8cce5c55b
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-02-21 (Wed, 21 Feb 2018)

  Changed paths:
    M src/lxc/cgroups/cgfsng.c

  Log Message:
  -----------
  cgfsng: lxc_cpumask_to_cpulist()

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 0b4cd6389ceee7ee301f650d34206a638db79828
      https://github.com/lxc/lxc/commit/0b4cd6389ceee7ee301f650d34206a638db79828
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-02-21 (Wed, 21 Feb 2018)

  Changed paths:
    M src/lxc/cgroups/cgfsng.c

  Log Message:
  -----------
  cgfsng: get_max_cpus()

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: bf222be67668536f9d6ad1aa38b89434d0a60fd4
      https://github.com/lxc/lxc/commit/bf222be67668536f9d6ad1aa38b89434d0a60fd4
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-02-21 (Wed, 21 Feb 2018)

  Changed paths:
    M src/lxc/cgroups/cgfsng.c

  Log Message:
  -----------
  cgfsng: cg_legacy_filter_and_set_cpus()

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: bfde9f34108d73a1a14b7df8058d6504c5db9b51
      https://github.com/lxc/lxc/commit/bfde9f34108d73a1a14b7df8058d6504c5db9b51
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-02-21 (Wed, 21 Feb 2018)

  Changed paths:
    M src/lxc/cgroups/cgfsng.c

  Log Message:
  -----------
  cgfsng: copy_parent_file()

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 6c6e8d2f12ecc9896b5aee930c497b0019fba37f
      https://github.com/lxc/lxc/commit/6c6e8d2f12ecc9896b5aee930c497b0019fba37f
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-02-21 (Wed, 21 Feb 2018)

  Changed paths:
    M src/lxc/cgroups/cgfsng.c

  Log Message:
  -----------
  cgfsng: cg_legacy_handle_cpuset_hierarchy()

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: bb3401caac2df33f19b7169322b8b4c49c96bf52
      https://github.com/lxc/lxc/commit/bb3401caac2df33f19b7169322b8b4c49c96bf52
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-02-21 (Wed, 21 Feb 2018)

  Changed paths:
    M src/lxc/cgroups/cgfsng.c

  Log Message:
  -----------
  cgfsng: controller_lists_intersect()

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 90152412fe367c715c4b910ed188813cc132ff00
      https://github.com/lxc/lxc/commit/90152412fe367c715c4b910ed188813cc132ff00
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-02-21 (Wed, 21 Feb 2018)

  Changed paths:
    M src/lxc/cgroups/cgfsng.c

  Log Message:
  -----------
  cgfsng: controller_list_is_dup()

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: f2c4655d15cf71f6ca8d9ecdc89a5477285562e8
      https://github.com/lxc/lxc/commit/f2c4655d15cf71f6ca8d9ecdc89a5477285562e8
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-02-21 (Wed, 21 Feb 2018)

  Changed paths:
    M src/lxc/cgroups/cgfsng.c

  Log Message:
  -----------
  cgfsng: controller_found()

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: a119b01d86f7db329fab000ff292fea66fb79ad2
      https://github.com/lxc/lxc/commit/a119b01d86f7db329fab000ff292fea66fb79ad2
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-02-21 (Wed, 21 Feb 2018)

  Changed paths:
    M src/lxc/cgroups/cgfsng.c

  Log Message:
  -----------
  cgfsng: all_controllers_found()

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 9888a11262db33ac19f12c49fa77aa6dafbdd5cf
      https://github.com/lxc/lxc/commit/9888a11262db33ac19f12c49fa77aa6dafbdd5cf
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-02-21 (Wed, 21 Feb 2018)

  Changed paths:
    M src/lxc/cgroups/cgfsng.c

  Log Message:
  -----------
  cgfsng: cg_hybrid_get_controllers()

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 533bccb97cce302cad0f89c53dcc5d0604c80077
      https://github.com/lxc/lxc/commit/533bccb97cce302cad0f89c53dcc5d0604c80077
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-02-21 (Wed, 21 Feb 2018)

  Changed paths:
    M src/lxc/cgroups/cgfsng.c

  Log Message:
  -----------
  cgfsng: cg_hybrid_get_mountpoint()

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: f26da40e1dec9f03c5ce07d52c50017437fa9b19
      https://github.com/lxc/lxc/commit/f26da40e1dec9f03c5ce07d52c50017437fa9b19
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-02-21 (Wed, 21 Feb 2018)

  Changed paths:
    M src/lxc/cgroups/cgfsng.c

  Log Message:
  -----------
  cgfsng: copy_to_eol()

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 75818dac17b7a65df3ecd22d8a1f65a0ca7058c1
      https://github.com/lxc/lxc/commit/75818dac17b7a65df3ecd22d8a1f65a0ca7058c1
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-02-21 (Wed, 21 Feb 2018)

  Changed paths:
    M src/lxc/cgroups/cgfsng.c

  Log Message:
  -----------
  cgfsng: controller_in_clist()

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 1f23fb200758e363e748b439fba0e1b435284627
      https://github.com/lxc/lxc/commit/1f23fb200758e363e748b439fba0e1b435284627
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-02-21 (Wed, 21 Feb 2018)

  Changed paths:
    M src/lxc/cgroups/cgfsng.c

  Log Message:
  -----------
  cgfsng: cg_hybrid_get_current_cgroup()

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 81b1669969a555f94c88b6ed7127090343f825af
      https://github.com/lxc/lxc/commit/81b1669969a555f94c88b6ed7127090343f825af
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-02-21 (Wed, 21 Feb 2018)

  Changed paths:
    M src/lxc/cgroups/cgfsng.c

  Log Message:
  -----------
  cgfsng: must_append_string()

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 92c4c41428976fc97a84d77fb94b74caf34acf6d
      https://github.com/lxc/lxc/commit/92c4c41428976fc97a84d77fb94b74caf34acf6d
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-02-21 (Wed, 21 Feb 2018)

  Changed paths:
    M src/lxc/cgroups/cgfsng.c

  Log Message:
  -----------
  cgfsng: trim()

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 1d3cad2d6c35e11d1e3ec13ea55e6c4d1526beaf
      https://github.com/lxc/lxc/commit/1d3cad2d6c35e11d1e3ec13ea55e6c4d1526beaf
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-02-21 (Wed, 21 Feb 2018)

  Changed paths:
    M src/lxc/cgroups/cgfsng.c

  Log Message:
  -----------
  cgfsng: lxc_cgfsng_print_hierarchies()

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: d8b45633573ca00f9be4dc87900f900a770f87e6
      https://github.com/lxc/lxc/commit/d8b45633573ca00f9be4dc87900f900a770f87e6
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-02-21 (Wed, 21 Feb 2018)

  Changed paths:
    M src/lxc/cgroups/cgfsng.c

  Log Message:
  -----------
  cgfsng: lxc_cgfsng_print_basecg_debuginfo()

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: e3b4a126ed0c4249bb75ca1d76d5c9dd4f851f54
      https://github.com/lxc/lxc/commit/e3b4a126ed0c4249bb75ca1d76d5c9dd4f851f54
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-02-21 (Wed, 21 Feb 2018)

  Changed paths:
    M src/lxc/cgroups/cgfsng.c

  Log Message:
  -----------
  cgfsng: cg_hybrid_init()

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: d251d9272a97f26778e3bbfbcac4dfcc473b4ed5
      https://github.com/lxc/lxc/commit/d251d9272a97f26778e3bbfbcac4dfcc473b4ed5
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-02-21 (Wed, 21 Feb 2018)

  Changed paths:
    M src/lxc/cgroups/cgfsng.c

  Log Message:
  -----------
  cgfsng: cg_is_pure_unified()

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 300c37a2274f522833c7633cb89add9afbe31e13
      https://github.com/lxc/lxc/commit/300c37a2274f522833c7633cb89add9afbe31e13
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-02-21 (Wed, 21 Feb 2018)

  Changed paths:
    M src/lxc/cgroups/cgfsng.c

  Log Message:
  -----------
  cgfsng: cg_unified_get_current_cgroup()

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: d515f66beed668a6d1c37b2d2dc70dfce6d298c9
      https://github.com/lxc/lxc/commit/d515f66beed668a6d1c37b2d2dc70dfce6d298c9
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-02-21 (Wed, 21 Feb 2018)

  Changed paths:
    M src/lxc/cgroups/cgfsng.c

  Log Message:
  -----------
  cgfsng: cgfsng_init()

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 8051cfd53f31c132db5f916c7eb2a2394144e027
      https://github.com/lxc/lxc/commit/8051cfd53f31c132db5f916c7eb2a2394144e027
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-02-21 (Wed, 21 Feb 2018)

  Changed paths:
    M src/lxc/cgroups/cgfsng.c

  Log Message:
  -----------
  cgfsng: recursive_destroy()

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: a160c45b7c544f731c1c157546d684afb3d0e847
      https://github.com/lxc/lxc/commit/a160c45b7c544f731c1c157546d684afb3d0e847
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-02-21 (Wed, 21 Feb 2018)

  Changed paths:
    M src/lxc/cgroups/cgfsng.c

  Log Message:
  -----------
  cgfsng: cg_unified_create_cgroup()

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 923049675d1ad880e64f4b7b204aa7f43b57e1a3
      https://github.com/lxc/lxc/commit/923049675d1ad880e64f4b7b204aa7f43b57e1a3
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-02-21 (Wed, 21 Feb 2018)

  Changed paths:
    M src/lxc/cgroups/cgfsng.c

  Log Message:
  -----------
  cgfsng: create_path_for_hierarchy()

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 77a3a03e7d2e79b4624636a7424e6b4a6b3497cb
      https://github.com/lxc/lxc/commit/77a3a03e7d2e79b4624636a7424e6b4a6b3497cb
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-02-21 (Wed, 21 Feb 2018)

  Changed paths:
    M src/lxc/cgroups/cgfsng.c

  Log Message:
  -----------
  cgfsng: remove_path_for_hierarchy()

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: d1ef2d9187e1986c0b4c2066734c9546fd338bcf
      https://github.com/lxc/lxc/commit/d1ef2d9187e1986c0b4c2066734c9546fd338bcf
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-02-21 (Wed, 21 Feb 2018)

  Changed paths:
    M src/lxc/cgroups/cgfsng.c

  Log Message:
  -----------
  cgfsng: cgfsng_create()

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: c4228c5b27e4f539c41a5ccb5a7bf26219d34707
      https://github.com/lxc/lxc/commit/c4228c5b27e4f539c41a5ccb5a7bf26219d34707
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-02-21 (Wed, 21 Feb 2018)

  Changed paths:
    M src/lxc/cgroups/cgfsng.c

  Log Message:
  -----------
  cgfsng: cgfsng_enter()

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: f73fcbf975f519151399ef6a94bfa0dc37d7ec86
      https://github.com/lxc/lxc/commit/f73fcbf975f519151399ef6a94bfa0dc37d7ec86
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-02-21 (Wed, 21 Feb 2018)

  Changed paths:
    M src/lxc/cgroups/cgfsng.c

  Log Message:
  -----------
  cgfsng: cgfsng_chown()

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 643b9674d2e8c84db7d1b7b3019b2f355cf2055e
      https://github.com/lxc/lxc/commit/643b9674d2e8c84db7d1b7b3019b2f355cf2055e
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-02-21 (Wed, 21 Feb 2018)

  Changed paths:
    M src/lxc/cgroups/cgfsng.c

  Log Message:
  -----------
  cgfsng: mount_cgroup_full()

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: f283d72b6abce6ea712e01dd9cb9c5b4f1ba512e
      https://github.com/lxc/lxc/commit/f283d72b6abce6ea712e01dd9cb9c5b4f1ba512e
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-02-21 (Wed, 21 Feb 2018)

  Changed paths:
    M src/lxc/cgroups/cgfsng.c

  Log Message:
  -----------
  cgfsng: cgfsng_mount()

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: fad3f655c227b1c1aee53ce905ba7aa5f9ce0673
      https://github.com/lxc/lxc/commit/fad3f655c227b1c1aee53ce905ba7aa5f9ce0673
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-02-21 (Wed, 21 Feb 2018)

  Changed paths:
    M src/lxc/cgroups/cgfsng.c

  Log Message:
  -----------
  cgfsng: recursive_count_nrtasks()

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 4fd41ab1919b0b19a7fcc08e8a751e1e094ef773
      https://github.com/lxc/lxc/commit/4fd41ab1919b0b19a7fcc08e8a751e1e094ef773
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-02-21 (Wed, 21 Feb 2018)

  Changed paths:
    M src/lxc/cgroups/cgfsng.c

  Log Message:
  -----------
  cgfsng: recursive_count_nrtasks()

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 8992a33a02b3b5c6ee73bee0bc4ab55784a10bf2
      https://github.com/lxc/lxc/commit/8992a33a02b3b5c6ee73bee0bc4ab55784a10bf2
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-02-21 (Wed, 21 Feb 2018)

  Changed paths:
    M src/lxc/cgroups/cgfsng.c

  Log Message:
  -----------
  cgfsng: cgfsng_escape()

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 9b4200498cf1617fc4ec1f8b3b52936e9c7a2ea7
      https://github.com/lxc/lxc/commit/9b4200498cf1617fc4ec1f8b3b52936e9c7a2ea7
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-02-21 (Wed, 21 Feb 2018)

  Changed paths:
    M src/lxc/cgroups/cgfsng.c

  Log Message:
  -----------
  cgfsng: build_full_cgpath_from_monitorpath()

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 8f975b98e4c1f33ac6dec606d5e9e3c8602c8a38
      https://github.com/lxc/lxc/commit/8f975b98e4c1f33ac6dec606d5e9e3c8602c8a38
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-02-21 (Wed, 21 Feb 2018)

  Changed paths:
    M src/lxc/cgroups/cgfsng.c

  Log Message:
  -----------
  cgfsng: __cg_unified_attach()

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 7c625b530963e4e1624899bf5a9e2eb2814de8c4
      https://github.com/lxc/lxc/commit/7c625b530963e4e1624899bf5a9e2eb2814de8c4
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-02-21 (Wed, 21 Feb 2018)

  Changed paths:
    M src/lxc/cgroups/cgfsng.c

  Log Message:
  -----------
  cgfsng: cgfsng_attach()

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 49b156cf187e99307e5ddae2f19575f766307ed0
      https://github.com/lxc/lxc/commit/49b156cf187e99307e5ddae2f19575f766307ed0
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-02-21 (Wed, 21 Feb 2018)

  Changed paths:
    M src/lxc/cgroups/cgfsng.c

  Log Message:
  -----------
  cgfsng: cgfsng_get()

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: b03b723771bf9225c526f30ced336e22d14ef36c
      https://github.com/lxc/lxc/commit/b03b723771bf9225c526f30ced336e22d14ef36c
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-02-21 (Wed, 21 Feb 2018)

  Changed paths:
    M src/lxc/cgroups/cgfsng.c

  Log Message:
  -----------
  cgfsng: cgfsng_set()

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 4a185bf68e6c99c8cb58af52454a374e28ed6f92
      https://github.com/lxc/lxc/commit/4a185bf68e6c99c8cb58af52454a374e28ed6f92
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-02-21 (Wed, 21 Feb 2018)

  Changed paths:
    M src/lxc/cgroups/cgfsng.c

  Log Message:
  -----------
  cgfsng: convert_devpath()

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: d8acdf54f685fc30329842d6213eb3eacbd02be9
      https://github.com/lxc/lxc/commit/d8acdf54f685fc30329842d6213eb3eacbd02be9
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-02-21 (Wed, 21 Feb 2018)

  Changed paths:
    M src/lxc/cgroups/cgfsng.c

  Log Message:
  -----------
  cgfsng: cg_legacy_set_data()

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 96ef603bc2cc9473f56634b52ae0460d82870afc
      https://github.com/lxc/lxc/commit/96ef603bc2cc9473f56634b52ae0460d82870afc
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-02-21 (Wed, 21 Feb 2018)

  Changed paths:
    M src/lxc/cgroups/cgfsng.c

  Log Message:
  -----------
  cgfsng: __cg_legacy_setup_limits()

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 586bd38c0b3b19febec871f17ef1d2dc741ec17b
      https://github.com/lxc/lxc/commit/586bd38c0b3b19febec871f17ef1d2dc741ec17b
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-02-21 (Wed, 21 Feb 2018)

  Changed paths:
    M src/lxc/lxccontainer.c

  Log Message:
  -----------
  lxccontainer: use wait_for_pid()

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 8f8aefcc7556448f400a618212448021324ab78c
      https://github.com/lxc/lxc/commit/8f8aefcc7556448f400a618212448021324ab78c
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-02-21 (Wed, 21 Feb 2018)

  Changed paths:
    M src/lxc/start.c

  Log Message:
  -----------
  start: remove duplicate lxc_monitor_send_state()

Closes #2177.

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 96f0cf3b67a9dd5630204934c1b46bae708191ce
      https://github.com/lxc/lxc/commit/96f0cf3b67a9dd5630204934c1b46bae708191ce
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-02-21 (Wed, 21 Feb 2018)

  Changed paths:
    M src/lxc/conf.c
    M src/lxc/console.c

  Log Message:
  -----------
  tree-wide: remove locking around openpty()

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 7669dc3415df97f3062af07a00a31f73f6af0ada
      https://github.com/lxc/lxc/commit/7669dc3415df97f3062af07a00a31f73f6af0ada
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-02-21 (Wed, 21 Feb 2018)

  Changed paths:
    M src/lxc/commands.c
    M src/lxc/start.c

  Log Message:
  -----------
  {commands,start}: remove element from list first

First remove the client from the list then close the fd. Otherwise we open
ourselves to a race where another codepath might be writing to a bad file
descriptor.

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 05ee16e7c0e56b0e33ee311264eae1d8a893f2ba
      https://github.com/lxc/lxc/commit/05ee16e7c0e56b0e33ee311264eae1d8a893f2ba
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-02-21 (Wed, 21 Feb 2018)

  Changed paths:
    M src/lxc/start.c

  Log Message:
  -----------
  start: use correct prefix for includes

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: e836f50a34bcedf705e08e2b48d1355b7f01af43
      https://github.com/lxc/lxc/commit/e836f50a34bcedf705e08e2b48d1355b7f01af43
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-02-21 (Wed, 21 Feb 2018)

  Changed paths:
    M src/lxc/start.c

  Log Message:
  -----------
  start: print_top_failing_dir()

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 0d98d3670aad686b86bd41788dead2d9a0ee273c
      https://github.com/lxc/lxc/commit/0d98d3670aad686b86bd41788dead2d9a0ee273c
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-02-21 (Wed, 21 Feb 2018)

  Changed paths:
    M src/lxc/start.c

  Log Message:
  -----------
  start: close_ns()

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: d2f10912ee4575445a9c630fa93380078127b843
      https://github.com/lxc/lxc/commit/d2f10912ee4575445a9c630fa93380078127b843
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-02-21 (Wed, 21 Feb 2018)

  Changed paths:
    M src/lxc/start.c

  Log Message:
  -----------
  start: preserve_ns()

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 7070388108c3d5db14a7083c6a34a2188cd5be8b
      https://github.com/lxc/lxc/commit/7070388108c3d5db14a7083c6a34a2188cd5be8b
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-02-21 (Wed, 21 Feb 2018)

  Changed paths:
    M src/lxc/start.c

  Log Message:
  -----------
  start: lxc_check_inherited()

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: be576e1e2f2058621d61710b7597b19d9a1dd29d
      https://github.com/lxc/lxc/commit/be576e1e2f2058621d61710b7597b19d9a1dd29d
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-02-21 (Wed, 21 Feb 2018)

  Changed paths:
    M src/lxc/start.c

  Log Message:
  -----------
  start: signal_handler()

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 90f0753b4bd842a478767bffbd28dddf6a63d61b
      https://github.com/lxc/lxc/commit/90f0753b4bd842a478767bffbd28dddf6a63d61b
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-02-21 (Wed, 21 Feb 2018)

  Changed paths:
    M src/lxc/start.c

  Log Message:
  -----------
  start: lxc_poll()

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: bba8123b4ed9e188d2eeab0a24ba6f5068845960
      https://github.com/lxc/lxc/commit/bba8123b4ed9e188d2eeab0a24ba6f5068845960
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-02-21 (Wed, 21 Feb 2018)

  Changed paths:
    M src/lxc/start.c

  Log Message:
  -----------
  start: lxc_init_handler()

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 345a035cdd522a3b2e53c951cdfa9ce4e797ad73
      https://github.com/lxc/lxc/commit/345a035cdd522a3b2e53c951cdfa9ce4e797ad73
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-02-21 (Wed, 21 Feb 2018)

  Changed paths:
    M src/lxc/start.c

  Log Message:
  -----------
  start: lxc_init()

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 66fe45774d091bf78259fda2d466ad92e5e7532e
      https://github.com/lxc/lxc/commit/66fe45774d091bf78259fda2d466ad92e5e7532e
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-02-21 (Wed, 21 Feb 2018)

  Changed paths:
    M src/lxc/start.c

  Log Message:
  -----------
  start: lxc_abort()

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 5ce9195ba78c1235fc66c1f6c718e2cb5600c809
      https://github.com/lxc/lxc/commit/5ce9195ba78c1235fc66c1f6c718e2cb5600c809
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-02-21 (Wed, 21 Feb 2018)

  Changed paths:
    M src/lxc/start.c

  Log Message:
  -----------
  start: start()

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: ba7d715b330cc47b2c52cc4375fb25a96f820d39
      https://github.com/lxc/lxc/commit/ba7d715b330cc47b2c52cc4375fb25a96f820d39
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-02-21 (Wed, 21 Feb 2018)

  Changed paths:
    M src/lxc/start.c

  Log Message:
  -----------
  start: post_start()

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: a3c089a791e02832088d04df8ccc62517fa30739
      https://github.com/lxc/lxc/commit/a3c089a791e02832088d04df8ccc62517fa30739
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-02-21 (Wed, 21 Feb 2018)

  Changed paths:
    M src/lxc/start.c

  Log Message:
  -----------
  start: lxc_destroy_container_on_signal()

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: a2105514cf9b52a34fc3403e5c4c29d7ada1a116
      https://github.com/lxc/lxc/commit/a2105514cf9b52a34fc3403e5c4c29d7ada1a116
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-02-21 (Wed, 21 Feb 2018)

  Changed paths:
    M src/lxc/start.c

  Log Message:
  -----------
  start: do_destroy_container()

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 834b74a070970ffe4895bc72e19804f7fd4b3c5f
      https://github.com/lxc/lxc/commit/834b74a070970ffe4895bc72e19804f7fd4b3c5f
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-02-21 (Wed, 21 Feb 2018)

  Changed paths:
    M src/lxc/cgroups/cgfsng.c
    M src/lxc/confile.c

  Log Message:
  -----------
  cgfsng: enable "force" for "cgroup-full"

This enables cgroup-full:{mixed,ro,rw}:force and reworks the mount logic.
When cgroup-full was specified we used to bind-mount the cgroups from the host.
That is pretty weird thing to do given that you can simply mount them directly
without going through bind-mounts.

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

Compare: https://github.com/lxc/lxc/compare/46bd3acf5691...834b74a07097