[lxc-devel] [lxc/lxc] 5cdc9b: lxclock: remove pthread_atfork_handlers

GitHub noreply at github.com
Sat Feb 17 12:51:14 UTC 2018


  Branch: refs/heads/stable-2.0
  Home:   https://github.com/lxc/lxc
  Commit: 5cdc9b306b15f5986b4d71a36b03216f85b00d8f
      https://github.com/lxc/lxc/commit/5cdc9b306b15f5986b4d71a36b03216f85b00d8f
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-02-17 (Sat, 17 Feb 2018)

  Changed paths:
    M src/lxc/attach.c
    M src/lxc/lxclock.c

  Log Message:
  -----------
  lxclock: remove pthread_atfork_handlers

They shouldn't be needed anymore.

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: d5addf792f2573b0b8ff233ede302134ee58a215
      https://github.com/lxc/lxc/commit/d5addf792f2573b0b8ff233ede302134ee58a215
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-02-17 (Sat, 17 Feb 2018)

  Changed paths:
    M src/lxc/cgroups/cgfsng.c

  Log Message:
  -----------
  cgfsng: simplifications and fixes

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: 32773a5d7c64fef3ff22ab450faf6ab78c9d9f6b
      https://github.com/lxc/lxc/commit/32773a5d7c64fef3ff22ab450faf6ab78c9d9f6b
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-02-17 (Sat, 17 Feb 2018)

  Changed paths:
    M CONTRIBUTING

  Log Message:
  -----------
  CONTRIBUTING: update

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: 14ea1a1a2ae5d7db91a3d94d310e95a01129f6cd
      https://github.com/lxc/lxc/commit/14ea1a1a2ae5d7db91a3d94d310e95a01129f6cd
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-02-17 (Sat, 17 Feb 2018)

  Changed paths:
    A CODING_STYLE.md
    M CONTRIBUTING

  Log Message:
  -----------
  CODING_STYLE: add CODING_STYLE.md

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: 6af4c1323612f107988167c4c56201e16a4d843c
      https://github.com/lxc/lxc/commit/6af4c1323612f107988167c4c56201e16a4d843c
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-02-17 (Sat, 17 Feb 2018)

  Changed paths:
    M src/lxc/cgroups/cgfsng.c

  Log Message:
  -----------
  cgroups: use correct mask for chmod()

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: dc1e50c2d7a8808643034e1aa0558adc04e5cf00
      https://github.com/lxc/lxc/commit/dc1e50c2d7a8808643034e1aa0558adc04e5cf00
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-02-17 (Sat, 17 Feb 2018)

  Changed paths:
    M CODING_STYLE.md

  Log Message:
  -----------
  CODING_STYLE: add section for str{n}cmp()

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: c5c238356989e38b84a58d26846e64f89445211f
      https://github.com/lxc/lxc/commit/c5c238356989e38b84a58d26846e64f89445211f
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-02-17 (Sat, 17 Feb 2018)

  Changed paths:
    M src/tests/Makefile.am
    R src/tests/lxc-test-ubuntu

  Log Message:
  -----------
  tests: remove lxc-test-ubuntu

This is really taking a long time for not a lot of benefit.

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: b21dcea482701f814e8797dc2168882d58cc8326
      https://github.com/lxc/lxc/commit/b21dcea482701f814e8797dc2168882d58cc8326
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-02-17 (Sat, 17 Feb 2018)

  Changed paths:
    M src/lxc/utils.c

  Log Message:
  -----------
  utils: fix lxc_p{close,open}()

If a file descriptor fd is opened by fdopen() and associated with a stream f
will **not** have been dup()ed. This means that fclose(f) will also close the
fd. So never call close(fd) after fdopen(fd) succeeded.
This fixes a double close() Stéphane and I observed when debugging on aarch64
and armf.

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: a376d63e7691e1dcc22647b2b31a45a886ee0a17
      https://github.com/lxc/lxc/commit/a376d63e7691e1dcc22647b2b31a45a886ee0a17
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-02-17 (Sat, 17 Feb 2018)

  Changed paths:
    M src/lxc/start.c

  Log Message:
  -----------
  start: don't call close on invalid file descriptor

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: 84bdd46000f8452857efc6acd1af4a512f122b7c
      https://github.com/lxc/lxc/commit/84bdd46000f8452857efc6acd1af4a512f122b7c
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-02-17 (Sat, 17 Feb 2018)

  Changed paths:
    M src/lxc/console.c

  Log Message:
  -----------
  console: ensure that fd is marked EBADF

If the handler closes the file descriptor for the peer or master fd it is
crucial that we mark it as -EBADF. This will prevent lxc_console_delete()
from calling close() on an already closed file descriptor again. I've
observed the double close in the attach code.

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: 46bd3acf5691b1bd650379f4892d1997a57717af
      https://github.com/lxc/lxc/commit/46bd3acf5691b1bd650379f4892d1997a57717af
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-02-17 (Sat, 17 Feb 2018)

  Changed paths:
    M README.md

  Log Message:
  -----------
  README: add coverity

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


Compare: https://github.com/lxc/lxc/compare/48440ef8c3ee...46bd3acf5691


More information about the lxc-devel mailing list