[lxc-devel] [lxc/lxc] cbec95: lxc-test-unpriv: check user existence before remov...

Wed Feb 7 11:35:23 UTC 2018

  Branch: refs/heads/stable-1.0
  Home:   https://github.com/lxc/lxc
  Commit: cbec95c1f6081c383ac489d68dffaef1ce1d4ed0
      https://github.com/lxc/lxc/commit/cbec95c1f6081c383ac489d68dffaef1ce1d4ed0
  Author: Po-Hsu Lin <po-hsu.lin at canonical.com>
  Date:   2018-02-07 (Wed, 07 Feb 2018)

  Changed paths:
    M src/tests/lxc-test-unpriv

  Log Message:
  -----------
  lxc-test-unpriv: check user existence before removing it

Check the test user (lxcunpriv) before calling deluser command,
otherwise it will print unnecessary error message:
/usr/sbin/deluser: The user 'lxcunpriv' does not exist.

Signed-off-by: Po-Hsu Lin <po-hsu.lin at canonical.com>

  Commit: 6d5f43e13f83919283e837d6ba897f9a550e10d8
      https://github.com/lxc/lxc/commit/6d5f43e13f83919283e837d6ba897f9a550e10d8
  Author: Marcos Paulo de Souza <marcos.souza.org at gmail.com>
  Date:   2018-02-07 (Wed, 07 Feb 2018)

  Changed paths:
    A config/ax_pthread.m4
    M configure.ac

  Log Message:
  -----------
  Use AX_PTHREAD config script to detect pthread api

Closes: #84

Signed-off-by: Marcos Paulo de Souza <marcos.souza.org at gmail.com>

  Commit: 17cac30cee2c8e30b6c3d6e70eec2540de0f7c4a
      https://github.com/lxc/lxc/commit/17cac30cee2c8e30b6c3d6e70eec2540de0f7c4a
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-02-07 (Wed, 07 Feb 2018)

  Changed paths:
    M .travis.yml

  Log Message:
  -----------
  test: reenable Coverity integration

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 7e2624f3209a6137084b911059fc01b454d74f9c
      https://github.com/lxc/lxc/commit/7e2624f3209a6137084b911059fc01b454d74f9c
  Author: Serge Hallyn <shallyn at cisco.com>
  Date:   2018-02-07 (Wed, 07 Feb 2018)

  Changed paths:
    M src/lxc/execute.c

  Log Message:
  -----------
  lxc_execute: properly figure out number of needed arguments

The lxc_log args have noghing to do with lxc.rootfs.path, and
we need room for a NULL at end of arguments.

How this bug was hidden for so long I don't know - I can only
trigger it on certain systems under certain conditions, but it's
definately wrong as is.

Signed-off-by: Serge Hallyn <shallyn at cisco.com>

  Commit: 241f7d14656d9479a5b5cfc258743ac71d44bb2f
      https://github.com/lxc/lxc/commit/241f7d14656d9479a5b5cfc258743ac71d44bb2f
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-02-07 (Wed, 07 Feb 2018)

  Changed paths:
    M src/lxc/cgfs.c

  Log Message:
  -----------
  coverity: #1425923

avoid NULL-pointer dereference

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: d83e85cf5a3a8b40af034e2ee3434910f40d3220
      https://github.com/lxc/lxc/commit/d83e85cf5a3a8b40af034e2ee3434910f40d3220
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-02-07 (Wed, 07 Feb 2018)

  Changed paths:
    M src/lxc/attach.c

  Log Message:
  -----------
  coverity: #1425921

free allocated memory

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 120fa8f855c5eed10852950c7b37f3878acdbfd9
      https://github.com/lxc/lxc/commit/120fa8f855c5eed10852950c7b37f3878acdbfd9
  Author: Marcos Paulo de Souza <marcos.souza.org at gmail.com>
  Date:   2018-02-07 (Wed, 07 Feb 2018)

  Changed paths:
    M src/lxc/cgmanager.c
    M src/lxc/lxclock.c

  Log Message:
  -----------
  lxc: Distinguish pthread_mutex_unlock error messages

The same message exists in lxclock.c and cgmanager.c, so print the
filename along with the message.

Before this patch:
lxc-destroy -n u1
pthread_mutex_unlock returned:1 Operation not permitted

After this patch:
xc-destroy -n u1
lxclock.c: pthread_mutex_unlock returned:1 Operation not permitted

Signed-off-by: Marcos Paulo de Souza <marcos.souza.org at gmail.com>

  Commit: 5a7c6e01fb73460a258973a4163fde167589892a
      https://github.com/lxc/lxc/commit/5a7c6e01fb73460a258973a4163fde167589892a
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-02-07 (Wed, 07 Feb 2018)

  Changed paths:
    M src/lxc/af_unix.c

  Log Message:
  -----------
  coverity: #1425893

used calculated string length when copying into buffer

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: ccc1619dcbf779cfdb203a2c18e0a05e10cc5cb9
      https://github.com/lxc/lxc/commit/ccc1619dcbf779cfdb203a2c18e0a05e10cc5cb9
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-02-07 (Wed, 07 Feb 2018)

  Changed paths:
    M src/lxc/lxccontainer.c

  Log Message:
  -----------
  coverity: #1425883

ensure \0-termination

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: bbcb463c8aaab3b71cfb50dfcb572a2246310765
      https://github.com/lxc/lxc/commit/bbcb463c8aaab3b71cfb50dfcb572a2246310765
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-02-07 (Wed, 07 Feb 2018)

  Changed paths:
    M src/lxc/lxccontainer.c

  Log Message:
  -----------
  coverity: #1425863

remove logically dead code

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 3c3e0cb5309c6eddc3004284e096074650f14395
      https://github.com/lxc/lxc/commit/3c3e0cb5309c6eddc3004284e096074650f14395
  Author: Marcos Paulo de Souza <marcos.souza.org at gmail.com>
  Date:   2018-02-07 (Wed, 07 Feb 2018)

  Changed paths:
    M src/lxc/lxc_config.c

  Log Message:
  -----------
  lxc_config: Add -h and --help flags handler

As the other tools already handle, show usage message when -h or --help
are used.

Signed-off-by: Marcos Paulo de Souza <marcos.souza.org at gmail.com>

  Commit: 558add0fba8162243a0521c661fba896978224ce
      https://github.com/lxc/lxc/commit/558add0fba8162243a0521c661fba896978224ce
  Author: LiFeng <lifeng68 at huawei.com>
  Date:   2018-02-07 (Wed, 07 Feb 2018)

  Changed paths:
    M src/lxc/lxccontainer.c

  Log Message:
  -----------
  Add return check for 'lxc_cmd_get_name'

If 'lxc_cmd_get_name' failed and return with NULL, this would cause a segment fault.

Signed-off-by: LiFeng <lifeng68 at huawei.com>

  Commit: 10e5c67e71e70712dff0017e70b9dea7b8f159fc
      https://github.com/lxc/lxc/commit/10e5c67e71e70712dff0017e70b9dea7b8f159fc
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-02-07 (Wed, 07 Feb 2018)

  Changed paths:
    M src/lxc/console.c

  Log Message:
  -----------
  console: set SFD_CLOEXEC on signal fd

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 1bab0cad99186b4922fe8d03832f4c29ad836429
      https://github.com/lxc/lxc/commit/1bab0cad99186b4922fe8d03832f4c29ad836429
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-02-07 (Wed, 07 Feb 2018)

  Changed paths:
    M src/lxc/freezer.c

  Log Message:
  -----------
  freezer: non-functional changes

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: e14d827055df730ec85cbe26938a37d787f31998
      https://github.com/lxc/lxc/commit/e14d827055df730ec85cbe26938a37d787f31998
  Author: Tycho Andersen <tycho at tycho.ws>
  Date:   2018-02-07 (Wed, 07 Feb 2018)

  Changed paths:
    M src/lxc/lxc_init.c

  Log Message:
  -----------
  unlink lxc-init

It's sort of an implementation detail that this exists at all, and we
should probably not pollute the container's mount tables or FS with this.

Signed-off-by: Tycho Andersen <tycho at tycho.ws>

  Commit: a48622d85140e329298f7ae2e45f7ce14449de0a
      https://github.com/lxc/lxc/commit/a48622d85140e329298f7ae2e45f7ce14449de0a
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-02-07 (Wed, 07 Feb 2018)

  Changed paths:
    M src/lxc/lxc_init.c

  Log Message:
  -----------
  coverity: #1427668

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 02b05b04bbd65d31086ad530bb5cd7c2e98751fa
      https://github.com/lxc/lxc/commit/02b05b04bbd65d31086ad530bb5cd7c2e98751fa
  Author: Tycho Andersen <tycho at tycho.ws>
  Date:   2018-02-07 (Wed, 07 Feb 2018)

  Changed paths:
    M src/lxc/utils.c

  Log Message:
  -----------
  better check for lock dir

Consider the case where we're running in a user namespace but in the host's
mount ns with the host's filesystem (something like
lxc-usernsexec ... lxc-execute ...), in this case, we'll be euid 0, but we
can't actually write to /run. Let's improve this locking check to make sure
we can actually write to /run before we decide to actually use it as our
locking dir.

Signed-off-by: Tycho Andersen <tycho at tycho.ws>

  Commit: 0dfed0f902b9bc0df7518d32c217f89696de4d4b
      https://github.com/lxc/lxc/commit/0dfed0f902b9bc0df7518d32c217f89696de4d4b
  Author: Tycho Andersen <tycho at tycho.ws>
  Date:   2018-02-07 (Wed, 07 Feb 2018)

  Changed paths:
    M src/lxc/utils.h

  Log Message:
  -----------
  better unprivileged detection

In particular, if we are already in a user namespace we are unprivileged,
and doing things like moving the physical nics back to the host netns won't
work. Let's do the same thing LXD does if euid == 0: inspect
/proc/self/uid_map and see what that says.

Signed-off-by: Tycho Andersen <tycho at tycho.ws>

  Commit: fb029c014ef3fdaa8e6889c610bb116361a1d73e
      https://github.com/lxc/lxc/commit/fb029c014ef3fdaa8e6889c610bb116361a1d73e
  Author: Stéphane Graber <stgraber at ubuntu.com>
  Date:   2018-02-07 (Wed, 07 Feb 2018)

  Changed paths:
    M templates/lxc-debian.in

  Log Message:
  -----------
  debian: Use iproute2 instead of iproute

The package has pretty much always been iproute2 with iproute being an
alias for it, the alias is now gone so we need to use iproute2.

Signed-off-by: Stéphane Graber <stgraber at ubuntu.com>

  Commit: ef2f262210eec3c0bff90f3db0eb519ee01e392f
      https://github.com/lxc/lxc/commit/ef2f262210eec3c0bff90f3db0eb519ee01e392f
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-02-07 (Wed, 07 Feb 2018)

  Changed paths:
    M src/lxc/arguments.c

  Log Message:
  -----------
  tools: make "-n" optional

This lets users use the tools with "lxc-* -n <container-name>" or
"lxc-* <container-name>".

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 9bbb1ed81741c08df122bb9c8c2975642ccfc136
      https://github.com/lxc/lxc/commit/9bbb1ed81741c08df122bb9c8c2975642ccfc136
  Author: Stéphane Graber <stgraber at ubuntu.com>
  Date:   2018-02-07 (Wed, 07 Feb 2018)

  Changed paths:
    M templates/lxc-debian.in

  Log Message:
  -----------
  debian: We must use iproute on wheezy

Signed-off-by: Stéphane Graber <stgraber at ubuntu.com>

Compare: https://github.com/lxc/lxc/compare/74941f9a3376...9bbb1ed81741