[lxc-devel] [lxc/lxc] 7a3e28: secure coding: #2 strcpy => strlcpy

[GitHub]

  Branch: refs/heads/stable-2.0
  Home:   https://github.com/lxc/lxc
  Commit: 7a3e2867cb96e65fa5091bc3a7cf9c336547ee4a
      https://github.com/lxc/lxc/commit/7a3e2867cb96e65fa5091bc3a7cf9c336547ee4a
  Author: Donghwa Jeong <dh48.jeong at samsung.com>
  Date:   2018-12-10 (Mon, 10 Dec 2018)

  Changed paths:
    M src/lxc/initutils.c
    M src/lxc/lxc_user_nic.c
    M src/lxc/storage/nbd.c
    M src/lxc/storage/storage.c
    M src/lxc/utils.c

  Log Message:
  -----------
  secure coding: #2 strcpy => strlcpy

Signed-off-by: Donghwa Jeong <dh48.jeong at samsung.com>


  Commit: 743a299439149aee308d6a882de315aab639e551
      https://github.com/lxc/lxc/commit/743a299439149aee308d6a882de315aab639e551
  Author: Donghwa Jeong <dh48.jeong at samsung.com>
  Date:   2018-12-10 (Mon, 10 Dec 2018)

  Changed paths:
    M src/lxc/tools/lxc_usernsexec.c

  Log Message:
  -----------
  fix fd handle leak

Signed-off-by: Donghwa Jeong <dh48.jeong at samsung.com>


  Commit: a3d67822f349361eb1541125340b480f06e08a03
      https://github.com/lxc/lxc/commit/a3d67822f349361eb1541125340b480f06e08a03
  Author: Donghwa Jeong <dh48.jeong at samsung.com>
  Date:   2018-12-10 (Mon, 10 Dec 2018)

  Changed paths:
    M src/tests/get_item.c

  Log Message:
  -----------
  fix pointer c is dereferenced after checking null

Signed-off-by: Donghwa Jeong <dh48.jeong at samsung.com>


  Commit: ebd961d2466c25ef17051da8b7a5f36778df0333
      https://github.com/lxc/lxc/commit/ebd961d2466c25ef17051da8b7a5f36778df0333
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-12-10 (Mon, 10 Dec 2018)

  Changed paths:
    M src/lxc/commands.c

  Log Message:
  -----------
  commands: simplify lxc_cmd()

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: d3ff0fdfef3b556434b2710cd744edc2c56e46a7
      https://github.com/lxc/lxc/commit/d3ff0fdfef3b556434b2710cd744edc2c56e46a7
  Author: 2xsec <dh48.jeong at samsung.com>
  Date:   2018-12-10 (Mon, 10 Dec 2018)

  Changed paths:
    M src/lxc/monitor.c

  Log Message:
  -----------
  monitor: change exit() => _exit() system call in child process

Signed-off-by: 2xsec <dh48.jeong at samsung.com>


  Commit: f1f839b88121e7a405baf2af4c6e6e4c71314f80
      https://github.com/lxc/lxc/commit/f1f839b88121e7a405baf2af4c6e6e4c71314f80
  Author: 2xsec <dh48.jeong at samsung.com>
  Date:   2018-12-10 (Mon, 10 Dec 2018)

  Changed paths:
    M lxc.spec.in

  Log Message:
  -----------
  move some comments in lxc.spec.in

Signed-off-by: 2xsec <dh48.jeong at samsung.com>


  Commit: 14a740a620558daf092790b82ef6aaed515eca63
      https://github.com/lxc/lxc/commit/14a740a620558daf092790b82ef6aaed515eca63
  Author: 2xsec <dh48.jeong at samsung.com>
  Date:   2018-12-10 (Mon, 10 Dec 2018)

  Changed paths:
    M src/lxc/log.h
    M src/lxc/lsm/apparmor.c
    M src/lxc/lsm/lsm.c
    M src/lxc/lsm/selinux.c
    M src/lxc/monitor.c
    M src/lxc/state.c
    M src/lxc/sync.c

  Log Message:
  -----------
  log: add lxc_log_strerror_r macro

Let's ensure that we always use the thread-safe strerror_r() function and add
an approriate macro.
Additionally, define SYS*() macros for all log levels. They will use the new
macro and ensure thread-safe retrieval of errno values.

Signed-off-by: 2xsec <dh48.jeong at samsung.com>
[christian.brauner at ubuntu.com: simplify lxc_log_strerror_r macro]
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: 182846996b1f2310968cdd8feaa3e9dc71965c10
      https://github.com/lxc/lxc/commit/182846996b1f2310968cdd8feaa3e9dc71965c10
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-12-10 (Mon, 10 Dec 2018)

  Changed paths:
    M src/lxc/log.h

  Log Message:
  -----------
  log: account for Android's Bionic's strerror_r()

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: c13a1a0a3b5b7b045a8aff83358056f133acd1ed
      https://github.com/lxc/lxc/commit/c13a1a0a3b5b7b045a8aff83358056f133acd1ed
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-12-10 (Mon, 10 Dec 2018)

  Changed paths:
    M CODING_STYLE.md

  Log Message:
  -----------
  CODING_STYLE: add section about using strlcat()

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: 3a8d6b6491306a9fc8eec4e1232367b80b6bdd15
      https://github.com/lxc/lxc/commit/3a8d6b6491306a9fc8eec4e1232367b80b6bdd15
  Author: 2xsec <dh48.jeong at samsung.com>
  Date:   2018-12-10 (Mon, 10 Dec 2018)

  Changed paths:
    M src/tests/concurrent.c

  Log Message:
  -----------
  coverity: #1425816

Explicit null dereferenced

Signed-off-by: 2xsec <dh48.jeong at samsung.com>


  Commit: 535ceb0b2629bb14583cca0bfd22e6acb6c3a01d
      https://github.com/lxc/lxc/commit/535ceb0b2629bb14583cca0bfd22e6acb6c3a01d
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-12-10 (Mon, 10 Dec 2018)

  Changed paths:
    M src/lxc/start.c

  Log Message:
  -----------
  start: don't unconditionally open("/dev/null")

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: c619ba29a4f58291fa33f346a040923195e4076d
      https://github.com/lxc/lxc/commit/c619ba29a4f58291fa33f346a040923195e4076d
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-12-10 (Mon, 10 Dec 2018)

  Changed paths:
    M configure.ac
    M src/lxc/console.c
    M src/lxc/log.h

  Log Message:
  -----------
  log: thread-safety backports

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


Compare: https://github.com/lxc/lxc/compare/0c4826e31cf1...c619ba29a4f5
      **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.