[lxc-devel] [lxc/lxc] e9d425: strlcpy: add strlcpy() implementation

GitHub noreply at github.com
Mon Dec 10 08:35:21 UTC 2018


  Branch: refs/heads/stable-2.0
  Home:   https://github.com/lxc/lxc
  Commit: e9d425abe2bffbf93ca44c0d441df4028833151e
      https://github.com/lxc/lxc/commit/e9d425abe2bffbf93ca44c0d441df4028833151e
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-12-10 (Mon, 10 Dec 2018)

  Changed paths:
    M configure.ac
    A src/include/strlcpy.c
    A src/include/strlcpy.h
    M src/lxc/Makefile.am

  Log Message:
  -----------
  strlcpy: add strlcpy() implementation

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: 3bfa1f5b3923a2ed884ee44ccbf2e36f8e375673
      https://github.com/lxc/lxc/commit/3bfa1f5b3923a2ed884ee44ccbf2e36f8e375673
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-12-10 (Mon, 10 Dec 2018)

  Changed paths:
    M src/lxc/af_unix.c
    M src/lxc/criu.c
    M src/lxc/log.c
    M src/lxc/lxccontainer.c
    M src/lxc/monitor.c
    M src/lxc/network.c
    M src/lxc/start.c
    M src/lxc/storage/btrfs.c
    M src/lxc/storage/storage_utils.c

  Log Message:
  -----------
  tree-wide: s/strncpy()/strlcpy()/g

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: 8baf35702fedd98bc9844ea7543bdcab515c2ca2
      https://github.com/lxc/lxc/commit/8baf35702fedd98bc9844ea7543bdcab515c2ca2
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-12-10 (Mon, 10 Dec 2018)

  Changed paths:
    M CODING_STYLE.md

  Log Message:
  -----------
  CODING_STYLE: add section about using strlcpy()

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: cabae9d14e66b86598ada809d196ddcde0e8592e
      https://github.com/lxc/lxc/commit/cabae9d14e66b86598ada809d196ddcde0e8592e
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-12-10 (Mon, 10 Dec 2018)

  Changed paths:
    M src/lxc/Makefile.am
    M src/lxc/tools/lxc_monitor.c

  Log Message:
  -----------
  tools: s/strncpy()/strlcpy()/g

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: 5762579e32968b419850ad4f7b834d1725566676
      https://github.com/lxc/lxc/commit/5762579e32968b419850ad4f7b834d1725566676
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-12-10 (Mon, 10 Dec 2018)

  Changed paths:
    M src/lxc/Makefile.am
    M src/lxc/tools/lxc_monitor.c

  Log Message:
  -----------
  Revert "tools: s/strncpy()/strlcpy()/g"

This reverts commit 2ec47d5149e73db97f7877d06d67cb11421097bb.

First, I forgot to actually replace strncpy() with strlcpy(). Second, we don't
want to \0-terminate since this is an abstract unix socket and this is not
required. Instead, let's simply use memcpy() which is more correct and also
silences gcc-8.

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: 1cf14cc9dedd00d0980adea200fd3d6d054c07fc
      https://github.com/lxc/lxc/commit/1cf14cc9dedd00d0980adea200fd3d6d054c07fc
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-12-10 (Mon, 10 Dec 2018)

  Changed paths:
    M src/lxc/network.c

  Log Message:
  -----------
  coverity: #1435604

Resource leak

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: aea8ed0d6c83910781f4b3aee5a585c0c6c12b37
      https://github.com/lxc/lxc/commit/aea8ed0d6c83910781f4b3aee5a585c0c6c12b37
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-12-10 (Mon, 10 Dec 2018)

  Changed paths:
    M src/lxc/storage/btrfs.c

  Log Message:
  -----------
  coverity: #1435603

Resource leak

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: f6e94633db7a467248edec192fc7f706591ac921
      https://github.com/lxc/lxc/commit/f6e94633db7a467248edec192fc7f706591ac921
  Author: Simos Xenitellis <simos.lists at googlemail.com>
  Date:   2018-12-10 (Mon, 10 Dec 2018)

  Changed paths:
    M src/lxc/conf.c

  Log Message:
  -----------
  coverity: #1425836

Resource leak

Signed-off-by: Simos Xenitellis <simos.lists at googlemail.com>


  Commit: 4db946a0a4f28bfc440e99f0a359098ca25adea2
      https://github.com/lxc/lxc/commit/4db946a0a4f28bfc440e99f0a359098ca25adea2
  Author: Simos Xenitellis <simos.lists at googlemail.com>
  Date:   2018-12-10 (Mon, 10 Dec 2018)

  Changed paths:
    M src/lxc/network.c

  Log Message:
  -----------
  coverity: #1248106

Resource leak

Signed-off-by: Simos Xenitellis <simos.lists at googlemail.com>


  Commit: 670c689bea8c1395a14da32427c7c6b92652cf24
      https://github.com/lxc/lxc/commit/670c689bea8c1395a14da32427c7c6b92652cf24
  Author: Simos Xenitellis <simos.lists at googlemail.com>
  Date:   2018-12-10 (Mon, 10 Dec 2018)

  Changed paths:
    M src/lxc/conf.c

  Log Message:
  -----------
  coverity: #1425844

Resource leak

Signed-off-by: Simos Xenitellis <simos.lists at googlemail.com>


  Commit: 06c2e8932f5cc1c4de4a73ceced3fcb2e79f3952
      https://github.com/lxc/lxc/commit/06c2e8932f5cc1c4de4a73ceced3fcb2e79f3952
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-12-10 (Mon, 10 Dec 2018)

  Changed paths:
    M config/templates/userns.conf.in

  Log Message:
  -----------
  config: allow read-write /sys in user namespace

Unprivileged containers can safely mount /sys as read-write. This also allows
systemd-udevd to be started in unprivileged containers.

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: 5686e78d1f88a9b10302ebcb11bfb31dcbf51ff9
      https://github.com/lxc/lxc/commit/5686e78d1f88a9b10302ebcb11bfb31dcbf51ff9
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-12-10 (Mon, 10 Dec 2018)

  Changed paths:
    M src/lxc/caps.c
    M src/lxc/caps.h
    M src/lxc/start.c

  Log Message:
  -----------
  capabilities: raise ambient capabilities

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Suggested-by: Jonathan Calmels <jcalmels at nvidia.com>


  Commit: 0167124431812f30cece1fc167923f229982c79d
      https://github.com/lxc/lxc/commit/0167124431812f30cece1fc167923f229982c79d
  Author: Simos Xenitellis <simos.lists at googlemail.com>
  Date:   2018-12-10 (Mon, 10 Dec 2018)

  Changed paths:
    M src/lxc/conf.c

  Log Message:
  -----------
  coverity: #1425802

Resource leak

Signed-off-by: Simos Xenitellis <simos.lists at googlemail.com>


  Commit: db69009d6a2fc10ce3dff65e6ec777aec72dab5c
      https://github.com/lxc/lxc/commit/db69009d6a2fc10ce3dff65e6ec777aec72dab5c
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-12-10 (Mon, 10 Dec 2018)

  Changed paths:
    M src/lxc/lxc_init.c

  Log Message:
  -----------
  lxc-init: skip signals that can't be caught

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: dfd1d0176eba882d044573fa60f9b3e9521c38a2
      https://github.com/lxc/lxc/commit/dfd1d0176eba882d044573fa60f9b3e9521c38a2
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-12-10 (Mon, 10 Dec 2018)

  Changed paths:
    M src/lxc/lxc_init.c
    M src/lxc/lxc_monitord.c
    M src/lxc/start.c
    M src/lxc/utils.c

  Log Message:
  -----------
  tree-wide: s/sigprocmask/pthread_sigmask()/g

The behavior of sigprocmask() is unspecified in multi-threaded programs. Let's
use pthread_sigmask() instead.

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: fbf93af1859be3c142fad54315ef5acd34096ce0
      https://github.com/lxc/lxc/commit/fbf93af1859be3c142fad54315ef5acd34096ce0
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-12-10 (Mon, 10 Dec 2018)

  Changed paths:
    M src/lxc/lxccontainer.c
    M src/lxc/utils.c

  Log Message:
  -----------
  utils: fix task_blocking_signal()

sscanf() skips whitespace anyway so don't account for tabs in case the file
layout changes.

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: 1a764aba461353277f41001f91ca9c4d89a696c9
      https://github.com/lxc/lxc/commit/1a764aba461353277f41001f91ca9c4d89a696c9
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-12-10 (Mon, 10 Dec 2018)

  Changed paths:
    M src/lxc/lxccontainer.c

  Log Message:
  -----------
  lxccontainer: fix fd leaks when sending signals

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: 94bf9d9d6f0a8a8d5a13f174ed9aa6d3fb6df669
      https://github.com/lxc/lxc/commit/94bf9d9d6f0a8a8d5a13f174ed9aa6d3fb6df669
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-12-10 (Mon, 10 Dec 2018)

  Changed paths:
    M src/lxc/confile.c

  Log Message:
  -----------
  confile: order architectures

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: 5acde2b638e39aeab5386c09ca6a86304b583685
      https://github.com/lxc/lxc/commit/5acde2b638e39aeab5386c09ca6a86304b583685
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-12-10 (Mon, 10 Dec 2018)

  Changed paths:
    M src/lxc/tools/lxc_create.c

  Log Message:
  -----------
  tools: fix lxc-create with global config value

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: b214645765b414b4c4abb2dde22349675560e79e
      https://github.com/lxc/lxc/commit/b214645765b414b4c4abb2dde22349675560e79e
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-12-10 (Mon, 10 Dec 2018)

  Changed paths:
    M src/lxc/tools/lxc_create.c

  Log Message:
  -----------
  tools: fix lxc-create with global config value II

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: c2f5c0970631c89e49d89034b7b81db1b15811d2
      https://github.com/lxc/lxc/commit/c2f5c0970631c89e49d89034b7b81db1b15811d2
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-12-10 (Mon, 10 Dec 2018)

  Changed paths:
    M src/lxc/lxccontainer.c

  Log Message:
  -----------
  coverity: #1435805

Logically dead code

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: 7e2164b48c58f77966b46829255838c85596d152
      https://github.com/lxc/lxc/commit/7e2164b48c58f77966b46829255838c85596d152
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-12-10 (Mon, 10 Dec 2018)

  Changed paths:
    M src/lxc/start.c

  Log Message:
  -----------
  coverity: #1435803

Unchecked return value

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: 1bd237a60722c83320acae215a21ff98d35a35ad
      https://github.com/lxc/lxc/commit/1bd237a60722c83320acae215a21ff98d35a35ad
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-12-10 (Mon, 10 Dec 2018)

  Changed paths:
    M src/lxc/lxccontainer.c
    M src/lxc/parse.c
    M src/lxc/parse.h
    M src/lxc/seccomp.c
    M src/lxc/utils.c
    M src/lxc/utils.h
    M src/tests/Makefile.am
    M src/tests/lxc-test-utils.c

  Log Message:
  -----------
  utils: fix task_blocking_signal()

Closes #2342.

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: 1322cb60d95efa0bc5663581b1558c11b33a789e
      https://github.com/lxc/lxc/commit/1322cb60d95efa0bc5663581b1558c11b33a789e
  Author: Donghwa Jeong <dh48.jeong at samsung.com>
  Date:   2018-12-10 (Mon, 10 Dec 2018)

  Changed paths:
    M src/lxc/network.c

  Log Message:
  -----------
  network: fix socket handle leak

Signed-off-by: Donghwa Jeong <dh48.jeong at samsung.com>


  Commit: aa9100ad0136b935dff6206367c9890ed41e204a
      https://github.com/lxc/lxc/commit/aa9100ad0136b935dff6206367c9890ed41e204a
  Author: Donghwa Jeong <dh48.jeong at samsung.com>
  Date:   2018-12-10 (Mon, 10 Dec 2018)

  Changed paths:
    M src/lxc/conf.c

  Log Message:
  -----------
  conf: va_end was not called.

Signed-off-by: Donghwa Jeong <dh48.jeong at samsung.com>


  Commit: a882bb4b015bd9e105c50aa1890d7441ea0a96cb
      https://github.com/lxc/lxc/commit/a882bb4b015bd9e105c50aa1890d7441ea0a96cb
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-12-10 (Mon, 10 Dec 2018)

  Changed paths:
    M src/lxc/confile.c
    M src/lxc/confile_utils.h

  Log Message:
  -----------
  confile: improve strprint()

POSIX specifies [1]:
"If the value of n is zero on a call to snprintf(), nothing shall be written,
the number of bytes that would have been written had n been sufficiently large
excluding the terminating null shall be returned, and s may be a null pointer."

But in case there are any non-sane libcs out there that do actually dereference
the buffer when when 0 is passed as length to snprintf() let's give them a
dummy buffer.

[1]: The Open Group Base Specifications Issue 7, 2018 edition
     IEEE Std 1003.1-2017 (Revision of IEEE Std 1003.1-2008)
     Copyright © 2001-2018 IEEE and The Open Group

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Reported-by: Donghwa Jeong <dh48.jeong at samsung.com>
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: 6bc415b658dee92d4d981943ce185d25c4646f90
      https://github.com/lxc/lxc/commit/6bc415b658dee92d4d981943ce185d25c4646f90
  Author: Donghwa Jeong <dh48.jeong at samsung.com>
  Date:   2018-12-10 (Mon, 10 Dec 2018)

  Changed paths:
    M src/lxc/start.c

  Log Message:
  -----------
  start: fix waitpid() blocking issue

Signed-off-by: Donghwa Jeong <dh48.jeong at samsung.com>


  Commit: 75fd0b3405396a0c58e0d479423984f0ec2e4b6e
      https://github.com/lxc/lxc/commit/75fd0b3405396a0c58e0d479423984f0ec2e4b6e
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-12-10 (Mon, 10 Dec 2018)

  Changed paths:
    M src/lxc/start.c

  Log Message:
  -----------
  start: log unknown info.si_code

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: cf5b450f58a7d45b8f37b97897e4a35d736140fd
      https://github.com/lxc/lxc/commit/cf5b450f58a7d45b8f37b97897e4a35d736140fd
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-12-10 (Mon, 10 Dec 2018)

  Changed paths:
    M src/lxc/conf.c
    M src/lxc/start.c

  Log Message:
  -----------
  tree-wide: handle EINTR in some read()/write()

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: af41287e7faae7afe863551d391c71a5ecc7e5a9
      https://github.com/lxc/lxc/commit/af41287e7faae7afe863551d391c71a5ecc7e5a9
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-12-10 (Mon, 10 Dec 2018)

  Changed paths:
    M src/lxc/conf.c

  Log Message:
  -----------
  conf: copy mountinfo for remount_all_slave()

While a container reads mountinfo from proc fs, the mountinfo can be changed by
the kernel anytime. This has caused critical issues on some devices.

Signed-off-by: Donghwa Jeong dh48.jeong at samsung.com
Reported-by: Donghwa Jeong dh48.jeong at samsung.com
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: 3f962af8a26cc0fbfb46f1611ac63b459aedd3f1
      https://github.com/lxc/lxc/commit/3f962af8a26cc0fbfb46f1611ac63b459aedd3f1
  Author: duguhaotian <lh548426 at 126.com>
  Date:   2018-12-10 (Mon, 10 Dec 2018)

  Changed paths:
    M config/tls.m4

  Log Message:
  -----------
  support tls in cross-compile

AC_RUN_IFELSE will fail in cross-compile,
we can use AC_COMPILE_IFELSE replace.

Signed-off-by: duguhaotian <duguhaotian at gmail.com>


  Commit: 6a9668f6620d5c7ce3111633d8c0c9a67bc80fad
      https://github.com/lxc/lxc/commit/6a9668f6620d5c7ce3111633d8c0c9a67bc80fad
  Author: Stéphane Graber <stgraber at ubuntu.com>
  Date:   2018-12-10 (Mon, 10 Dec 2018)

  Changed paths:
    M src/lxc/utils.c

  Log Message:
  -----------
  Fix typo

Signed-off-by: Stéphane Graber <stgraber at ubuntu.com>


  Commit: 16d2f898a5a8b5865147611f4b00fdd06a21d71c
      https://github.com/lxc/lxc/commit/16d2f898a5a8b5865147611f4b00fdd06a21d71c
  Author: Donghwa Jeong <dh48.jeong at samsung.com>
  Date:   2018-12-10 (Mon, 10 Dec 2018)

  Changed paths:
    M src/lxc/lxccontainer.c

  Log Message:
  -----------
  coverity: #1425777

Signed-off-by: Donghwa Jeong <dh48.jeong at samsung.com>


  Commit: 8cf133e2ef883fc78b1eb2a5274847c1b62f73e7
      https://github.com/lxc/lxc/commit/8cf133e2ef883fc78b1eb2a5274847c1b62f73e7
  Author: Donghwa Jeong <dh48.jeong at samsung.com>
  Date:   2018-12-10 (Mon, 10 Dec 2018)

  Changed paths:
    M src/lxc/lxccontainer.c

  Log Message:
  -----------
  coverity: #1425779

Signed-off-by: Donghwa Jeong <dh48.jeong at samsung.com>


  Commit: 9382362ebd7dcd33f3e831d774fc263c08e00f61
      https://github.com/lxc/lxc/commit/9382362ebd7dcd33f3e831d774fc263c08e00f61
  Author: Donghwa Jeong <dh48.jeong at samsung.com>
  Date:   2018-12-10 (Mon, 10 Dec 2018)

  Changed paths:
    M src/lxc/confile.c

  Log Message:
  -----------
  coverity: #1425794

Signed-off-by: Donghwa Jeong <dh48.jeong at samsung.com>


  Commit: e06cb972fed365bbf945c826ec05f7a338c8170a
      https://github.com/lxc/lxc/commit/e06cb972fed365bbf945c826ec05f7a338c8170a
  Author: Donghwa Jeong <dh48.jeong at samsung.com>
  Date:   2018-12-10 (Mon, 10 Dec 2018)

  Changed paths:
    M src/lxc/utils.c

  Log Message:
  -----------
  coverity: #1425795

Signed-off-by: Donghwa Jeong <dh48.jeong at samsung.com>


  Commit: 6d9493df00d008e8a55fad57a8c27766ab6bd0f4
      https://github.com/lxc/lxc/commit/6d9493df00d008e8a55fad57a8c27766ab6bd0f4
  Author: Donghwa Jeong <dh48.jeong at samsung.com>
  Date:   2018-12-10 (Mon, 10 Dec 2018)

  Changed paths:
    M src/lxc/utils.c

  Log Message:
  -----------
  coverity: #1425841

Signed-off-by: Donghwa Jeong <dh48.jeong at samsung.com>


  Commit: e93d4c25aa7d8ad58828e810ddd3adbc90dfd0ba
      https://github.com/lxc/lxc/commit/e93d4c25aa7d8ad58828e810ddd3adbc90dfd0ba
  Author: Donghwa Jeong <dh48.jeong at samsung.com>
  Date:   2018-12-10 (Mon, 10 Dec 2018)

  Changed paths:
    M src/lxc/commands_utils.c

  Log Message:
  -----------
  coverity: #1425849

Signed-off-by: Donghwa Jeong <dh48.jeong at samsung.com>


  Commit: fec92990c56f6dbb252a2e58169c2adea099c2d7
      https://github.com/lxc/lxc/commit/fec92990c56f6dbb252a2e58169c2adea099c2d7
  Author: Donghwa Jeong <dh48.jeong at samsung.com>
  Date:   2018-12-10 (Mon, 10 Dec 2018)

  Changed paths:
    M src/lxc/conf.c

  Log Message:
  -----------
  coverity: #1425836

Resource leak

Signed-off-by: Donghwa Jeong <dh48.jeong at samsung.com>


  Commit: 9075febe63196ca7d65d1f1c6074b6c22e04fbe8
      https://github.com/lxc/lxc/commit/9075febe63196ca7d65d1f1c6074b6c22e04fbe8
  Author: Jonathan Calmels <jcalmels at nvidia.com>
  Date:   2018-12-10 (Mon, 10 Dec 2018)

  Changed paths:
    M src/lxc/conf.c

  Log Message:
  -----------
  conf: only use newuidmap and newgidmap when necessary

Signed-off-by: Jonathan Calmels <jcalmels at nvidia.com>


  Commit: 3a15f35b513fb1f20fe923d7448c67e8eb8b7298
      https://github.com/lxc/lxc/commit/3a15f35b513fb1f20fe923d7448c67e8eb8b7298
  Author: Donghwa Jeong <dh48.jeong at samsung.com>
  Date:   2018-12-10 (Mon, 10 Dec 2018)

  Changed paths:
    M src/lxc/tools/arguments.c

  Log Message:
  -----------
  arguments: improve some operations

Signed-off-by: Donghwa Jeong <dh48.jeong at samsung.com>


  Commit: 776bb08b233d0832fa9e98d04ce4028538d89acc
      https://github.com/lxc/lxc/commit/776bb08b233d0832fa9e98d04ce4028538d89acc
  Author: Donghwa Jeong <dh48.jeong at samsung.com>
  Date:   2018-12-10 (Mon, 10 Dec 2018)

  Changed paths:
    M src/lxc/criu.c

  Log Message:
  -----------
  coverity: #1425781

Resource leak

Signed-off-by: Donghwa Jeong <dh48.jeong at samsung.com>


  Commit: e2faeedba985a4af2ec664791c9cebea3b93cd56
      https://github.com/lxc/lxc/commit/e2faeedba985a4af2ec664791c9cebea3b93cd56
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-12-10 (Mon, 10 Dec 2018)

  Changed paths:
    M src/lxc/tools/lxc_create.c

  Log Message:
  -----------
  tools: restore lxc-create log behavior

Older versions of lxc-create used to set log_file to "none" when a log priority
but no log file was specified on the command line. Let's restore this behavior.

Closes #2392.

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: d75659e3ac48efd21e61dae97634b76dcc67955c
      https://github.com/lxc/lxc/commit/d75659e3ac48efd21e61dae97634b76dcc67955c
  Author: Donghwa Jeong <dh48.jeong at samsung.com>
  Date:   2018-12-10 (Mon, 10 Dec 2018)

  Changed paths:
    M src/lxc/tools/lxc_unshare.c

  Log Message:
  -----------
  fix getpwnam() thread safe issue

Signed-off-by: Donghwa Jeong <dh48.jeong at samsung.com>


  Commit: 027adbcf5125032a9946b8280b632e34d5484346
      https://github.com/lxc/lxc/commit/027adbcf5125032a9946b8280b632e34d5484346
  Author: Donghwa Jeong <dh48.jeong at samsung.com>
  Date:   2018-12-10 (Mon, 10 Dec 2018)

  Changed paths:
    M src/lxc/attach.c

  Log Message:
  -----------
  attach: fix double free

Signed-off-by: Donghwa Jeong <dh48.jeong at samsung.com>


  Commit: 7a1cd0852575fc4d52665b0d8287e33c24da849b
      https://github.com/lxc/lxc/commit/7a1cd0852575fc4d52665b0d8287e33c24da849b
  Author: Donghwa Jeong <dh48.jeong at samsung.com>
  Date:   2018-12-10 (Mon, 10 Dec 2018)

  Changed paths:
    M src/lxc/tools/lxc_unshare.c

  Log Message:
  -----------
  coverity: #1436916

Resource leak

Signed-off-by: Donghwa Jeong <dh48.jeong at samsung.com>


  Commit: 4e4e025e36557cd4f5e5c99316cff1fc628b70fc
      https://github.com/lxc/lxc/commit/4e4e025e36557cd4f5e5c99316cff1fc628b70fc
  Author: Donghwa Jeong <dh48.jeong at samsung.com>
  Date:   2018-12-10 (Mon, 10 Dec 2018)

  Changed paths:
    M src/lxc/attach.c
    M src/lxc/conf.c
    M src/lxc/lxc_user_nic.c
    M src/lxc/tools/lxc_usernsexec.c

  Log Message:
  -----------
  fix getpwuid() thread safe issue

Signed-off-by: Donghwa Jeong <dh48.jeong at samsung.com>


  Commit: 21944ce56eb633acc7b9d56dee1cbd13ed09f055
      https://github.com/lxc/lxc/commit/21944ce56eb633acc7b9d56dee1cbd13ed09f055
  Author: Donghwa Jeong <dh48.jeong at samsung.com>
  Date:   2018-12-10 (Mon, 10 Dec 2018)

  Changed paths:
    M src/lxc/conf.c
    M src/lxc/lxc_user_nic.c

  Log Message:
  -----------
  fix getgrgid() thread safe issue

Signed-off-by: Donghwa Jeong <dh48.jeong at samsung.com>


  Commit: 04bed15ae752993b66e10876382bd8568353a582
      https://github.com/lxc/lxc/commit/04bed15ae752993b66e10876382bd8568353a582
  Author: 2xsec <dh48.jeong at samsung.com>
  Date:   2018-12-10 (Mon, 10 Dec 2018)

  Changed paths:
    M src/lxc/lxc_user_nic.c

  Log Message:
  -----------
  coverity: #1437017

Uninitialized pointer

Signed-off-by: 2xsec <dh48.jeong at samsung.com>


  Commit: 5acd5cf0e9b64a50de04343041865f1c2e844481
      https://github.com/lxc/lxc/commit/5acd5cf0e9b64a50de04343041865f1c2e844481
  Author: 2xsec <dh48.jeong at samsung.com>
  Date:   2018-12-10 (Mon, 10 Dec 2018)

  Changed paths:
    M src/lxc/criu.c

  Log Message:
  -----------
  coverity: #1425778

Out-of-bounds write

Signed-off-by: 2xsec <dh48.jeong at samsung.com>


  Commit: 65d63c505e86aab7b0856327a4274a985f05a59f
      https://github.com/lxc/lxc/commit/65d63c505e86aab7b0856327a4274a985f05a59f
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-12-10 (Mon, 10 Dec 2018)

  Changed paths:
    M src/lxc/tools/lxc_ls.c

  Log Message:
  -----------
  coverity: #1425760

Use of untrusted scalar value

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: 124b0dc73ed8ecbdc1c951b65ecd03f31dfc0002
      https://github.com/lxc/lxc/commit/124b0dc73ed8ecbdc1c951b65ecd03f31dfc0002
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-12-10 (Mon, 10 Dec 2018)

  Changed paths:
    M src/lxc/criu.c

  Log Message:
  -----------
  coverity: #1425766

Unchecked return value

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: 77149cc08884d38eede70496b4b705f2d507334a
      https://github.com/lxc/lxc/commit/77149cc08884d38eede70496b4b705f2d507334a
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-12-10 (Mon, 10 Dec 2018)

  Changed paths:
    M src/lxc/storage/btrfs.c

  Log Message:
  -----------
  coverity: #1425767

Unchecked return value

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: 4d687a3a97e502d654eb14222d767eaa95172b9a
      https://github.com/lxc/lxc/commit/4d687a3a97e502d654eb14222d767eaa95172b9a
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-12-10 (Mon, 10 Dec 2018)

  Changed paths:
    M src/lxc/state.c

  Log Message:
  -----------
  coverity: #1425768

Untrusted array index read

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: 87ca8ec4a8a56149afbd09129f8ba19ca3626286
      https://github.com/lxc/lxc/commit/87ca8ec4a8a56149afbd09129f8ba19ca3626286
  Author: Donghwa Jeong <dh48.jeong at samsung.com>
  Date:   2018-12-10 (Mon, 10 Dec 2018)

  Changed paths:
    M src/lxc/storage/storage_utils.c

  Log Message:
  -----------
  storage: Resource leak

Signed-off-by: Donghwa Jeong <dh48.jeong at samsung.com>


  Commit: 912ea0944c35e783cc6d477cb89f70ee4fc48664
      https://github.com/lxc/lxc/commit/912ea0944c35e783cc6d477cb89f70ee4fc48664
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-12-10 (Mon, 10 Dec 2018)

  Changed paths:
    M configure.ac
    A src/include/getgrgid_r.c
    A src/include/getgrgid_r.h
    M src/lxc/Makefile.am

  Log Message:
  -----------
  include: add getgrgid_r()

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: f40348415783bbeba82fab1df7dd2e2d140dd81e
      https://github.com/lxc/lxc/commit/f40348415783bbeba82fab1df7dd2e2d140dd81e
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-12-10 (Mon, 10 Dec 2018)

  Changed paths:
    M src/lxc/utils.c

  Log Message:
  -----------
  coverity: #1425770

Insecure temporary file

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: fd11b7ae74c7aa20a20f3bd309f5457425f08170
      https://github.com/lxc/lxc/commit/fd11b7ae74c7aa20a20f3bd309f5457425f08170
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-12-10 (Mon, 10 Dec 2018)

  Changed paths:
    M src/tests/lxc-test-utils.c

  Log Message:
  -----------
  coverity: #1425771

Insecure temporary file

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: 094c8a069d43cbc35953d479522877377c4516cb
      https://github.com/lxc/lxc/commit/094c8a069d43cbc35953d479522877377c4516cb
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-12-10 (Mon, 10 Dec 2018)

  Changed paths:
    M src/lxc/lxccontainer.c

  Log Message:
  -----------
  coverity: #1425789

Unchecked return value from library

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: f330d8ee264a25548b2527238c495ea4dbf8d434
      https://github.com/lxc/lxc/commit/f330d8ee264a25548b2527238c495ea4dbf8d434
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-12-10 (Mon, 10 Dec 2018)

  Changed paths:
    M src/tests/parse_config_file.c

  Log Message:
  -----------
  coverity: #1425792

Insecure temporary file

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: a0a4d2ce0d5115e7d287b4426bbca5b5787d5089
      https://github.com/lxc/lxc/commit/a0a4d2ce0d5115e7d287b4426bbca5b5787d5089
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-12-10 (Mon, 10 Dec 2018)

  Changed paths:
    M src/lxc/lxccontainer.c

  Log Message:
  -----------
  coverity: #1425793

Unchecked return value

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: 1c8fb132424055c26b871d445ba499bdaa10b816
      https://github.com/lxc/lxc/commit/1c8fb132424055c26b871d445ba499bdaa10b816
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-12-10 (Mon, 10 Dec 2018)

  Changed paths:
    M src/lxc/cgroups/cgfsng.c

  Log Message:
  -----------
  coverity: #1425799

Logically dead code

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: ce871f2fe158904b842adf8e9e38ce9f87eb7238
      https://github.com/lxc/lxc/commit/ce871f2fe158904b842adf8e9e38ce9f87eb7238
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-12-10 (Mon, 10 Dec 2018)

  Changed paths:
    M src/lxc/commands.c

  Log Message:
  -----------
  coverity: #1425810

Explicit null dereferenced

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: 7b4803b42a5be8016080f1cc76bff0d685ee95d5
      https://github.com/lxc/lxc/commit/7b4803b42a5be8016080f1cc76bff0d685ee95d5
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-12-10 (Mon, 10 Dec 2018)

  Changed paths:
    M src/lxc/tools/lxc_ls.c

  Log Message:
  -----------
  coverity: #1425813

Resource leak

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: cd1cbee0c32639c8c2df091f60477295977deefb
      https://github.com/lxc/lxc/commit/cd1cbee0c32639c8c2df091f60477295977deefb
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-12-10 (Mon, 10 Dec 2018)

  Changed paths:
    M src/lxc/start.c

  Log Message:
  -----------
  coverity: #1425818

Dereference after null check

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: e8d6490b5abe3809000fb18a92ffcc43148320c8
      https://github.com/lxc/lxc/commit/e8d6490b5abe3809000fb18a92ffcc43148320c8
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-12-10 (Mon, 10 Dec 2018)

  Changed paths:
    M src/lxc/tools/lxc_ls.c

  Log Message:
  -----------
  coverity: #1425819

Resource leak

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: 175f944a821eb7b62108393848af10e7d45e031f
      https://github.com/lxc/lxc/commit/175f944a821eb7b62108393848af10e7d45e031f
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-12-10 (Mon, 10 Dec 2018)

  Changed paths:
    M src/lxc/tools/arguments.c

  Log Message:
  -----------
  coverity: #1425824

Missing break in switch

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: ea7f7cb042eb56df07fd85f262465c808298b828
      https://github.com/lxc/lxc/commit/ea7f7cb042eb56df07fd85f262465c808298b828
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-12-10 (Mon, 10 Dec 2018)

  Changed paths:
    M src/lxc/network.c

  Log Message:
  -----------
  coverity: #1425825

Unchecked return value

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: 5eadf49507077baebefec1c3fcf004cf4c4876ee
      https://github.com/lxc/lxc/commit/5eadf49507077baebefec1c3fcf004cf4c4876ee
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-12-10 (Mon, 10 Dec 2018)

  Changed paths:
    M src/lxc/lxccontainer.c

  Log Message:
  -----------
  coverity: #1425837

String not null terminated

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: 45550376b4fc561c6def804b35b131af1568011f
      https://github.com/lxc/lxc/commit/45550376b4fc561c6def804b35b131af1568011f
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-12-10 (Mon, 10 Dec 2018)

  Changed paths:
    M src/lxc/tools/lxc_top.c

  Log Message:
  -----------
  coverity: #1425840

Unchecked return value

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: cb47fcd8931db0ce017594b7d7ba7c7141f24d38
      https://github.com/lxc/lxc/commit/cb47fcd8931db0ce017594b7d7ba7c7141f24d38
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-12-10 (Mon, 10 Dec 2018)

  Changed paths:
    M src/lxc/attach.c

  Log Message:
  -----------
  coverity: #1425846

Unchecked return value

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: a07105205656d6b5b65c1ec864f40165c9fb7b08
      https://github.com/lxc/lxc/commit/a07105205656d6b5b65c1ec864f40165c9fb7b08
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-12-10 (Mon, 10 Dec 2018)

  Changed paths:
    M src/lxc/lxccontainer.c

  Log Message:
  -----------
  coverity: #1425789

Unchecked return value from library

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: b5710d3c75a019b73e8c8de3a4c61a01d7b90129
      https://github.com/lxc/lxc/commit/b5710d3c75a019b73e8c8de3a4c61a01d7b90129
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-12-10 (Mon, 10 Dec 2018)

  Changed paths:
    M src/lxc/tools/lxc_info.c

  Log Message:
  -----------
  coverity: #1425855

String not null terminated

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: 0fb3fd4452c2af20f8832d6ebfc4b2b1de7b9cb8
      https://github.com/lxc/lxc/commit/0fb3fd4452c2af20f8832d6ebfc4b2b1de7b9cb8
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-12-10 (Mon, 10 Dec 2018)

  Changed paths:
    M src/lxc/tools/lxc_ls.c

  Log Message:
  -----------
  coverity: #1437027

Read from pointer after free

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: b1528b425f11bee08fd02d8cdd95794f0b4ca2f0
      https://github.com/lxc/lxc/commit/b1528b425f11bee08fd02d8cdd95794f0b4ca2f0
  Author: Donghwa Jeong <dh48.jeong at samsung.com>
  Date:   2018-12-10 (Mon, 10 Dec 2018)

  Changed paths:
    M src/lxc/criu.c
    M src/lxc/lxccontainer.c
    M src/lxc/start.c
    M src/lxc/storage/btrfs.c

  Log Message:
  -----------
  secure coding: strcpy => strlcpy

Signed-off-by: Donghwa Jeong <dh48.jeong at samsung.com>


  Commit: edc59b8c7818dc3ffb05014903d8e7a6fe065aaf
      https://github.com/lxc/lxc/commit/edc59b8c7818dc3ffb05014903d8e7a6fe065aaf
  Author: Donghwa Jeong <dh48.jeong at samsung.com>
  Date:   2018-12-10 (Mon, 10 Dec 2018)

  Changed paths:
    M src/lxc/network.c

  Log Message:
  -----------
  secure coding: network: strcpy => strlcpy

Signed-off-by: Donghwa Jeong <dh48.jeong at samsung.com>


Compare: https://github.com/lxc/lxc/compare/db4219603946...edc59b8c7818
      **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.


More information about the lxc-devel mailing list