[lxc-devel] [lxc/lxc] 8ed8a6: commands: return -1 on lxc_cmd_get_init_pid() err

GitHub noreply at github.com
Tue Aug 28 18:30:37 UTC 2018


  Branch: refs/heads/master
  Home:   https://github.com/lxc/lxc
  Commit: 8ed8a6265bcd8958f0d026b2168bd6ee2ea61b68
      https://github.com/lxc/lxc/commit/8ed8a6265bcd8958f0d026b2168bd6ee2ea61b68
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-08-28 (Tue, 28 Aug 2018)

  Changed paths:
    M src/lxc/commands.c

  Log Message:
  -----------
  commands: return -1 on lxc_cmd_get_init_pid() err

A while back the whole lxc_cmd() infrastructure was changed to return
meaningful negative error codes. But lxc_cmd_get_init_pid() should always
return -1. Make it so!

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Reported-by: Stéphane Graber <stgraber at ubuntu.com>


  Commit: c8208ff034ed15f675ad1d707c15b5719d018685
      https://github.com/lxc/lxc/commit/c8208ff034ed15f675ad1d707c15b5719d018685
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-08-28 (Tue, 28 Aug 2018)

  Changed paths:
    M src/tests/Makefile.am
    A src/tests/basic.c

  Log Message:
  -----------
  tests: add basic.c

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: 691544a0e421a99fe2750dacb8cbbc7c5508b5f2
      https://github.com/lxc/lxc/commit/691544a0e421a99fe2750dacb8cbbc7c5508b5f2
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-08-28 (Tue, 28 Aug 2018)

  Changed paths:
    M src/tests/Makefile.am

  Log Message:
  -----------
  tests: cleanup Makefile

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: e8cd1208869322472467311ef4ccc4a236124a5a
      https://github.com/lxc/lxc/commit/e8cd1208869322472467311ef4ccc4a236124a5a
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-08-28 (Tue, 28 Aug 2018)

  Changed paths:
    M src/lxc/commands.c

  Log Message:
  -----------
  commands: ensure -1 is sent on EPIPE for init pid

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Reported-by: Stéphane Graber <stgraber at ubuntu.com>


  Commit: de2c63143a3d343745372c3c95095ebbbd8d4562
      https://github.com/lxc/lxc/commit/de2c63143a3d343745372c3c95095ebbbd8d4562
  Author: Stéphane Graber <stgraber at stgraber.org>
  Date:   2018-08-28 (Tue, 28 Aug 2018)

  Changed paths:
    M src/lxc/commands.c
    M src/tests/Makefile.am
    A src/tests/basic.c

  Log Message:
  -----------
  Merge pull request #2576 from brauner/2018-08-28/command_init_id

commands: always return -1 on lxc_cmd_get_init_pid() err


Compare: https://github.com/lxc/lxc/compare/7ee4b4b8f0a8...de2c63143a3d
      **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.


More information about the lxc-devel mailing list