[lxc-devel] [lxc/lxc] a7c4dd: start: do not initialize cgroup_ops twice

GitHub noreply at github.com
Tue Aug 28 18:08:15 UTC 2018


  Branch: refs/heads/master
  Home:   https://github.com/lxc/lxc
  Commit: a7c4ddea9f4677f65012502905842b9a9f26966c
      https://github.com/lxc/lxc/commit/a7c4ddea9f4677f65012502905842b9a9f26966c
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-08-26 (Sun, 26 Aug 2018)

  Changed paths:
    M src/lxc/start.c

  Log Message:
  -----------
  start: do not initialize cgroup_ops twice

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: 76f0e2e7395a4417330b8ed943b14194ba70622d
      https://github.com/lxc/lxc/commit/76f0e2e7395a4417330b8ed943b14194ba70622d
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-08-27 (Mon, 27 Aug 2018)

  Changed paths:
    M src/lxc/conf.h
    M src/lxc/confile.c

  Log Message:
  -----------
  confile: add lxc.cgroup.keep

This adds the new lxc.cgroup.keep config key. The key can be used to instruct
LXC to not escape to never escape to the root cgroup. This makes it easy for
users to adhere to restrictions enforced by cgroup2 and systemd. Specifically,
this makes it possible to run LXC containers as systemd services.

Note that cgroup v1 is considered legacy and will not see additional
controllers being added to it. This means that it is safe to use
lxc.cgroup.keep as config key since there is no "keep" controller. The only way
a conflict can be introduced is if the user is creating a named controller. I
think this case can be safely ignored since it is super rare and also the users
problem.

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Cc: Felix Abecassis <fabecassis at nvidia.com>
Cc: Jonathan Calmels <jcalmels at nvidia.com>


  Commit: 5a087e056f945aa2112ebdcad7df05e57ce56c8a
      https://github.com/lxc/lxc/commit/5a087e056f945aa2112ebdcad7df05e57ce56c8a
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-08-27 (Mon, 27 Aug 2018)

  Changed paths:
    M src/lxc/attach.c
    M src/lxc/cgroups/cgfsng.c
    M src/lxc/cgroups/cgroup.c
    M src/lxc/cgroups/cgroup.h
    M src/lxc/criu.c
    M src/lxc/freezer.c
    M src/lxc/lxc.h
    M src/lxc/lxccontainer.c
    M src/lxc/start.c
    M src/tests/cgpath.c

  Log Message:
  -----------
  cgroups: don't escape if lxc.cgroup.keep is true

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Cc: Felix Abecassis <fabecassis at nvidia.com>
Cc: Jonathan Calmels <jcalmels at nvidia.com>


  Commit: 7ee4b4b8f0a8b04cfa4c50d54e755b4bd95a38c3
      https://github.com/lxc/lxc/commit/7ee4b4b8f0a8b04cfa4c50d54e755b4bd95a38c3
  Author: Stéphane Graber <stgraber at stgraber.org>
  Date:   2018-08-28 (Tue, 28 Aug 2018)

  Changed paths:
    M src/lxc/attach.c
    M src/lxc/cgroups/cgfsng.c
    M src/lxc/cgroups/cgroup.c
    M src/lxc/cgroups/cgroup.h
    M src/lxc/conf.h
    M src/lxc/confile.c
    M src/lxc/criu.c
    M src/lxc/freezer.c
    M src/lxc/lxc.h
    M src/lxc/lxccontainer.c
    M src/lxc/start.c
    M src/tests/cgpath.c

  Log Message:
  -----------
  Merge pull request #2574 from brauner/2018-08-26/cgroup_keep

 confile: add lxc.cgroup.keep


Compare: https://github.com/lxc/lxc/compare/40a6212ec973...7ee4b4b8f0a8
      **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.


More information about the lxc-devel mailing list