[lxc-devel] [lxc/lxc] abd512: lxc_init: don't mount filesystems

Thu Aug 23 21:15:07 UTC 2018

  Branch: refs/heads/stable-2.0
  Home:   https://github.com/lxc/lxc
  Commit: abd512744174c5d245478556b4169f9b261c6b3b
      https://github.com/lxc/lxc/commit/abd512744174c5d245478556b4169f9b261c6b3b
  Author: Serge Hallyn <shallyn at cisco.com>
  Date:   2018-08-23 (Thu, 23 Aug 2018)

  Changed paths:
    M src/lxc/initutils.c
    M src/lxc/lxc_init.c

  Log Message:
  -----------
  lxc_init: don't mount filesystems

We have an extensive set of container config options to do this
for us, and doing this unconditionally breaks several use cases.
For instance, if we want to bind mount a /dev/shm using the
container configuration, then lxc-execute, then lxc-init will
rudely unmount the /dev/shm and remount it as a private tmpfs.

Signed-off-by: Serge Hallyn <shallyn at cisco.com>

  Commit: 7f916a5fa84ff67ceb420dab1778eb351a191b6e
      https://github.com/lxc/lxc/commit/7f916a5fa84ff67ceb420dab1778eb351a191b6e
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-08-23 (Thu, 23 Aug 2018)

  Changed paths:
    M src/lxc/cgroups/cgfsng.c

  Log Message:
  -----------
  cgfsng: non-functional changes

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 13869b2097c2874915d9cc39ccc70467a36b7cf2
      https://github.com/lxc/lxc/commit/13869b2097c2874915d9cc39ccc70467a36b7cf2
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-08-23 (Thu, 23 Aug 2018)

  Changed paths:
    M src/lxc/mainloop.h

  Log Message:
  -----------
  mainloop: add LXC_MAINLOOP_ERROR

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: d5f9a0185a5a2d2b2184f7d1d954fd6e8ccf9397
      https://github.com/lxc/lxc/commit/d5f9a0185a5a2d2b2184f7d1d954fd6e8ccf9397
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-08-23 (Thu, 23 Aug 2018)

  Changed paths:
    M config/templates/userns.conf.in

  Log Message:
  -----------
  config: start with a full capability set

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 956a1f716db92eedf846edf8c1753121d15186a9
      https://github.com/lxc/lxc/commit/956a1f716db92eedf846edf8c1753121d15186a9
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-08-23 (Thu, 23 Aug 2018)

  Changed paths:
    M CODING_STYLE.md

  Log Message:
  -----------
  CODING_STYLE: remove duplicate _exit() entry

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: c7655a219690b4b8052eb47a7bcb96775aae6834
      https://github.com/lxc/lxc/commit/c7655a219690b4b8052eb47a7bcb96775aae6834
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-08-23 (Thu, 23 Aug 2018)

  Changed paths:
    M CODING_STYLE.md

  Log Message:
  -----------
  CODING_STYLE: clang-format

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 972af15de7dda8eec02116fe805e9484ec12d838
      https://github.com/lxc/lxc/commit/972af15de7dda8eec02116fe805e9484ec12d838
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-08-23 (Thu, 23 Aug 2018)

  Changed paths:
    M CODING_STYLE.md

  Log Message:
  -----------
  CODING_STYLE: arrays of structs

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: e05712f3163781eed3082fb07261cf9c12b4e2de
      https://github.com/lxc/lxc/commit/e05712f3163781eed3082fb07261cf9c12b4e2de
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-08-23 (Thu, 23 Aug 2018)

  Changed paths:
    M CODING_STYLE.md

  Log Message:
  -----------
  CODING_STYLE: add languages to highlight

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 2f642144221a0f16a9591dff3d952e5cda28c813
      https://github.com/lxc/lxc/commit/2f642144221a0f16a9591dff3d952e5cda28c813
  Author: Felix Abecassis <fabecassis at nvidia.com>
  Date:   2018-08-23 (Thu, 23 Aug 2018)

  Changed paths:
    M src/lxc/caps.h

  Log Message:
  -----------
  Add a workaround for a build issue with old versions of libcap

Fixes: #2178

Signed-off-by: Felix Abecassis <fabecassis at nvidia.com>

  Commit: 27abc1fea3db65c11bb1bd26612a544082f289c2
      https://github.com/lxc/lxc/commit/27abc1fea3db65c11bb1bd26612a544082f289c2
  Author: Tycho Andersen <tycho at tycho.ws>
  Date:   2018-08-23 (Thu, 23 Aug 2018)

  Changed paths:
    M src/lxc/tools/lxc_usernsexec.c

  Log Message:
  -----------
  usernsexec: init log fd

lxc-usernsexec uses some functions (e.g. lxc_map_ids()), which are part of
the lxc library and thus use the WARN etc. macros to emit log messages.
However, it doesn't initialize the log in any way, so these messages go
into the ether.

lxc-usernsexec currently has no log parameters, so let's just log these to
stderr. Someone can do something fancier later if they want.

Signed-off-by: Tycho Andersen <tycho at tycho.ws>

  Commit: 673c8f0c46f276025ee779905dc4c6f81a16798e
      https://github.com/lxc/lxc/commit/673c8f0c46f276025ee779905dc4c6f81a16798e
  Author: Tycho Andersen <tycho at tycho.ws>
  Date:   2018-08-23 (Thu, 23 Aug 2018)

  Changed paths:
    M src/lxc/cgroups/cgfsng.c

  Log Message:
  -----------
  cgroups: don't escape if we're not real root

If we're host unpriv but root in our userns, we can't really escape
cgroups. Let's switch the cgroup escape test to reflect this.

Signed-off-by: Tycho Andersen <tycho at tycho.ws>

  Commit: d87b52006520973acb049acf6def619da1fa5b0c
      https://github.com/lxc/lxc/commit/d87b52006520973acb049acf6def619da1fa5b0c
  Author: Serge Hallyn <shallyn at cisco.com>
  Date:   2018-08-23 (Thu, 23 Aug 2018)

  Changed paths:
    M src/lxc/cgroups/cgfsng.c

  Log Message:
  -----------
  Revert "cgroups: don't escape if we're not real root"

This reverts commit 8d961e28f1d759669b477a659cbb694aaa2af915.

Unfortunately I don't believe the check is correct in the general case.

Signed-off-by: Serge Hallyn <shallyn at cisco.com>

  Commit: 6acdd9c4de8ae1224f007599c5d5e0fb20c70582
      https://github.com/lxc/lxc/commit/6acdd9c4de8ae1224f007599c5d5e0fb20c70582
  Author: Igor Galić <igor.galic at automatic-server.com>
  Date:   2018-08-23 (Thu, 23 Aug 2018)

  Changed paths:
    M src/lxc/conf.c

  Log Message:
  -----------
  conf: fix clang warning when building w/o libcap

when compiling lxc with clang-5.0 parse_cap()'s main loop will produce a
warning about a tautological comparision (#2215).

By moving the result of computation into a variable (end) this is no
longer a constant expression. clang-5.0 does not do dataflow analysis at
this point, so it is, to quote someone from #llvm, "morally equivalent"
to casting `(int)i`.

in addition, we also clean up the #if HAVE_LIBCAP to no longer need
its #else branch!

Signed-off-by: Igor Galić <igor.galic at automatic-server.com>

  Commit: 29b46b276ce57ff8e8dc1cfb0a801e141c48609a
      https://github.com/lxc/lxc/commit/29b46b276ce57ff8e8dc1cfb0a801e141c48609a
  Author: Tycho Andersen <tycho at tycho.ws>
  Date:   2018-08-23 (Thu, 23 Aug 2018)

  Changed paths:
    M src/lxc/execute.c
    M src/lxc/lxc.h
    M src/lxc/lxccontainer.c
    M src/lxc/start.c
    M src/lxc/start.h

  Log Message:
  -----------
  fix handler use-after-free

The problem here is that __lxc_start frees the handler, so any use
afterwards is invalid. Since we don't have access to the actual struct
lxc_container object in __lxc_start, let's pass a pointer to error_num in
so it can be returned.

Unfortunately, I'm a little too paranoid to change the return type of
lxc_start, since it returns failure if some of the cleanup fails, which
may be useful in some cases. So let's keep this out of band.

Closes #2218
Closes #2219

Reported-by: Felix Abecassis <fabecassis at nvidia.com>
Signed-off-by: Tycho Andersen <tycho at tycho.ws>

  Commit: 03cabad3958ca206e321ce86821a09574452a8dd
      https://github.com/lxc/lxc/commit/03cabad3958ca206e321ce86821a09574452a8dd
  Author: fliiiix <de-ch at hotmail.de>
  Date:   2018-08-23 (Thu, 23 Aug 2018)

  Changed paths:
    M config/init/common/lxc-net.in

  Log Message:
  -----------
  Rename ifup/down and remove usless parameter passing

Signed-off-by: Felix <de-ch at hotmail.de>

  Commit: 2df1b5ca57592e3c8d88c59dac7717aebc34aeb4
      https://github.com/lxc/lxc/commit/2df1b5ca57592e3c8d88c59dac7717aebc34aeb4
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-08-23 (Thu, 23 Aug 2018)

  Changed paths:
    M src/lxc/conf.c

  Log Message:
  -----------
  conf: simplify lxc_fill_autodev()

This function was way more syscall heavy than it needed to be.

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 2efc4ab7d1f94a7a43a407ba322738fe41ffa513
      https://github.com/lxc/lxc/commit/2efc4ab7d1f94a7a43a407ba322738fe41ffa513
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-08-23 (Thu, 23 Aug 2018)

  Changed paths:
    M src/lxc/start.c

  Log Message:
  -----------
  start: always make us dumpable

Otherwise lxc.hook.mount hooks that try to inspect /proc/<pid>/*
will fail.

Cc: Jonathan Calmels <jcalmels at nvidia.com>
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: b41008b4f4d597706e7af2b4c73601ea8a144b60
      https://github.com/lxc/lxc/commit/b41008b4f4d597706e7af2b4c73601ea8a144b60
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-08-23 (Thu, 23 Aug 2018)

  Changed paths:
    M src/lxc/lxclock.c
    M src/lxc/lxclock.h

  Log Message:
  -----------
  lxclock: use thread-safe *_OFD_* fcntl() locks

If they aren't available fallback to BSD flock()s.

Closes #2245.

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 746c7ebfa3f0e1e1b6991da0b475ee77af9fef75
      https://github.com/lxc/lxc/commit/746c7ebfa3f0e1e1b6991da0b475ee77af9fef75
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-08-23 (Thu, 23 Aug 2018)

  Changed paths:
    M src/tests/locktests.c

  Log Message:
  -----------
  locktests: fix test suite

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 603851f9bfe89953ebd9569286a0988011ec47a5
      https://github.com/lxc/lxc/commit/603851f9bfe89953ebd9569286a0988011ec47a5
  Author: Tycho Andersen <tycho at tycho.ws>
  Date:   2018-08-23 (Thu, 23 Aug 2018)

  Changed paths:
    M src/lxc/start.c

  Log Message:
  -----------
  fix signal sending in lxc.init

The problem here is that these two clauses were ordered backwards: we first
check if the signal came from not the init pid, and if it did, then we give
a notice and return. The comment notes that this is intended to protect
against SIGCHLD, but we don't in fact know if the signal is a SIGCHLD yet,
because that's tested in the next hunk.

The symptom is that if I e.g. send SIGTERM from the outside world to the
container init, it ignores it and gives this notice. If we re-order these
clauses, it forwards non SIGCHLD signals, and ignores SIGCHLD signals from
things that aren't the real container process.

Signed-off-by: Tycho Andersen <tycho at tycho.ws>

  Commit: 934b8f44c3fed23210f5cf67fd4abf1763a2f539
      https://github.com/lxc/lxc/commit/934b8f44c3fed23210f5cf67fd4abf1763a2f539
  Author: C0deAi <benjamin.bales at assrc.us>
  Date:   2018-08-23 (Thu, 23 Aug 2018)

  Changed paths:
    M src/lxc/lxc_init.c

  Log Message:
  -----------
  lxc init: remove dead code

Value stored is never read.

Closes #2262.

Signed-off-by: C0deAi <techsupport at mycode.ai>
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 1fee633e962e20f47c2a15e79dbbaf52d46388b7
      https://github.com/lxc/lxc/commit/1fee633e962e20f47c2a15e79dbbaf52d46388b7
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-08-23 (Thu, 23 Aug 2018)

  Changed paths:
    M src/lxc/lxc_init.c

  Log Message:
  -----------
  lxc init: coding style

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 9f07da0263f715d45de344a920ca811c7b8ec596
      https://github.com/lxc/lxc/commit/9f07da0263f715d45de344a920ca811c7b8ec596
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-08-23 (Thu, 23 Aug 2018)

  Changed paths:
    M src/lxc/utils.h

  Log Message:
  -----------
  utils: define __NR_setns if missing on old glibcs

Closes #2248.

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 3d872a3fb21899a37b25f654c1fae8b439651d0e
      https://github.com/lxc/lxc/commit/3d872a3fb21899a37b25f654c1fae8b439651d0e
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-08-23 (Thu, 23 Aug 2018)

  Changed paths:
    M src/lxc/conf.c

  Log Message:
  -----------
  conf: ret-try devpts mount without gid=5 on error

We should always default to mounting devpts with gid=5 but we should fallback
to mounting without gid=5. This let's us cover use-cases such as container
started with only a single mapping e.g.:

lxc.idmap = u 1000 1000 1
lxc.idmap = g 1000 1000 1

Closes #2257.

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 1286c27129b1ca6f6c9195fe0c871817fe3cc7ab
      https://github.com/lxc/lxc/commit/1286c27129b1ca6f6c9195fe0c871817fe3cc7ab
  Author: Kaarle Ritvanen <kaarle.ritvanen at datakunkku.fi>
  Date:   2018-08-23 (Thu, 23 Aug 2018)

  Changed paths:
    M src/lxc/lxccontainer.c

  Log Message:
  -----------
  do_lxcapi_create: set umask

Always use 022 as the umask when creating the rootfs directory and
executing the template. A too loose umask may cause security issues.
A too strict umask may cause programs to fail inside the container.

Signed-off-by: Kaarle Ritvanen <kaarle.ritvanen at datakunkku.fi>

  Commit: 5db54377ec586ff376146a9b46550d6a550253aa
      https://github.com/lxc/lxc/commit/5db54377ec586ff376146a9b46550d6a550253aa
  Author: LiFeng <lifeng68 at huawei.com>
  Date:   2018-08-23 (Thu, 23 Aug 2018)

  Changed paths:
    M src/lxc/cgroups/cgfsng.c

  Log Message:
  -----------
  Fix the memory leak in cgfsng_attach

Signed-off-by: LiFeng <lifeng68 at huawei.com>

  Commit: a8558cda381a341223157e3a038b0f2cfc78f164
      https://github.com/lxc/lxc/commit/a8558cda381a341223157e3a038b0f2cfc78f164
  Author: LiFeng <lifeng68 at huawei.com>
  Date:   2018-08-23 (Thu, 23 Aug 2018)

  Changed paths:
    M src/lxc/lxccontainer.c

  Log Message:
  -----------
  Fix memory leak in list_active_containers

Signed-off-by: LiFeng <lifeng68 at huawei.com>

  Commit: b2f287befaba21bd3ba8bca4a2fc2cb928519140
      https://github.com/lxc/lxc/commit/b2f287befaba21bd3ba8bca4a2fc2cb928519140
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-08-23 (Thu, 23 Aug 2018)

  Changed paths:
    M src/lxc/cgroups/cgfsng.c

  Log Message:
  -----------
  coverity: #1435208

Unused value

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 58ae8b1ece701a261bb3d42463aa3ddf155fa9bb
      https://github.com/lxc/lxc/commit/58ae8b1ece701a261bb3d42463aa3ddf155fa9bb
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-08-23 (Thu, 23 Aug 2018)

  Changed paths:
    M src/tests/aa.c

  Log Message:
  -----------
  coverity: #1435207

Unchecked return value

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: da49f814ff75f887dabe28b12d44b4e929f1b84a
      https://github.com/lxc/lxc/commit/da49f814ff75f887dabe28b12d44b4e929f1b84a
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-08-23 (Thu, 23 Aug 2018)

  Changed paths:
    M src/tests/attach.c

  Log Message:
  -----------
  coverity: #1435205

Unchecked return value

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 16155993b53ad1a8f098e7f1eab0b0be968e3fdf
      https://github.com/lxc/lxc/commit/16155993b53ad1a8f098e7f1eab0b0be968e3fdf
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-08-23 (Thu, 23 Aug 2018)

  Changed paths:
    M src/lxc/tools/lxc_create.c

  Log Message:
  -----------
  coverity: #1435198

Unchecked return value

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 82cdb21218ac9351965dcc17527efcd9efdd2346
      https://github.com/lxc/lxc/commit/82cdb21218ac9351965dcc17527efcd9efdd2346
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-08-23 (Thu, 23 Aug 2018)

  Changed paths:
    M src/lxc/lxccontainer.c
    M src/lxc/lxclock.c

  Log Message:
  -----------
  lxccontainer: use thread-safe *_OFD_* locks

If they aren't available fallback to BSD flock()s.

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: b0f533e20a2a924b66159806a898f903d05cd697
      https://github.com/lxc/lxc/commit/b0f533e20a2a924b66159806a898f903d05cd697
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-08-23 (Thu, 23 Aug 2018)

  Changed paths:
    M src/lxc/lxccontainer.c

  Log Message:
  -----------
  lxccontainer: non-functional changes

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: a19343bc0ef3274ee1a3f75ef65f23499d1f615d
      https://github.com/lxc/lxc/commit/a19343bc0ef3274ee1a3f75ef65f23499d1f615d
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-08-23 (Thu, 23 Aug 2018)

  Changed paths:
    M src/lxc/lxccontainer.c

  Log Message:
  -----------
  lxccontainer: do_lxcapi_is_running()

There's no need to do string comparisons.

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 07df9ff81fa727369b1e8d8f899dc20fc42bcb74
      https://github.com/lxc/lxc/commit/07df9ff81fa727369b1e8d8f899dc20fc42bcb74
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-08-23 (Thu, 23 Aug 2018)

  Changed paths:
    M src/lxc/lxccontainer.c

  Log Message:
  -----------
  lxccontainer: do_lxcapi_freeze()

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 9997951657c7116d466fc6349f9632f112969350
      https://github.com/lxc/lxc/commit/9997951657c7116d466fc6349f9632f112969350
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-08-23 (Thu, 23 Aug 2018)

  Changed paths:
    M src/lxc/lxccontainer.c

  Log Message:
  -----------
  lxccontainer: do_lxcapi_unfreeze()

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 429d21a7e6b7ac10ef441db32dc110217a717ccb
      https://github.com/lxc/lxc/commit/429d21a7e6b7ac10ef441db32dc110217a717ccb
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-08-23 (Thu, 23 Aug 2018)

  Changed paths:
    M src/lxc/lxccontainer.c

  Log Message:
  -----------
  lxccontainer: non-functional changes

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: eee2c6a01c111465b2e9dcaf670c83a7d1e6ba64
      https://github.com/lxc/lxc/commit/eee2c6a01c111465b2e9dcaf670c83a7d1e6ba64
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-08-23 (Thu, 23 Aug 2018)

  Changed paths:
    M src/lxc/lxccontainer.c

  Log Message:
  -----------
  lxccontainer: non-functional changes

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 62a2ede05811bcfcbec4f1cdafcc5ceb8ac67bc8
      https://github.com/lxc/lxc/commit/62a2ede05811bcfcbec4f1cdafcc5ceb8ac67bc8
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-08-23 (Thu, 23 Aug 2018)

  Changed paths:
    M src/lxc/lxccontainer.c

  Log Message:
  -----------
  lxccontainer: non-functional changes

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 853026fb799e1d75b44ce86201deb8ae969c3393
      https://github.com/lxc/lxc/commit/853026fb799e1d75b44ce86201deb8ae969c3393
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-08-23 (Thu, 23 Aug 2018)

  Changed paths:
    M src/lxc/lxccontainer.c

  Log Message:
  -----------
  coverity: #1435263

Use after free

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: f5d5324bff94f2fbefdb53a50c8b413c274e3cc0
      https://github.com/lxc/lxc/commit/f5d5324bff94f2fbefdb53a50c8b413c274e3cc0
  Author: Tycho Andersen <tycho at tycho.ws>
  Date:   2018-08-23 (Thu, 23 Aug 2018)

  Changed paths:
    M src/lxc/execute.c

  Log Message:
  -----------
  fix logic for execute log file

The problem here is that lxc-init runs *inside* the container. So if a
person has the log file set to /home/$USER/foo, lxc-init ends up making a
directory /home/$USER/foo inside the container to put the log file in. What
we really want are the logs to be propagated from inside the container to
the outside. We accomplish this by passing an fd without O_CLOEXEC, and
telling lxc-init to log to that file.

Signed-off-by: Tycho Andersen <tycho at tycho.ws>

  Commit: cbb8254f013c093ea34a4b9ee0befc4b69a81035
      https://github.com/lxc/lxc/commit/cbb8254f013c093ea34a4b9ee0befc4b69a81035
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-08-23 (Thu, 23 Aug 2018)

  Changed paths:
    M src/lxc/execute.c

  Log Message:
  -----------
  execute: use static buffer

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 0a52c0f8330118e9b2216535af42bf3fa2523ea3
      https://github.com/lxc/lxc/commit/0a52c0f8330118e9b2216535af42bf3fa2523ea3
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-08-23 (Thu, 23 Aug 2018)

  Changed paths:
    M src/lxc/execute.c

  Log Message:
  -----------
  execute: do not check inherited fds again

This is already done in do_lxcapi_start{l}() so a) no need to do it again here
and b) this would close the state socket pair sockets, corrup the fd, and lead
to EBADF.

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 37b143df7d8ed9aaec8c1fbecdd24256633af946
      https://github.com/lxc/lxc/commit/37b143df7d8ed9aaec8c1fbecdd24256633af946
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-08-23 (Thu, 23 Aug 2018)

  Changed paths:
    M src/lxc/initutils.h
    M src/lxc/tools/lxc_unshare.c

  Log Message:
  -----------
  lxc-unshare: add missing declaration

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 15dbf0a01d752a2420817c2c39e38aa8d79e4c25
      https://github.com/lxc/lxc/commit/15dbf0a01d752a2420817c2c39e38aa8d79e4c25
  Author: Tycho Andersen <tycho at tycho.ws>
  Date:   2018-08-23 (Thu, 23 Aug 2018)

  Changed paths:
    M src/lxc/execute.c

  Log Message:
  -----------
  execute: account for -o path option count

This always works fine... until your exec() fails and you try to go and
free it, you've overwritten the allocator's metadata (and potentially other
stuff) and it fails.

Signed-off-by: Tycho Andersen <tycho at tycho.ws>

  Commit: 84b489ee5ae9f802d3e446ba8638c1e29b2cb30f
      https://github.com/lxc/lxc/commit/84b489ee5ae9f802d3e446ba8638c1e29b2cb30f
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-08-23 (Thu, 23 Aug 2018)

  Changed paths:
    M src/lxc/Makefile.am
    R src/lxc/genl.c
    R src/lxc/genl.h

  Log Message:
  -----------
  genl: remove

These files have never been used and as such have no dependencies in the
codebase whatsoever. So remove them. If we need them we can simply pull them
out of the git history.

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 8053f98b976f010d9e9aae94508758df028c2695
      https://github.com/lxc/lxc/commit/8053f98b976f010d9e9aae94508758df028c2695
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-08-23 (Thu, 23 Aug 2018)

  Changed paths:
    M src/lxc/conf.c
    M src/lxc/lxccontainer.c

  Log Message:
  -----------
  coverity: #1425744

Dereference after null check

userns_exec_{1,full} are called from functions that might not have a conf.

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 00a3088cc1918fab2160e5f4510d2166174a2b11
      https://github.com/lxc/lxc/commit/00a3088cc1918fab2160e5f4510d2166174a2b11
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-08-23 (Thu, 23 Aug 2018)

  Changed paths:
    M src/lxc/utils.c

  Log Message:
  -----------
  utils: account for terminating \0 byte

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 04cf91566a4f34c18c8b1679c361facfe17fc4f3
      https://github.com/lxc/lxc/commit/04cf91566a4f34c18c8b1679c361facfe17fc4f3
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-08-23 (Thu, 23 Aug 2018)

  Changed paths:
    M src/lxc/network.c

  Log Message:
  -----------
  network: silence gcc-8

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: c414d6fd0e06212cacfd05e2c44fe75e9aba25b0
      https://github.com/lxc/lxc/commit/c414d6fd0e06212cacfd05e2c44fe75e9aba25b0
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-08-23 (Thu, 23 Aug 2018)

  Changed paths:
    M src/lxc/network.c

  Log Message:
  -----------
  network: adhere to IFNAMSIZ limit

The additional \0-byte space added is not needed since IFNAMSIZ needs to
include the \0-byte.

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

Compare: https://github.com/lxc/lxc/compare/071b170479c6...c414d6fd0e06
      **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.