[lxc-devel] [lxc/lxc] e8fcdf: cmd: Use parenthesis around complex macro

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/lxc/lxc
  Commit: e8fcdf3db293a7772390c4e289a03e04b9660237
      https://github.com/lxc/lxc/commit/e8fcdf3db293a7772390c4e289a03e04b9660237
  Author: Tobin C. Harding <me at tobin.cc>
  Date:   2018-08-17 (Fri, 17 Aug 2018)

  Changed paths:
    M src/lxc/cmd/lxc_init.c

  Log Message:
  -----------
  cmd: Use parenthesis around complex macro

checkpatch emits error:

    ERROR: Macros with complex values should be enclosed in parentheses

Safeguard macro by use of parenthesis.

Signed-off-by: Tobin C. Harding <me at tobin.cc>


  Commit: 2b360805d029058b99871dc6a5706231eee30236
      https://github.com/lxc/lxc/commit/2b360805d029058b99871dc6a5706231eee30236
  Author: Tobin C. Harding <me at tobin.cc>
  Date:   2018-08-17 (Fri, 17 Aug 2018)

  Changed paths:
    M src/lxc/cmd/lxc_init.c

  Log Message:
  -----------
  cmd: Use 'void' instead of empty parameter list

checkpatch warns because of function definitions using empty parameter
list.  We should define these functions with 'void' as the parameter.

Use 'void' instead of empty parameter list for function definitions.

Signed-off-by: Tobin C. Harding <me at tobin.cc>


  Commit: 24d6fb8a271b604e6e4b98de79b1f9d80e5e8e28
      https://github.com/lxc/lxc/commit/24d6fb8a271b604e6e4b98de79b1f9d80e5e8e28
  Author: Tobin C. Harding <me at tobin.cc>
  Date:   2018-08-17 (Fri, 17 Aug 2018)

  Changed paths:
    M src/lxc/cmd/lxc_init.c

  Log Message:
  -----------
  cmd: Do not use braces for single statement block

checkpatch emites warning:

    WARNING: braces {} are not necessary for single statement blocks

Do not use braces for single statement block.

Signed-off-by: Tobin C. Harding <me at tobin.cc>


  Commit: 32cf169fab6758812d31dcc218738a82dbfd9c76
      https://github.com/lxc/lxc/commit/32cf169fab6758812d31dcc218738a82dbfd9c76
  Author: Tobin C. Harding <me at tobin.cc>
  Date:   2018-08-17 (Fri, 17 Aug 2018)

  Changed paths:
    M src/lxc/cmd/lxc_init.c
    M src/lxc/cmd/lxc_monitord.c
    M src/lxc/cmd/lxc_user_nic.c

  Log Message:
  -----------
  cmd: Fix whitespace issues

checkpatch warns about a bunch of whitespace issues.  Fix the
non-controversial ones.

Fix whitespace issues found by checkpatch.

Signed-off-by: Tobin C. Harding <me at tobin.cc>


  Commit: 7f5700e6aaf8dc15dbf2efe2039eda17cfbe9708
      https://github.com/lxc/lxc/commit/7f5700e6aaf8dc15dbf2efe2039eda17cfbe9708
  Author: Tobin C. Harding <me at tobin.cc>
  Date:   2018-08-17 (Fri, 17 Aug 2018)

  Changed paths:
    M src/lxc/cmd/lxc_init.c

  Log Message:
  -----------
  cmd: Use 'const' for static string constant.

checkpatch emits warning:

WARNING: static char array declaration should probably be static const char

Use 'const' for static string constant (array of chars).

Signed-off-by: Tobin C. Harding <me at tobin.cc>


  Commit: 1d9f2743b25eeb87d236ef9f935a6a3dcad189be
      https://github.com/lxc/lxc/commit/1d9f2743b25eeb87d236ef9f935a6a3dcad189be
  Author: Tobin C. Harding <me at tobin.cc>
  Date:   2018-08-17 (Fri, 17 Aug 2018)

  Changed paths:
    M src/lxc/cmd/lxc_init.c

  Log Message:
  -----------
  cmd: Remove unnecessary whitespace in string

checkpatch emits warning:

    WARNING: unnecessary whitespace before a quoted newline

Remove unnecessary whitespace before a quoted newline

Signed-off-by: Tobin C. Harding <me at tobin.cc>


  Commit: 75ca3dc6aa526c9b24dacb6107c7b1b43e756771
      https://github.com/lxc/lxc/commit/75ca3dc6aa526c9b24dacb6107c7b1b43e756771
  Author: Tobin C. Harding <me at tobin.cc>
  Date:   2018-08-17 (Fri, 17 Aug 2018)

  Changed paths:
    M src/lxc/cmd/lxc_user_nic.c

  Log Message:
  -----------
  cmd: Put trailing */ on a separate line

checkpatch emits warning:

    WARNING: Block comments use a trailing */ on a separate line

Put trailing */ on a separate line.

Signed-off-by: Tobin C. Harding <me at tobin.cc>


  Commit: 2115d56671fb8574e9c513d3d0168d113a597394
      https://github.com/lxc/lxc/commit/2115d56671fb8574e9c513d3d0168d113a597394
  Author: Tobin C. Harding <me at tobin.cc>
  Date:   2018-08-17 (Fri, 17 Aug 2018)

  Changed paths:
    M src/lxc/cmd/lxc_user_nic.c

  Log Message:
  -----------
  cmd: Remove typo'd semicolon

checkpatch emits warning:

    WARNING: Statements terminations use 1 semicolon

Remove typo'd semicolon.

Signed-off-by: Tobin C. Harding <me at tobin.cc>


  Commit: 551865932ee6c5e70d310d56d89ddc5bee6b0348
      https://github.com/lxc/lxc/commit/551865932ee6c5e70d310d56d89ddc5bee6b0348
  Author: Tobin C. Harding <me at tobin.cc>
  Date:   2018-08-17 (Fri, 17 Aug 2018)

  Changed paths:
    M src/lxc/cmd/lxc_monitord.c
    M src/lxc/cmd/lxc_user_nic.c

  Log Message:
  -----------
  cmd: Do not use comparison to NULL

checkpatch emits two warnings of type:

    CHECK: Comparison to NULL could be written "!foo"

Prefer `(!foo)` instead of `(foo == NULL)`.

Do not use comparison to NULL, use !foo

Signed-off-by: Tobin C. Harding <me at tobin.cc>


  Commit: 3278fdc26cd781978720d6dab962fb03e454eaee
      https://github.com/lxc/lxc/commit/3278fdc26cd781978720d6dab962fb03e454eaee
  Author: Christian Brauner <christian at brauner.io>
  Date:   2018-08-17 (Fri, 17 Aug 2018)

  Changed paths:
    M src/lxc/cmd/lxc_init.c
    M src/lxc/cmd/lxc_monitord.c
    M src/lxc/cmd/lxc_user_nic.c

  Log Message:
  -----------
  Merge pull request #2540 from tcharding/checkatch-cmd

cmd: Fix up checkpatch warnings


Compare: https://github.com/lxc/lxc/compare/5246e140b8dc...3278fdc26cd7
      **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.