[lxc-devel] [lxc/lxc] e65165: state: s/sleep()/nanosleep()/

[GitHub]

  Branch: refs/heads/stable-3.0
  Home:   https://github.com/lxc/lxc
  Commit: e6516582dc929c102d80f9c41d3aafc65190ad6a
      https://github.com/lxc/lxc/commit/e6516582dc929c102d80f9c41d3aafc65190ad6a
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-08-16 (Thu, 16 Aug 2018)

  Changed paths:
    M src/lxc/state.c

  Log Message:
  -----------
  state: s/sleep()/nanosleep()/

sleep() is not thread-safe but nanosleep() is. Since no resources are allocated
in lxc_wait() it is safe to call nanosleep() without cancellation handlers.

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: fcacfc5b8e65eb771ad62a22aef68e042164bcdc
      https://github.com/lxc/lxc/commit/fcacfc5b8e65eb771ad62a22aef68e042164bcdc
  Author: Tobin C. Harding <me at tobin.cc>
  Date:   2018-08-16 (Thu, 16 Aug 2018)

  Changed paths:
    M doc/lxc.container.conf.sgml.in

  Log Message:
  -----------
  doc: Fix minor grammatical errors

Current we have a few minor grammatical errors in the documentation for
lxc container configuration.

Fix minor grammatical errors.

Signed-off-by: Tobin C. Harding <me at tobin.cc>


  Commit: fbc67eba368c0e671717313995bf32a2b4b4b53b
      https://github.com/lxc/lxc/commit/fbc67eba368c0e671717313995bf32a2b4b4b53b
  Author: Tobin C. Harding <me at tobin.cc>
  Date:   2018-08-16 (Thu, 16 Aug 2018)

  Changed paths:
    M src/lxc/cmd/lxc_usernsexec.c

  Log Message:
  -----------
  usernsexec: Make err out vebose for unshare error

Currently if lxc-usernsexec is run on a kernel without user namespaces
enabled the error message is

	unshare: Invalid argument
	read pipe: Success

This error message 'Invalid argument' does not point at the root cause
of the error.  We can help the user out by giving a more detailed error
message and also not using perror() if errno==0.

Improve error message by
 - Printing unshare flags
 - Printing suggested cause of failure (user namespace not enabled)
 - Print error message with fprintf() if errno==0 (EOF)

Signed-off-by: Tobin C. Harding <me at tobin.cc>


  Commit: d3d13097c75526b881135b6a13df0f2ad493895d
      https://github.com/lxc/lxc/commit/d3d13097c75526b881135b6a13df0f2ad493895d
  Author: Tobin C. Harding <me at tobin.cc>
  Date:   2018-08-16 (Thu, 16 Aug 2018)

  Changed paths:
    M src/lxc/cmd/lxc_usernsexec.c

  Log Message:
  -----------
  cmd: Correctly indent switch statement

checkpatch.pl emits error

    ERROR: do not use assignment in if condition

Correctly indent switch statement.

Signed-off-by: Tobin C. Harding <me at tobin.cc>


  Commit: 2d4beae507445064241c2e742d7b73c8b5edaa72
      https://github.com/lxc/lxc/commit/2d4beae507445064241c2e742d7b73c8b5edaa72
  Author: Tobin C. Harding <me at tobin.cc>
  Date:   2018-08-16 (Thu, 16 Aug 2018)

  Changed paths:
    M src/lxc/cmd/lxc_init.c

  Log Message:
  -----------
  cmd: Do not initialise statics to 0

checkpatch.pl emits error

    ERROR: do not initialise statics to 0

Do not initialise statics to 0.

Signed-off-by: Tobin C. Harding <me at tobin.cc>


  Commit: 1ccfb5cdac06a7a35b473387559cf8f81d753f6f
      https://github.com/lxc/lxc/commit/1ccfb5cdac06a7a35b473387559cf8f81d753f6f
  Author: Tobin C. Harding <me at tobin.cc>
  Date:   2018-08-16 (Thu, 16 Aug 2018)

  Changed paths:
    M src/lxc/cmd/lxc_init.c
    M src/lxc/cmd/lxc_monitord.c
    M src/lxc/cmd/lxc_usernsexec.c

  Log Message:
  -----------
  cmd: Fix whitespace ERRORS

checkpatch.pl emits a bunch of warnings about various whitespace
issues.  Fix all these as a single patch since they are all whitespace
only changes.

Fix whitespace issues found by checkpatch.pl

Signed-off-by: Tobin C. Harding <me at tobin.cc>


  Commit: ee75dca2f09eabf1abac8ccd3a060316bc12c6b5
      https://github.com/lxc/lxc/commit/ee75dca2f09eabf1abac8ccd3a060316bc12c6b5
  Author: Tobin C. Harding <me at tobin.cc>
  Date:   2018-08-16 (Thu, 16 Aug 2018)

  Changed paths:
    M src/lxc/cmd/lxc_usernsexec.c

  Log Message:
  -----------
  cmd: Move assignment out of if statement

checkpatch.pl emits error

    ERROR: do not use assignment in if condition

Move assignment out of if statement.

Signed-off-by: Tobin C. Harding <me at tobin.cc>


  Commit: 37b9abb1acd0e5e683ff3960ee65ec245145636c
      https://github.com/lxc/lxc/commit/37b9abb1acd0e5e683ff3960ee65ec245145636c
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-08-16 (Thu, 16 Aug 2018)

  Changed paths:
    M src/lxc/log.h

  Log Message:
  -----------
  log: add  CMD_SYSERROR()

Add a thread-safe and uniform way to retrieve errno values in programs that are
shipped as part of LXC but are not expected to have access to the logging
system.

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: 9a926cbb309a83e123e75f68bb213a4e657cdb1c
      https://github.com/lxc/lxc/commit/9a926cbb309a83e123e75f68bb213a4e657cdb1c
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-08-16 (Thu, 16 Aug 2018)

  Changed paths:
    M src/lxc/log.h

  Log Message:
  -----------
  log: add  CMD_SYSINFO()

Add a thread-safe and uniform way to retrieve errno values in programs that are
shipped as part of LXC but are not expected to have access to the logging
system.

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: a5a455fe744dc726e20a26d72ddd61865fca038e
      https://github.com/lxc/lxc/commit/a5a455fe744dc726e20a26d72ddd61865fca038e
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-08-16 (Thu, 16 Aug 2018)

  Changed paths:
    M src/lxc/Makefile.am
    M src/lxc/cmd/lxc_usernsexec.c

  Log Message:
  -----------
  lxc-usernsexec: cleanup and bugfixes

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


Compare: https://github.com/lxc/lxc/compare/4cb8ca3492e6...a5a455fe744d
      **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.