[lxc-devel] [lxc/lxc] ede912: usernsexec: Make err out vebose for unshare error

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/lxc/lxc
  Commit: ede912b440c579da4653ac9ded6d292b80e19f06
      https://github.com/lxc/lxc/commit/ede912b440c579da4653ac9ded6d292b80e19f06
  Author: Tobin C. Harding <me at tobin.cc>
  Date:   2018-08-16 (Thu, 16 Aug 2018)

  Changed paths:
    M src/lxc/cmd/lxc_usernsexec.c

  Log Message:
  -----------
  usernsexec: Make err out vebose for unshare error

Currently if lxc-usernsexec is run on a kernel without user namespaces
enabled the error message is

	unshare: Invalid argument
	read pipe: Success

This error message 'Invalid argument' does not point at the root cause
of the error.  We can help the user out by giving a more detailed error
message and also not using perror() if errno==0.

Improve error message by
 - Printing unshare flags
 - Printing suggested cause of failure (user namespace not enabled)
 - Print error message with fprintf() if errno==0 (EOF)

Signed-off-by: Tobin C. Harding <me at tobin.cc>


  Commit: c5aca61506ddf976ce4b677a23f757baabcd31bb
      https://github.com/lxc/lxc/commit/c5aca61506ddf976ce4b677a23f757baabcd31bb
  Author: Christian Brauner <christian at brauner.io>
  Date:   2018-08-16 (Thu, 16 Aug 2018)

  Changed paths:
    M src/lxc/cmd/lxc_usernsexec.c

  Log Message:
  -----------
  Merge pull request #2532 from tcharding/unshare-err

usernsexec: Make err out vebose for unshare error


Compare: https://github.com/lxc/lxc/compare/3193354ce052...c5aca61506dd
      **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.